From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22DB2A0547; Fri, 28 May 2021 11:09:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B8E540143; Fri, 28 May 2021 11:09:17 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id D618E40040 for <dev@dpdk.org>; Fri, 28 May 2021 11:09:15 +0200 (CEST) IronPort-SDR: OkwuixXk4YZZaZ70bDU3DK/Qrk3hy4Lq6spMxnwJHTum5EHI25a2SHSRqmVH/P3vm57j0R9212 AkLbpv6+XBoQ== X-IronPort-AV: E=McAfee;i="6200,9189,9997"; a="202928154" X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="202928154" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2021 02:09:14 -0700 IronPort-SDR: tAsvUNsOL7GwViyRJbiMskLE1igc/TPFYC/pRN50AGWnVDlQEsAZLiQPcCBiRH1fm2mLJAyDbK CpZP7RHv1NDw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="415235047" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga002.jf.intel.com with ESMTP; 28 May 2021 02:09:14 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 28 May 2021 02:09:14 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Fri, 28 May 2021 02:09:14 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Fri, 28 May 2021 02:09:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oAbN+un05EK7ubqehBVcVi5nuxLEI2QOcz5UjCsxffT7LHz4gdMww3xMIAaVF6cV5u9K7QIDS2VFx/B351S+kKEZ7HRfocY8QsymtCuyzsbBH7d0wFmziRv1YlUgmL6U4V4/jlN7bqho9qDaFzq7ypbPadZvOQ2KHAzRSE8SJiXsToTRyY2z4FFnC5mtC1jjn+TTCOoz/Pts5VvtprloSeCXL04vXcKaJcASAWDghj5F56+zrT1WeQoTCrJ4ylPkrmu7YuM3A/iUhtKZwgP7PDY/Dnj1YvEYnvbjNM9WdEEPV2XjuoTCvQzBJNKf8PG+lmIhguk7GvB8GL9zCc/S3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y+PUWvgPv4YmxfzEoc5hZLpYmtDM4sG8SKWJBQVtANE=; b=m5z6MI3CaDAkIk3ARqYs2o4npfcwecqSoUPACP86nC9+WzCWSHI59+m1kYVC0vbwSrWA9u4N4rLtOsUIJK+7Y+FOawr3FVLhgeemQdlH0RvwlgborUE/WsoNm6RzsYpI6p6ubLQ7unQS1RCHZpKwD+1dkbEO76INuJUnDMmoLAORF5fR/B3CJrAxdW1FZP6FGr1ccvONGDasp2ZgLN22LQJpW2EwDOX9vEPV1caiqnvaIp7oV3dhCimqo8/pMXZws8WCviSVScEDhrBy9H37JT03JJtSzUMkYIFIKc7SegWo6JxsVi4c9pLUnoz3zWPaun1pS2Wt/dUH0IIDur8lSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y+PUWvgPv4YmxfzEoc5hZLpYmtDM4sG8SKWJBQVtANE=; b=xb3tyqc/Fik0Ps9eToXGKDclD/i57790feaRwRJB39snNeNv8UYjKm+3kPDhvCdAjV2cnv25o200Aoax998hOQyoMPFpFinYs/cKr/HcfDma8z/AAW/J6tL1ebZKPpO2gj56ldTgCmCCRKScBhdHhC5ad8TG2EhVXXARx/eeEoE= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM6PR11MB3897.namprd11.prod.outlook.com (2603:10b6:5:4::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.26; Fri, 28 May 2021 09:09:11 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::15ed:b4f4:540e:ea0c]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::15ed:b4f4:540e:ea0c%7]) with mapi id 15.20.4150.030; Fri, 28 May 2021 09:09:11 +0000 From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> To: "Liu, Yong" <yong.liu@intel.com>, "Burakov, Anatoly" <anatoly.burakov@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "McDaniel, Timothy" <timothy.mcdaniel@intel.com>, "Xing, Beilei" <beilei.xing@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Yang, Qiming" <qiming.yang@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Wang, Haiyue" <haiyue.wang@intel.com>, Matan Azrad <matan@nvidia.com>, "Shahaf Shuler" <shahafs@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Li, Miao" <miao.li@intel.com> CC: "Loftus, Ciara" <ciara.loftus@intel.com> Thread-Topic: [dpdk-dev] [21.08 PATCH v1 1/2] power: invert the monitor check Thread-Index: AQHXRnrzEUWQDuGQZky4RGElwKuWQ6rz/+oAgANlW4CAAMlMgIAAhaYA Date: Fri, 28 May 2021 09:09:11 +0000 Message-ID: <DM6PR11MB44914DF238E85C40E2FE9B769A229@DM6PR11MB4491.namprd11.prod.outlook.com> References: <819ef1ace187365a615d3383e54579e3d9fb216e.1620747068.git.anatoly.burakov@intel.com> <4b05f3b389e04e098ab298f49b97d6a2@intel.com> <bfdf4ade-455d-5ffc-a177-06cea1bb4ff3@intel.com> <d4096521267e44029c12f69d0c4bb41d@intel.com> In-Reply-To: <d4096521267e44029c12f69d0c4bb41d@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.255.184.192] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3c07f97d-2683-4d0c-6554-08d921b841fa x-ms-traffictypediagnostic: DM6PR11MB3897: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <DM6PR11MB3897C709340B7A93060EAAB19A229@DM6PR11MB3897.namprd11.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GAxgDZwYFdkB7vj3iMBPB9IhFjhz5R7PmZaf9h+hYvOxpcD4OqBskU9BziknL+Qgl3gvkZNkWocYBqMxeWbRJdXI6Jz/tdnJKtbOOL6Y58CtAjNKPiJ3dXv1y5hYtEs/55khf15ThUajaQYZyThe9RJ5H3gMrjy03sktkg9AgTF5rGJyiZhyatR8H6CpqZQ+0DjICgFt0RRXnug+XaA21+sbbwjML5tYupr6TST43SPQRUK8Wec1/DdqfUAE6QW7F2ObvdXzPvZ/sAxodwooqrG2OoV11z0RAaHtno10uKmMQ2ABkQa0HnO4R0ZJ6dfVkq5Y3idLpvZFfGYrWSlaggsWJKpq8hVX1W1yrXsmZSPnrLYMMnVDEkDDrExqx27RPJ5LUCANNiilxkFsll3sL0GyM8yyPp+in/6SnSU9WbP2g+V09pU9xHI75MiP4OvoqTQj/gqJV7dsQqeOyflb63sKKXTSCj7P6RiBAG0ZbO6Hn1msVTfa+axZYkn3Kno10ZROqvamPEv2mmUjI7e8u5pf1eDeQZNoAHuhywAmmt+UVbndLRqarw6ozNVl0C+1bWT/8CnT/+R5zQQElMT/xaB9bJk8kqHAHuHX/WZTLWmiY/jalDztMveDSzbMFRWoPoF7kNxLLbeQG4i3BEoPlA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(376002)(346002)(366004)(136003)(396003)(64756008)(66476007)(66446008)(186003)(33656002)(66556008)(55236004)(6506007)(86362001)(8676002)(107886003)(52536014)(5660300002)(66946007)(53546011)(9686003)(122000001)(38100700002)(7696005)(478600001)(55016002)(6636002)(8936002)(110136005)(83380400001)(76116006)(316002)(4326008)(26005)(921005)(2906002)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?0hZHApGqgFN50jtHm0m+WoMJjaCkZhv0RwiyMUQdTcvxwVxDY63zu1NgfH+L?= =?us-ascii?Q?Lh1jSyvu/t+JNPBrQaKlSran1o5K9uMhLohIp1cS/SlmWvOvpZ1BWhLqilp5?= =?us-ascii?Q?mkTNlBqymLouOb87HCBJft7ywquN2FZ8J9mCOqXjlXINPGvMfmq/g7bKSS1k?= =?us-ascii?Q?EtpGGHNqbpJusALUlSrJP5ERvg0Y8rir5lvtoq6skkhUlVs+/BzDcV/PWs4n?= =?us-ascii?Q?ahOX2l8HBDj+EbeX6ZNcFzDMAfjXqE9u7ElfMIoR8cE4Nw2n7eBfTNEQKeQ3?= =?us-ascii?Q?Bs4LFSlC00EL2fMp4iuWDtuw6nRf72jBYl/u6D30yeG2VzToYRvP1LM7HRui?= =?us-ascii?Q?OQhZKJZeS1DRvJOBphWd1NqVWUdi68vP2nvjlCAkN+Q7gcIXV9pPiWOYDYxR?= =?us-ascii?Q?tjs3tP7qYAaqbUGQEMeKEO9SN9DFKHL2xKt6EjNXuGYdccujgoHUY9yGy9sc?= =?us-ascii?Q?Qos58nTRN7WosSatW0Tq4sEbnpE5tClvogwjDvUGYnRXqPmyWlXItU2t2PxX?= =?us-ascii?Q?lfk26lcTmB+jtAneYcvUqOn3nOHhofyGVOeKxz32RwhUHw7cJc5BBAotYVGQ?= =?us-ascii?Q?v6qkYQpctmMOp1Jn+aYaCgfaPV0JaTgC9/HudSWLUSs9TkxuJC15hXka9sqB?= =?us-ascii?Q?uE+IpCeFtfpbDAS+l8lpPuf9hinykKQZaNzp/+/9V2ecgGCIb64vfbYedSh4?= =?us-ascii?Q?hX5fNzzcQpDVCnYRexbtUiIYo8RBPuUQxv2J/6TB07go+98WEm5YeN8x1scW?= =?us-ascii?Q?u5MWUjsvNG0jfuhS/UOzGttsAI3fxc064RwDUzfZVv2/fraankjEUNU41vBy?= =?us-ascii?Q?Q8hUAv973+UZocibYfeVRi8Vy3NBo/5LRg9J5ejphnXdGAtYgXyBNcywlzdx?= =?us-ascii?Q?zAfSnQOPJZY1IfHVmZqEXpMrYy7XjQj2Bv7K3/RMBPvRqBA3RCJH0EaAW3ZO?= =?us-ascii?Q?COmD+diObfuCG1fKBkkHWS0eB4GFQcRXxCrRoJ2OSyDoSTzFa/lp0Toj7GhJ?= =?us-ascii?Q?Ci50YI1rdEsUywmmmFEqnzdcybIkr8YyY2hoGOH13np4avsWt2KSqbRI2pFA?= =?us-ascii?Q?piAU3KPOnt6UvyCo4QhWkHvecKckjT2IYfe1sxyU9W4QrW+J2vV9trWLaUVM?= =?us-ascii?Q?jUBZT7iMrEWP5/uoWdsljydEk/xdw2XwjEqykZweZuY6dV2y60p15HvFOE6X?= =?us-ascii?Q?7kzVM0pfH3UXe5hy0IMPDIZqGnXom44O9p6K6TkTnL17myVI4nU46ZgHoJx6?= =?us-ascii?Q?leekUSg7G6v7uLRh6kBXN2nV2D6tXhIKfH+vehXMbdYkY78/QOmZxSjxZqKU?= =?us-ascii?Q?AqykmM2DABwCE2OhqIJemrfA?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c07f97d-2683-4d0c-6554-08d921b841fa X-MS-Exchange-CrossTenant-originalarrivaltime: 28 May 2021 09:09:11.1045 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XpR9OfLUwcFhGpTSreqZyuEqdY+kqeEsb8nqTIZJ1EpOfbSUhK726ItODMs+/6hVO4FwBADrC8Y/I9/djZvExThBaZ1d1MrtnieRhxoN/p8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3897 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [21.08 PATCH v1 1/2] power: invert the monitor check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > > > > On 25-May-21 10:15 AM, Liu, Yong wrote: > > > > > > > > >> -----Original Message----- > > >> From: dev <dev-bounces@dpdk.org> On Behalf Of Anatoly Burakov > > >> Sent: Tuesday, May 11, 2021 11:32 PM > > >> To: dev@dpdk.org; McDaniel, Timothy <timothy.mcdaniel@intel.com>; > > Xing, > > >> Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>= ; Yang, > > >> Qiming <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; > > >> Wang, Haiyue <haiyue.wang@intel.com>; Matan Azrad > > >> <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>; Viacheslav > > >> Ovsiienko <viacheslavo@nvidia.com>; Richardson, Bruce > > >> <bruce.richardson@intel.com>; Ananyev, Konstantin > > >> <konstantin.ananyev@intel.com> > > >> Cc: Loftus, Ciara <ciara.loftus@intel.com> > > >> Subject: [dpdk-dev] [21.08 PATCH v1 1/2] power: invert the monitor c= heck > > >> > > >> Previously, the semantics of power monitor were such that we were > > >> checking current value against the expected value, and if they match= ed, > > >> then the sleep was aborted. This is somewhat inflexible, because it = only > > >> allowed us to check for a specific value. > > >> > > >> We can reverse the check, and instead have monitor sleep to be abort= ed > > >> if the expected value *doesn't* match what's in memory. This allows = us > > >> to both implement all currently implemented driver code, as well as > > >> support more use cases which don't easily map to previous semantics > > >> (such as waiting on writes to AF_XDP counter value). > > >> > > > > > > Hi Anatoly, > > > In virtio spec, packed formatted descriptor utilizes two bits for rep= resenting > > the status. One bit for available status, one bit for used status. > > > For checking the status more precisely, it is need to check value aga= inst the > > expected value. > > > The monitor function in virtio datapath still can work with new seman= tics, > > but it may lead to some useless io call. > > > Base on that, I'd like to keep previous semantics. > > > > > > Regards, > > > Marvin > > > > > > > Thanks for your feedback! Would making this an option make things > > better? Because we need the inverted semantics for AF_XDP, it can't wor= k > > without it. So, we either invert all of them, or we have an option to d= o > > regular or inverted check on a per-condition basis. Would that work? > > >=20 > That will be great if we can select the check type based on input paramet= er. > Just in virtio datapath, we need both inverted and original semantics for= different ring formats. >=20 Should we probably the consider introducing _check_ callback to be provided= by PMD? So we can leave these various check details inside PMD itself.=20 And monitor will just read the specified address and call the callback. Konstantin