From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2401A0547; Wed, 21 Apr 2021 13:43:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB09441AA9; Wed, 21 Apr 2021 13:43:20 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id C3D6041A72 for ; Wed, 21 Apr 2021 13:43:19 +0200 (CEST) IronPort-SDR: WA2/yFInr1D6F1Ev0r18kSs1IRdUHi10pfDAuLH6VRYQEKO6zbLv7kg45gvsGP+0/1aIidND5n ppQxdxhwHyug== X-IronPort-AV: E=McAfee;i="6200,9189,9960"; a="281013225" X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="281013225" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2021 04:43:18 -0700 IronPort-SDR: Ke8wZ0Kp0o0t9uUxcEj6zhJicSlaFUKbnwVlG9p0uRJcE0cteDiLM+IHOmStBAdzQzDRARhSye 0iS0WG6ZbxYw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="534854137" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga004.jf.intel.com with ESMTP; 21 Apr 2021 04:43:17 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 21 Apr 2021 04:43:17 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 21 Apr 2021 04:43:17 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 21 Apr 2021 04:43:17 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 21 Apr 2021 04:43:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WOufmPYT6Zhh63g93WTRcWvpde+l9dIz7ONoNEidk0Mb3U1ETV3y8bfSLUJM+wLFwfcmaRUv2jGycnB6x8JOyAmMKSOUtrCEBWdEob24j7GAzux3lt2gJ2CygHe4DZrJbjXPdGRcvZJ7YDQrwnzgnttLMNqK8Rnb7bpUTyMQ9Y1Gxtv6NqQ8K6twb4l5Yn/GFWi6zRrebNVlHU6SISBdoDaeULSFh/inWCfeekXWdeP/1OOrUeDJ/dFM8G4syRl7j8bR5x4umiquSQRK8R6o4hZsibnGrFrN7CDdOu4yzh3qrc6K2NX2XCukhPEH7Hkq0D/P3uaPX2LgmxVuoHhlBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=thHHeAOontFzasefrRoAtBv+vBVeGHFiLVFLvXWmNDM=; b=IJlnhAwIwK9i6frkPWtU5avBnctSJdy37HbJEEUSx/lvAkw1fpkxe/32w8oxxTGiLnU+qjZKRQhEkqyKIuj3Dg76o/Fa4rW3p7BVPYtvXDTVwsklwrxA/ViHWIezCSzkqQkApGqIRMfC2/cbqj0M8iwlFAzsW4Cyr0igDO+U094vkjXCLpJIizK759os3yG+eV5QiwvonIwRITX//lYcqYMf1NHtnPFnzq9D0j6INRaujGqDB1ogHEd87haIDho/eYSdH9R7aPJm9pJ0XwM2K/cNOty1jg5KMVCmxlIeKEvFRzGQRkEZCv55bshiYBbTAJ6ucFYDa2+Pjw557GGs+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=thHHeAOontFzasefrRoAtBv+vBVeGHFiLVFLvXWmNDM=; b=pjimoMPxIxhhZ0Mbf7kF1ALzwXliruy+YiW7DdsfOqbcDKELLOcRYY6VNEp9vcm7mJwOrREmQynkQ/7x80BHgLspDAiUtN8TVox4KetIEBjyllFePWoW67PYTsqEt8i4+V8GbSeaMJII/v089yc8kmNsypCItz3F2rPc7i4g3YA= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM5PR11MB1626.namprd11.prod.outlook.com (2603:10b6:4:9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.23; Wed, 21 Apr 2021 11:43:15 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::3182:6da2:8c64:f07a]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::3182:6da2:8c64:f07a%3]) with mapi id 15.20.4042.024; Wed, 21 Apr 2021 11:43:15 +0000 From: "Ananyev, Konstantin" To: "Min Hu (Connor)" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "Ananyev, Konstantin" Thread-Topic: [PATCH] bpf: delete meaningless code Thread-Index: AQHXNqJ0nyVe86DFFUqQsZJAWhc106q+2V4g Date: Wed, 21 Apr 2021 11:43:15 +0000 Message-ID: References: <1619004925-58869-1-git-send-email-humin29@huawei.com> In-Reply-To: <1619004925-58869-1-git-send-email-humin29@huawei.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.255.184.192] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fe032c59-01f0-4389-2e3a-08d904baa69a x-ms-traffictypediagnostic: DM5PR11MB1626: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:873; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iJVmcaOd7x1RRMB5ezIbl/MLRgI5EC9scyrSv46I1chs+pUBqaTQd5BPkJAHNpJ1eRQK02d/mUdpNsWLFUJLikvw6BXmdSguK/Uq92w5Gp9sHrHSMw2qz1zQaJ60QKSwTdOt1rnTw2IN7pw7U6dFPLn3zpzvZHaoF6c77dhv2oyuYMuJl+bHn/y6D6qLBq4Uo3gX28ZEYIwhvD2cQZYcjkHvyagJOcU1aa/RHCjdR5NukckLcvAHwLDPz//JpDxZ8Qx7hNFCfoA0NOxHW4bfHbzIX8yBpJxnuvngcDWqqgTWC9el+rt8a0a3/LrZh7eaq30qvuewP4KHPEDRPDnBm3KrecV/8plKHFP0utwZEinA/Z4GZGIkp8yv5u48Fv0i+WsAwRH7qkodzUUZA3bBV8rt4ACL9h7RjznMI/McaHGvuw3VSZ6Jg5tOZ094kNccy9l4ualjPGEjBmFSuOc7Z5C4Yi2pvu/D13vqU7PWU2j73x0xLAgAv5IjTJhH6j1g9AKqrDiCbkvvgst7VKRf2OPBbU+1HsD6rO19CoAREOEDSSqjq5dyMjA2yY8+PkPgr3EESK+m+r76wMZFjYvAQJlmJfUA76V2ZsOVPrXz0fI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(346002)(366004)(376002)(396003)(136003)(66476007)(86362001)(71200400001)(8936002)(54906003)(8676002)(38100700002)(55236004)(7696005)(26005)(6506007)(2906002)(316002)(33656002)(110136005)(66946007)(9686003)(4326008)(122000001)(66556008)(66446008)(64756008)(478600001)(5660300002)(107886003)(4744005)(83380400001)(76116006)(55016002)(52536014)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?VPcgf3e4Ec2uIpO7IHhY+gaifW7uWT+W+wFKEIHO5D1ytuh4EKxaHZ5npWhL?= =?us-ascii?Q?pHPI/3NbEXbjI3s221ELP14HaPjRdo4UdFSRIjk+Aim1kivr5gDC2yLdM6B8?= =?us-ascii?Q?pMAJaeB/xaTBQ+Yf9fPWyAcy7ARDchwI6U+2lLYhnNK+vHVTCfSAVqrV/oI6?= =?us-ascii?Q?k/H4OQeOwcEC7peP3R0fV6CQnmMewUDCii0BjV7tppqHOCgqBL/lipki2iyv?= =?us-ascii?Q?d3u/JUiMELa4LKQ4tvWa3ajh7TwBLqEFUl1xpZMQErDNuToFDG4joPu4ugH6?= =?us-ascii?Q?iOo77zO4wM6PLoYEUF3iI+RKs4iZBS9TUsmavVr1BidfCahyvuklPGc1enZ9?= =?us-ascii?Q?vLgkNDmaFMQg85vzD7rahID7Dt5hXoJUauIKEAoCpjC5lZ9quRsfasoE6cOt?= =?us-ascii?Q?XsgP810+TvHlL1LaIb7omuTbFHOKe657OnwwjLdHq0nS0cWkiKCmLz5uhhXI?= =?us-ascii?Q?kHtcw1gkDNqzQMuJbaQwKSKRBeFzgo4PlqD0gsbZ4CN7dXf8PWuA6uEoTNt0?= =?us-ascii?Q?w8MbFu93ymTZFEqtoFOEM5ORGp/4nFo7e/tONmkxHGMpco6czL8ym8a9LoE+?= =?us-ascii?Q?sfKgmp7fDvYkJNkp8hLnd2taBS8AkNuMJizslQJfEY6r83615Ce5YJbpPU8o?= =?us-ascii?Q?KX8LoGjXLyRS06Np2AJs9deIqfIZCRv6TvJOBRUzsvfcfZrdaVrF2O6FRK4O?= =?us-ascii?Q?xXH6IlEUkw64SpB4yqYX0KA7+wZFuMxgFSZg+/14Ud2Ku0h+4avxweTMa6Zd?= =?us-ascii?Q?GJEdJNMJgCcDU6Y/uJVeoOoc6VQUflAqHKgnOVyGWiNgXFucEQzSWaD8WQ0O?= =?us-ascii?Q?yPx6HzIAaPuAu3LVn21NruPMpabyzzkRi/MVwCkFHzxDaLtmCUXs7aFeZui5?= =?us-ascii?Q?RbRZCcRR/zWlemdOEo4HXuQDIVjYRQ2L9WMd2Eimy2SPlxwLyDYAUKtb1XoI?= =?us-ascii?Q?8aFvUt+qXKOS9gBESiFA1USDlxKXQAU4QQ3XmKcMvchp5ZbIgMOm+ox9ioKk?= =?us-ascii?Q?Nkmf9C4Qbqr8HwxMKOXH2NqYHGtrlbVSjjnmthwmXVbcKLcCZh1xaxdbMcJV?= =?us-ascii?Q?Lcyb95i1xJhnMfntFedQ0iNfLbx+fWE0fKrjDWNTslrq2AmoFwWB+fYnySIT?= =?us-ascii?Q?J6iHrbFyXbzFUfUiCpn4iH7RE3Pu2b7Lg1Rtsw0XMoZk217qOlAPMF2BZaiY?= =?us-ascii?Q?RfgZBxH4+gBQ2X+c42++LAdy74XgGN9h+s1pauUKci/9DNi4O0B2E9nBqNdQ?= =?us-ascii?Q?ma6Q58MrltbHxMB2etsNva8HaZgaEQVJa2Q+g0Q4NvZhMMO1OYl6TiZckwi0?= =?us-ascii?Q?Li+GARIKEaaMRtZvwWkjR3wL?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe032c59-01f0-4389-2e3a-08d904baa69a X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2021 11:43:15.3797 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 92+NMESR7imLafEZUMAMCahN9kZe32VbA4ugf1XbIcjqOAxvh+B/KN+kG+2agpRX4rvC+E3ySXUgsR2xEck24pxjSmp6ecAB5m2zmFX9AyE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1626 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] bpf: delete meaningless code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > 'rd->u.max =3D rd->u.max' is meaningless which should be deleted. >=20 > This patch fixed it. >=20 > Fixes: 8021917293d0 ("bpf: add extra validation for input BPF program") > Cc: stable@dpdk.org As I remember, I did it on purpose. Some old (but still supported) version of clang complained about unitialized variable. > Signed-off-by: Min Hu (Connor) > --- > lib/librte_bpf/bpf_validate.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/lib/librte_bpf/bpf_validate.c b/lib/librte_bpf/bpf_validate.= c > index 9214f15..c5ad951 100644 > --- a/lib/librte_bpf/bpf_validate.c > +++ b/lib/librte_bpf/bpf_validate.c > @@ -517,8 +517,6 @@ eval_divmod(uint32_t op, struct bpf_reg_val *rd, stru= ct bpf_reg_val *rs, > } else { > if (op =3D=3D BPF_MOD) > rd->u.max =3D RTE_MIN(rd->u.max, rs->u.max - 1); > - else > - rd->u.max =3D rd->u.max; > rd->u.min =3D 0; > } >=20 > -- > 2.7.4