* [dpdk-dev] [PATCH] bpf: delete meaningless code
@ 2021-04-21 11:35 Min Hu (Connor)
2021-04-21 11:43 ` Ananyev, Konstantin
0 siblings, 1 reply; 5+ messages in thread
From: Min Hu (Connor) @ 2021-04-21 11:35 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, konstantin.ananyev
'rd->u.max = rd->u.max' is meaningless which should be deleted.
This patch fixed it.
Fixes: 8021917293d0 ("bpf: add extra validation for input BPF program")
Cc: stable@dpdk.org
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
lib/librte_bpf/bpf_validate.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/librte_bpf/bpf_validate.c b/lib/librte_bpf/bpf_validate.c
index 9214f15..c5ad951 100644
--- a/lib/librte_bpf/bpf_validate.c
+++ b/lib/librte_bpf/bpf_validate.c
@@ -517,8 +517,6 @@ eval_divmod(uint32_t op, struct bpf_reg_val *rd, struct bpf_reg_val *rs,
} else {
if (op == BPF_MOD)
rd->u.max = RTE_MIN(rd->u.max, rs->u.max - 1);
- else
- rd->u.max = rd->u.max;
rd->u.min = 0;
}
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] bpf: delete meaningless code
2021-04-21 11:35 [dpdk-dev] [PATCH] bpf: delete meaningless code Min Hu (Connor)
@ 2021-04-21 11:43 ` Ananyev, Konstantin
2021-04-21 12:02 ` Min Hu (Connor)
0 siblings, 1 reply; 5+ messages in thread
From: Ananyev, Konstantin @ 2021-04-21 11:43 UTC (permalink / raw)
To: Min Hu (Connor), dev; +Cc: Yigit, Ferruh, Ananyev, Konstantin
>
> 'rd->u.max = rd->u.max' is meaningless which should be deleted.
>
> This patch fixed it.
>
> Fixes: 8021917293d0 ("bpf: add extra validation for input BPF program")
> Cc: stable@dpdk.org
As I remember, I did it on purpose.
Some old (but still supported) version of clang complained
about unitialized variable.
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> lib/librte_bpf/bpf_validate.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/lib/librte_bpf/bpf_validate.c b/lib/librte_bpf/bpf_validate.c
> index 9214f15..c5ad951 100644
> --- a/lib/librte_bpf/bpf_validate.c
> +++ b/lib/librte_bpf/bpf_validate.c
> @@ -517,8 +517,6 @@ eval_divmod(uint32_t op, struct bpf_reg_val *rd, struct bpf_reg_val *rs,
> } else {
> if (op == BPF_MOD)
> rd->u.max = RTE_MIN(rd->u.max, rs->u.max - 1);
> - else
> - rd->u.max = rd->u.max;
> rd->u.min = 0;
> }
>
> --
> 2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] bpf: delete meaningless code
2021-04-21 11:43 ` Ananyev, Konstantin
@ 2021-04-21 12:02 ` Min Hu (Connor)
2021-04-22 11:29 ` Ananyev, Konstantin
0 siblings, 1 reply; 5+ messages in thread
From: Min Hu (Connor) @ 2021-04-21 12:02 UTC (permalink / raw)
To: Ananyev, Konstantin, dev; +Cc: Yigit, Ferruh
在 2021/4/21 19:43, Ananyev, Konstantin 写道:
>>
>> 'rd->u.max = rd->u.max' is meaningless which should be deleted.
>>
>> This patch fixed it.
>>
>> Fixes: 8021917293d0 ("bpf: add extra validation for input BPF program")
>> Cc: stable@dpdk.org
>
> As I remember, I did it on purpose.
> Some old (but still supported) version of clang complained
> about unitialized variable.
Well, how about like this ?
uint64_t tmp = rd->u.max;
if (op == BPF_MOD)
tmp = RTE_MIN(tmp, tmp - 1);
rd->u.max = tmp;
>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> ---
>> lib/librte_bpf/bpf_validate.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/lib/librte_bpf/bpf_validate.c b/lib/librte_bpf/bpf_validate.c
>> index 9214f15..c5ad951 100644
>> --- a/lib/librte_bpf/bpf_validate.c
>> +++ b/lib/librte_bpf/bpf_validate.c
>> @@ -517,8 +517,6 @@ eval_divmod(uint32_t op, struct bpf_reg_val *rd, struct bpf_reg_val *rs,
>> } else {
>> if (op == BPF_MOD)
>> rd->u.max = RTE_MIN(rd->u.max, rs->u.max - 1);
>> - else
>> - rd->u.max = rd->u.max;
>> rd->u.min = 0;
>> }
>>
>> --
>> 2.7.4
>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] bpf: delete meaningless code
2021-04-21 12:02 ` Min Hu (Connor)
@ 2021-04-22 11:29 ` Ananyev, Konstantin
2021-04-22 11:39 ` Min Hu (Connor)
0 siblings, 1 reply; 5+ messages in thread
From: Ananyev, Konstantin @ 2021-04-22 11:29 UTC (permalink / raw)
To: Min Hu (Connor), Ananyev, Konstantin, dev; +Cc: Yigit, Ferruh
>
> 在 2021/4/21 19:43, Ananyev, Konstantin 写道:
> >>
> >> 'rd->u.max = rd->u.max' is meaningless which should be deleted.
> >>
> >> This patch fixed it.
> >>
> >> Fixes: 8021917293d0 ("bpf: add extra validation for input BPF program")
> >> Cc: stable@dpdk.org
> >
> > As I remember, I did it on purpose.
> > Some old (but still supported) version of clang complained
> > about unitialized variable.
>
> Well, how about like this ?
> uint64_t tmp = rd->u.max;
> if (op == BPF_MOD)
> tmp = RTE_MIN(tmp, tmp - 1);
> rd->u.max = tmp;
Then, I think it should be:
tmp = RTE_MIN(tmp, rs->u.max - 1);
Or just leave things as they are right now.
Nothing is broken here.
> >
> >> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> >> ---
> >> lib/librte_bpf/bpf_validate.c | 2 --
> >> 1 file changed, 2 deletions(-)
> >>
> >> diff --git a/lib/librte_bpf/bpf_validate.c b/lib/librte_bpf/bpf_validate.c
> >> index 9214f15..c5ad951 100644
> >> --- a/lib/librte_bpf/bpf_validate.c
> >> +++ b/lib/librte_bpf/bpf_validate.c
> >> @@ -517,8 +517,6 @@ eval_divmod(uint32_t op, struct bpf_reg_val *rd, struct bpf_reg_val *rs,
> >> } else {
> >> if (op == BPF_MOD)
> >> rd->u.max = RTE_MIN(rd->u.max, rs->u.max - 1);
> >> - else
> >> - rd->u.max = rd->u.max;
> >> rd->u.min = 0;
> >> }
> >>
> >> --
> >> 2.7.4
> >
> > .
> >
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] bpf: delete meaningless code
2021-04-22 11:29 ` Ananyev, Konstantin
@ 2021-04-22 11:39 ` Min Hu (Connor)
0 siblings, 0 replies; 5+ messages in thread
From: Min Hu (Connor) @ 2021-04-22 11:39 UTC (permalink / raw)
To: Ananyev, Konstantin, dev; +Cc: Yigit, Ferruh
在 2021/4/22 19:29, Ananyev, Konstantin 写道:
>
>
>>
>> 在 2021/4/21 19:43, Ananyev, Konstantin 写道:
>>>>
>>>> 'rd->u.max = rd->u.max' is meaningless which should be deleted.
>>>>
>>>> This patch fixed it.
>>>>
>>>> Fixes: 8021917293d0 ("bpf: add extra validation for input BPF program")
>>>> Cc: stable@dpdk.org
>>>
>>> As I remember, I did it on purpose.
>>> Some old (but still supported) version of clang complained
>>> about unitialized variable.
>>
>> Well, how about like this ?
>> uint64_t tmp = rd->u.max;
>> if (op == BPF_MOD)
>> tmp = RTE_MIN(tmp, tmp - 1);
>> rd->u.max = tmp;
>
>
> Then, I think it should be:
> tmp = RTE_MIN(tmp, rs->u.max - 1);
>
> Or just leave things as they are right now.
> Nothing is broken here.
>
OK, this patch can be abandoned ,thanks.
>>>
>>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>>>> ---
>>>> lib/librte_bpf/bpf_validate.c | 2 --
>>>> 1 file changed, 2 deletions(-)
>>>>
>>>> diff --git a/lib/librte_bpf/bpf_validate.c b/lib/librte_bpf/bpf_validate.c
>>>> index 9214f15..c5ad951 100644
>>>> --- a/lib/librte_bpf/bpf_validate.c
>>>> +++ b/lib/librte_bpf/bpf_validate.c
>>>> @@ -517,8 +517,6 @@ eval_divmod(uint32_t op, struct bpf_reg_val *rd, struct bpf_reg_val *rs,
>>>> } else {
>>>> if (op == BPF_MOD)
>>>> rd->u.max = RTE_MIN(rd->u.max, rs->u.max - 1);
>>>> - else
>>>> - rd->u.max = rd->u.max;
>>>> rd->u.min = 0;
>>>> }
>>>>
>>>> --
>>>> 2.7.4
>>>
>>> .
>>>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-22 11:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 11:35 [dpdk-dev] [PATCH] bpf: delete meaningless code Min Hu (Connor)
2021-04-21 11:43 ` Ananyev, Konstantin
2021-04-21 12:02 ` Min Hu (Connor)
2021-04-22 11:29 ` Ananyev, Konstantin
2021-04-22 11:39 ` Min Hu (Connor)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).