From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1A74A034E; Tue, 22 Feb 2022 11:39:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A95BD40DF6; Tue, 22 Feb 2022 11:39:21 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 3F02E40DF4 for ; Tue, 22 Feb 2022 11:39:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645526360; x=1677062360; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=zVbyXbdFy0nP7K5LA9LCADHjNevDP6AsvEGcCwIYUIs=; b=MDfNcGgcOoHQcbKAtl7UInK11EtcQPOUvqxyofQa7cpEYEwxVYW5kiBj FmyEm5I74MjY2gALbAG/M+GzCkYEi4tRDqlRwVurfj3oFvA2YqvENYZZ8 RGnVsMlN7p3oAvCCF2r/F74wVuUWhcy8bPa2JOQ/3v1SQgJV1bRfyz7Uq F1+xWmKB6T2fAnZTbnPsanSFbHzKaI/CINUKasCk3pyHIaRJqVgvrs/I7 AedmDvvcLUEjC1UiEh6+57Ep9v+Ib01FWTEpEMsvXIYCbCKrQzYA/Tg1u 6XXQcDrcbTf6ZX8KmzQQN+vx09I/20/qWHw+mX3l12p3XCNY85Spq5s0Z w==; X-IronPort-AV: E=McAfee;i="6200,9189,10265"; a="276266272" X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="276266272" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2022 02:39:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="706566942" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga005.jf.intel.com with ESMTP; 22 Feb 2022 02:39:08 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 22 Feb 2022 02:39:07 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 22 Feb 2022 02:39:07 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 22 Feb 2022 02:39:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WVVcZTrO3UEqdwH2o4fbGs83/FnPLCk7AlM9dCVyBWs/PUP3Tenv/LeUQleNPghVkQeL5ueda1Q/IvoLLXOjn2ABcYIpPxUaw/BFsxXpWew27KSmp+aDpQZkRVZ6KBUMFEgUx8rgbyvWyH1C0ekbCKFFYtAXctVw34o+bZ6kVoNb4s7H5JWUKWykV+XQj7Nd4ZwVQewPsvfQAJKNRk/eicNHmzGeymiEoAXfSmgrEXkii8ZWruu63lKYPUT3a7EGiblFI+V7duq5ElzVrkRzR1V+2cy8clfcPjMIxt8xFMk8QwPskM3WSmOa305OKuR5LflnSaGaOPTTxyIVEwS1XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MzNsVuvO2e+6OBrGp/sL/jO17sWOazDqhWjL3B28Syg=; b=O2E4X7nQSHwB6dS/Xx3u/sstKXNmesY5BYpwgAmfuhypvjou+BzKkj/mMMDJAeLZTGOxG51oZWR4MQmd3WdAFojwCo3xkwmDMDdQHclKRWgauWdmIY0d7IqOaXKdgNl3nfm5ZBlATUUcbmX87f5ruuIOAy3OHqV+50oFZOaSBkWMRt9M5UoTKxntGwfAyQ/26Riz/L138PeGehTQLyTPOxrfKFAwRnsoYJsR++1xavbn2fYcBE7U5D0mnGwR6o64JrlBwciHbmab441LDLR3qzEnQZ5E1sCKE1J399TN/F1VOJ8OKViIPiJX9UEcQgCHlgQRu5up97xDMy7Ckmk3Lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by BN6PR1101MB2196.namprd11.prod.outlook.com (2603:10b6:405:52::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Tue, 22 Feb 2022 10:39:05 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::8ccc:ed65:78fa:1b07]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::8ccc:ed65:78fa:1b07%4]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022 10:39:04 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon , Stephen Hemminger , "Medvedkin, Vladimir" , "dev@dpdk.org" , "Morrissey, Sean" , "Richardson, Bruce" CC: "dev@dpdk.org" Subject: RE: [PATCH v5 0/2] Add config file support for l3fwd Thread-Topic: [PATCH v5 0/2] Add config file support for l3fwd Thread-Index: AQHYGgG/2P6JAfnPu0eGpqCdewcShKyD+IYAgAKg5FCAAmOzgIAAe1hAgABhpICAABo2AIABKkCAgBRTGICAAAL2gA== Date: Tue, 22 Feb 2022 10:39:04 +0000 Message-ID: References: <20220126124459.2469838-1-sean.morrissey@intel.com> <20220208094904.5ca9db4c@hermes.local> <1763854.FMhQkTaH9n@thomas> In-Reply-To: <1763854.FMhQkTaH9n@thomas> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7b990d07-8c10-49de-32e7-08d9f5ef8c53 x-ms-traffictypediagnostic: BN6PR1101MB2196:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KK+IA6ID1O0Cnox1DVt9NWHUlknB4A12ZsvFAQHGshKZS1cQ3abnt9N4j9zrym6OroiJLpulisVPMn9LP58ATDCzc7zwvsXW38F2BAIkl0KNS40aKbw6244yxPshY6Ytp+TQMaaHohJELIihwj858fZFt7bpxzAz46t7efVRDrfOVWcW1DeHibaSD/UOMCP8G3BWLSL8ceeQvFKYhCVhoZd1jtEm/s/iz38jJnuMzId39dMBpXplyjr8OqLmpmO6tRyTayCoWYImYXMNWG6S1tl+JncrYWFHOLXn293SR8Bq6w2hwCih9ri9ddiSJkboHT4JhYJ6AJf2P7pnhcVqyFWPo62AMHRB9KX5kqWAd0l2vtgf4DWvCQ+kFAlCk+mUb0JVPT3JzoZF6l4pxgw81U0UDI9/vLJuKcUgJg6/7dd36rkHxEzOY0xL56Ky++iGapbBqrPIrD16WyKWKcnqPVp6wftzq8Zx4KchZnRFa0quAdkG3dqwfaotTD8TrnDL/dDmWki1n39S78VYfxeErvGAa1Yk3B72EZzysiAMLhYNWoRsTtLGpNPUuOTC6QIxmRlV7U5Ebp8en9iCJsGhKNI9TFZabqp6vZRjI3n9LZZ0lNgRyTB3WL/A4NxE2yGwsqAOLSdM9w1v8BerCHusCZGseD7wke1skUxBoj37W/SgJ4tINvGq5bnpWhsvcUe0T4R5gy+4He1o4AC0CuiJRvO+WxhujsSqWT6Wkx24R2w= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66556008)(66476007)(7696005)(66446008)(64756008)(8676002)(66946007)(4326008)(9686003)(86362001)(6506007)(76116006)(83380400001)(52536014)(8936002)(5660300002)(508600001)(186003)(26005)(71200400001)(6636002)(316002)(82960400001)(55016003)(2906002)(33656002)(122000001)(38070700005)(110136005)(38100700002)(32563001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pfGiYH/BPqiOSSsx5NgnWXgn2jSJhVex+Uwj/eODTaMUAhBxP4nwk6t7S/JQ?= =?us-ascii?Q?9vksGHgKuUpxiUJkh9DIOIEjDWYfxdpXfaQRpyfQD4DnhfLLF1k7m5TJ3iz6?= =?us-ascii?Q?jiLwlqBfV5uscPRcHZnHWQm8peBwvDbOjJHcyL4YiFPywAseLBZzrPIppwyi?= =?us-ascii?Q?Z88vRGhk46ds53U5R62JMLaoLX6+xZFHRck8n930H1Z0rzrF3kpbZ7Nb/o4C?= =?us-ascii?Q?XnDQ/hNxMLSCCVeRDtoSxh9Nhj/O2fR2Qh4jGodn3kFNGhw4vm2GOEn66XNG?= =?us-ascii?Q?7nW6Ts4zitoHt0DDR01VkBrRsTEwSLlGhvxKyVB1z9so2SE07yFqDfOu6v34?= =?us-ascii?Q?ANMTe7NcOhsojQcN25WnG2ovDQhFgBmBhp/Yy0EDcIZ40gjaSFAggBAizzbY?= =?us-ascii?Q?58KHlsOoQCzCkTnNjaZstd8J6Ookl3K0E+ng9gWQ40wIXhco13kEqoMYmo4/?= =?us-ascii?Q?BZNXLUSaFjD7S5KJY3EqY/NzXo6BxcvC90f3n4oTGCXN8sDSWpRgD+3ALvFN?= =?us-ascii?Q?7/SAkt4rDQHr5SZbVzYTZ4ePDqD5ND9OyxtYEizwQ4IY1jJcJCeJgOl8dn6H?= =?us-ascii?Q?v0ywYRpfmxQsiSrUK2qX+AUsHHhZwiiy6Hs4x4afEsbEoQQ+6OLGRd7AI2Kv?= =?us-ascii?Q?D/xY9aDHN7wi3WxYH5aFx81HL6/kM8usklKUiMpzDB0sRQw3pzFVxmuqsTTY?= =?us-ascii?Q?GgyJ+1ie7EadVNtB4qbLWHn9UGqeu10dozaUjSnuNJ4d1fWETFfkQfGU4/v/?= =?us-ascii?Q?hqO4lON371gsgF6csAYPOM1BY7WoAuJ4T1WvEjbY7E5nH/XyPpMu1agWcW5P?= =?us-ascii?Q?811iW6UzaTJPSPuguaBBZtlYrDn187ApglFyfbH4CHEDEcQKOITQI1Bb8zKF?= =?us-ascii?Q?9fdf+CkSEvq5rfS2S/7Yz8uSPad/ejy7X1BgJIxpLwcaYT4pBDk1ZIWi8Sha?= =?us-ascii?Q?A6EURbco1PweneLMueJsN5XHI3/1mSMdGja3zKRqIgjIvo0QdiRBwp+mNGcY?= =?us-ascii?Q?rRknccspOfvTUT6eBRdqUeRHyxk9yRVuCcFNvQPQxJ5D9HnfmJKhufr0OCUb?= =?us-ascii?Q?Oy0OsNT0A539jgj1/CgITMMpoH9rsYHP/9uKLVgPbmqy06c+SsWQwU2BlgQS?= =?us-ascii?Q?sZY5MsDSrmu0OH7I4Q9ioISedgQQN3qyzWgffFBfBVsR/XPQzrkFy8El4CP3?= =?us-ascii?Q?CNV1cCRIOxHB8iJrq0ddBaQIioNWR6G+o1nhKRe/KJJx71pgfc6HVK40yTsZ?= =?us-ascii?Q?T4KmrKikK0k1uHL91QqkpZFdoatXNB3UqtD9bNodmpb2ZxBAGXeTV5rRZn+X?= =?us-ascii?Q?3PY3HGR5TjpaYtq6TsHUR2F1ffYnLuFOrSiMUJ9DShdNBCRPuEOAEN8GsjKf?= =?us-ascii?Q?RbNNZjSCHFMzx/vdVAPPkOx8hfRD6RWhTsDTVD3S0fA/nOl5H1Glak/wPWkf?= =?us-ascii?Q?7PkriSiBViqJPPJmKfyjJ9M5Xm6dSHB6NH3J2de//QXJ2/gcAAimChKIXvFR?= =?us-ascii?Q?fd/NPXGz7QADEN0rnOBehSTBIe2fil5J5WpluyYuynMUiBk9PHjZAD8kgFSb?= =?us-ascii?Q?UxyDU6Bwk6vVoNFj4OAad7vTKOBBdMeM7H6zv7qSTsSzBvmWBtCj6izwmDfl?= =?us-ascii?Q?+qHHg1F9GP2rOw6K6VDTpahgVPrCCZ3SOG59PIo4YzCTLE9At1e2JWMvXSjf?= =?us-ascii?Q?GtJY7g=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b990d07-8c10-49de-32e7-08d9f5ef8c53 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2022 10:39:04.9262 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lYglOjmCCYrjmIZ+ea/7vbejije9GXJ0iGZAWNMNzdoTbxfQtAOz39jMSK/06tpBj1hr6Cgz+N4mEISV18F4+I0xwUrgQLi04xYHOS26mdo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2196 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > > >> Or have a generic library for reading LPM entries. L3fwd is sup= posed > > > > >> to be as small as possible (it no longer is), and the real work = should > > > > >> be done by libraries to make it easier to build other applicatio= ns. > > > > > > > > > > I never heard users ask about such thing, > > > > > but if there is a demand for that, then I suppose it could be con= sidered. > > > > > CC-ing LPM/FIB maintainers to comment. > > > > > Though I believe it should be a subject of separate patch and dis= cussion > > > > > (I think many questions will arise - what format should be, how t= o support > > > > > different types of user-data, to make it generic enough, etc.). > > > > > > > > Agree, it is very application specific, so it could be really diffi= cult > > > > to make it generic. > > > > > > But several other also have LPM tables, so why not have common code f= or other applications. > > > > > > examples/l3fwd-power/main.c > > > examples/ipsec-secgw/rt.c > > > examples/ip_fragmentation/main.c > > > examples/l3fwd/l3fwd_lpm.c > > > examples/ip_reassembly/main.c > > > > Ah yes, that's good point. > > All these examples (except ipsec-secgw) started as l3fwd clones, > > so all of them have hard-coded LPM (and EM) tables too. > > Yes it would be good thing to address that problem too, > > and have some common code (and common routes file format) for all of th= em. > > I don't know is that a good idea to introduce parse file function in LP= M/FIB library > > itself, might be better to have something like examples/common/lpm_par= se*. > > Anyway, this is an extra effort, and I think no-one has time for it in = 22.03 timeframe. > > My suggestion would be for 22.03 go ahead with current l3fwd patches, > > then later we can consider to make it common and update other examples. >=20 > I don't think this patch is urgent. > I suggest taking time to have common code for all examples > and target a merge in DPDK 22.07. Well, yes, from one perspective it not really a critical one, we do live with hard-coded routes inside l3fwd for nearly 10 year by now. Though l3fwd is one of mostly used examples inside DPDK and it is quite a pain to patch/rebuild it each time someone needs to run l3fwd with a different routing table.=20 Merging this patch will allow people to use l3fwd for more realistic test scenarios in a painless manner. So I believe this patch is really helpful and should be beneficial for the = whole community. Looking from that perspective, I don't see why it has to be "all or nothing= " attitude here. Why we can't move one step at a time instead? That would allow to split and effort in terms of development/testing/upstre= aming/etc.