From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E63A6A0546; Fri, 30 Apr 2021 13:28:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A5014014F; Fri, 30 Apr 2021 13:28:12 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 3CA144013F for ; Fri, 30 Apr 2021 13:28:11 +0200 (CEST) IronPort-SDR: 2cehDNVURcjfM0ebvzHCCi3sTxGsm8/J0mi6hhbPSnFaWLPvzQCDdfWX6Ugp1MB5D3/8Mkxb6J +3jCw4q6Lqjw== X-IronPort-AV: E=McAfee;i="6200,9189,9969"; a="261201631" X-IronPort-AV: E=Sophos;i="5.82,262,1613462400"; d="scan'208";a="261201631" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2021 04:28:10 -0700 IronPort-SDR: 7OrNumgUZb9edNcG1WbdleBb+4jfDAE+4mkAXPrO+368K9xwxyj1jepPa0VVUws2uV3gB1icO5 +ogQgO/cvt+Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,262,1613462400"; d="scan'208";a="426419802" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga007.jf.intel.com with ESMTP; 30 Apr 2021 04:28:09 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 30 Apr 2021 04:28:09 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Fri, 30 Apr 2021 04:28:09 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Fri, 30 Apr 2021 04:28:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jZtjdziDGE62oF67XdnDcJCuQHLowFWDdrh9m6J2pQMBj/4TYbz2z9/ZPE8Ww5XvUryeF1AVjzBQsZWECdikmDw37YNhfYgOq4iwAzkMdqoMrEocosUm9PT3G9e4kaiXJV2xpKvEg1rCL1pqraw3CsnISH5r2FKnmgkMf1Wqe/JVjxbU7bYQl9phu36ubhxOCfX9GcMJzp1hteDCms3iIRsEinBwgv7zYYQwo8Puqry/CM3Osy/K1R/aFDzuRAVjhaoeR41SPElZCVCGzBrmTSbvCz6KxJTnY528o/YJbfeqEc7K9Qs7GEukxcidSunEoY+10GdCk4hOQU9hIenP3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HmiGpMwNXtRMVseY0me6gYOLcR78bmM3YAXU3LXrbys=; b=VuWHtH0Z8GLVriYQcIwyYx7+9bki+EmmygEQHXA91IueETOAkW74NISOUiVtZNnFCNLZH27kFQcXYYBGPZT06uEZo/XtDUNxJ/tjlXHqSI4VA+hsRPEjHDBEB4yXshAwK3gN8sjd47TUVdRCbmLHNStjPIHQcHJpCAMFp9ruP7yp1+VWTW3c094qRkCAonEOCTIcKWzTpNmxa4MR7P5tu6Ca1yIR2qCmzrigzQUVSUtsLRpK9idTOcgeb0+vVwgsicnQG+KIxyrKqxldgWscofTSYCFsPhEajXf0bGKpfGuwiPIJZrJD3zgJc4eJozqJuLZb87/DAEbNoEwhw6LsJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HmiGpMwNXtRMVseY0me6gYOLcR78bmM3YAXU3LXrbys=; b=vXYpJ5Wj55NMt2eR7hFfxcEglfPb5sM62PvUIM4BPVIbxxseQsNknBogNp0nxHXoN0yY70o5nQunnNw250g+M8a8fnbgRpmw3VPv7JK1f4HAw22cktfbpbgNyS+OdnY92iV4dtGj2dk2tYhA5sbSQS7lYrogpzQoP/lPPAfVb9s= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM6PR11MB4012.namprd11.prod.outlook.com (2603:10b6:5:6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Fri, 30 Apr 2021 11:28:07 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::15ed:b4f4:540e:ea0c]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::15ed:b4f4:540e:ea0c%7]) with mapi id 15.20.4065.033; Fri, 30 Apr 2021 11:28:07 +0000 From: "Ananyev, Konstantin" To: Stanislaw Kardach CC: Honnappa Nagarahalli , "Richardson, Bruce" , "Yigit, Ferruh" , Stephen Hemminger , Jerin Jacob , Kathleen Capella , "thomas@monjalon.net" , "dev@dpdk.org" , Dharmik Thakkar , Ruifeng Wang , "david.marchand@redhat.com" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , Stephen Hemminger , nd Thread-Topic: [dpdk-dev] L3fwd mode in testpmd Thread-Index: AdcV2H0Bhkmz7z6QTBeC8FixZy3dngAaQ6AAABIFuOAAAQNCAAAAQNqgA/efEhAAAYi7gAAF6HhgAAl7GoAEe3+OoAB4fPWAABDYiwAABc478AAb06kAAAAT1EAAG+pgEAAYVQwAAACPgIAAFkuHYAAVMNWAAADvOoAABP1DAAACDBggAACKkIAAMPKUYA== Date: Fri, 30 Apr 2021 11:28:07 +0000 Message-ID: References: <81781e97-735c-f584-4148-ff07dedc5cb4@intel.com> <20210429074945.alquywrvyxjdezqi@toster> <20210429103922.7jw2e24qemsd4y3y@toster> <20210429115329.a2zek6rkmna6qhs3@toster> In-Reply-To: <20210429115329.a2zek6rkmna6qhs3@toster> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: semihalf.com; dkim=none (message not signed) header.d=none;semihalf.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.255.184.192] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7660a513-ebff-4dc5-f5ef-08d90bcb0748 x-ms-traffictypediagnostic: DM6PR11MB4012: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ejjEsUjI2eApNjQHePFNhaTR0eoLsHFruo+5JmBTbzgihcRs5b6fgDkx3ffbSz2jFQPgKzydArk4oKQ6q28gsvtS33ris4+g6aT+8unM0ieC+b3cV0s1K8RCqBpy1tYSfh+euu5FVX80pG4TPGExMvBkK6Z9LDtGldxH7KZXD9XzXBq7z9xgzgabw3FvN+HM/XVW3frPSzHDBsHiCUwDHZNr9v56PlK5RYFOkmbpTFEtXi/s1pRVmIZwsB6fG3GZq6NEJWSMixBFkJoANX7T4ygdyUjQ14QBqNwNQABOfaZ+89uwt2CYySu+QqQTw9Ykl6KBBDJ0KU2+A7WrT8RGIgCBIAkqDYNVoslsLCL6KI6c7R9GpXLVxa+EppAtHJq/Lfncu5UfIOSGqDLYbDya+XdNUmry4mTfSwxLcUd4+GsC5f2aoQg+12ZuX4R2a43fLzjSBBO/DJdlyxBEkSunhlK+zUqp1XkbBR+EJtKO9Bzzu1/5gaYxA4ZZ5xfP0u8/ztOBhECgZGbJx5PFZh/+BxE5nTMFYpfWmUHO69VQsruTmIultXalPevG07hIWn3W48lyNogPYb0+9Kqe7YqRHu9HEHmUc7eYzI3nV7SZ6u+eOuosiuUwxW22Mgg6F54sjy1y21APJy09CQND9mf/Cw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(136003)(376002)(346002)(39860400002)(366004)(8936002)(6916009)(38100700002)(33656002)(55236004)(8676002)(4326008)(122000001)(86362001)(66946007)(26005)(52536014)(186003)(64756008)(76116006)(5660300002)(66476007)(66556008)(9686003)(7416002)(6506007)(2906002)(7696005)(71200400001)(54906003)(316002)(478600001)(66446008)(55016002)(32563001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Gl8YaiU1JEzMgijpl+PHtKWA1pzkUdN/O0uhOqO+7lktmFOWvcGrU+UEMPDF?= =?us-ascii?Q?tmjf6QRR8ueZjVg5FyWzVWT4gXBQHtnVPooqZcbcOfuCnxkWcn297ikYQlEy?= =?us-ascii?Q?mN3Aol7Uwpr8RfC7Og0JGDsxG0nYuZakhNduovskf/VGXzS2eLL+F1hwFmN8?= =?us-ascii?Q?hDxXwY/iHB0zvihpKxUpvlMF82BKTqV844no/IyGXAgpZKXOrW2Ga6SmcF9Y?= =?us-ascii?Q?7l0nvbxJz/VKMUgnpn/PLdC0gb0Ka+Z84vdoezNDAxQ7zSEDlvSGZ/HXZZAI?= =?us-ascii?Q?rz7giyxxmv70Qa2gkIkEwmX2W4RuOHKgLVynzfWKMV83lnP/cswjDe+K6n9n?= =?us-ascii?Q?gn3uvdDY9NONoEfAvGUo91XlV3Ar7/by70xjqzRhS3gAcj8Ieqz6EJoOJF3R?= =?us-ascii?Q?aP4vBuDT16NMf271nk4sFlKrmGfPuX9Zg9jiNxXWZPrbXBh3DHo/M8Plmkfx?= =?us-ascii?Q?AUJdFImYgDeaF+z3po6TtWohl7LcQOfVU5H3YG1qBbmHtBQ8w41q0KbFOEt4?= =?us-ascii?Q?U6916WVRuLD/rDW21g4eR7v/41kp5XOhw81DfpDI8YlZooJS2VpbOnjwSxbP?= =?us-ascii?Q?aV4y/7ymEERnTr+pezK2foIAFC4CCcMMIraFNRH3V+U/D+o9levRUd/W6797?= =?us-ascii?Q?urXp7KmkzscosgMJcLEF1ueBnBthbQwSEW94G+3ZFs0oyEc3vW6crsNDn8T/?= =?us-ascii?Q?oo8H1szggcFVemRDli+7dhRXnuhj2duCRoSVhlaVaBCnlPF8/tKWZ6luUjjn?= =?us-ascii?Q?P23SFb4wMK/46OVJV/B81z+kCuh7BvaamVR93TurjFBGG8z6n6WWtkSnzCmx?= =?us-ascii?Q?EEJuoBm98vsBBWENu+O+vH8Ni/DwPapHjzzKicnSwk9cb81hrc9lBkkWP8Ze?= =?us-ascii?Q?u/JpU7AG17S7mzZ6XQuOQqHoIW/2xzbhYxw7HbQurhaaw2IM/0MO5kgPMHCN?= =?us-ascii?Q?DCWhdRyLc+v2LHSmH0VM4IGJQHtgqZHU+nDlnS+KUMBkopPWWQuiuxBWAMuP?= =?us-ascii?Q?Q9stsGP+SSHseKy4PLPUsttRs9NN+tG9pw/0X5hzb3cwozQxnDKl+/jIPG9o?= =?us-ascii?Q?hhwwTX8Ko9FwS1z4mnglM9/9oDmb+5fbP8PcmABx1nU3zuLDAuQe4htjPdv8?= =?us-ascii?Q?e79/skpTh5QU5I977ml6k83uiQwszBloUj+SOv9sRaTsH2/R1BYUplUxPr2A?= =?us-ascii?Q?xZTshNCg5m8QT4zcGxXpttuap0AlIXGWy+QK6XNzWSiC7v3NmglqHKfEKShQ?= =?us-ascii?Q?MmbzkqZ7ZwPtrAnerQL9xHMSPhkpIcaCOxgzhVo4Gh/AkCK91R6BZJGlQCX2?= =?us-ascii?Q?JhlCS+dh9ya+E6BUrj0HuKJr?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7660a513-ebff-4dc5-f5ef-08d90bcb0748 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2021 11:28:07.6675 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GY8tVl/H9z0RGiH411taEgqt4+Ju7beEzVVhWcX77KkFwClJtQgHgtu4+brmTMP1f9nvIw4ZTq7/unV1tMTQKqxJD6NOTLwSkVenX84DL/Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4012 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] L3fwd mode in testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > On Thu, Apr 29, 2021 at 11:47:30AM +0000, Ananyev, Konstantin wrote: > > > > > > > It looks as if implementing em_mask_key() is enough to get l3fwd > > > working. However to me this ifdef seems tricky. How should a scalar > > > implementation handle the xmm_t type? rte_xmm_t looks like an API > > > type/union, but both are not mentioned in documentation and are in > > > platform dependent rte_vect.h only. > > > So either I add another case for RISC-V or (what seems more proper) a= dd > > > an else clause implementation. However then should I change this func= tion > > > to take rte_xmm_t? If not is casting xmm_t to i.e. int32_t[] always > > > valid? Even if I change to rte_xmm_t, it's not a stable API type, is = it? > > > So what guarantee do I have that it maps to int32_t bit-wise on every > > > platform? > > > > > > I think the semantic requirements of xmm_t typedef are a bit undefine= d as > > > well as the vector handling across the architectures (being something > > > rather arch specific). I don't have a clear idea on how to solve this > > > yet and I would not like to hijack this discussion with vector stuff. > > > > > > Though I may be missing some obvious solution here. Any idea is welco= me. > > > :) > > > > I think it should be possible to replace xmm_t with rte_xmm_t in ipv(4|= 6)_5tuple_host > > and make em_mask_key to take 'rte_xmm_t *' as a parameter/return value = instead of xmm_t. > > With that in place scalar version seems straightforward. > > Of course perf regression test would be needed after such changes, > > but I think with '-O3' it should be no difference. > > > I did that and it works in practice. I'm more asking about the lack of > definition in rte_xmm_t semantics. Because once it's in an example, > people may start assuming it's OK to use it this way. > If it is OK, then I'll just post a patch, otherwise we need a separate > discussion. >From my perspective: rte_xmm_t is a union used to simplify SIMD-related code development. It contains HW specific field (xmm_t) and common ones. It is not used in public DPDK API, but it is used quite extensively inside = various libs. As a public structure - so it can be used by examples and user code (as long as it is defined for the given architecture). So I suppose it is up to you guys to decide do you want to define it for yo= ur architecture or not. If not, but you would still like to run l3fwd, then probably l3fwd_em.c nee= ds to be split Into l3fwd_em_scalar.c and l3fwd_em_vect.c. =20 Konstantin