From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51DA4A034D; Wed, 12 Jan 2022 11:48:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A80CF426E7; Wed, 12 Jan 2022 11:48:23 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 30E6540040 for ; Wed, 12 Jan 2022 11:48:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641984502; x=1673520502; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=nHR+SKc98UOAXHAdjnMMRaIqla6XQThYaa5e8byjrAw=; b=JNWc2w04HJXSy7URTpdT75W0ZcCYxW3eNlmZUoY2CJdJWUT/oCBtNfv/ BWKQk9vLJKQc5tajjhseuxgajzcBdCPIJmgyt0CHBpHhivpdUZj9Sd/kj E1oDFYE02mXKYpkpR3c4XVjfoUykeRat9MSwYqP+lPQJk9QoTFoc/IXfu 7JvOBSxxjxV1fKsuz7LP7HBEZEoF8UoX8BP6JNgCVgBAl8Wwjga4xhdWu 3wD1rXYbRFbsEdgSuDpYmdmzucDE6XNT9uBPZgxbbmz4OgGpat8kgfXve ifp5IiRK4ZbInSMpzug003jX40epUwprVmnA3gU5/GTZYtteXk4j9Dyjv w==; X-IronPort-AV: E=McAfee;i="6200,9189,10224"; a="224403326" X-IronPort-AV: E=Sophos;i="5.88,282,1635231600"; d="scan'208";a="224403326" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 02:48:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,282,1635231600"; d="scan'208";a="623397151" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 12 Jan 2022 02:48:21 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 02:48:20 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 02:48:20 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 02:48:20 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 02:48:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mApqJdz0hzOzHuBVoG9H7zkn8k5nxS4JuXVw8BKVeuBeCIhesK5YOs0sLjtN8aRN3ER//64LoD2l/cbl5TBPPX2BjDF/ZWr7+zOIa9f1JbuWq831MAIlozhFw3ZqKDt6qsAAXVphd1Zxnca2gXvVTt65IuibLshnELYEZkzXnISCVyQ6Iqs3dzosTaOsp49JiTCFbvWxrtDHlXDR/k70BCD5Q9dvTx9UqVOxo2C03FqGkTLScu7U3/fYJ0/MDfjHGSeTtEkyq2fDiQq+dffzuixoV2FQHcbOu5IDsy+M4/RQTtS83qqUs0FWw0AcAwsURSsiz015eiC9vCG+dqdzzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nHR+SKc98UOAXHAdjnMMRaIqla6XQThYaa5e8byjrAw=; b=eiBOS/RESPhakAvp1jvtUU1hDT26o5HOB/hW3hsOWTdErTzknSL5X/XmMRXzXqHIqc/WFPtmT4grjCFDcGOm4uxV8Rc1eupteZYPe28ejXTbTCTPaw3U+XflCSfmW2kSwZoueSGqOnt3kdqc1KlsGycFjoFhi3dE0PEJfCXa2Yt6/9Z1MiayigCuSPHKRxG8IkdGWXyuR90LmGwxQr6uazHZfa5rlqJ8dZih2zBQcZXkSwcM1rL/ptNZj0UJMrFiPYk4qNFd9OljnBmxsJxU6NdhU/MHAISFheWun4fII9Z6a4WNFSIpM9NxvAcLcuWQ5rQEuz3M/2tlqWjqOsygMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by PH0PR11MB5673.namprd11.prod.outlook.com (2603:10b6:510:d6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.11; Wed, 12 Jan 2022 10:48:18 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::7de4:731c:cee2:49c2]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::7de4:731c:cee2:49c2%3]) with mapi id 15.20.4888.010; Wed, 12 Jan 2022 10:48:18 +0000 From: "Ananyev, Konstantin" To: Akhil Goyal , "dev@dpdk.org" CC: Anoob Joseph , "Nicolau, Radu" , "Doherty, Declan" , "hemant.agrawal@nxp.com" , "matan@nvidia.com" , "thomas@monjalon.net" , "Yigit, Ferruh" , "andrew.rybchenko@oktetlabs.ru" , "olivier.matz@6wind.com" , "Xu, Rosen" Subject: RE: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration Thread-Topic: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration Thread-Index: AQHYALPTAeqGGhhhEUOj73nYsC3Sy6xeCRBQgAAu0ACAAQCHYIAABakAgAABkfA= Date: Wed, 12 Jan 2022 10:48:18 +0000 Message-ID: References: <20210823100259.1619886-1-gakhil@marvell.com> <20220103150813.1694888-1-gakhil@marvell.com> <20220103150813.1694888-3-gakhil@marvell.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fcca5114-8858-4ac3-b360-08d9d5b90b5d x-ms-traffictypediagnostic: PH0PR11MB5673:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: quRY9gdmD/ebLCiZ/4yCs61ETPygg9bCvGUMBj89on35grFfjCJ9eYxac7mchkPKI3dgy5uJnkgxmHHR9qCSn2JzQa33VibiDgNsO1jgfHFXhcJd92LTq9wBg1geZVDjNpRQ72EMeygKpnbyUGjErLMDYrR436+FHY5MIz3qp/BE6XQ5tLtLmPUwAqJSdMZRKDYH8nhhmLfMxMzvwL7IAo4YaB8MVpHdjF3WUiUNAYwxjDqJy0rF5zvcwhUkdBjQtF0kh7zD0ScOjkCESUk6ytzTmjxb0Fpia0OA48PitFVz0oSxSQFHsiXPZR7PEo0xb/x5DGj5c+FMCywCLmySxWYCBxtlIwcIPVPAR6vhJQ9z+p6icIyLrtOd9MX3Q7Cp0SFtyfrAXkCtXFnyHRnFqoJGZKKGzGq0qJTqFR+Tnm1AYIKK5eI8dladYhaqjWKcLavIjkt0CxGMXZTJyWMN8aYX6v5wEgjHH/vsXMsvll//dZnDGUwH/FiXrwsClRpjw+nDYavbAc//6FtDsGpCg/Bl3t3VSRIKPL6Pj75ZZ00d9mM/c5oN/NBMngwyn5n/JvDj/ZpVui9Xi9KGntL71/HuZDecxcIrosyw+Ou7y7HaExSPXTTUjJQBYfgcJ9fhPzPr4J58lZXjXO+Xr7AWTmuMSssOK4NtVSmMxXT2ZGxXgFz8jQHkbrRC2UshILMWtIqWe5RNukG1UGqtXVMUDg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(110136005)(316002)(52536014)(54906003)(8936002)(33656002)(4326008)(9686003)(86362001)(508600001)(5660300002)(82960400001)(8676002)(66476007)(38070700005)(6506007)(38100700002)(26005)(122000001)(186003)(71200400001)(2906002)(7696005)(64756008)(55016003)(107886003)(66946007)(66556008)(66446008)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/Lw3g40mc2h+pwrlLeiwaQhHVHZ6IMaK3OF200kh3XfeXg593vQa8Vok5HIr?= =?us-ascii?Q?VxNXNioOANxIxkMneZiXZv4yIAiec0Ed5LDAW4HC8bDS5h50QfEBj/iWYex0?= =?us-ascii?Q?Nyzl69YzTz3Ex395lfIkftsFvLOMWsQG042p7WA33AkpjIwckNryACg9d6gW?= =?us-ascii?Q?UIb7b5mJwf3/4ROGW2mg2pUa7pi6Mwfst4wZPWEsd9g4HW2MtZKsS8Bnsm5A?= =?us-ascii?Q?1toypCINH+J627BQkxmQ1dJJWER29FEs+lVT04P42OPxKmx/gblUtjEYVgwH?= =?us-ascii?Q?VcN1zK8xMCKxpmtBSPr4XBj9ut8N7jvJol6yZhaFca3D8BDVnSBAiw7pTCT3?= =?us-ascii?Q?QdVmz/WmMKemLUMqmYIEmSucd3wMl3cyFU+UkMAUfttzhxtx2M8YbBezmNiu?= =?us-ascii?Q?/AVvhrz7h/MLPZaCCDauPaQDUy5Lsx5un9JH4/cwatR/iWAWONvwOpTyfIKf?= =?us-ascii?Q?8NbKzyMKsoO3IHoOuUDRoJUIaeMDKLOOmyZEj8vOau4iW53TeuQzd1Qc/XcK?= =?us-ascii?Q?ttc9ZDSCRomyo7lNzTpTX7aXDCYQr68xplNU464h9e0MNyK0yxbq6DtfslNJ?= =?us-ascii?Q?V/ck7z1E93qqXmu2NXUp4AsKqoXuR0uE0i0IyI8tYv7xJmm3yzHoqu0CuHK4?= =?us-ascii?Q?/ePgZ7KslqyZDJRhLTdY47Hs2Ny6Qv1XvSUtK35GCGULMvhi70abBahbhV8G?= =?us-ascii?Q?k1XaA3Lr5ninda0WwsJo81qCFJUc228ag9svAb68sGdRgUz/9eJnm81QwV/t?= =?us-ascii?Q?c6SW2Ko26yYIFcRM2ZjEpGPOCWWqN9zc4VXIn7omRyHijma6Wu0k/ThQlOix?= =?us-ascii?Q?+mEff2KRdu6n7Le/g7SHKRtWOzpbQtC8yPb4skKCECDB1QRGoBmm3bzOLDgF?= =?us-ascii?Q?DmTF5U9wO+UFOpDS31Zy18kzqZY6wgbUokR4/F1L9rBbHjumcxdFd4L+BuAw?= =?us-ascii?Q?W2aEBwv1NAFhg/ND8mGTMdTXsYLnqmDmSwu+aXCA2TiHZKVvojtGvoOZxHIQ?= =?us-ascii?Q?O+n85BiYBPxTglJajX6uiaIfMhYmCdPW5i/4sM+mT5Y9WRN1eq2NhqG7Avr6?= =?us-ascii?Q?gku16q1CX/+9m/h+VIXONGOlGBMWeskjGX1FmTJkiQVUeauSUjZMnnMH9/Ii?= =?us-ascii?Q?D8gt4DAih/zL+RqKaCU57XhlK5nJ2TiONtMUGXRCyKc3UcXR5HoJw0opPKCH?= =?us-ascii?Q?Fjc3m/tiFd79qSA6VUZubo7tSFWUgGdsCZKz+4DLZD03ztqiMmC/kAWJLgZQ?= =?us-ascii?Q?A8ee1j4I8tJIVRKR7n8yD20LjbDc8L8ZhrLstkRBeVZlqJEbpJi7SvcQa/1o?= =?us-ascii?Q?rPLQDcxvLW5DNg2TTKRd4MLIWM39hf8kJF65KOSPminM03BRcTCnxRhkeCyw?= =?us-ascii?Q?d614t/W3lB8r7ffrlhim60SrC0f1CClz2ID3EAo2A+olj5/wVADheQd271jw?= =?us-ascii?Q?hCIZyViLsZcPwZogGuT+CEe3ZthqfyYhjJYHMstCE0KM3P1FcVc/jY3OSwlA?= =?us-ascii?Q?JpXxsxnzdUhPOKSV0nQMeAn/V8tCNj51axwQpVmlv/lIn+N79j4G9k5PCV+v?= =?us-ascii?Q?h/mCxbS7sVYOG/7HLCnWijQLMHBEOiS7US/X/GeF9DzU6o9fDcgDBftJs9ce?= =?us-ascii?Q?K55bkSYk5k1RxWxmO7BZMGc7xgV6QGnygG/09g1O1Q/az++LYO68jjc95Rb5?= =?us-ascii?Q?e1fCCw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fcca5114-8858-4ac3-b360-08d9d5b90b5d X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2022 10:48:18.4585 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UWmPH4n3KgSjv/TgSa7nB7Q4HKM/fqkbm/9Pm/UtDV0I2Hy+wizPeSo/YTUbHL38q4ei6SjNYCU/w2/UJ6eH56mwFmP7ZfRc0STFUizCs/4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5673 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > > Another question - if we have reassembly_conf_set() would it make s= ense to > > > > have also reassembly_conf_get? > > > > So user can retrieve current ip_reassembly config values? > > > > > > > The set/supported values can be retrieved using rte_eth_dev_info :: > > reass_capa > > > > Hmm, I thought rte_eth_dev_info :: reass_capa reports > > max supported values, not currently set values. > > Did I misunderstand something? > > > Reassembly configuration is expected to be a one-time setting and is not = expected > to change multiple times in the application. > You are correct that rte_eth_dev_info :: reass_capa reports max supported= values > by the PMD. > But if somebody uses the _set API, dev_info values will be overwritten. > However, a get API can be added, if we have some use case. > IMO, we can add it later if it will be required. Basically you forbid user to reconfigure this feature during application life-time?=20 That sounds like a really strange approach to me and Probably will affect its usability in a negative way.=20 Wonder why it has to be that restrictive? Also with the model you suggest, what would happen after user will do: dev_stop(); dev_configure();? Would rte_eth_dev_info :: reass_capa be reset to initial values, or user values will be preserved, or ...?