From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38AE2A0353; Thu, 24 Feb 2022 12:07:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA1FE41155; Thu, 24 Feb 2022 12:07:01 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 9AB8A4114D for ; Thu, 24 Feb 2022 12:07:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645700820; x=1677236820; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=MX1w+V0DAuoG4r5PqVIXaryNmTKu18yXOD51/lEynxc=; b=TZTj//jM4N9e+F9I/QgIse63S34oy9C1npMvEnE4dAXgG1rRlY6WsPHO KayjgZhduNCRJxKVeC2bNugqTEWLzj0URggBPs3Pb0KMnT9OCavZLwPyF 4NFbuOtlWAZLHFz0xNf0b4OwxJX0wCorK3eLkF7hTW9nvJslS+8aCkcKl pXJg5WhsSINx5+KFETOmPfcibdQUQObbO+r++DKJkvRx7/qJo2yFHbSrs dRd2HDk8GP9K4LIfKnh/ZmiXRmEEz9XvTZrb2LvjVTc8aKh9rD3KjXecH Ox1GUALRLyAkwHPW2O+oZle0Qh9rex/hKdN0x9lo3puYmyYaLa96v6ASl Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10267"; a="239603583" X-IronPort-AV: E=Sophos;i="5.88,393,1635231600"; d="scan'208";a="239603583" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2022 03:06:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,393,1635231600"; d="scan'208";a="637794385" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga002.fm.intel.com with ESMTP; 24 Feb 2022 03:06:59 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 24 Feb 2022 03:06:58 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Thu, 24 Feb 2022 03:06:58 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 24 Feb 2022 03:06:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GFNJ3Yevi0eNtN3yKYbT5JJ9c1fOkBxOCDUNaKWPk6QJRiWa6WqcZrI5Lu4jOaGKBMekrG7Vz7IkNohxxRkLeHD+i/4vgI8KJSL/+NV6BjH3lA2LS3yxNR7DSujtb8AnOsfG6qLPgt5xpw/uzgTMFjvwcmUCPgRZwWY7D30chPunCkE7TvPOl2OPfTOY5YqYEhlD0FzFX0JrCGwavye04fKY8MOVmvcyyHrDy09q1Me+oCLvJfK37qykyXyMzV81n6bxWVpka3i6AGZWamF5Js6cuv2bLM3K/786I7ToOBrqpWDEVS4TFifDecPH3tFfxbHaQTwuS8q3REDyC1odsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G2Nky5EiNzUq9o7bG1EB8uK57ODxwusheE3TyPdr7Kk=; b=U8O5k3YbH5h34hc4ArSZIOTDW61aaAz6o0rFZkJZY16SN98KUFJfexA4KcSmOGFP28zwphn5tAmH078PTF1s9tXJytHbl7+Cdzy8SWu0IbTH8XfzbU0ri1pK1mwzMKipgqn+K/ScP/S4eIMjP/ZqAuMvbSkM7csElExv5fng6xTSaG6STQPzOpKBXbskTL6VAUqHddWrbZ7FJGN2Ncff0GLf2TQ3uJSsSGmbtiDvF9H7dDylgT6fdZ9iay4d/gxvUpIU1VVrUMOhpwGj9N4loO5ygV1kzIdyEoXmvF4H33jGMeJ9BkXotGD6RdsFRDovlSA/WAtCOKkOVyOntVroMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by BYAPR11MB2776.namprd11.prod.outlook.com (2603:10b6:a02:c8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Thu, 24 Feb 2022 11:06:49 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::8ccc:ed65:78fa:1b07]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::8ccc:ed65:78fa:1b07%4]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022 11:06:49 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon , Stephen Hemminger , "Medvedkin, Vladimir" , "dev@dpdk.org" , "Morrissey, Sean" , "Richardson, Bruce" CC: "dev@dpdk.org" Subject: RE: [PATCH v5 0/2] Add config file support for l3fwd Thread-Topic: [PATCH v5 0/2] Add config file support for l3fwd Thread-Index: AQHYGgG/2P6JAfnPu0eGpqCdewcShKyD+IYAgAKg5FCAAmOzgIAAe1hAgABhpICAABo2AIABKkCAgBRTGICAAAL2gIAAPHYAgAAJqgCAAClggIABFLbQ Date: Thu, 24 Feb 2022 11:06:49 +0000 Message-ID: References: <20220126124459.2469838-1-sean.morrissey@intel.com> <1908816.VSt6etZd6J@thomas> <2262420.IPqQCg1nHW@thomas> In-Reply-To: <2262420.IPqQCg1nHW@thomas> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f4e207b6-9ec4-46bb-b79e-08d9f785c14f x-ms-traffictypediagnostic: BYAPR11MB2776:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GiAuyf5N+s9bZDVmwFaPXlrfHWERApNDEkw+xnDhRWWAZo0vacJ9Y5ZV4QiTZe1sr64Z6l+DCeGNbvBpTon3jBaqJpf7/VxmT6kcZvpsHMVHq+5aTsCtge499t0PvB2wI81iuTRMeGdQQKg4rMvsQAuRKaDgB1tlezoWuzO02Yd2x9IYZolTcireWel63kdsDrg5SpzAnJDOcUtVA0OW2TbB2m27nlU89TJ03G06deCqWA6N0nEmunhb5os/X8eLR8+28pp5xuwwLdh0zXDurW8c1gh82ln5S8GabZGuWvf8Dxkr9V7iDOAWGfk7H5+6aSvIvDYRJe0Fg+uVIIS7y4kX31aM/FyQxPfQsD1nj3zspW4wRVYURfJoSNo/mGaNFjUyifY9jqlJH6Fl0pMlVZMXkffUJIxBZO/Y+RIs3hpIXykjDU2rKOz5AaVKOc/XPdH0b/SZZa296ShSdy/NT9diclfFohUhKMqCwtsTYE1hdNlS+hKgRY+bmt8yPHwhOwOAJECESGqMPU2+JCcyRXdiGG1zoneQe2Cfn7d0UcEqCPdPtGUP9MkvHvBIffcdC2AZK2xSS0RlnEc2GDQw2WbSHU0eT7bDgQAAyVGNuCjM3vkTWHr3Ki6koqh3n4ncEbfy7Ju7TOcnu75Mqhfgn7bRqKzQFSBT6JC2Jl8uJAZgAzuBT54m6kNLn8oCGNHqkSlT0sOw3RozmZ23Kvtv35XVE5MXQUb0PMqOdg5+R5k= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38070700005)(4326008)(508600001)(316002)(66556008)(64756008)(66446008)(66476007)(8676002)(86362001)(76116006)(186003)(26005)(66946007)(122000001)(9686003)(38100700002)(71200400001)(33656002)(82960400001)(110136005)(6636002)(7696005)(55016003)(5660300002)(83380400001)(8936002)(6506007)(52536014)(2906002)(32563001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BS6LLkPTaOnkeWttS83L2g5J/T7YFnJ8AnW98tL48O27we/1iFzp9WppBvOE?= =?us-ascii?Q?6b5Mk7Ayq+4aAmjt8mKPtXOWQMaYdjU0XQyYNvkmwqVl7mgURTFjytGymsvR?= =?us-ascii?Q?qGJ4ESyfCWSYKRbvAJQznQ1Jm+IVSfsyUp4Z5j/NjBa7WbQKX6SFT2a7NzdD?= =?us-ascii?Q?Z9rcFXbg91epNS2HCcIyxqiDClITFe9Wekjy5lFUer2yfdwdcElT2wsGcVz3?= =?us-ascii?Q?sy5ohr3/lcX6ledx9rNQi2QtG1ziCZptA3g1wk9QMSn5xJYsvBhrkQ+LNXJw?= =?us-ascii?Q?lzz4Hwrbx+vww14WFCwyJTfe2DTJcLklrosoCpxCGqhlonHCWNkOJourljuy?= =?us-ascii?Q?wAGIWJabTAhDoSdciQEN21jvzh/24FbFLWyhnvgPjW6Ir83qypjwlIlTix2A?= =?us-ascii?Q?xcCAG99cjf8Yx43Y1db94h8NnoKn4qUzbFC3bxGCsyfe2XQMSaiRMuYjK9Iw?= =?us-ascii?Q?plQYjYhtey5zdl2BEwQcf7DQjeJMaaEPgTM8s+uqUpAl74vbvV0QdXMhpMFA?= =?us-ascii?Q?2/GLkfVWa6eMPggH96MZQdJFieRAm31Sd9ne4rp9MEIypjXjdHc/n9/ebfD3?= =?us-ascii?Q?+aIsJn6Tgef6R8gLaFyISu0gF4Gg6vP36ji50VoRPrtr03STemh1TMuP+mv3?= =?us-ascii?Q?W+6tAO+GfiDRYrVBkEs3Qd6dHoe5jpmkgbdEeGn+1sIYQZKQQ9CRe/N3kAZP?= =?us-ascii?Q?ccSHmfxL/6FhPnfdJbdZ/5BWkXoQtuETZiFchIXD1sZfbLtBAg4lgHf56VKL?= =?us-ascii?Q?1fEVsYbTtO26/v9Ad2ZAtsalQFVR+p45c1m7DQDYxIZffihvuLFvW5BX716W?= =?us-ascii?Q?V+jRV8y5HmBMx6nS+AKY1aC75hBwgJ9skjBxedcyZXiLRU4A9BehMOUytztG?= =?us-ascii?Q?qw4P57iKuIss6+ml3yhnvfAkWxhBZ167imRL2/ZaQzkAvCWj+0vk6VK4anUv?= =?us-ascii?Q?aJh/zj4PT6YEbCq8u8OGEFGnODko7q2+Tit8gqh4xqARylvwXOlXnX/fVcGD?= =?us-ascii?Q?9NgUqghjfSsUUTrXkg+F8/moGq9H72gzfWG3PgfSF7UPNmSocaMzK0aEGY+g?= =?us-ascii?Q?14qHVk7n8ZHnhF8aDJW21JASCHX6hiSqcgIdhq9ixcOnG0zwylWenhh+CEwU?= =?us-ascii?Q?DCj3nbcKxivE7gADyH95rshYrTYETlsg+TXCDqzGXMTuAYSwpwW4Cf/6S8pp?= =?us-ascii?Q?zeF4RE1GslvMPZPxzue1JTEzGG++IgLXEMjb+B2JalKWHXvPA1WRXlux1aex?= =?us-ascii?Q?4wqhQMa9tSFZxPLWtddetnC3/RPUeB4a9fpoZciBMMxpFmLXrGpo6K9Ygs1x?= =?us-ascii?Q?nIPLRfU8/LCIEQC9kNmKv2nCUFPeVqW4T+QNCXXyfowOcW3hk/vI7BzfuFZo?= =?us-ascii?Q?2qt2cdhkK4d9uJHEzwoNVy5CUOZR55D0LnR6Bfg/yb0yen1igyTItaRI03fA?= =?us-ascii?Q?bzg975Q1S0TnoCFeeRZK/upYm0nTuPbmknP+/qjcV1jOQOh9i3sSQ+VHmnr8?= =?us-ascii?Q?SKzI4e/hQhBVAhlCtS5nP0Eect/1UrZLT6i6GieZ8wctKj1Et7CyCl4iixtk?= =?us-ascii?Q?/UIpkT4cZ1YzQci++gAUSMhpbnik4Z4AiNMVcTWjvF6xyjccb8xXjykjku0k?= =?us-ascii?Q?HeHMjPNSh3dEO1I9oFc1vMxjdHrpUKWQOPlqOzjsOR75cS1oLLX7BVoS9W3f?= =?us-ascii?Q?Qez1rA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4e207b6-9ec4-46bb-b79e-08d9f785c14f X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 11:06:49.4792 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IFP/LSr+SQl8LVNHf7jpNDu29zTxBOKEN3ZExpffzConWcQTsi1+H6w9thUH9mjZ9SgDfSXYbgH+hgObDwI4pT6CNe2zI8a6181IkxQ1HTA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2776 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >=20 > 22/02/2022 16:13, Ananyev, Konstantin: > > > > > > > > > > > > > > >> Or have a generic library for reading LPM entries. L3fw= d is supposed > > > > > > > > >> to be as small as possible (it no longer is), and the re= al work should > > > > > > > > >> be done by libraries to make it easier to build other ap= plications. > > > > > > > > > > > > > > > > > > I never heard users ask about such thing, > > > > > > > > > but if there is a demand for that, then I suppose it coul= d be considered. > > > > > > > > > CC-ing LPM/FIB maintainers to comment. > > > > > > > > > Though I believe it should be a subject of separate patch= and discussion > > > > > > > > > (I think many questions will arise - what format should b= e, how to support > > > > > > > > > different types of user-data, to make it generic enough, = etc.). > > > > > > > > > > > > > > > > Agree, it is very application specific, so it could be real= ly difficult > > > > > > > > to make it generic. > > > > > > > > > > > > > > But several other also have LPM tables, so why not have commo= n code for other applications. > > > > > > > > > > > > > > examples/l3fwd-power/main.c > > > > > > > examples/ipsec-secgw/rt.c > > > > > > > examples/ip_fragmentation/main.c > > > > > > > examples/l3fwd/l3fwd_lpm.c > > > > > > > examples/ip_reassembly/main.c > > > > > > > > > > > > Ah yes, that's good point. > > > > > > All these examples (except ipsec-secgw) started as l3fwd clones= , > > > > > > so all of them have hard-coded LPM (and EM) tables too. > > > > > > Yes it would be good thing to address that problem too, > > > > > > and have some common code (and common routes file format) for a= ll of them. > > > > > > I don't know is that a good idea to introduce parse file functi= on in LPM/FIB library > > > > > > itself, might be better to have something like examples/common= /lpm_parse*. > > > > > > Anyway, this is an extra effort, and I think no-one has time fo= r it in 22.03 timeframe. > > > > > > My suggestion would be for 22.03 go ahead with current l3fwd pa= tches, > > > > > > then later we can consider to make it common and update other e= xamples. > > > > > > > > > > I don't think this patch is urgent. > > > > > I suggest taking time to have common code for all examples > > > > > and target a merge in DPDK 22.07. > > > > > > > > Well, yes, from one perspective it not really a critical one, > > > > we do live with hard-coded routes inside l3fwd for nearly 10 year b= y now. > > > > Though l3fwd is one of mostly used examples inside DPDK and > > > > it is quite a pain to patch/rebuild it each time someone needs to r= un > > > > l3fwd with a different routing table. > > > > Merging this patch will allow people to use l3fwd for more realisti= c test > > > > scenarios in a painless manner. > > > > So I believe this patch is really helpful and should be beneficial = for the whole community. > > > > Looking from that perspective, I don't see why it has to be "all or= nothing" attitude here. > > > > Why we can't move one step at a time instead? > > > > That would allow to split and effort in terms of development/testin= g/upstreaming/etc. > > > > > > When a feature is merged, there is less incentives to rework. > > > That's why, when a feature is not urgent, > > > it is better to wait for the complete work. > > > > That's true till some extent, though from other side > > even without further rework that patch improves situation > > from what we have right now. > > So I don't see any harm here. >=20 > It is adding a lot of code to an example which is already too big. > There are a lot of complain about the size of l3fwd. > That's why I think it makes sense to require this extra code > (not demonstrating anything, but just for testing convenience) > outside of the example. Ok, so your main concern is l3fwd code size increase, right? Then would it help if for we'll move file parsing code into a separate file= (s) =20 (under examples/l3fwd) for now? Something like examples/l3fwd/(lpm_em)_route_parse.c. =20