From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 022BFA0C43; Fri, 8 Oct 2021 19:20:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E41614067E; Fri, 8 Oct 2021 19:20:19 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 155D140140 for ; Fri, 8 Oct 2021 19:20:17 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10131"; a="226506395" X-IronPort-AV: E=Sophos;i="5.85,358,1624345200"; d="scan'208";a="226506395" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2021 10:20:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,358,1624345200"; d="scan'208";a="440000902" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga006.jf.intel.com with ESMTP; 08 Oct 2021 10:20:17 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 8 Oct 2021 10:20:16 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 8 Oct 2021 10:20:16 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 8 Oct 2021 10:20:15 -0700 Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM6PR11MB3225.namprd11.prod.outlook.com (2603:10b6:5:5b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Fri, 8 Oct 2021 17:20:12 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::740e:126e:c785:c8fd]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::740e:126e:c785:c8fd%4]) with mapi id 15.20.4587.019; Fri, 8 Oct 2021 17:20:12 +0000 From: "Ananyev, Konstantin" To: "Yigit, Ferruh" , Somalapuram Amaranath , Ajit Khaparde , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , "Wang, Haiyue" , Gagandeep Singh , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , "Xing, Beilei" , "Wu, Jingjing" , "Yang, Qiming" , "Zhang, Qi Z" , "Xu, Rosen" , Shijith Thotton , Srisivasubramanian Srinivasan , Heinrich Kuhn , "Harman Kalra" , Jerin Jacob , Rasesh Mody , Devendra Singh Rawat , "Andrew Rybchenko" , Maciej Czekaj , Jiawen Wu , Jian Wang , Thomas Monjalon CC: "Yigit, Ferruh" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v5 2/6] ethdev: move jumbo frame offload check to library Thread-Index: AQHXu55XdfHPKOqCh0yWXGD9GidbgqvJWh5A Date: Fri, 8 Oct 2021 17:20:12 +0000 Message-ID: References: <20211001143624.3744505-1-ferruh.yigit@intel.com> <20211007165626.2941995-1-ferruh.yigit@intel.com> <20211007165626.2941995-2-ferruh.yigit@intel.com> In-Reply-To: <20211007165626.2941995-2-ferruh.yigit@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dcf7bc42-f240-4576-907e-08d98a7fe357 x-ms-traffictypediagnostic: DM6PR11MB3225: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RkBZxemMZQqqgSUi7OdspGBxO0LM/mQ+bhItWx3x6WvkTgNE0m2pBTS52KJB4vw2Ibko8ktwtr/zfah94J1PiJGQbAEUHwdb1dXEW0ACcdEjYXWRF3eiZNDvXnqm9OMxxGHW1j454Lst0P9u6oK5sNzscBGasoKHf2heKXwvICxjw9f+hcOwxGnd2oxb3UrXqdmYjQ6Dpxzda7Ekqqy2tbkwFoyEk02ZX+my6/DFROjcJhJ/uhbAPbywuxRciTF8zElaG8iafgTcDoFlLWbn0aJiDfANvRsi2nYPONO05RRHtaYzffhp8QrlPJFsZXrHcLSEo2t+2XJ53N0NheBc/YqYFlZjzr16j12BYWTYFtSYCEskc3VkcqQG5zeiDMx5N92zjzZLawDTL489F7Jw4+KzygGTalhAjDW2JX4p3fxFiKKZrdoFlDuZnSLXfWjXTsGo3+zYPvfbCIc4gwehUthp37Q2yC0xj9SGs/lkjfd/wM65qF0sp1/ebJN/3dCLhuqbteSAcwA/jJ3pzMs0cnX7KqgfdT83GVwqPzUSiSzbYQUwynx1uyw7m0MIhOszmdb0HNzQWgnAawSnEavhbAMa8Z/guB2B9kjp+RRrNzdDokWxLO90uBoQntYVwjjQGdNyltG9TB8VnKrunOn8B6TtSJHkK/5y/NssuU1gNNAuwSMWjODcKalkcG5KTNZcczgeYd2uF8FF6u2KkGdlQj5a30LK6VzWV1hJhVwqA8U= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(122000001)(38100700002)(33656002)(4326008)(186003)(38070700005)(86362001)(8676002)(7406005)(7416002)(2906002)(54906003)(71200400001)(4744005)(5660300002)(7696005)(316002)(110136005)(66476007)(508600001)(52536014)(66946007)(6506007)(921005)(55236004)(83380400001)(8936002)(26005)(76116006)(9686003)(66446008)(64756008)(66556008)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wTLj6zoxMhZPlOKYOX8aOareSDpTXlee+r5qtXAZLdOPkxlp5pkTuQ+VU3LE?= =?us-ascii?Q?DSjSLhO9kuRZvjK0qcnQz5/MZiDWcV5ivC7psMKCb6RCqI/P/PkjLw2lGpJe?= =?us-ascii?Q?ZE18IB8heTwa6yHUoF1+ZfQXxlTbKGaWxthN8K+B6zPMuuXJILP1aTeJhAEy?= =?us-ascii?Q?Zrwm1W5KkuvLVw6AfcWPZpEx3sCYJO8+0/fDdhxeez0M9FT8ht6TxJjUqQbM?= =?us-ascii?Q?PBMpzmrc/LqFW1dNEmi7H6GR7JPkm8fNT4K6mg6xvutPUgZp6GXS9D40AI5L?= =?us-ascii?Q?GwzHJVlk01eb9UGY964uOjbjO+XApy0Sh4mHRkKoSG4DgX8j4DudUfYAJZw3?= =?us-ascii?Q?RMAV3L7jQZSXj5P8MOM6ma6whCBaknnOTd2eetXXJEKTg4b+CuxXGcd+9cen?= =?us-ascii?Q?QbuoSNRb+J1Vvaj+/35CM+biV5ERbSJfWVBus/0lzHB7wzMlqRHzGhPR3JWc?= =?us-ascii?Q?MLfdLa/Ksh/G2tUOLJ3DGX8hy9xYbRav1BTFt9Sr32Xs0vBP1DjEXvbz2s0c?= =?us-ascii?Q?11UAx0jcvNu0WnmFiH18gCYQgwqkRQuUYy/0IueRgjHbFAJo4AE558GcvIcX?= =?us-ascii?Q?Nwdhys0kQIHP1fLq5rlKdR2Oc0wA2X/NAjeo6nu7CjjIzNM5a7Pvd5oDRuFZ?= =?us-ascii?Q?W0rx49D5OaNKuJmAfa+dcZI5MKtsvh2TZMbvcMAgiRA3ZGyprEjscOPEmVgN?= =?us-ascii?Q?g/50u25TPVXaTsxP2uVPgdiq6urhTw/RSj8DtPILAmrDuWrsN/InqSCczop+?= =?us-ascii?Q?EKl4AtouG9S7BJuQ21oMeEcKt24MwCgG1Yw9PJvjaU67+ns94Ha96X8Juwvh?= =?us-ascii?Q?jQDCshxI5cXhSmEHADWVlbct3jxJ4kE5cUMwIqOMe1dcg3r3YWWhamDe5F42?= =?us-ascii?Q?eL+ZtPNvv7LcyG6vWA4GxeKgIWC27FxVy8Xxv6MlJ6aD2N4ye9O0YFzI7H6m?= =?us-ascii?Q?3M2mO+vhleIWpp0m49525rIuOo3LeFEY2G8rfkUDKXlgPRRRVAel0WR2jgUg?= =?us-ascii?Q?9wjY1OOtJ57EPBOg4bGTNhIfTLmLs6tseCStwBPVaVMHg9l/wh5cuWP2tsuH?= =?us-ascii?Q?+bZq4HsX/XbwcsoHL7rjKLzvGaB3Pjaf1hklUCYi7HtbM46ZEbua/KjYPrhw?= =?us-ascii?Q?eUYJOSL5g/D3Wq049T+0JkeZDQSjBLDUxo7hxP/Xqmojq6+DTfJzX4Pt6jrh?= =?us-ascii?Q?y6rfi+KgZNBuhrPIbzJVgffvvuHpfx6MYYGYTxtUxPCIopZO8CAzsu/yt9NQ?= =?us-ascii?Q?j6sjEUJis/pfvZH8jZeDsVgiTMcoYf6LLZje3wvWXopGs0mMqXBP8UZ3ds66?= =?us-ascii?Q?CZpDfxKQQvaHCpNTHIhh2CaL?= arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FbO6mOGuccFrP6ueqCQW9uHLn4+/mXCNYkngfCYr9i6YcNtrqnjYvpDIQs0oLChy4u10ZukFhVo19f5Sknb3yqqDudTbtnA5MqKFWqtarFlNRnSruOo0nRhQLqWSloYwCcThDR9ku41AGYJ1RQegLXgTEp/DlT91wkGgxVC9Sgt1aQGRH73xzLH9z+lLhs7Zcn3EeBrCWOdzDiGcNER6RaWbBfcJRlaGFK4x0Nj8cOrqqd2qdHB+KEXpBXJYlPsgXjWekLhB16RreMkfxQ4PkuxWRvIADsl98/DoAwOzu2FVhqzjHPh8RXhQF82JYtSqt88P4MR1d1pWzA2oto7ZeQ== arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rHnNUmDd6tO3mLYT1ulLA0NdIoMkLavJNldCl7f0BwM=; b=DGVN8pFM6vhKgQtsJ0QFnhtdulcSc3q4OkhozhboR+9klLShTrpsg/d54sRD56Hdvvl2ZjL4UMXTZxpagoOTMr1g6a/32CfUUihgH+dReqKmjfBuTmO5LOEa6NzbBuS9ItqE2a9sgLFbVPFQO8GfDr0EkbgYdFln9wIU36ws3sapRAHZM08L67Npk0/16Ikq7euZWuLbXYdbk1+icecnirWRjDzFWKJ+aOdgJqyBnSvW8C3RF7HIrM9WMjCWz/7d5ZXCANDeapucvpnPahfvqd4ah8u0mX2/WtwuiCZhpu64lujytECwvM0yf7dSby++inGarU//wtTjkGFmOd18Og== arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rHnNUmDd6tO3mLYT1ulLA0NdIoMkLavJNldCl7f0BwM=; b=aIslZDB8B0aBCoxlhd70QAm0IP7QiDXsoQ+IftzcKgu95KgqiVdWPaRVr6rsCRQ+hLRLKMglBlLGS3J0Y6fAhUYKaITMQr/VDsf8bdOggQl+NEQ9mV3Qw0Fi5lyjfEJGgAuhJaZBkmct0cMAo9Ek9wH4hj8wUT2pKPXZVihJp4g= x-ms-exchange-crosstenant-authas: Internal x-ms-exchange-crosstenant-authsource: DM6PR11MB4491.namprd11.prod.outlook.com x-ms-exchange-crosstenant-network-message-id: dcf7bc42-f240-4576-907e-08d98a7fe357 x-ms-exchange-crosstenant-originalarrivaltime: 08 Oct 2021 17:20:12.7723 (UTC) x-ms-exchange-crosstenant-fromentityheader: Hosted x-ms-exchange-crosstenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d x-ms-exchange-crosstenant-mailboxtype: HOSTED x-ms-exchange-crosstenant-userprincipalname: ytxvBm0OsNLpTO5OO0s1ymT4o9k8KPLUytG2jkRR1AEaSZRXiMBlRCgwwe+4CAAaM6FAB5PsCMHibNR/jUrQR1gpGF4RPYDaQrnjdtddeAA= x-ms-exchange-transport-crosstenantheadersstamped: DM6PR11MB3225 x-originatororg: intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 2/6] ethdev: move jumbo frame offload check to library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Setting MTU bigger than RTE_ETHER_MTU requires the jumbo frame support, > and application should enable the jumbo frame offload support for it. > > When jumbo frame offload is not enabled by application, but MTU bigger > than RTE_ETHER_MTU is requested there are two options, either fail or > enable jumbo frame offload implicitly. > > Enabling jumbo frame offload implicitly is selected by many drivers > since setting a big MTU value already implies it, and this increases > usability. > > This patch moves this logic from drivers to the library, both to reduce > the duplicated code in the drivers and to make behaviour more visible. > > Signed-off-by: Ferruh Yigit > Reviewed-by: Andrew Rybchenko > Reviewed-by: Rosen Xu > Acked-by: Ajit Khaparde > Acked-by: Somnath Kotur > --- Acked-by: Konstantin Ananyev > -- > 2.31.1