From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E42B6A04A6; Wed, 9 Feb 2022 13:00:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B1D5141143; Wed, 9 Feb 2022 13:00:48 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id AAFAA40140 for ; Wed, 9 Feb 2022 13:00:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644408046; x=1675944046; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+d911mMP6w4zVDAQTMYbpCvfk00vqshG1FX3BbegK3o=; b=dmWSuf7qmXImZP00i4S/HbTU4iZcKS6e7hcHIhR++mBGSNrtql3CKfcd 7qlZ8zXWr8TeVorD61fW3VhbjlXZ7j/joJtjbRppfo2aJchcmEnaTxFmT SLe5ZpPDzfoxEgriqBf48qLQPDAy119Q8ThfIwfjLDAwF8XaVXpGM4yVx hA590LUT4vVwMroH8HePotQO6fAMAnN7P66I0AB9VjN4ooT7ipM7/EZtK L6vl5tFMeL1FDsqWC/078dfDMVFPUlLhMZ1P1XmSVlWqh2E0fh5cBvMVe a0OpYT5OSmHP7dOBIYC3dLHy9Cl/jeefVaCBR7J/ukneMVYigeECtqWod g==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="232754491" X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="232754491" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 04:00:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="771322892" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga006.fm.intel.com with ESMTP; 09 Feb 2022 04:00:45 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 04:00:45 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 04:00:44 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 9 Feb 2022 04:00:44 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.46) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 9 Feb 2022 04:00:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lb3MG4tD750UE5k0cblGi9dMG4hHbovCxnBSNJ+U1r4J9NRA4Ek5Vxw03hDtPeos9S7IRiVOcfdtPQGzgT4zwhtonPCuZJJMW/2bJwQlafWqrbqgylm58f51AJG7CpUhl9Le/FC2zO/WDiEn8Y0Vj81GCKd70nO4uoBDniVZ5rTO19VY5ozw8H0DzyMUIpI5nptQS7mM6f3z1G6VjfJw6uLFZo1VWDYZlDi5HuBwODVTnd/kl6HLSjC2OtfBuSmAcDBIGVk/vCW86BqhDBWFGA+xIP5z8GiZo3xSNU6yAJ3T7OfSe8nC0gHQ3fFZrJkQ9nLY/LCV8jpQo/ZbkIBauQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OS+MKEC7li8ujJrnuZFVboSXfK7SOEE40b7hDPwPmf8=; b=YsbqBTco5ZcbOrO1XOfOLLawP4PS047JaBIwJxaEtSQl2Rrfq5RMpKzhQHXVkY9KQrZOF5/movoFkpbCQJOz3IApD6fmhDMcn5OKFDQQJgfmpgIijEGFzVR0kux4dMW5mBIDAZ3pwruBwan1H8hYjd+z0Qj2c8XiKRdExtRCvGqc5HPOPW+0mmOjOMjcq68SKhcQOI6vKP682Iv9TD9o3whogOuFKJKidu+oxPtW5PGcww/CkroCj+IZhkyAedaf6ZlDESk+a7odGJswGCJhQ3NOaSjdhszQIWiEdfaUWQxhNwWatAdO/PRT4E1eoY+66HBCXYxMnG3rvs/c437LrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM6PR11MB3961.namprd11.prod.outlook.com (2603:10b6:5:19a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 9 Feb 2022 12:00:40 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::8ccc:ed65:78fa:1b07]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::8ccc:ed65:78fa:1b07%4]) with mapi id 15.20.4951.019; Wed, 9 Feb 2022 12:00:40 +0000 From: "Ananyev, Konstantin" To: Stephen Hemminger , "Medvedkin, Vladimir" CC: "Morrissey, Sean" , "dev@dpdk.org" , "Richardson, Bruce" Subject: RE: [PATCH v5 0/2] Add config file support for l3fwd Thread-Topic: [PATCH v5 0/2] Add config file support for l3fwd Thread-Index: AQHYGgG/2P6JAfnPu0eGpqCdewcShKyD+IYAgAKg5FCAAmOzgIAAe1hAgABhpICAABo2AIABKkCA Date: Wed, 9 Feb 2022 12:00:40 +0000 Message-ID: References: <20220126124459.2469838-1-sean.morrissey@intel.com> <20220204195905.449192-1-sean.morrissey@intel.com> <20220204142636.6250f05c@hermes.local> <20220207190419.2a1ca44b@hermes.local> <5a01520b-b85a-02c7-67eb-5a7119e46ada@intel.com> <20220208094904.5ca9db4c@hermes.local> In-Reply-To: <20220208094904.5ca9db4c@hermes.local> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a589f732-b448-4a1c-c347-08d9ebc3cb14 x-ms-traffictypediagnostic: DM6PR11MB3961:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rssAyBBXYltUy2f/8s4+BLuMfnJMHpKp+NsJIBfbDeQFOHiMEnJgqWsW3+VMIZtCxQENZAvxVuaGN++hOQYWswLl+5Cl5QR6Utph+epW+yGyO9gfuEIXYGuni1a0fuF67haTaljU0S4fcBfh5/krE6GxCFLB4NPndNJCdaMF1tiOkVXzzMaERUMode6+ZtQDCxOVj4Brq3F7YW5bvbBcy+qG2/KyDTpluHb1R5I9xzuWbNN3J+NwVeHppDvjx4FnSPiUqLR9XKAERuTpfuRKBiFuiWai8UQxCHrzHO+WKyqcdDkqcYArTXYLi/QWPAIKIhNgqOSF88i+QjC4/flVgszlBm/VJo23hmJdSEaIM3TUKSlEf6AHFsIhsz5iMGhMf2IqhBIj+qR4ay5jDN6czjw7pxHcuxzwibCQ95F00/v4kGX27hBUPtbRrZA4eCjSZ0428sE4ymasybV6GghdijVTaWlWBwneVEZXMZ/mhOw8AtwZGSFCDP+lcq/5FuyoCDKBuSg+Izoh76Rqu0yB7fQzRRKBE1uHnmC/cSp9HDzbKy/m5bVTQYaIOBYROz9ZCHK/ZVqYasp7XakZHqXtW5uv1yYAo7TjK1QpiF92vE//vLwDGwwRgxsPKJf1xF1xjatnaYLwScUulRMOCV6QXlEb5tClkJRtg7YmgvQy5JBBprQcgeTXw7lCeja321RsjyLHUgfUjsV4SaSO1wHsJnH2DxV6SMN5W98tRCCJV1o= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(7696005)(2906002)(4326008)(83380400001)(33656002)(6506007)(9686003)(26005)(8676002)(38100700002)(76116006)(64756008)(66946007)(66556008)(5660300002)(8936002)(66446008)(54906003)(186003)(52536014)(107886003)(71200400001)(508600001)(55016003)(82960400001)(38070700005)(86362001)(6636002)(110136005)(122000001)(316002)(66476007)(32563001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GDlpgQobNqWfVGINPQejwavO+NF6kxnfwE3HqE0MSgTKxrgEFB0oWXtsJ6RH?= =?us-ascii?Q?OWgkUKvporNoK4fw1J9KVMdlhm2yWAMVRICKuGAIfnee9dkHqyqfHgF3TIfv?= =?us-ascii?Q?vRF7txmBxhIh3opRLDx1qACB/cH0CQ4MvXYQyb3/uU9/QFx6VJdwdpLaRTSA?= =?us-ascii?Q?65u0s5T+bwa6WjVPexUwsZ50ZMDAE6wSPfIPF2PqhpJp+ehxLyek3ggkNPmZ?= =?us-ascii?Q?wLThEApKncaBPJaiLvrxv9YG8EsrsuzNJjrgMj7eJbh0EcZJD9Dsy3aVTjWD?= =?us-ascii?Q?J8f4b+PFVrllg2VP611JppTORxfbwsbljjIjQi67Jwtcn8pKXgTLZos0erHF?= =?us-ascii?Q?JjP5CeK+rskX0D6RE88LbvhVzFRnzJxplujeTBJ3kn3H/lcSy0og6zbqqF9L?= =?us-ascii?Q?l8FusV09Xte/+xG83K9LglhvKzZKwF5nRfzXUtBUqbZQcELcVqP3sZM6M2Lo?= =?us-ascii?Q?D4tdwf5TbS7YzS8p1V9v/1LHumBhtbvUSzfD9fQzLHua8CT2LK33FVP3wVIi?= =?us-ascii?Q?iTLfbh2wzg2nOGDsSjR0vuGhCCI6wHW+XswA6zKLOXm/Uo0LaMBnZVYxgUAM?= =?us-ascii?Q?BWkx4cdn/ZwRb8IJlf40FFfwjtgrEYdN3HVblWmo0mgnC+IG7LjtThGB3+/X?= =?us-ascii?Q?dyeO0QzlJbMznrjM5N8HI0fAZhRLgvvNFVQsiWq8ipGXtdvhIBQVpGiFm/Hf?= =?us-ascii?Q?bQRDFWIQtkc3bzH+ubDvgPaQgXRJIyqm2csMmr8aJZ/S5VZbiH/r3K7DkneO?= =?us-ascii?Q?AFOfOkEg7H4mg/dZD+4puTCQ5zRAZe/Zulu4X9whtDJIJs0bAl1eufUfyoK0?= =?us-ascii?Q?9ecMAUu3hx67ky36j2DN76lzW2KIDif+w9c5JG4VX4/dho/Qy+i9fyD5VdUN?= =?us-ascii?Q?PVRJjqxW5EA5SfIqa2G8fsbcgHKH6jPe3Wi+bNHaDGNeCJO4ttrYva4QrXk+?= =?us-ascii?Q?1THvQzgjvlwRGiBaKMbGrEnNpvz0rD2nD57wR7qkqiPXzHNV6Lo1rA5yVg7o?= =?us-ascii?Q?AGl5Qn0+7AuELFuQtRRus4dVdOuyCZxGggE6QDPv24V0SIcbEBEXDaaFgUtu?= =?us-ascii?Q?Rp7GUED20hsbN7KmgRlk9MnV4WW07wapZM04a57P74uEOFxkSPxoH1K4ld6i?= =?us-ascii?Q?l5HvKIt4IZ74uvsMiXryw/pibMGePmbgrnw4NwpDC5HjLvqt1acylyVm7lBm?= =?us-ascii?Q?GOIe1hWpXLbeZyo2LIS9/SD8mPeqry32mfxQ6TShc3qDXbaWmAsf2fd3tAl6?= =?us-ascii?Q?SYvAWrX+6W+u8iUKM0RoFWPZYXHyyEC8ptveOKjiuHrwhrdcZ8jeYenphyO/?= =?us-ascii?Q?eq/fRzzUnGYB2fEL8dKHrNWKfcnG+RsLXkZ6+DGmYsmKWNGDzlXWGeI5bQWK?= =?us-ascii?Q?F/PIjhAj0zjaOOKk4nL13qf7kCIV7HJQX2CQ90PtqIrOO/jPODuXtx+DxeMN?= =?us-ascii?Q?55yG7UI8gJT/f8yPVXOVum2Yu+zJCELsTkJQj8HdHXOpVApY+Ezi27nIf/0J?= =?us-ascii?Q?KoHmR5jK9NAxTH5DHmo5yg8WDTUOxCUikuapVnwLMDnmF5MPXg6vDNeJ2vuS?= =?us-ascii?Q?MgV9EUGpw4NzGKuY6QZEl91se/849Yk6F4bHRLtVvvNY3bivQm0O5uRMIAhN?= =?us-ascii?Q?hN6j7opaAOB8W6DxEMvxqa5WI3vBP7guqVfgL5fueb/sEB0xIP8+phYXZ0Pw?= =?us-ascii?Q?V/EfPA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a589f732-b448-4a1c-c347-08d9ebc3cb14 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 12:00:40.7140 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3QqYiPvVzDeHo0hVbPFeABZNfvQMjzPM8m337cQZ2I9wgpgSd7TEtg8B9TH8IDbUVwj418UNCCEuhcUnP+vdljqMa99o/Fj37wzsT9t//5g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3961 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > >> Or have a generic library for reading LPM entries. L3fwd is suppose= d > > >> to be as small as possible (it no longer is), and the real work shou= ld > > >> be done by libraries to make it easier to build other applications. > > > > > > I never heard users ask about such thing, > > > but if there is a demand for that, then I suppose it could be conside= red. > > > CC-ing LPM/FIB maintainers to comment. > > > Though I believe it should be a subject of separate patch and discuss= ion > > > (I think many questions will arise - what format should be, how to su= pport > > > different types of user-data, to make it generic enough, etc.). > > > > Agree, it is very application specific, so it could be really difficult > > to make it generic. >=20 > But several other also have LPM tables, so why not have common code for o= ther applications. >=20 > examples/l3fwd-power/main.c > examples/ipsec-secgw/rt.c > examples/ip_fragmentation/main.c > examples/l3fwd/l3fwd_lpm.c > examples/ip_reassembly/main.c Ah yes, that's good point. All these examples (except ipsec-secgw) started as l3fwd clones, so all of them have hard-coded LPM (and EM) tables too. Yes it would be good thing to address that problem too, and have some common code (and common routes file format) for all of them. I don't know is that a good idea to introduce parse file function in LPM/FI= B library itself, might be better to have something like examples/common/lpm_parse*. Anyway, this is an extra effort, and I think no-one has time for it in 22.0= 3 timeframe. My suggestion would be for 22.03 go ahead with current l3fwd patches, then later we can consider to make it common and update other examples. Konstantin=20