From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A60BEA0A0E; Wed, 28 Apr 2021 13:00:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CF25410E0; Wed, 28 Apr 2021 13:00:41 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 917CE40147 for ; Wed, 28 Apr 2021 13:00:39 +0200 (CEST) IronPort-SDR: qsKJ0qyYgnRbSlf4UXwO4SLkecVSE1tuow4ThQNKjUzjGHOzMDBpWkhcG1yz0ekks2KhsdyL4p +WAFV4mEmejg== X-IronPort-AV: E=McAfee;i="6200,9189,9967"; a="260663553" X-IronPort-AV: E=Sophos;i="5.82,258,1613462400"; d="scan'208";a="260663553" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2021 04:00:38 -0700 IronPort-SDR: 4CGZpVI+sNyn0KrUaKzVn6PdBwCkvpoPv7euYr20dL4vuM8cB4srO7z5p6JkhncQ9e0IV4jFUQ KSq6giosi2zg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,258,1613462400"; d="scan'208";a="386472608" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga003.jf.intel.com with ESMTP; 28 Apr 2021 04:00:38 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 28 Apr 2021 04:00:38 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 28 Apr 2021 04:00:37 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 28 Apr 2021 04:00:37 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 28 Apr 2021 04:00:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ftZWD5t4VkPuR3vWLF0K2YzRA5AIVWPMkWwkwDXLoc6O2g8sNcxGxqDIImwG9Vkrbk5S40Sv0t5CB8z/VkPG5CEFdos58cMWlOIFUqTMjz9/BsvM+uQ6xTVxO+OQtAr1MzeQJSBbLD9LIHbaBLPrXRqKepL3lpjTLB5VUn3gtU3O2GRu/vZ0Wc67aDnBhzMwmjbIwgnfdCITMk8Sl8VN12cDEyk+8lhKJNiccjj0N+m76mAACAIyzGtFjLTsO+9hz2QmsPZmxMY8OJOXtTJSGjhyXwJWAuRK3M28or6ucQMpazYx65yvs4AEQCkZhjg2ZhFe8PT9akaiLwd9TPhsIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nkO53kqLwajv3vy0CbISaRvWkdLYd2RuSmpNs9ZyE4o=; b=UXtoiDb3lUAT6IRSCi1LubBm+KkPIsj2jQy8dc1eRaqBozgfhOViuxP+FpvhXOV+uu3Zgc84fU/BjOQivRqtYiDeVwFr9vwFTC2f4LwzOfnC8qK+L5EvLKAqDoJIIwsg2pHUSAu3+NR2eMYV7lL5bXl9pWTXhfmYjyoUO5HCrYOAZInFvX/nwkkb/kpNCLHuMJDSGyWT5Z09iHsWrzKQI4MmsOz/S1DEGPNKHp07QBseOsyvG4nwKQ87j7DkQ0HNubZAzlZATdOeORREze6ODeCQqXjUOlvwQvj1VOpIiFrkiRPCGQhFSQZmrTYEj9EtKoVjY9ze0J2USvNB1iUuEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nkO53kqLwajv3vy0CbISaRvWkdLYd2RuSmpNs9ZyE4o=; b=K8+MOHhibvzmxqB8PROHhserkfRPUBIn+1Jh1YNNOg0yEoMmq6b1FFhjNJB0CjkKP53PZ5hf3txrQWoHeHnfzh93XlnxtMPhJyZx/s085ZstPbMO0Fej5i8MBW5Hdg38dxzRCMqvihe8RLx0ecoAMg+Ug8xmVFtU5TTrDW3rlJ0= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM5PR11MB1531.namprd11.prod.outlook.com (2603:10b6:4:10::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.24; Wed, 28 Apr 2021 11:00:25 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::15ed:b4f4:540e:ea0c]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::15ed:b4f4:540e:ea0c%7]) with mapi id 15.20.4065.027; Wed, 28 Apr 2021 11:00:25 +0000 From: "Ananyev, Konstantin" To: Honnappa Nagarahalli , Stephen Hemminger , "Yigit, Ferruh" CC: Jerin Jacob , Kathleen Capella , "thomas@monjalon.net" , "dev@dpdk.org" , Dharmik Thakkar , Ruifeng Wang , "david.marchand@redhat.com" , "Richardson, Bruce" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , Stephen Hemminger , nd , nd , "Medvedkin, Vladimir" , "Walsh, Conor" Thread-Topic: [dpdk-dev] L3fwd mode in testpmd Thread-Index: AdcV2H0Bhkmz7z6QTBeC8FixZy3dngAaQ6AAABIFuOAAAQNCAAAAQNqgA/efEhAAAYi7gAAF6HhgAAl7GoAEe3+OoAB4fPWAABDYiwAABc478AAb06kAAAz1JoAABPozEAAH+U1gAAHMiTAAF6lVkA== Date: Wed, 28 Apr 2021 11:00:25 +0000 Message-ID: References: <2273212.ItJIoklBD0@thomas> <20210426104720.2b892045@hermes.local> <81781e97-735c-f584-4148-ff07dedc5cb4@intel.com> <20210427090121.4f6f0089@hermes.local> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.255.184.192] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1f7bdb78-531f-4631-5693-08d90a34d3e1 x-ms-traffictypediagnostic: DM5PR11MB1531: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jQTBlQyYvqdAvLPn+FY+0TqlZRJm/DjgvUyhMZnkYRYHVA9Tq6OXQK8JEYr7oiLCNNVJMOW5eSo2eh30D0csvc6EzCarRl34/CtMJh0kJqsBIzD+p9VJJOxA6cB1WK2mIxRlkOweJABc+ioTABKFjvPvphUuDPC7Kj0FcRf8tARmZG5WlXWDVdZ+DIlAO7ZOmAmepdh9hk0bkoXv2EAeHPMHyvYNG2Q2tHQTnK+35e/+KfRk7LIpiJgiV1FAI3PNiPeyB0gRYWB8QpCCSA7vNMF3OYHu//MlyAiA1Eih88TWucaDsgvspnltUJlYWI61ief5YF/qtlqB8zTeJRn92vRYUYCQ12oP6q0zREBhNEOrASt1T7NjKSrDiRBsXgHkJiMAtnhiPIMcvyShyfKwYv/7Rmji/uTQBvuGE3Cu3DpZ5WMWuWnsPqNp+au4QDxDxowUyFOZMP7Qi44TrhlD3xhWCRPQVfYTkX4NCFWU9qxt11YDe/Vymd1SjqyjDWTl6nHMyo6RLIzOlogcDY4Ixg2eyQ5So5GGDqYAUwr2H8COzJp7d3Bls3Dy2WICUvkpGiUpEsLasBADuXij83B4oKybxyXFHsX/shi+ihJ1JtTuPPRsIbnsVVEQMKiN8DROUfpDddk3EKYLJBlxfdZhlA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(376002)(366004)(136003)(396003)(39860400002)(76116006)(4326008)(5660300002)(9686003)(64756008)(66556008)(66946007)(66476007)(83380400001)(478600001)(86362001)(66446008)(122000001)(7416002)(6636002)(71200400001)(38100700002)(55016002)(52536014)(8676002)(107886003)(2906002)(110136005)(8936002)(54906003)(33656002)(316002)(186003)(6506007)(7696005)(26005)(55236004)(32563001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?dfh0tZ5c/W3YrDjTuX00bqzfiwe15xB0oT+jmdnr667B0rkBL7ySIJU3RsEy?= =?us-ascii?Q?FV3t3ri9Zp87byrtQBe87ATkX4hbpd9zHYj7YRpFgUpCvtSQashwVvnwm4Is?= =?us-ascii?Q?1UUbiruJwURy06be1nUfDFiUjNcCFp39bl0rzCwdYAJMwVkXAnnhsyo368rZ?= =?us-ascii?Q?CHRAvW5Fw+dPrha+W/QU8xqlYvljj3NggLpF6ydES0xMR64/jrntUUP2yrVX?= =?us-ascii?Q?NOPgl7uBQwBcLp8Un+ebHNj85T4UKSdL6fb/SdQLyYj+WkFarA96oDaTMvHh?= =?us-ascii?Q?47Gbc7lpHJJXofi2Axegg5NY4Ymd3J+vgatBhz+ixKuOeQ8HqyoXqdHJ3HgX?= =?us-ascii?Q?ldpFR83FUBfKQtJZN2ECsitfgXmJPrN89W18U47T+t+wwFBxQFLf0e2JFn/M?= =?us-ascii?Q?1NGsLOYHwBP/paXpXYYvrDGz9fYw6QUJZa/ClsbCtMAHNO0QyFnXVJGkq8wu?= =?us-ascii?Q?Ao0oFnZqa6e1J6/jS4TaZEtR+rF1aP4IyGw30yccVhjdJMSiTNHRXmoars4l?= =?us-ascii?Q?FDqU0OHyTAMTt4l3jR9Ac9sHW07TUhag7TGjlq5Qn8YgHbs/4xIKh0rXnogn?= =?us-ascii?Q?/88FMdf/yXtqhfSDGVmgph5xluBDhKTMSLSzybuTiv11BtD6jJzu2ujUPgm8?= =?us-ascii?Q?U9jJRCaCKvKZbI4xGBx6fbP2gvYWWs3hpoSTu40qgOsk8YMeEeV6fT68av7z?= =?us-ascii?Q?vLIR+LfA2iKU9euGqFS8zeGRB0HkP8otY3n/ZZGHvh7ZNy5pewiDm/CUUWk+?= =?us-ascii?Q?gUQ3ucFa7ORnFClIg/c7QLlQRUG07sco4Fa4SuWdR1sQsprPptYul97md7oR?= =?us-ascii?Q?VUUOPEVWlqbPpVFHXn2+E//VhnmeB63JwUeECP6JsRPKLbX9cya1b4WVrKry?= =?us-ascii?Q?JQFaUCaMzCjubzk6bYUiUwK+Ch+asvc9QrbPqqNInPjfku2s5xPbQH35nTEG?= =?us-ascii?Q?/u4A8P44UJFWrbYYGlLJM+McKjFVjvsyEIrKwEO9fXSmgFN9ospABTZzKPKG?= =?us-ascii?Q?mw1nfbuZChBB367V+33Cp4L/BXbT+T8b+DM62z+Pwy+H3JF+N9A8lGqWPQZK?= =?us-ascii?Q?+thdeXtVR+oeoy0OG3V3WrBNkfY/qAqWZqlH+72CeorG4KMw+O7na9kaXmLp?= =?us-ascii?Q?G4S2/auuLjKlVOs4xyLiatrD2X3rjad+0T3yBAVaKICf1hPHcykG199Plgl1?= =?us-ascii?Q?g4wr9werGqZVqUp5D2odNBTl5wB8rjkwJKp3nbkuwTPxjBCN/PAndNuu7bgZ?= =?us-ascii?Q?l2qQH285ZW9HeK/H+pT5E4s8OTzH2lBwrZ9IP2jWst+Fcry/5I+HhmzAQ6wq?= =?us-ascii?Q?AD406yt/fDDKnvX7BBq4IZsK?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f7bdb78-531f-4631-5693-08d90a34d3e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2021 11:00:25.7244 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EMv7FDwmKNB7RxoUhEjZ4OtgQoaXtItZL/rmQdf8Nm+fzmQnkkx0taOxUvl18exZSYEvazTBe6oLOIVeD7nC4RSaNPsnM7dWFLYNgeP/aPg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1531 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] L3fwd mode in testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > >=20 > > > > > > > > > > On Tue, 27 Apr 2021 10:50:20 +0100 > > > > Ferruh Yigit wrote: > > > > > > > > > Agree that it may help testing to have l3fwd support on the testp= md. > > > > > > > > > > Two concerns, > > > > > 1) Testpmd already too complex. > > > > > 2) Code duplication. > > > > > > > > > > For 1), if the l3fwd can be implemented in testpmd as new, > > > > > independent forwarding mode, without touching rest of the testpmd= , > > > > > I think it can be > > > > OK. > > > > > > > > > > Not sure how to address 2), also lets say we want to add new > > > > > feature to l3fwd, where it should go, to the sample or to the tes= tpmd? > > > > > > > > The original purpose of l3fwd seems to be getting lost here. > > > > It was intended as an example, not a complete test or real life app= lication. > > > The issue is, this app has become an industry standard for performanc= e > > comparison between platforms (whether we like it or not). > > > But, it > > > does not have a whole lot of debugging capabilities. > > > > Ok, could you list what exactly you think is missed? > > If we are talking about extra stats, then I still think it is probably = easier to add > > it into l3fwd, then pull whole l3fwd code into test-pmd. > In stats it is missing hardware, software stats, burst stats. > From run time configuration capability, it is missing burst size, rx/tx q= ueue depth, number of queues we can assign to a core. AFAIK l3fwd is quite flexible in rx queues to cores assignments, so not sur= e what else do you have in mind here. About other things - in general I am ok for adding these extra functionalit= y into l3fwd. I don't see any major issues here. =20 I think it will be less effort then pulling l3fwd into test-pmd. >=20 > > > > > I think adding a L3fwd mode to testpmd will be helpful to keep the > > > sample application simpler. > > > > Hmm, not sure how these 2 things are linked... > > Why let say adding fib-fwd into test-pmd will help to decrease l3fwd co= de > > complexity? > From my perspective, L3fwd example application should showcase how to use= DPDK, various packet processing models in DPDK. Anyone > new to DPDK should be able to take this code and start creating their app= lication. > However, this application has LPM, Exact match and FIB. I am not sure how= Exact Match and FIB modes help the user. About exact match - routing decisions are not always made on des tip addres= s. Sometimes you need to look at whole addrs+proto+ports tuple. Exact match provides example for such case. I also think it would be really good to add ACL mode into l3fwd too (merge = l3fwd and l3fd-acl apps into one). > I suggest removing LPM from L3fwd example application as FIB is added (or= vice versa). AFAIK, as a stretch goal LPM library has to be replaced with FIB one. Recently FIB was added into l3fwd, so I suppose deprecating and removing LP= M mode here is natural next step (if there would be no performance impact off-course). CC-ing to Vladimir (FIB maintainer) and Conor to learn their opinions. =20