From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Rong, Leyi" <leyi.rong@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: add Tx preparation for simple Tx data path
Date: Tue, 20 Apr 2021 08:03:29 +0000 [thread overview]
Message-ID: <DM6PR11MB4491EE1AA8B5E3641DF3318F9A489@DM6PR11MB4491.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210420052945.89472-1-leyi.rong@intel.com>
> Introduce i40e_simple_prep_pkts() as the preparation function for
> simple Tx data path, as it's for sanity check for simple Tx.
>
> Suggested-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Signed-off-by: Leyi Rong <leyi.rong@intel.com>
> ---
> drivers/net/i40e/i40e_rxtx.c | 39 +++++++++++++++++++++++++++++++++++-
> drivers/net/i40e/i40e_rxtx.h | 2 ++
> 2 files changed, 40 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
> index 3c7686c3f4..86a9eae370 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -1479,6 +1479,43 @@ i40e_xmit_pkts_vec(void *tx_queue, struct rte_mbuf **tx_pkts,
> return nb_tx;
> }
>
> +/*********************************************************************
> + *
> + * TX simple prep functions
> + *
> + **********************************************************************/
> +uint16_t
> +i40e_simple_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,
> + uint16_t nb_pkts)
> +{
> + int i;
> + uint64_t ol_flags;
> + struct rte_mbuf *m;
> +
> + for (i = 0; i < nb_pkts; i++) {
> + m = tx_pkts[i];
> + ol_flags = m->ol_flags;
> +
> + if (m->nb_segs != 1) {
> + rte_errno = EINVAL;
> + return i;
> + }
> +
> + if (ol_flags & PKT_TX_OFFLOAD_MASK) {
> + rte_errno = ENOTSUP;
> + return i;
> + }
> +
> + /* check the size of packet */
> + if (m->pkt_len < I40E_TX_MIN_PKT_LEN ||
> + m->pkt_len > I40E_FRAME_SIZE_MAX) {
> + rte_errno = EINVAL;
> + return i;
> + }
> + }
> + return i;
> +}
> +
> /*********************************************************************
> *
> * TX prep functions
> @@ -3412,7 +3449,7 @@ i40e_set_tx_function(struct rte_eth_dev *dev)
> PMD_INIT_LOG(DEBUG, "Simple tx finally be used.");
> dev->tx_pkt_burst = i40e_xmit_pkts_simple;
> }
> - dev->tx_pkt_prepare = NULL;
> + dev->tx_pkt_prepare = i40e_simple_prep_pkts;
> } else {
> PMD_INIT_LOG(DEBUG, "Xmit tx finally be used.");
> dev->tx_pkt_burst = i40e_xmit_pkts;
> diff --git a/drivers/net/i40e/i40e_rxtx.h b/drivers/net/i40e/i40e_rxtx.h
> index 3447a58c82..5ccf5773e8 100644
> --- a/drivers/net/i40e/i40e_rxtx.h
> +++ b/drivers/net/i40e/i40e_rxtx.h
> @@ -208,6 +208,8 @@ uint16_t i40e_recv_scattered_pkts(void *rx_queue,
> uint16_t i40e_xmit_pkts(void *tx_queue,
> struct rte_mbuf **tx_pkts,
> uint16_t nb_pkts);
> +uint16_t i40e_simple_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
> + uint16_t nb_pkts);
> uint16_t i40e_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
> uint16_t nb_pkts);
> int i40e_tx_queue_init(struct i40e_tx_queue *txq);
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.17.1
next prev parent reply other threads:[~2021-04-20 8:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 8:53 [dpdk-dev] [PATCH] net/i40e: add Tx preparation for vector " Leyi Rong
2021-04-01 12:27 ` Zhang, Qi Z
2021-04-01 12:33 ` David Marchand
2021-04-01 13:19 ` Ananyev, Konstantin
2021-04-07 16:39 ` Ferruh Yigit
2021-04-08 8:29 ` Rong, Leyi
2021-04-08 10:32 ` Ananyev, Konstantin
2021-04-09 7:19 ` Rong, Leyi
2021-04-09 10:40 ` Ananyev, Konstantin
2021-04-13 10:23 ` Rong, Leyi
2021-04-13 10:41 ` Ananyev, Konstantin
2021-04-08 8:39 ` David Marchand
2021-04-08 8:49 ` Rong, Leyi
2021-04-19 8:36 ` [dpdk-dev] [PATCH v2] net/i40e: add Tx preparation for simple Tx " Leyi Rong
2021-04-19 9:36 ` Zhang, Qi Z
2021-04-19 10:59 ` Ananyev, Konstantin
2021-04-20 5:31 ` Rong, Leyi
2021-04-20 5:29 ` [dpdk-dev] [PATCH v3] " Leyi Rong
2021-04-20 8:03 ` Ananyev, Konstantin [this message]
2021-04-20 14:00 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB4491EE1AA8B5E3641DF3318F9A489@DM6PR11MB4491.namprd11.prod.outlook.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=leyi.rong@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).