From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18003A0548; Sun, 11 Apr 2021 11:04:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADF311413C9; Sun, 11 Apr 2021 11:04:43 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-eopbgr770054.outbound.protection.outlook.com [40.107.77.54]) by mails.dpdk.org (Postfix) with ESMTP id 777CD1413C8; Sun, 11 Apr 2021 11:04:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O8E/sGt4GMGBLgVDys4YUaxTgYZx4jQPuajU65meJMs01aX1Nr71WZSrRWNt2EzLZHzfUK8JOsUVa4HKSPvCbNWVk4uAul/EaiYzRT7Q4o+n/1VL6JVcrPCrCu81udDYP1bL13jARJl3AiVvimcN2M6GIoG1qVqE3iDKsmIzKb3l+X5Y9si0xBjtaX3ZxKq0cBz//SAFgHMEABcS5FnaSGeBTwN6C9FpIDkAvEg1VnwD8BhTG0LGz6qKcupelpmhbKhPUgVzpV5z9Q22zkMXn/G1h1gfI28n26N/SuFzGU95Yr8q2/z4MLEzmcJ1bRUFT+maofVtPJsWFfsLNzc/Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c1XvhDn3QMVh/Bsge8/0iIgN9Wk7y8Pbtf4RbuLPPls=; b=WBTzp4kx5gdfcivwYL2qQjEpHAyYMUlMpB6MjxFZjuTe27pcBZnoZYOrEfECzlsFUylY2lKwtJZM5V6QhZ5zVUIh2h7jTFtnBIYh0gFuM8echkj24eUzrDrPrbQsumsj7vILMeffy47FVE03AGdue6FFiy6N9zhmkqs/LwrbRrcgNzMFZ8K9SHg93iRauZtsXj41qgusEd61BBd1UGiWfH7jgLy+aY/3mvbDSZD9uHn1Xc73KnVOuBHlU8ZuQPrd8THqUM6dWtIbBCokA+3QxGQB2aAcU4FYNw28+E4cUQggtU9oYFzyteNmPCINQXd97prp+3LyCLqzfw9SrKNa8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c1XvhDn3QMVh/Bsge8/0iIgN9Wk7y8Pbtf4RbuLPPls=; b=nBja2eVx3lcS6d5hwdN1kj+VkH9yte+57uxN8NA3xwM5PCjmmNexF5PmhtJU7QyQpWH0xetDqr7U4NT8TURGfyjqTSfrfesXkDz/be8v1Siz18C3dZ8XGxEqdFtLrHvduK7sIVrf1xKU8md85jemoQCbQJPz3TZNbZmMIUT3keJMvKR04DeiPoJBetJI64p8uv4MNWqkldSynVndORurzVFddzsu5Rhrf5MAeRi2WpC6EGqVkC568F8Cmv9Bjj3HgytA2wEiGrwNiQmkGdoY0tjS7a++X+2IBYHe9b+SMHEO2sCe1vvdX3ZDJP6A95iQHhtVWhwxw0eENwm/dsg+eA== Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB4843.namprd12.prod.outlook.com (2603:10b6:5:1d1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.21; Sun, 11 Apr 2021 09:04:39 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::d011:3b55:aafb:9280]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::d011:3b55:aafb:9280%5]) with mapi id 15.20.4020.021; Sun, 11 Apr 2021 09:04:39 +0000 From: Raslan Darawsheh To: Jack Min , Matan Azrad , Shahaf Shuler , Slava Ovsiienko , Jack Min , Ori Kam CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix redundant flow after RSS expansion Thread-Index: AQHXJWpNjGo415dzIUGbjnqtJNVIkaqvGHpw Date: Sun, 11 Apr 2021 09:04:38 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.230.40] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 995d2db7-3217-4787-ac4b-08d8fcc8d638 x-ms-traffictypediagnostic: DM6PR12MB4843: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1728; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mtMy0NFgStaB6ipdL49mSXJlO8Ofh5X5siR0xe4zcL1mraQ3G9iPoFaDLKBwh4kAFRKgEXhtcSRobkdinsSN1rYM9svIiiOCax4P9U7mQw6JPjRDwuieMr6VBhMkpFPQhTKOPb50C13cacQ8LBP5vZbNcUga3bn1iUb8f/rbNDHdfHho7ANtSaAnXT1fDW5ynka4Bmj8U3jFNNGpFLnahQwGv1Sp5wbW4tpEidrVsmVbfdqlrX+K7Rw+m/EqSAL6YkI6NFY4DpW3bnejI/FgzWYwb/Ml3Bj5eX1xiZ49VVxybj+N/KgX6QEsWvyazgf2ydRNWThKGVEHpg42qar4GtviOy51YaIdNoK5oXJisyCk0LgNXD4OSplOeOFVC8VLAcylnyp8bf2FdOe4njZISdjmj5xBHMywhRq3nNxecPUEHCiT1JEUFWru8cGmWVuefqZWw0JqQDln8akiqYPDMmRwPlOiYXOLB5d0UWddHYnXLs0s0d2fWX/wVLeXxx2JfruFq4KX+GwM8j6mbtDyKs87d937GsfNnu5RStUYLxy5YjWcKSJqFD4tNVPREpyr0HR4dkqzNS6fu9/sbfWXhLd0rfWKMRL959s255gVPe8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(346002)(376002)(136003)(39860400002)(83380400001)(9686003)(55016002)(52536014)(64756008)(5660300002)(66946007)(6506007)(53546011)(66446008)(71200400001)(110136005)(66476007)(38100700002)(316002)(66556008)(86362001)(54906003)(76116006)(7696005)(26005)(8936002)(450100002)(186003)(8676002)(4326008)(6636002)(33656002)(478600001)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?IoBxgEpuVtl5CNujihchTuYo3OZz51NDaKUrfBpaxfSXSDQxqBLAZkuDxizX?= =?us-ascii?Q?wCprVQBLlYXJGhXJNvfep7xLBSBR0Ipgp9deXZRiOJ4n6WUyQrGLgZsCq4IE?= =?us-ascii?Q?UIUrj8HocmY0y6N/ogCUoC8A3P1DGHGVG9mNiaiUfdHjAKu0+U7/ZmxAAQUe?= =?us-ascii?Q?hmP4oW7EYQBMtgug1WL1cW61cyx30Q6J2iYPGfl+0oJT0kq/uNF/cvhrfNsz?= =?us-ascii?Q?ZGWPqhmJJS9uRBKlmv1e91DISHfzMvMsg/98u3jE3xZ0m8TtP3+blMayDmdp?= =?us-ascii?Q?z0rEmEsAlmPGSR/rKSeU2fQpkfE7JuuAK5cOqKPe3k92Y3pROaBDCUvTXd9K?= =?us-ascii?Q?lWXBfqFw/Qj4TZFLxRMYiy2as3Fu+VZOJXEN7YBZR2hihqoZw96BvtGqHfTf?= =?us-ascii?Q?VzdZMkNJq10U4vgQB9POKyeYiB0faL77cdvxcri+g5HAAaQoiOLvXeE2SewO?= =?us-ascii?Q?44AsTutzsz9v7MqPOXTIUJXY4h0zkMhR+7AasXZiwGD+vg/9Fp/Qdnn6prOY?= =?us-ascii?Q?aVzENkgeSAKaxVrizSMZIxTf6lMUxQcW+2rJBWjHbxa4j/Grfa+iBnhYmBAQ?= =?us-ascii?Q?rUbKyzpj7f9hZ0SvH8aJHlBo96BNEmRGRvUteS72mQFrAhMzBeVbZr8JJu8u?= =?us-ascii?Q?CDfXXu0z77i6jkm3OB5k4ilAOpQRrjZcz7c1vpHbB9VllrC4vz+DbAovKWaQ?= =?us-ascii?Q?aJdmPI8UYSrCa7dgeuYH5OIGChwz4SZ1IKRpOVoeMS8lA4V2FFQH2s3Y5Psc?= =?us-ascii?Q?K0jPX0uT76/DohDQvcg3hZUs+ZfFCaqOS7k4IBLWOw6NtZrHSiWggpif6tOb?= =?us-ascii?Q?dM9s/KprRY2Cit8gAaAzLXYt6wHJhC8UFsJROLktEBztu9+S4+HiIdWJ/QLq?= =?us-ascii?Q?hsm8F1ikCf0W1+hRgfk2qvLecxNyPq7Df7yE3yC6+ae2hCBwB6RLirHY3SrO?= =?us-ascii?Q?TR2TvhAQMc0DIWxEOwWTOMPEmXBsJw9vs/fPsFWpm7OCxW+yheR9lQx0nlRD?= =?us-ascii?Q?twWkFzYumvXfNSZop8VP+F/cAdivneBJwAVja6cP98VYdEGw7rujUo+KCZAt?= =?us-ascii?Q?5ZddZfX/s0MVob6qLnPQ5vO3K4XC638X1fC3yg79mkFlpQH4Xxk6X6jEjf5p?= =?us-ascii?Q?Pq0U5tgPTmITvtsR1sCZ/fzHIB88vy15deUENjOpS8EIp5+nkHGfQCCCbsPX?= =?us-ascii?Q?Q4AECvjp3zY1wxS9trC9qFKftrS/ZeQ6moLtiZIAsnJPFSAqPSw4F1ByatOy?= =?us-ascii?Q?g5MvemWqBoRb/K7ORmoydW0n+GelWRSZlmKnrLRmn1pVOEntG3REX/cm8aig?= =?us-ascii?Q?isccEprrLUh/2IUaLVRanSTY?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 995d2db7-3217-4787-ac4b-08d8fcc8d638 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2021 09:04:39.0192 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BqsnD39tb8/lniINjeOLEJzYvmlozef3mefWgpYu/7TubHsflsT0IU7kv6wP8i6adAhJZRxVy5NTsPvsufJz3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4843 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix redundant flow after RSS expansion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Xiaoyu Min > Sent: Tuesday, March 30, 2021 4:41 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; Jack Min > ; Ori Kam > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix redundant flow after RSS > expansion >=20 > When RSS expand, if there is no expansion happened but completion > happened > because user only input next protocol field instead of item > i.e, ether type =3D=3D 0x8100 instead of VLAN, an extra flow is created w= ith > missing item in order to filter traffic strictly. >=20 > However, after [1] and [2] the rte_flow_item_eth itself is enough to > filter out VLAN traffic, the VLAN item is not needed. >=20 > This redundant flow will cause faiure in some scenarios on group 0 due > to they are the same FTE. >=20 > Fixes: fc2dd8dd492f ("ethdev: fix expand RSS flows") > Cc: stable@dpdk.org >=20 > [1]: > commit 09315fc83861 ("ethdev: add VLAN attributes to ethernet and > VLAN items") >=20 > [2]: > commit 86b59a1af671 ("net/mlx5: support VLAN matching fields") >=20 > Signed-off-by: Xiaoyu Min > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh