From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AADE1A04E7; Thu, 5 Nov 2020 18:37:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 176A3F64; Thu, 5 Nov 2020 18:37:27 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by dpdk.org (Postfix) with ESMTP id EAEC3160 for ; Thu, 5 Nov 2020 18:37:23 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 05 Nov 2020 09:37:23 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 5 Nov 2020 17:37:21 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 5 Nov 2020 17:37:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fbAXU5BnukHcPhIu/igLTPuv58CQgf8gOjEl/VWsCpHBEidFaRJhzqMG8sLPwMx0wF9iidr+uOMG5bn4+EIKbsR9WTpnUPXuTriTqoXTwOfUHBQBw5R8i4vAOt0hhgzEH+gnB/vGXVKoVwxyWgwp0ADRjaEHFxr0D4yUJF62l9cUS6hmoAvLMmGNtujSMm68RQ+E+foNf0zD071elPbm4b6VfMAIlGupAggKdxjzOhLqwBhZsMTnwtn9LmVYxz4WmvFIJ857m1ywV4R4+AwL7IxP+spmIQYzZnPTiiiVQ80xm+WWpmUqedF73AUMuBz+9NECuoJgoprilOQP9joh9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xFR4aDnKe28pQrh8aFi8J1QpzEtvR/T5iTdpgr6VLcE=; b=XEyAZ2bc9j5OYr4EChWyKVj5c+x+e660pIBQv4niNIDiCrfwPbVXyAC2YbpMfQZOdwtkDlvVmHV5W6hKBUZcedFYSsEtPpCIucyIo1PozJEmb3mms0JKwrAyg2L56rw1Kyfrh9u9WJ/g7vTGboMLkP2nOpcGXvydRcBB+2IV0PuTUDlqDYG6xb/0GXIkPllWUnJhP5T2GDsulhjm+0nqXFEsLxt7+1SX5sY1chRKq8o19u0xnUClf0oMwyg61NMcyHlmBly8REIKl7dEJh/o2ZQmjjZ8Er8XP7sh7ZrhGLem2rs+CoEHSmkRKVxykKaikgXh/BLDImlyMzKGxsHD/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR12MB1322.namprd12.prod.outlook.com (2603:10b6:3:70::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Thu, 5 Nov 2020 17:37:20 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51%6]) with mapi id 15.20.3541.021; Thu, 5 Nov 2020 17:37:20 +0000 From: Raslan Darawsheh To: Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix atomic API update Thread-Index: AQHWsa1UmvUZrqiPt0Klp7nDdxkRCKm50Q7g Date: Thu, 5 Nov 2020 17:37:19 +0000 Message-ID: References: <1604386064-342267-1-git-send-email-matan@nvidia.com> In-Reply-To: <1604386064-342267-1-git-send-email-matan@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.229.12] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ae7bbdff-7632-447d-9417-08d881b1725c x-ms-traffictypediagnostic: DM5PR12MB1322: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3jLWBrcOSakKZJitYVPSmWAshqyOBwz8Mzy6RPvbyFIu6hGcSnb7ncXe87IK7sew69LE1Vs05lyeyJbjj3xxd4slTteFLQ/qV97wZuxtVPTfH8zs5allNS77jLmbc3z1Z+hSXXvMHTKWSzKj7jDB4Lsjuvpxg/D95Iv6fwPS0495EpSFj0+vN96HIJuRh/74fkmeRUpXSLP6+lxdwlHM+VuT924iLhZKHDR1F21Dcika3g94i5U3Jwjig5lc2vYm0gR1zvOEOxdCi4GQPVlXwxC2VndkyJcTZu3SVZ9rbO18udtcUw6Bpy7WzZxddZSCQSNALetUyXS7pkQifP/7Tw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(366004)(346002)(376002)(39860400002)(83380400001)(110136005)(7696005)(55016002)(4326008)(478600001)(6506007)(53546011)(6636002)(15650500001)(316002)(66476007)(26005)(4744005)(66946007)(33656002)(2906002)(8676002)(86362001)(52536014)(9686003)(76116006)(66556008)(66446008)(64756008)(5660300002)(71200400001)(8936002)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: T0lZtEz5B+MhxTllzDEdHpMVMuipkuCst5cV1R/IXU5uduOsfyhzvBc/XIVqBT/Q/p/IaRZsq15x/aDrGnKtLa6bWoKUYUKm6OfK1Hyp0KC0B5JLiKdbCpT8b6q8XKWipRx1cJ0P89L+q9WMIQZSS0Yn9UVPnZ4EfOYq54tqaVHkSVcztQAa25Qqc6fejdnV5o8zS8wTq3FN4dQhkxBfjDhmFzB3I1ecb2wN8k1ArDtJlYIVkDVTZ/JrSpmqvZjazdtiNynn1VryYu4GGVe2zivp5P3rSs687XnCf3/TGGNuJ2KBHq5Sk2u4nwdtjw9CZEypyjlfkslRd4QdXdt5P/dSSxryri1dUurx9oiQpjw0INLhisSws+r3VNO2BD3sxih99doE92h54GW51ymfmLOiillt4xDRf9NVg6yZ70FjLdGiWIy619niQJf2sCBkclWd/e7smBAAgAH4mjYo1fYV47vaM5g9EiUl833r/Dv1ZsygADtk/QQwJNkMXxl1214z+Z2d//mv0Rzleg26xGCiH/H/pgzjPL0n3fTLB13h0EGIZvjUvGhGOpR4C3bDsQbKFga8gDJJmLGATT0jFo9qnXB0BI2LcPwHADQLb5i5fwNp+dgSsdQc/oy2cNejQweVq754LyF2l8mXe1tnGw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae7bbdff-7632-447d-9417-08d881b1725c X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2020 17:37:19.9890 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xJ8P8WApm+bFOfolA4qrnGOJVA0MdHhZs7vPa+sLlUj4Jmp5mlkGb0CDWn0woTP6JsOpAwgwsJz/lGXcZvjj5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1322 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604597843; bh=xFR4aDnKe28pQrh8aFi8J1QpzEtvR/T5iTdpgr6VLcE=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=DFLN5gSD40YQS1X3LSYWRTuHGeB7GCgZ+1C1wR/DYV8poWWB3AjEh32Ss+mz+IqUC 43BUaPE7vIgUTeihK7gpfD3lJljAU8H1wQfxf1AarIzJV1E/AOr6t6xtgzJtFNNLgF 4jQ98exwxOiZOXTXYZvqTKwn1zJL2x18ZbSHVwd6odQqJDuOemAncj5g4wHe7Ngxo7 JqkkaKyqVAmYz3RJRXCfaIGRkdUCKNBJgwg3ZMbVxg3JeVk0KhXtamUdPSVyVM5brW corGzYKKtvp054Qc74L5ljTWbn2uaP1xplRbpX4pectxFwhUyD9nQKztc/QAXNgMVt +WSIiFoq01emw== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix atomic API update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Matan Azrad > Sent: Tuesday, November 3, 2020 8:48 AM > To: Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix atomic API update >=20 > The Txq refcnt 1 value means that there is not real reference to the > queue and only the control configuration are saved in the struct. >=20 > The patch below wrongly didn't consider it and caused a leak in the Txq > object resource. >=20 > Revert the specific update in the refcnt. >=20 > Fixes: a02d6dd9e61f ("net/mlx5: use C11 atomics for RxQ/TxQ refcounts") >=20 > Signed-off-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_txq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh