From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D212A04E6; Tue, 17 Nov 2020 17:19:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 675A7567C; Tue, 17 Nov 2020 17:19:56 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id C055537B1; Tue, 17 Nov 2020 17:19:53 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 17 Nov 2020 08:19:56 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 17 Nov 2020 16:19:51 +0000 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.58) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 17 Nov 2020 16:19:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ag4d/5wOliRgBugaGy+Z/scXItp889Fg3igqNZH/m4+GpXSA+GYGzML6OHuhpmo3rOOaRV7Xc+AMBdgKkitq1yTHkztw27zqN727SVkMgnYBbbGHSSfDCitaOMTiJCx78fWWjVo3k/DMwqAVkRvEGlwIvh4/Zm52C33QAKTOBpLSJ2o47XnlIS/ibRKu2Ku6FmPfi8LapX3ioW6tF1o/niTijZ8HE1oQIJfIQv/FQLQfn/YZMLGCnaREn/jVQgORMGUPRFl7mlgCFUJBSEqyid6zf2qD1cFlOKkVsNLdWi3+Qi8oRVOzgQuWqfb5EL72QeuhJ7JhRM+HsulNeQm3/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=za42GTL8J6dJNdtqyaKQ74nnzupWvVqc5RMXgwieW8M=; b=llEP1U6rjs74i6/sUXbrnN8sNnQu0DG4MUwzruDjdTOM7uRI+bb5bN3tGtWJ6J4hUEFHD1D00rdhu7BJFytOXraZj1hEICFllEP6Tq7NIpbU8oe9tM6WbXR5+STES0Ct3X8pRvZId/6yJOKXWGZdsElKOJa5y87YqLAFw89T8Cj7dJ+IsQcUAqE+8wuOpwatMJ6oRWsQRqzetQ4WRA9bYMc5qU4Tr2lqlFECwSvDYDrUlFVO9XFuQeHL6FWDujbuHsk5CBE+VbilPu6Y3w4/RyM2SyWEt0EI9BAvNf6/DJ5qKdLHoWNcqcyXbFG+kqfjnSZO42N5TK4ITVMtGqnJJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB3164.namprd12.prod.outlook.com (2603:10b6:5:188::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25; Tue, 17 Nov 2020 16:19:50 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51%6]) with mapi id 15.20.3564.028; Tue, 17 Nov 2020 16:19:50 +0000 From: Raslan Darawsheh To: Alexander Kozyrev , "dev@dpdk.org" CC: "stable@dpdk.org" , Slava Ovsiienko , Matan Azrad Thread-Topic: [PATCH] net/mlx5: fix WQE counter assert in free completion queue Thread-Index: AQHWvFLsmRKyTs6ILECXFk7tcT/v1KnMghoQ Date: Tue, 17 Nov 2020 16:19:49 +0000 Message-ID: References: <20201116194815.29712-1-akozyrev@nvidia.com> In-Reply-To: <20201116194815.29712-1-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.230.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c1d44b9b-60a8-4115-c4d4-08d88b149bf9 x-ms-traffictypediagnostic: DM6PR12MB3164: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RTNLoaPatFBWcwTl9YHvP7luQ49MuNu1EyG9Y9dVLVEcPGpASQvE3IfjKvw8Gw4Yyn2d44unoET+8ox/6AkjKat1Il+0T7vZtTQ4trAc8r+Zrevq+9VW9Ph9dMwlVqNOo7Vdd6USuLGsyexgMt49GJBQojVevCH3tEYr0Z3knKVL3+cDOUMzDpG4+UTd9O2FJq0BCIAcLNFyHPadIK/rburs1XS8/+sGHtK3lTb6GCYcJNdSIXiA08Wi+fCfosB8gvDKFR9eazKZUI9aR838E6pyTb3WZ5mgnSHHp4W4gDd+9k941pidYfmYgJddBjnRC6z/fO/bF9wUvUxGVA6MsA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(376002)(136003)(396003)(39860400002)(64756008)(66946007)(66446008)(66476007)(76116006)(2906002)(52536014)(4326008)(66556008)(53546011)(5660300002)(26005)(8936002)(6506007)(86362001)(186003)(71200400001)(450100002)(4744005)(33656002)(107886003)(83380400001)(8676002)(54906003)(478600001)(9686003)(110136005)(316002)(55016002)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: rhMkpjd8Uou7wlkitBx/VN7muWlgoHfUegzJ+jiuOqpTfDVKSAtD8w3NRA/6BOwpZDHiqMQUJfncdGpYc87TWZaf5Q8JWUdZ49YAAxC/S6F2d6KU8E0u9TmaRzx8bz6KlE+9zIelgRQy1xhHc9rAnn764bjK397AOwDGp5hspQc80jBpk3mTCeXISGIK8JF+IDKTuXfh0T/7u3L6r+QQ88kGQ6uDlKczseRz4Kgot7a7/M+mfS7yp4A+YvktAiTjjbSkfrdc2eY7EJG9c2mljtEgBXB9hHg+yQ8A10Zt8uvV8DPuWXz5faiY+uyIfiavdmoU3kYJLfy2PAOkjgEgO/oT1zmPlI2B2/wJt4Nfydj3NHoI6Muky0HVxNLNvlpmdC0F0tx2zHtg0PNcwxsJaiMmtIB1OR9W7IPU6+8al/nAWqa0KxXb8VdzCKjkottMzssHGqFVlXVlwFma1R3Nzy7S423NYshVTa9gvKXH4KeRIArtJUHEGhN7/pndDpwLwKSuj+RNuA/52sAWPnGZ/rKbCNlCM2AxHfuzDomczK0ZCj3sEv+m7WRqxFu9CYvfMZB3f+C8BRfX2kau8Ovm2P6hUM68XAx29A2YuHMzJEnFbyluPJz4VZyxny2L+pijGtYjCXLtGg9TtJbrGQ6KTAqlQW9Q+Aw/vfcEeRVzBulCuQ8C823hxuVB58hhTBcWuAD2uu8i8e4Dhm6MrlJ0ruWc+6GqQbpPBmdmd5H3M03l5rJ2p9D902NM4qgQj+l/PtHY8Nh0Oi0Pf/1ePqRS2DLGyZfdz1wtJ+mb6xDMpLMEiK8GJCqVHMjuScN5hVaAVGL0MZA92QhUxoyp7YSkATN5gea6tUlVNIyw6Zoswp0jtwR+Um5F48FdJxpUDCwTDpg4JsnisA7+9E+rQEJj/A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1d44b9b-60a8-4115-c4d4-08d88b149bf9 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2020 16:19:50.4899 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SVS+4ISnuakksWsNadBLR7wuPRaDz8G7ctsruPBDh2wm9sXtbiNmNtbjTGfkUwCEiZB1mTLo/NsoakrKvncYFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3164 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605629996; bh=za42GTL8J6dJNdtqyaKQ74nnzupWvVqc5RMXgwieW8M=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=kk/KVh9tAOYkHATIS/39DkHbhV9q8EKVtYpGK30snHmP96d5WuI1lHyvh32azbKVO sX+tOFfXC/TDdlRdnQLUtRdd8HlvWTu91IQ0mB6d+k6WCcPmmcNoZSaGfcxCl3ZCX7 jDPF05dEVeIHXKu3XA1jojO5alFSq7JIYCHyMHEjurJ3v7oNWl15+5ZdKIPiXtn+cm yuW4aMsC4iYcayY+3UtL+T2nrIx5EU7l+HPYdMbkcclMfHX/4lID4r/3bpNjdlvO7p 0191ZQ7SUrzeJ14TBhuhv6OwVnLzFL8Dx0BMSPOlnXTLhGtFiCh9uehq7cm+SV5V/P X/ddoSHE7733g== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix WQE counter assert in free completion queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Alexander Kozyrev > Sent: Monday, November 16, 2020 9:48 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad > Subject: [PATCH] net/mlx5: fix WQE counter assert in free completion queu= e >=20 > The following assertion fails in case RTE_ENABLE_ASSERT is enabled: > PANIC in mlx5_tx_handle_completion(): > assert "(txq->fcqs[txq->cq_ci & txq->cqe_m] >> 16) > =3D=3D cqe->wqe_counter" failed >=20 > The free completion queue only contains an expected WQE counter if > RTE_LIBRTE_MLX5_DEBUG is enabled as well. Thus enabling > RTE_ENABLE_ASSERT alone causes the assert to fail. >=20 > Compile the assert conditionally only if RTE_ENABLE_ASSERT is enabled. >=20 > Fixes: 0afacb04f5 ("common/mlx5: remove NDEBUG") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alexander Kozyrev > Acked-by: Viacheslav Ovsiienko > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh