From: Raslan Darawsheh <rasland@nvidia.com>
To: Slava Ovsiienko <viacheslavo@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix vectorized Rx burst check
Date: Wed, 23 Sep 2020 07:37:50 +0000 [thread overview]
Message-ID: <DM6PR12MB2748121D8B60A48C1082C4B4CF380@DM6PR12MB2748.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1600025619-6369-1-git-send-email-viacheslavo@nvidia.com>
Hi,
> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Sent: Sunday, September 13, 2020 10:34 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>
> Subject: [PATCH] net/mlx5: fix vectorized Rx burst check
>
> The Rx queue start/stop feature is not supported if vectorized
> rx_burst routine is engaged. There was a routine address typo
> and rx_burst type check was wrong.
>
> Fixes: 161d103b231c ("net/mlx5: add queue start and stop")
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> drivers/net/mlx5/mlx5_rxq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index 0b3e813..1aee6d1 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -562,7 +562,7 @@
> * The routine pointer depends on the process
> * type, should perform check there.
> */
> - if (pkt_burst == mlx5_rx_burst) {
> + if (pkt_burst == mlx5_rx_burst_vec) {
> DRV_LOG(ERR, "Rx queue stop is not supported "
> "for vectorized Rx");
> rte_errno = EINVAL;
> --
> 1.8.3.1
Patch applied to next-net-mxl,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-09-23 7:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-13 19:33 Viacheslav Ovsiienko
2020-09-17 11:20 ` Matan Azrad
2020-09-23 7:37 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB2748121D8B60A48C1082C4B4CF380@DM6PR12MB2748.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).