From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE36BA04C7; Tue, 15 Sep 2020 15:38:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B6C0C1BF83; Tue, 15 Sep 2020 15:38:03 +0200 (CEST) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id AE9F7DE0 for ; Tue, 15 Sep 2020 15:38:01 +0200 (CEST) Received: from hkpgpgate101.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 15 Sep 2020 21:38:00 +0800 Received: from HKMAIL101.nvidia.com ([10.18.16.10]) by hkpgpgate101.nvidia.com (PGP Universal service); Tue, 15 Sep 2020 06:38:00 -0700 X-PGP-Universal: processed; by hkpgpgate101.nvidia.com on Tue, 15 Sep 2020 06:38:00 -0700 Received: from HKMAIL102.nvidia.com (10.18.16.11) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 15 Sep 2020 13:37:59 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.44) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 15 Sep 2020 13:37:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WWvTR5MoceT0ulDqgv1FIwwwZtNFRUJhCuEHd4ff3PcXlKR69Zv8kOOUR8D1oj6PmDyksXVi/PLWiAA6PbYM4yLqd2tdLGj8EIRrYN6sxDfJD2wylJia5L7Du2hjcGQ+Th075VsovtfubUd04tlkmetskWuQORDx1gae/yz3H214YgxalpJHPiaV7RX65CgNfjaBUqF6bKgjn/SInaZC1+mwBkA2xGSbL0QhJjCNRWi+kTATtkl7PNOHIW/WebRls9lddc7IOqKW+4+3lp4437s38Wvr1dVrNQnzGrPVHP91+FYTfaXvIRy8exDC4rPnfYFe0Oz3F01guqHb6u3rCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MygNb0hNt4PGzHOWJsihi+0OG4K1BSsGorjBT7AThS8=; b=lk9iyJlPjgtrYgG2aBJiEh7kG4v8PJz6cPWBdtVdMo8dMnItgX2t9h1Df3fqgHGVLEKhXuKBB51ROQC2EJjXHKIdypmc4vwf1XeBCztRG4N3FkHuvCKqEKFe6Dtv3r8aYLQ66FnVKC7eDWI1/uSXSWIh8K3IzgpoOPR+fveosIElZ6quRRVVSJ2aZaYDAVZK4/xd3p+NFckgjVVjltovl1nhwKMwqw6HVhSWwAh42coURwqgAtIL6SFl1EPNob1Ju6u5HLkbvVo1NA6hLZJabhjQJFct9XmrN3nljwu2WZg9JKpLNWYfLhjK9lq+FQl545i5WJLOF0NH5ox08gRM0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB2972.namprd12.prod.outlook.com (2603:10b6:5:39::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Tue, 15 Sep 2020 13:37:57 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb%7]) with mapi id 15.20.3370.019; Tue, 15 Sep 2020 13:37:57 +0000 From: Raslan Darawsheh To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko Thread-Topic: [PATCH v1 1/2] net/mlx5: fix Rx objects creator selection Thread-Index: AQHWigDl+Aou33yX2U2pGQQYE3IxXalptsRg Date: Tue, 15 Sep 2020 13:37:57 +0000 Message-ID: References: <1600023922-14738-1-git-send-email-michaelba@nvidia.com> In-Reply-To: <1600023922-14738-1-git-send-email-michaelba@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f991e714-794e-42cd-ae26-08d8597c8e50 x-ms-traffictypediagnostic: DM6PR12MB2972: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NJKQDj/94yB4XAoLZtxgqvUs4QHUdGhAeFKBE9NYn5LfFN+nK113DdFcRLa4DIucYt9KNyGryKLmvNXCfupJXQYVvk34k3R8Hfoa3m7bBn8A50kWCxnms7Zz/1Raq+QbQy4u3vN0nOlZzllJWmpLGPiYA9Ux/bReyI0rsZAIEBlc/HMa2Xjb8X35Nt8+2IBQ40vZZRUxq3+3POuutvPkGJ77mL42Yzekb742bGp2yiPmSSFQ9aMGzvJ5RWGIHgI99twljQl2nRAMO0++jqmwrbxmwIbGAD2wIc/3ja7PWxVfYDS2f9hWhOm4pEf9lziU9lUEuxm4II1iDJTmokyD/A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(136003)(396003)(39860400002)(346002)(66946007)(4326008)(7696005)(107886003)(33656002)(2906002)(5660300002)(83380400001)(71200400001)(8676002)(26005)(76116006)(186003)(66446008)(64756008)(66556008)(66476007)(52536014)(478600001)(110136005)(55016002)(9686003)(86362001)(6506007)(53546011)(8936002)(54906003)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: plMyn+juFOx6l0ctVHEmKj/dhl4R5sholX/W1F/MywaCbgd4JrTpmX16gcgt48K3hfwuG3zbtXYgtE1lmICOg7SznDDp863VaEQzBWwH1nrvX5N8ot7Hevs+Tc4hod44VmMnnkQsTUNxWvIa3ks8O7GDOaoIjQJwJr3TmyuGf4TXEhOtAdrlUWbu0z19EbivNr1crRtLK7zquzRPDHykuuRJ+XvyljEWiV+7fioTnaNjcLuLIrdeRRoglph9lchJxIWRF/8SlGUiVvt23IOhcgd+TcW8d/xsnYjymgy9Q8SzBKOMMbl9ooR0EWyKBkgmD0TCH5Yj0765/eRpUdUarESuKvN3B/VG/foQVpk83GMRVSPKHhlQ0yseC16LVn2bSBDvpdvqKv+yN9/4Wpm48v1khvCBXQ5uQMkByx05YsQhCkS8t6ieMBKNLtyl9Lwh20bT3BimjXtpGPHCRpNJTgtYVpPICoqB1Klgj4gNwBGHbfT4RtOsZWa2o/VvGyCMUNuFr/MswQWDeGufdRc6XTy0guWyYmIPZaDs7dJsMeY8FaY0DiToelbGhnhr7UhBmg7c8KVXRCG9zVSAZjagXc43skVTjTiYOyqwdThcThUzSUN4eZkw29xU0hBzGKFDZefuNMqtRWbr2gW1xtBRWQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f991e714-794e-42cd-ae26-08d8597c8e50 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2020 13:37:57.0544 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yjESIhvKuD6mGAX09Qp7gVBM8tkOTUZSODEo0sF/V8vDoEzHKiGIPBZKrYs+vD9GAe65KPYuE+HnqVT5PTzJKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2972 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600177080; bh=MygNb0hNt4PGzHOWJsihi+0OG4K1BSsGorjBT7AThS8=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=SLNmJtgJ/kMR+3Cc52hi5B0pNRJXdHi5isTfdUXPDi7usw6T7Ky4T23mIkR6QF8ka YAV2ICcKZkQFxaLAHfLqWHq3mjRT5L39nlTSq5GxWPh4NjzMeQgXuNgmTLoCPivNu1 wX4P2iDN/9vXNereMwwDRcL6F/PPJRirziYtSFu4mK52OiMJSok/SArBHcHu8g8nhP QdrC3TOPe/ZeZUwGx9TJUFS1tgTV6oqZc9sW8J94MHTBKaXpfZsL/a4c8A0ua9kUdd k8xBKsID6NmTz1UCAhQ4odnmal9UOojf/6uN9j6Iaj5kV1DsO2hl+QOsfQ+gqAb9Uo 2xoU5Bch72nxQ== Subject: Re: [dpdk-dev] [PATCH v1 1/2] net/mlx5: fix Rx objects creator selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Michael Baum > Sent: Sunday, September 13, 2020 10:05 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH v1 1/2] net/mlx5: fix Rx objects creator selection >=20 > There are 2 creators for Rx objects, DevX and Verbs. > There are supported DR versions when a DevX destination TIR flow action > creation cannot be supported, using this versions the TIR object should > be created by Verbs, what forces all the Rx objects to be created by > Verbs. >=20 > The selection of the Rx objects creator, wrongly, didn't take into > account the destination TIR action support what caused a failure in the > Rx flows creation. >=20 > Select Verbs creator when destination TIR action creation is not > supported by the DR version. >=20 > Fixes: 71dee7694a70 ("net/mlx5: separate Rx queue object creations") >=20 > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > drivers/net/mlx5/linux/mlx5_os.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/linux/mlx5_os.c > b/drivers/net/mlx5/linux/mlx5_os.c > index 41db75e..0511a55 100644 > --- a/drivers/net/mlx5/linux/mlx5_os.c > +++ b/drivers/net/mlx5/linux/mlx5_os.c > @@ -1272,7 +1272,7 @@ > goto error; > } > } > - if (config->devx && config->dv_flow_en) { > + if (config->devx && config->dv_flow_en && config->dest_tir) { > priv->obj_ops =3D devx_obj_ops; > priv->obj_ops.drop_action_create =3D >=20 > ibv_obj_ops.drop_action_create; > -- > 1.8.3.1 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh