From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C607A04B5; Tue, 27 Oct 2020 13:09:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ECB542BF5; Tue, 27 Oct 2020 13:08:58 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 167BF2BF5 for ; Tue, 27 Oct 2020 13:08:55 +0100 (CET) Received: from HKMAIL104.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 27 Oct 2020 20:08:54 +0800 Received: from HKMAIL102.nvidia.com (10.18.16.11) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 27 Oct 2020 12:08:54 +0000 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.52) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 27 Oct 2020 12:08:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OXtpvAYqzwHF+gfXQNfLkr7r0+vE6YAKxu4GsdWwe4xQ/8pk4ZABBGkjq0W6k1QxnAnfnzGWd7uOo8iTK52OV6OZECBEFE4GtY2bxr4LkwyozItmunt0ICgBSG04/qc1gc5vKUXiGe7me1jbmkSPlSc7QFjhpbdtBbzpEgVLtcerODmIaFwnjQ7MMJVWJsxg+gZKT+Bh5EnmJk/yrnu3/oW5gEtN90xTAN06VsaVXYXC/cifiRUjSAPInXp8UUVx1W4uPkNaNJahChrm54jvEyX69kHkeknMQ7KUOKIWNoJ0qttllyzQdpFdg5FAGjq7EgxWpHKklt4bzocCtYp0zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T9nsWqf0I6VG8ft9aswwQQB/iEZGUbL6dvSzvCiqPsg=; b=lH1mla5O/4nevF3gBkx/bcs1XZX38M5yyEWmEVucYa/3hy1efi/aE2HWSwPYIziMsj4huf2gwkclo3C7pRIPH5H44r2M0UDsc9l9xOtzXy6lsZ2Ahh6ksumQElP8SGZm9aAc0PBLYPdz1NMBexwCXB5cfoibAG5HTMnXGhesJwSuTc5K60pkB3r6z0Rd40yy/b8jgAbbc9R1yWojYwhUXw4/8Wn7tVbsXMT/Xylbfoywrw3ze0m8ZYRPIZByl6NLwedAPStOBZeFdQUKk268rnTDcaFMjkBo28MbjZlBMr3I+a06bMYXKzK/lGlYC5jqoqf4dnmZ/sCDD5iTbeywjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR12MB1322.namprd12.prod.outlook.com (2603:10b6:3:70::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 27 Oct 2020 12:08:50 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb%7]) with mapi id 15.20.3477.028; Tue, 27 Oct 2020 12:08:50 +0000 From: Raslan Darawsheh To: Li Zhang , Dekel Peled , Ori Kam , Slava Ovsiienko , Matan Azrad CC: "dev@dpdk.org" , NBU-Contact-Thomas Monjalon Thread-Topic: [PATCH V1 1/1] net/mlx5: support item type error message in flow Verbs Thread-Index: AQHWlWRpTqwbOT4j9UWsSTwtjlD+9KmriOig Date: Tue, 27 Oct 2020 12:08:50 +0000 Message-ID: References: <20200928065546.26742-1-lizh@nvidia.com> In-Reply-To: <20200928065546.26742-1-lizh@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 207691b9-a4b3-47e2-6f2b-08d87a7110ce x-ms-traffictypediagnostic: DM5PR12MB1322: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2043; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Nqvl88aFvi6vjQlOk0i3NLP8Q/GRHT/BD/VNsD9ZSgAUEt3/wWDeTSF+U1gfdGGlmb/LvB4Hux3CHBO7I9PHT0WLndG+QINzwh6+wDd/w9if5yeTf5N2g8UYzqg0JVLGgSYJmKsnq1KUURFJB4srIv5FcA2zsYsY86KAOWBxyldFc8NWuCaKFShKdrMfuJWfk2bcIuVVWvVOkzshvOeIhE7tAvZQa1hmFMT0BI5R3n5IyoiUlLW3bCq/bhDP/5zyeU/LIsl58J8JvkOOxK5f6nZe9DADSx4y/XkTZnrstoU/2YAko790WKYnNo1UqAUkojTyeV8qtprvXR8/TQujxA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(366004)(396003)(39860400002)(346002)(9686003)(54906003)(6636002)(66556008)(83380400001)(5660300002)(66446008)(4326008)(64756008)(76116006)(66946007)(52536014)(71200400001)(66476007)(15650500001)(55016002)(478600001)(7696005)(110136005)(8936002)(316002)(2906002)(6506007)(8676002)(86362001)(53546011)(26005)(33656002)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: ZNmY0RD+UWAGpJh2ZRrc56bRal5rflOAncjBqlauJRzlIv/tTpF/RLSupZ43gb6Cl47yE/YASW1Zmffnomyhq/y4tqGVmi16PMfzNjVbd1B78TSfzxaefKtzqQ0PUW38Sn1kNA6y+X0C8ajIURJlANno3ZDwGLW6HEA6j5nZN9c1X/H9j+UMyW4Na7Yj0VLIupJEmxkiOHt96JDlw+ByjJLR/J8BssKR36EssNxSodh8AkMYix4cayGGNvNPpK+vA5pCrVNG1C9LobIgPTq/LgxA8plBBo8TOyh50uZju8w/ZqxD+p3KdD2uLC93xm8ezOZI+z4ngJsXyU3AG01LQ5BjCPERderY8KnVD7MYmq9br4jeiTsjx7JkXvt/oKACq4zF0uoJ4AlXEo2SNXKTEsEBE3aQ4m36DliEdlHpHm4yEiijEGApmPGaveRd+qpcCfwstP2SUfRRlIlb+Du8vd7B3J26HYq5gPrj563CqG/I9w9Z6ulLVvjppiuPmnuRfzQBfeNubZeTv+/ITQ/KU8+T+9NO5iy3N81sR8sacjr0R72407WUb4fkJc46FcfCnwAI6Pgrvo0WFLLYH0ISkDduPM8THiwIeQRNwnKmi0J7SIZV8CtcYCIgMh9nzKNDO7UJObUIGn3UObLTZRP2sw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 207691b9-a4b3-47e2-6f2b-08d87a7110ce X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 12:08:50.2793 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cqYXxBvSNTxzFT+9w9bzO2YApmfXdAnhrwpTzb5JURNUAoWyMggHKsY5+A/G3i5uJlwaMIgM6dRpyB3BXoafUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1322 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603800534; bh=T9nsWqf0I6VG8ft9aswwQQB/iEZGUbL6dvSzvCiqPsg=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=YVmPo3z65SO3ejmQzDVYOvHtFk1m4wAxc4ango8KZV6KJ1/RwWmwzXBS1fV3elBK8 UL1d/PyKx/P5pEjWXF0emLvbAzUU/2614YaHUX9d1JsWmz9mvBHn3uayO8g0VBLmAg aK1kxqmHa3aNHgcArAn46VxX9LAgs2zlrq3AnkEX0Hovi3XqYoTnFR5+UX5JvVwrjd /NpP2VnAInHQRbgHsVIak1hQyCtwo3ivBG8xN+9i3guHuoJBxh4Dfv1RD2S6RTxAxT 0CMsyWtH6gpfY0m1HfaW26Vu5eUFEHdAesjLs7SBEyAqxViIN75CrlMjTkmu3tuZOv 5saaRJHrPiVuw== Subject: Re: [dpdk-dev] [PATCH V1 1/1] net/mlx5: support item type error message in flow Verbs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Li Zhang > Sent: Monday, September 28, 2020 9:56 AM > To: Dekel Peled ; Ori Kam ; Slava > Ovsiienko ; Matan Azrad > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; Raslan Darawsheh > Subject: [PATCH V1 1/1] net/mlx5: support item type error message in flow > Verbs >=20 > Update the flow verbs error message to "item type X not supported", > when it is not supported, > instead of a generic error message "item not supported". >=20 > Signed-off-by: Li Zhang > --- > drivers/net/mlx5/mlx5_flow_verbs.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c > b/drivers/net/mlx5/mlx5_flow_verbs.c > index 62c18b834f..0e0042f17b 100644 > --- a/drivers/net/mlx5/mlx5_flow_verbs.c > +++ b/drivers/net/mlx5/mlx5_flow_verbs.c > @@ -1258,6 +1258,7 @@ flow_verbs_validate(struct rte_eth_dev *dev, > uint64_t last_item =3D 0; > uint8_t next_protocol =3D 0xff; > uint16_t ether_type =3D 0; > + char errstr[32]; >=20 > if (items =3D=3D NULL) > return -1; > @@ -1408,9 +1409,11 @@ flow_verbs_validate(struct rte_eth_dev *dev, > last_item =3D MLX5_FLOW_LAYER_MPLS; > break; > default: > + snprintf(errstr, sizeof(errstr), "item type %d not > supported", > + items->type); > return rte_flow_error_set(error, ENOTSUP, >=20 > RTE_FLOW_ERROR_TYPE_ITEM, > - NULL, "item not > supported"); > + NULL, errstr); > } > item_flags |=3D last_item; > } > @@ -1704,6 +1707,7 @@ flow_verbs_translate(struct rte_eth_dev *dev, > struct mlx5_flow_rss_desc *rss_desc =3D &((struct > mlx5_flow_rss_desc *) > priv->rss_desc) > [!!priv->flow_nested_idx]; > + char errstr[32]; >=20 > if (priority =3D=3D MLX5_FLOW_PRIO_RSVD) > priority =3D priv->config.flow_prio - 1; > @@ -1849,10 +1853,11 @@ flow_verbs_translate(struct rte_eth_dev *dev, > item_flags |=3D MLX5_FLOW_LAYER_MPLS; > break; > default: > + snprintf(errstr, sizeof(errstr), "item type %d not > supported", > + items->type); > return rte_flow_error_set(error, ENOTSUP, >=20 > RTE_FLOW_ERROR_TYPE_ITEM, > - NULL, > - "item not supported"); > + NULL, errstr); > } > } > dev_flow->handle->layers =3D item_flags; > -- > 2.21.0 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh