DPDK patches and discussions
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@nvidia.com>
To: Alexander Kozyrev <akozyrev@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	Slava Ovsiienko <viacheslavo@nvidia.com>,
	"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
	Matan Azrad <matan@nvidia.com>,
	"Alexander Kozyrev" <akozyrev@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2] drivers/net: do not enforce RSS hash offload
Date: Tue, 27 Oct 2020 23:06:33 +0000
Message-ID: <DM6PR12MB27481CF3FBB305F59957DB24CF160@DM6PR12MB2748.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201027151436.14599-1-akozyrev@nvidia.com>

Hi,

> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Tuesday, October 27, 2020 5:15 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; arybchenko@solarflare.com; Matan
> Azrad <matan@nvidia.com>; Alexander Kozyrev <akozyrev@mellanox.com>
> Subject: [PATCH v2] drivers/net: do not enforce RSS hash offload
> 
> From: Alexander Kozyrev <akozyrev@mellanox.com>
> 
> Rx RSS hash offload should be controlled by the user
> and should not be enforced by RSS multi-queue Rx mode.
> 
> Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities")
> Cc: stable@dpdk.org
> 
> Author: Andrew Rybchenko <arybchenko@solarflare.com>
> Signed-off-by: Alexander Kozyrev <akozyrev@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
>  drivers/net/mlx4/mlx4.c        | 3 ---
>  drivers/net/mlx5/mlx5_ethdev.c | 3 ---
>  2 files changed, 6 deletions(-)
> 
> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
> index 34c2bbb373..d5d8c96351 100644
> --- a/drivers/net/mlx4/mlx4.c
> +++ b/drivers/net/mlx4/mlx4.c
> @@ -249,9 +249,6 @@ mlx4_dev_configure(struct rte_eth_dev *dev)
>  	struct rte_flow_error error;
>  	int ret;
> 
> -	if (dev->data->dev_conf.rxmode.mq_mode &
> ETH_MQ_RX_RSS_FLAG)
> -		dev->data->dev_conf.rxmode.offloads |=
> DEV_RX_OFFLOAD_RSS_HASH;
> -
>  	/* Prepare internal flow rules. */
>  	ret = mlx4_flow_sync(priv, &error);
>  	if (ret) {
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c
> b/drivers/net/mlx5/mlx5_ethdev.c
> index fc04fc8224..6cadfe3eb0 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -86,9 +86,6 @@ mlx5_dev_configure(struct rte_eth_dev *dev)
>  		return -rte_errno;
>  	}
> 
> -	if (dev->data->dev_conf.rxmode.mq_mode &
> ETH_MQ_RX_RSS_FLAG)
> -		dev->data->dev_conf.rxmode.offloads |=
> DEV_RX_OFFLOAD_RSS_HASH;
> -
>  	memcpy(priv->rss_conf.rss_key,
>  	       use_app_rss_key ?
>  	       dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key :
> --
> 2.24.1

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

      reply	other threads:[~2020-10-27 23:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-29 18:39 [dpdk-dev] [PATCH] drivers/net/mlx: " Alexander Kozyrev
2020-10-27 15:14 ` [dpdk-dev] [PATCH v2] drivers/net: " Alexander Kozyrev
2020-10-27 23:06   ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB27481CF3FBB305F59957DB24CF160@DM6PR12MB2748.namprd12.prod.outlook.com \
    --to=rasland@nvidia.com \
    --cc=akozyrev@mellanox.com \
    --cc=akozyrev@nvidia.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git