From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D65B2A04B5; Wed, 28 Oct 2020 00:06:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F1D112BFE; Wed, 28 Oct 2020 00:06:39 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id 240511D9E; Wed, 28 Oct 2020 00:06:36 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 27 Oct 2020 16:06:15 -0700 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 27 Oct 2020 23:06:36 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 27 Oct 2020 23:06:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hwUOR4wTb2k6u2n72eDe+ZLNtuEB5v4d4ClOgv4rm63I7m3VZF5xiXYr1zH5y2+CM1pK1zNCHuc14tMIyN/LFdV8UaJOVMjI1ANd9OmBHjTeS6wgT7MsZV7a9M7h1L367mgOrok9VjDS0UPXntC9nrhSBxVLdz56A107mPb80qdshHzxTh8oe8hUgRN5/NdTEGZketF8syceU7QhZAK9VPEHEnM3Zw4qSQMjGyWK7t2yWVsTack1J5qTV1/wVAvy4zklJEA67wsxPfqSRBuN550ggWMlnsxLzh3rHVw5cBhF0scINVLBOF0BNkOf97gBYdtZoXPk5l56ZITdWrtUCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IRNIsctm+HDZGEh9egQC7f5W8RSZ3Bi7syFwNZn+N/w=; b=evTAkKdh5IKLFdKDoCN0bMKOcECuOoiaVJGEqKW+sPAAtHcr3yjk0gI7T+iVhahTHe3CsPqdThDWJFjJXNV5cZABucLmbq0+Kdz38MBd63po2vCHAg8Y8w2BEGDLeJ2mLku7hFNxvZ9n1A+nXmiEsqokr6jmRU98ymoNn1vqeBQEZluYs1Z8+IABOtEdjNC9rl9O9l8BN96XwipjEmtptYNoaLK/mo9RGFEVI6HvLcFc3IPR+gByb8HVUrbNMsF614zsITu8U0fKSF1a+HpU2mROiAAA1i0F2WIBQv6Psjoev4kbrxjMg7zCtvOiFnEPBHn4s1vQ6+Q6bz96niTorg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB4418.namprd12.prod.outlook.com (2603:10b6:5:28e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Tue, 27 Oct 2020 23:06:33 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb%7]) with mapi id 15.20.3477.028; Tue, 27 Oct 2020 23:06:33 +0000 From: Raslan Darawsheh To: Alexander Kozyrev , "dev@dpdk.org" CC: "stable@dpdk.org" , Slava Ovsiienko , "arybchenko@solarflare.com" , Matan Azrad , "Alexander Kozyrev" Thread-Topic: [PATCH v2] drivers/net: do not enforce RSS hash offload Thread-Index: AQHWrHP3JPFJooNAREecSVpp7BDWB6msEptw Date: Tue, 27 Oct 2020 23:06:33 +0000 Message-ID: References: <20200929183921.23445-1-akozyrev@nvidia.com> <20201027151436.14599-1-akozyrev@nvidia.com> In-Reply-To: <20201027151436.14599-1-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.229.126] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f7d93431-9cc5-4c33-30a9-08d87accf276 x-ms-traffictypediagnostic: DM6PR12MB4418: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1468; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: isNIqu3pQKsJwi6cCMah9W6M88mA78Pkx0bPrTM1/LQBW3ZnHCGs5MbLn0AQtZZESmwK3RId537h+D0haFzK6s9HkpN2pFRlN+WOVeO/0H9w9KJMNZJnTbEK2hhoIfG33HXc4G3q7lo4yvMsdystJqXqfrd1BB5tyOaKxWccCjR0ROXE53TMRG01s0U5FfdMJ9PcVJlaFkWV3l0DK6XJKZzLdc4gA55/zbiTGvlSQtRIkxJt6V1ou/qiUrm/vB9kr7hNDh50pF41lOB1BUSnno7nYyHdpgyD587mc0zzjdhldpoq8xOv0SUeViTzkSQqLokPv76ZaNQVXrPt2/SKpw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(376002)(39860400002)(366004)(136003)(71200400001)(86362001)(4326008)(66946007)(66476007)(66556008)(9686003)(54906003)(5660300002)(8936002)(478600001)(64756008)(186003)(8676002)(55016002)(26005)(110136005)(66446008)(107886003)(83380400001)(53546011)(7696005)(6506007)(76116006)(52536014)(316002)(2906002)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: ZHtUKU7muZyX7G7JBahdN90GyLKLR7SS86BScneegpdb1OWs7iYXG2j2WNo/fYLXz8l/W4P68I5dyQqe2mbOerKp5gXoN7J9tsqSwaYSSFZfrhBcHc/t0nF22HUkIryiYPTo0JuuyhoqmV4ghvuk7nhXrcUiSmpJyqxJu3l6Avlkwzc3+AHYGfY7/1q5JyTQTbxEQvRf8JElOgagn4Pew8p8Klkcpqh4ZPa50vWP8k7iOEvjdlAmJ7xh86eaekiKe3UDy+PL4Pw6q7Qc/wEChUrL/m+Y3COWwFPP96zdWdYNXgrB7991WEyY3yve/pxIsjA/MfOSPHX4UJfYexXlZ6ZC3GG+na3HMvrvyDJq6WX0fwHPiMkxAVHhzuPoKVvhe/7YWAAyRIWd/ie7hkYq9OHnclJXqYZIyT9/Ve5eLWZ6hCHvmUVMc2bEekUlGSon9tA4miBYlqSTrgnLE60EGBei7X1Frish1SztoauYRowzlgwzyJwvlZMWxaZ5CEKN4uLydvByRJJZsQWo8Z5U4+UXbDzdzEWR6VUE4inlqKdCztHgjNaBjS+yxF1Nh80lkr5Qij4AjltqLWyus16WhpOo3ye7Q/xfPuvEc0Ubgjimg4PiF5GBAHOt9mvozlUJNkJCLmhNeM7CZ/Zu/F+Swg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7d93431-9cc5-4c33-30a9-08d87accf276 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 23:06:33.1634 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kgv21Pl9w/T2CKK5Qkr6Ja/uXnFeInwJ7ANqdNHLqrywZz3enkRR8dXL2YMm8si3qzyalVxv4Xf3OdTsbFzokA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4418 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603839975; bh=IRNIsctm+HDZGEh9egQC7f5W8RSZ3Bi7syFwNZn+N/w=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=YGzSyeko17Pu8GPlD0Zj7uQbIMcT5EiemRxblENcKpVkdrarxZ2867G8GYq9OlxA4 0yZ0pcdGG6nhYlqyLn5y6psu29K2A56pgQNLGHvKoyOLAxVc3WjZJIt4mUvW9FdEHO CB4o27l3PvEJbl7HmZ5xVXY5j4pBM9VYJtA26YnFPohPdWpL8thoSo2fMuhlkv7wo8 gA/hBKtPEXC35yuccPtCIcmP0Si3eKLelXBseBJJU85j6/r58hBH8r87fiBqBerfRf +0c6Vk0wmd2ANOBP9cvsBjVpKgCadD6EroOOZp8wvY57dM0MWN1GsYGFS7+QnWI4p8 dxGg6qv7VSYpg== Subject: Re: [dpdk-dev] [PATCH v2] drivers/net: do not enforce RSS hash offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Alexander Kozyrev > Sent: Tuesday, October 27, 2020 5:15 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; arybchenko@solarflare.com; Matan > Azrad ; Alexander Kozyrev > Subject: [PATCH v2] drivers/net: do not enforce RSS hash offload >=20 > From: Alexander Kozyrev >=20 > Rx RSS hash offload should be controlled by the user > and should not be enforced by RSS multi-queue Rx mode. >=20 > Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilitie= s") > Cc: stable@dpdk.org >=20 > Author: Andrew Rybchenko > Signed-off-by: Alexander Kozyrev > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx4/mlx4.c | 3 --- > drivers/net/mlx5/mlx5_ethdev.c | 3 --- > 2 files changed, 6 deletions(-) >=20 > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > index 34c2bbb373..d5d8c96351 100644 > --- a/drivers/net/mlx4/mlx4.c > +++ b/drivers/net/mlx4/mlx4.c > @@ -249,9 +249,6 @@ mlx4_dev_configure(struct rte_eth_dev *dev) > struct rte_flow_error error; > int ret; >=20 > - if (dev->data->dev_conf.rxmode.mq_mode & > ETH_MQ_RX_RSS_FLAG) > - dev->data->dev_conf.rxmode.offloads |=3D > DEV_RX_OFFLOAD_RSS_HASH; > - > /* Prepare internal flow rules. */ > ret =3D mlx4_flow_sync(priv, &error); > if (ret) { > diff --git a/drivers/net/mlx5/mlx5_ethdev.c > b/drivers/net/mlx5/mlx5_ethdev.c > index fc04fc8224..6cadfe3eb0 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -86,9 +86,6 @@ mlx5_dev_configure(struct rte_eth_dev *dev) > return -rte_errno; > } >=20 > - if (dev->data->dev_conf.rxmode.mq_mode & > ETH_MQ_RX_RSS_FLAG) > - dev->data->dev_conf.rxmode.offloads |=3D > DEV_RX_OFFLOAD_RSS_HASH; > - > memcpy(priv->rss_conf.rss_key, > use_app_rss_key ? > dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key : > -- > 2.24.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh