DPDK patches and discussions
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@nvidia.com>
To: Xiaoyu Min <jackmin@mellanox.com>, Matan Azrad <matan@nvidia.com>,
	"Shahaf Shuler" <shahafs@nvidia.com>,
	Slava Ovsiienko <viacheslavo@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Jack Min <jackmin@nvidia.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix validate RSS queues types
Date: Tue, 17 Nov 2020 11:49:02 +0000	[thread overview]
Message-ID: <DM6PR12MB27482BCE149BDA2B3FCC39E4CFE20@DM6PR12MB2748.namprd12.prod.outlook.com> (raw)
In-Reply-To: <109d4f4e6b5dc9588af9603207d5d4a490fdb725.1605492098.git.jackmin@nvidia.com>


> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xiaoyu Min
> Sent: Monday, November 16, 2020 4:08 AM
> To: Matan Azrad <matan@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; Jack Min <jackmin@nvidia.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix validate RSS queues types
> From: Xiaoyu Min <jackmin@nvidia.com>
> When the RSS queues' types are not uniformed, i.e, mixed with normal RX
> queue and hairpin queue, PMD accept this flow after commit[1] instead of
> reject it.
> This because commit[1] create RX queue object as DEVX type via DEVX API
> instead of IBV type via verbs, in which the latter will check the queues'
> type when create verbs ind table but the formmer doesn't check when
> create DEVX ind table.
> However, in any case, logically PMD should check whether the input
> configuration of RSS action is reasonable or not, which should
> include queues' type check as well as the others.
> So add the check of RSS queues' type in validation function to fix issue.
> Fixes: 63bd16292c3a ("net/mlx5: support RSS on hairpin")
> Cc: stable@dpdk.org
> [1]:
> commit 6deb19e1b2d2 ("net/mlx5: separate Rx queue object creations")
> Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

      reply	other threads:[~2020-11-17 11:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-16  2:07 Xiaoyu Min
2020-11-17 11:49 ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB27482BCE149BDA2B3FCC39E4CFE20@DM6PR12MB2748.namprd12.prod.outlook.com \
    --to=rasland@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=jackmin@mellanox.com \
    --cc=jackmin@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=shahafs@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).