From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 344C8A04DD; Wed, 18 Nov 2020 16:34:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 25D77C912; Wed, 18 Nov 2020 16:34:52 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by dpdk.org (Postfix) with ESMTP id C5634C90E for ; Wed, 18 Nov 2020 16:34:48 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 18 Nov 2020 07:34:37 -0800 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 18 Nov 2020 15:34:46 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 18 Nov 2020 15:34:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YDvR1aNpvYtaoew2qT/cpLSTzYyl4gfvG3w2jDlf8p/gT3vGAS2HkMoF/rBGetWTyMbyDB7FEdRRoA9AVP/mgb95N8WPGl47cEi9YZpVuUPXPQmUgqQUB/mv3iuXV4dpwJt6uK3duHR2/welbD0ZOGP1Ogjc7RGhWAWBEPcEM21I76n3EQh2MOwgNr9gaaSfUOYIA9ndti/PkDVfGA89lyDuqlhOrLpFVgyPt2eGpPFaL+AlNRI9vuBLi2ADrJ5IkhnXPZ79ISyU6s4S8royzgsHRiHVypxMPJc+pknwlcwz4J+ejwDqAruwIpTCGJbpDop5o3SoGNFfV0ugvWKJRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LFLELBAGUM9IwG+LI5i49Q2T5aXxOGa230ueQc1GVuI=; b=VsxJoVMrqcJYfhucWjBjyBMUC3QUpy574UKK6DPmbublrcyQWJOiik+B+L5zF4pvwU3oe2LRNxlocG6cbTpR0q889DUl5IJdzzW31D1JhtvVYegohGMfaXUGJOIIZdmBhtSX/XrOiHr/A93WBvRQrweI+Rsnq+Ewk+nT7yY5o3sfs93cQXQcR6Pb0iPwxg8pfXlehqyRmg3j7bJ9hFh9n0dglqk/aNBh4uCSZwLxKIY/yXGd7JbP2X7maqc3mFpWueHBNcBpIbSsHDfYSbKOOielBGzx+S3+lIVeMBbhT4ivL3Go/6BpYajtRjlQML4EwET6LfaGUlAY4bZFeFew6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR12MB1723.namprd12.prod.outlook.com (2603:10b6:3:111::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25; Wed, 18 Nov 2020 15:34:44 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51%6]) with mapi id 15.20.3564.028; Wed, 18 Nov 2020 15:34:44 +0000 From: Raslan Darawsheh To: Dekel Peled , Slava Ovsiienko , Shahaf Shuler , Matan Azrad CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix RSS queue types validation Thread-Index: AQHWvYzBILTdUMUANEuJetd7zIC2U6nOBXuw Date: Wed, 18 Nov 2020 15:34:44 +0000 Message-ID: References: <8e069ae0fd8b042051a81ee1227ac50e7d841200.1605691382.git.dekelp@nvidia.com> In-Reply-To: <8e069ae0fd8b042051a81ee1227ac50e7d841200.1605691382.git.dekelp@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.230.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 753bcb02-861b-4e6a-752c-08d88bd779ad x-ms-traffictypediagnostic: DM5PR12MB1723: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Klo96e5e81lpypSm6aIrdSkG5P4MNPjeWi0amzc63vEY2mdoXQrd7233PNoYx/2idrHFuT4UqbfLcvtHrAChE0k1wBmO8VKynE865GJAYG1Ago9bkX6dn69phabUwzNXvFPAteEPoePnZpS9m/53WhNO7v8czykn/t0PQWZIdG8YS6YM3zbJhnCECBC0Njnfp01+4Pz0c0y0sTJAneIdNRMR6+AMOJmJ73KA/kwCI23jjXTlblUjiyn3r8vbLHSzBwPn4SXzEjr9eOsr+GZsz84/ffy3cuk0gE0e79sSLxT06dDP4UJAaC85tGyMTcMU++U+lMNw8xo1Zzd5zIqLtA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(55016002)(52536014)(316002)(9686003)(478600001)(186003)(8676002)(5660300002)(6636002)(110136005)(2906002)(8936002)(83380400001)(26005)(7696005)(86362001)(66446008)(66946007)(6506007)(4744005)(76116006)(66556008)(71200400001)(64756008)(53546011)(33656002)(66476007)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: kJYc+R34aN6++8V6AZrqt2O24R7OidrEBSb/YyNEYu4SDbMpHqClbWAE1ISezT6Q6MC9Yn/76MjmtKNjRWOUJA91XM1tjL9oXA9SCwgKMxL8PIXNe8JxFnFlsGj/CVsmmHEKGrqTqpU7A9cgB9dXmhIbBXsilOLMZSVB0FtMlLgdN54gGHeZzlaVeDyFVuz5063AsMbicE9Caz8hk/X4c7uqG0aFb8uoXzf6Z3Vl3fug7sarakeXfAy4P+Q4t7xjsHNK6aZS/88e0KfDdCp6DCDpKpsIC3raNeCF0NKBFavZSzPLqf1K8kka+wokaPZoCBA/Nw7uqQZtuElcLx6aETujgaevpbF/5823CXPSPTKQe71pOkX8b6S9b4RQfjzuOEke2HgEEd27AwQ0Lf/mC0jD2SFLiZE/GlNBAtpnZtBarbGVmzJBfFp7fRyfRTiQYjnbTDzkQsy2yC4Yj30/di7k+NBuJhMbuEQQ7tjbl7T8OwOHg0HTUtBAAE4mGxBUjWQRsAOy1b5KSI+X7kTYJi2YY0jwu9U/IEIgbHd4Js89Jkpx9tmQ6Hs0Fwp/Z2Q0Jgc1Q3qaRmysz+Ryk8Ykaqg9OWFlFh8W1M1uOkrsT3SbgEaAjbpQn+Wn4p0dTcBOsBW4f9wblRW1vd6hudqYhWBPcrh1ZsB3dixhAg2eqBDsmSrmp0KK684vImIcWQ4U+7GVpjcYZz8bkIQPl/4i6kRC8uhn5Nbe6Gb5Zx0+tV2nWLDTOnx7fwSwq8prpZkPK3/GYriYNvI+W9U2zfdZ9IfhCYOlgJJe4cCMsUK9YNtgBXiMKMurtAdKFu19bNKrTrA7koX2nBZL3XHGzcd1G29+k6vT9PT23ihf1Xp0xn3le3SVstqAu+l11WWWK+OYLKC8ZZJkgWCWNRkZm+zEfQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 753bcb02-861b-4e6a-752c-08d88bd779ad X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2020 15:34:44.7256 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uDvndFvwEVrDy6/CM/wyqGvkOlPQp1DKYAvpQCQjPEGVuq9gMLTXZMYvXvUg94VXR/SqHnv1E3rKh2BX+bfFqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1723 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605713677; bh=LFLELBAGUM9IwG+LI5i49Q2T5aXxOGa230ueQc1GVuI=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=J8XykLDKrYthyWxesUr0ZwHjdPFZX3UF6XEnzz0TN89bCjbHkQCrWFjkpaA1b/4vD fNHaZjLKaGEEkS/lvsnFxlkpBoKo6Mp6LzuKkOo8cDLb/ZaUGYvlOcsZWlV7L+gelG zgMjxdl3oSiPJREykpO2fHyepLjDEWOkhRPFD+41iFk6So0Ni810pJITYObIeswojL M4hI4LUa2RkvPNwWL+YSt2yqMk9seN7FBUsWlmGDleZ1n5H/oWw3IUNtGPHBvPGNwH MRZklNlS5Alie9msxGeC+7yb/IMH3zISZpf1p6yifg8b4NMN4ZTnwQsuLzZjuBNaS5 KWcXSosYVuQ4w== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix RSS queue types validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, November 18, 2020 11:24 AM > To: Slava Ovsiienko ; Shahaf Shuler > ; Matan Azrad > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix RSS queue types validation >=20 > Recent patch fixed the RSS action validation, making sure hairpin queues > and standard queues are not used together in the same RSS action. > The variable used for comparison was declared and initialized within the > check loop, making the queue type comparison wrong. >=20 > This patch moves the variable declaration to the start of the function, > outside of the check loop. >=20 > Fixes: cb8a079aee5d ("net/mlx5: fix validate RSS queues types") >=20 > Signed-off-by: Dekel Peled > Acked-by: Ori Kam > Acked-by: Jack Min > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh