From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17EDCA04DD; Thu, 19 Nov 2020 11:53:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 442BF592C; Thu, 19 Nov 2020 11:53:21 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id E805BF90 for ; Thu, 19 Nov 2020 11:53:18 +0100 (CET) Received: from HKMAIL101.nvidia.com (Not Verified[10.18.92.9]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 19 Nov 2020 18:53:16 +0800 Received: from HKMAIL102.nvidia.com (10.18.16.11) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 19 Nov 2020 10:53:16 +0000 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.50) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 19 Nov 2020 10:53:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eUVXFC7Q4+uOOrD+zGxT6bkSEj5h7wKIXcLC1lgktnNmcqZrC8ohDuOFTK0jVO3cwbkARroR52eZEUZmeqF5g0u2M9fkm1/GRcXL0RoCTOahswB70DR8/Kek+/mMG1QgPcVAAAytqkp7SqnLrxh0lq8F2gE+59B3QTkpZvQHkUsusLjH9NGK4FLvmvbjxl4t+mo+xPx38NpvBnlwzzY/DZJ/1fG1ExwoGoLGhWduk8w3Co+f4pSjJ97CDxa4kSUcqWkMYCUvw8YqkB5Pre+fxUJ1X020BRfx8eHpJ4CtpNaH8n7n8rnFGIgzz/CO+YaBnd69h4wXs0SeIyPTlpyNsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AlatHTMl9UkPKSdVvVN7d5L88vgZxnHYu2bK69OIEq8=; b=fSzfRNe3Vtt3EbT8dJ49gxQ33iTSYPMMJ/C+WfClHa8KNERho8tXGKFPRrqVPPuOJaBIGIvAm1LG2TUNAcVmMeyfPjHV6pjwHnz2p56exu4YssIrPXuG4qwVqkCHiwtU15b6ZWw/gCTChTrSKtjZny9VxQEwtQP+RL7sGE+GxZ4CRqSHYUOeD5LdRWgzPHul67hBnPTE+qlQeBTg6rJQN/dePTuIbhouboEUgZpmkKxkjpe0zOIzarKTo8pecoOkdK+6+oK8/BAf0Yudot9dZZokoez5exLsIyvqw2vHv8ZBLj6Wg4iFD65Y1lue1/PQnDgE6N5xTrMDX8VwSqSkqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.28; Thu, 19 Nov 2020 10:53:13 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51%6]) with mapi id 15.20.3564.028; Thu, 19 Nov 2020 10:53:13 +0000 From: Raslan Darawsheh To: Gregory Etelson CC: "dev@dpdk.org" , Matan Azrad , "Slava Ovsiienko" , Shahaf Shuler Thread-Topic: [PATCH] net/mlx5: fix restore info in non-tunnel traffic. Thread-Index: AQHWvdgFCTQ0Pza+vU2drsSvwI0L8qnPSI8g Date: Thu, 19 Nov 2020 10:53:13 +0000 Message-ID: References: <20201118182359.4883-1-getelson@nvidia.com> In-Reply-To: <20201118182359.4883-1-getelson@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.230.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0b9768b6-9870-4fcf-4b1e-08d88c795001 x-ms-traffictypediagnostic: DM6PR12MB2748: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wTePyGPDYilU9oOE5YJnbbHvy1mlbSwJkOk1jsuG6+TAeEPPqC6y0LIicbOoMT5HW9WIvGKBj/KnG3rCaJyzLmK7Oj6cxfGRGFTz0tzeUtAT+JXqhtV2vRt9xPzetn3RjBvv3WQNRtTNjLiSTQRLxuw2QXOg+iuha6dGhUP5zMc/bwKogTlHWvYOOtTQbMMtNtxZK6M9Cl3MSK3abOEHMj02ybRIuAk/oT0r/CDUsi9DxA2insOkID2fMG9AvL8/+VnusstXZpy6zaxAsIcfZjrNrPCU04TnETzJm6PKWwHs5oTyn7i9hxwDS6tZMyKI x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(376002)(346002)(39860400002)(396003)(478600001)(4326008)(9686003)(107886003)(6636002)(53546011)(6862004)(8936002)(8676002)(26005)(7696005)(55016002)(316002)(186003)(54906003)(6506007)(66476007)(66446008)(86362001)(83380400001)(2906002)(66556008)(76116006)(52536014)(66946007)(71200400001)(5660300002)(33656002)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: ekEI6LNoTtYj2VQF8IxjdPmaQYD8TcTz7P+ljHUi9GCNHYacoYauFKzURCoAcGXJRBWfE++vaPqU6Fc5RuQX+ARs8Ytxt42InZnm5yXlOi+fM/xUvBfTyLl9ZjY4rlSebvRNg/yXsNjswt2slLWaqd1xPPuwE8+QKdZC42OvWiTMeB0qW7pbyiLhLKkos+EL1vASlhRnMdu4zDxwcmqWX/ByJb1i0Xgm27/xkcMnFOD2nkNTCTVsu3jEL+dW7LnUDmlZSboQgm/TEICFbHb1E8YuLgqB7LBwsA27eNrGevazOWsXWxXPI2Tgn1bhkhpsmE/TCSS1sEGgTvWJcoV5Bmh7l9NtQfw7mBBA8w4I5azS7/zx9QIJkrAKBQdPHMZW8ritVETsjIebjN20fAzWQT7XLVktX+Em+VahEi2nKevJAkG3JmvsMTyXUv0ifIK4i68v7meyBx2f6HLcO3zYDlpB+qehEshvDj29PZO+E4LwIttV9NAMK3xqRchGy3OkuNkirN96QV2ZFFTrPLiBqagESO/iIuVCHTTmL8MIkpPwLPUaOvBze8W8B50vTGVEGgNcuvJOqyFVZZL7Soy17b54W2rhhU44P87o40JgzxMv7z+waeJ/8oJswT2+FY4/YsjT5ndpzJK41Z90rmSsQ5YGxC97K5tZneP2eOf22Ymaw0X0q/OY0HnMyjp5PBgl+ey4JacOWFn9x2b0ZT9cAjZcDCG9c0+N0JGacOmiXZyGPHxfPfuN94kaUK1XdjssdZBfRsRmlxvNIV+FyrR1ZfvYNp+ao655bJz7T3U7DoH6pNGpyOBsZyKyHAB4YXIrIoJfC7LBD4Hl9T2O8Od+ExSgm5PpcuU3NL0NUe4UdzddwJF+NbVuLWIK2ZsCYIoV+NS+xv93hG2bBE4baL5B/Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b9768b6-9870-4fcf-4b1e-08d88c795001 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2020 10:53:13.2819 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GlqwzcVh2FQfgZ7Twx9+BvTCCZ0AGdDBvz4IzdiD7J4yxet5orlOA+9OAj/5/zxVqEF7o7HVtlB0GSCGJQNrTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2748 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605783196; bh=AlatHTMl9UkPKSdVvVN7d5L88vgZxnHYu2bK69OIEq8=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=mF0VrENwI1i9RgWsUjw0siMyXIXnqUM1a2ubJmATejwgwWJdziBa/hfAAGu7XEmv9 4UGsGieADZ6CGwSbXK31Eh00CF7nt93JmMWSW3ssV+3CQzX9wlKLIY7xpG5NrWl7Ha EOoaW7Irj/CqvAtgFKMu5iF/8Q2A7h3k2eRzYavfTXywwE0QDxqQOOq7hiRAidcJir 6bGnPDvKD1TVMeK93629uQ9hQjYYz4eSQ2Hj4eQq755fNYlLdJMwqPWrWoH+65VGos RrAA5iFoYszI5mKa/VZGNZgtfMiVAihy+Cfwt7gHcbrjouoZ9+UOIOemUqpeNhw5S2 559+khhQ8IFLQ== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix restore info in non-tunnel traffic. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Gregory Etelson > Sent: Wednesday, November 18, 2020 8:24 PM > To: Gregory Etelson > Cc: dev@dpdk.org; Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; Shahaf > Shuler > Subject: [PATCH] net/mlx5: fix restore info in non-tunnel traffic. >=20 > Tunnel offload API provides applications with ability to restore > packet outer headers after partial offload. Exact feature execution > depends on hardware abilities and PMD implementation. Hardware that is > supported by MLX5 PMD places a mark on a packet after partial offload. > PMD decodes that mark and provides application with required > information. > Application can call the restore API for packets that are part of > offloaded tunnel and not. It's up to a PMD to provide correct > information. > Current MLX5 tunnel offload implementation does not allow applications > to use flow MARK actions. It is restricted to tunnel offload use only. > This fault was triggered by application that did not activate tunnel > offload and called the restore API with a marked packet. The PMD tried > to decode the mark value and crashed. The patch decodes mark value > only if tunnel offload is active. >=20 > Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload") >=20 > Signed-off-by: Gregory Etelson > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh