[dpdk-dev] [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPC

[dpdk-dev] [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPC

[Alexander Kozyrev]

The recent Rx code refactoring moved the incrementing
of the CQ completion index out of the rxq_cq_decompress_v()
function to the rxq_burst_v() function.

The advancing of CQ completion index was removed in SSE
version only causing Neon and Altivec Rx bursts to stall.

Remove the incrementation of CQ completion index for all
the architectures in order to fix the stall.

Fixes: bf7d5157ed ("net/mlx5: refactor vectorized Rx")

Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
---
 drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 1 -
 drivers/net/mlx5/mlx5_rxtx_vec_neon.h    | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_altivec.h b/drivers/net/mlx5/mlx5_rxtx_vec_altivec.h
index cf3a795843..4af4ccafca 100644
--- a/drivers/net/mlx5/mlx5_rxtx_vec_altivec.h
+++ b/drivers/net/mlx5/mlx5_rxtx_vec_altivec.h
@@ -301,7 +301,6 @@ rxq_cq_decompress_v(struct mlx5_rxq_data *rxq, volatile struct mlx5_cqe *cq,
 	rxq->stats.ibytes += rcvd_byte;
 #endif
 
-	rxq->cq_ci += mcqe_n;
 	return mcqe_n;
 }
 
diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
index 47b6692942..f194cc99b7 100644
--- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
+++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
@@ -240,7 +240,6 @@ rxq_cq_decompress_v(struct mlx5_rxq_data *rxq, volatile struct mlx5_cqe *cq,
 	rxq->stats.ipackets += mcqe_n;
 	rxq->stats.ibytes += rcvd_byte;
 #endif
-	rxq->cq_ci += mcqe_n;
 	return mcqe_n;
 }
 
-- 
2.24.1

Re: [dpdk-dev] [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPC

[Slava Ovsiienko]

> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Thursday, October 29, 2020 19:58
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Subject: [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPC
> 
> The recent Rx code refactoring moved the incrementing of the CQ completion
> index out of the rxq_cq_decompress_v() function to the rxq_burst_v()
> function.
> 
> The advancing of CQ completion index was removed in SSE version only
> causing Neon and Altivec Rx bursts to stall.
> 
> Remove the incrementation of CQ completion index for all the architectures in
> order to fix the stall.
> 
> Fixes: bf7d5157ed ("net/mlx5: refactor vectorized Rx")
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

Re: [dpdk-dev] [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPC

[Raslan Darawsheh]

Hi,

> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Thursday, October 29, 2020 7:58 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Subject: [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPC
Fixed styling issue ARM->Arm 
> 
> The recent Rx code refactoring moved the incrementing
> of the CQ completion index out of the rxq_cq_decompress_v()
> function to the rxq_burst_v() function.
> 
> The advancing of CQ completion index was removed in SSE
> version only causing Neon and Altivec Rx bursts to stall.
> 
> Remove the incrementation of CQ completion index for all
> the architectures in order to fix the stall.
> 
> Fixes: bf7d5157ed ("net/mlx5: refactor vectorized Rx")
Fixed commit id
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
> ---
Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh