From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E685A04BC; Thu, 8 Oct 2020 14:05:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7762D1BEC9; Thu, 8 Oct 2020 14:05:27 +0200 (CEST) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id 8D51B1BEC0; Thu, 8 Oct 2020 14:05:25 +0200 (CEST) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 08 Oct 2020 05:05:12 -0700 Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 8 Oct 2020 12:05:24 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 8 Oct 2020 12:05:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lLTnZNX1uqtOjg3wc0m5hXQXp53qK1cVVWfGcYarC6C8qFZ36sOKfJdQuCaPtynqoiIjvtL5GuRUyVOfRmb2k5vGgy0+WIDr2QgqY7LPgdjokFX8x5fS7fBsVI7bwhOjYCVc7AReRJbgEvVyFp1g9B5Udpw6EJyGMxYeKFkm/uKo6k6N3KmFIqOiCBdEMKBtNSzSDh5pa366sJ94IhXxMhyO2RnZeIcmziygmY6cu/zMwMqQtjcHsuSExV+7TdLVpef8CPgsGixDqiVaau85kX6UYYMO6kAAJhfjg5MINeTbRFtN55jM4vhI4okn7Y0Gq6I/VHkcULxxddlIdzIK7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rWKtKkL4Dn8W7J3aEN2cMsbt36Wtk8qKJsleWZ2M2f4=; b=Qqo6s2uYCT50gUH47rQoQh+nMZ2vdtK/CLdPp6dWY/4s16Gs+SBKNgZMY3oHwpzw9bmAVHVSRyMHQgAKuLTYGsJxG2WXnbzIkNnd+DptNsGnPOlM3Yq+kGC9GcCtEBg/T7hWANbg8hPmcR3D344Y69u05X52lIpxIGHjjSLJ5WdSG35EhZ1Jz7QSHgBfQlrTeB2nUCyrSJeCZHIoF9xZtv6Rmgxy6/UOyoc/hKG/QYr1lx1dlyQ1r6Xg6TSg6lCSK/5zG25eobdo7MChZAHw8Sqka7KrDZfqPWRxa/n8JkGdqBFXtqCU52yX1dkeJVYTU6f091yGn9OGyKaOy+KIJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB4698.namprd12.prod.outlook.com (2603:10b6:5:34::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.21; Thu, 8 Oct 2020 12:05:22 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb%7]) with mapi id 15.20.3455.024; Thu, 8 Oct 2020 12:05:22 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , Ori Kam , "stable@dpdk.org" Thread-Topic: [PATCH] common/mlx5: fix PCI location address routine Thread-Index: AQHWigfN4bwJOBE4YEeId3hoL4GiAamNwngA Date: Thu, 8 Oct 2020 12:05:22 +0000 Message-ID: References: <1600026906-9702-1-git-send-email-viacheslavo@nvidia.com> In-Reply-To: <1600026906-9702-1-git-send-email-viacheslavo@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2eb684e2-4b6c-4415-3b79-08d86b826f3e x-ms-traffictypediagnostic: DM6PR12MB4698: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U1vMljzloq60C+ujYqeU/Dt5u0GSqfavlNcx0EFhEzFbZuYFbHj/amADEwPnHeBDqQDbUJL9nkiUgAzSp3cKPauhBYdcvIVS5DhabfhjNiMWsAw/bDmvm/kkWKL2C8HKHo6RGaMKFswte764v3chZGGqwvIwsQZh+/ue59nGLKv8C5aUcIrIeBfIYUq4d7IQLp2FAAdtTrRIgFRmN/kadzE10FNDLxctoGbmaHuy5JQ8LqBRpkILOJo5Mn4TO0m7E/4aHipaZiphM+XGrcUtUKjUgdVCMV7aLpHMDe+7axsPZlWwUHgSe4U4wQ7/0eiawcppKTL7eXpbOaZwC99pBQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(366004)(346002)(396003)(136003)(86362001)(2906002)(66476007)(66946007)(110136005)(66556008)(64756008)(53546011)(26005)(66446008)(52536014)(5660300002)(8676002)(186003)(71200400001)(6506007)(478600001)(76116006)(316002)(7696005)(83380400001)(8936002)(4326008)(33656002)(9686003)(450100002)(54906003)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: LvkL+/JjX4Tyz8bZw8mu/Yls0X5cUHL7SMznEPEF0RR48V5m9V950CKfTxkqd8KdPh/fcXvk+SVPd6KrAsmq55wDNfsNQahDWZ3MBlOvlyragrx0URQVGxLJQc82YsKcaFHkR8w5634c0fUwrUAlDqG5gCQsobIzzeUSKxLp8AiiBEuNlNJ8RQR7jkbn2POzrNAAqN4WQrNb4DcyOUm7xnpd4aIIPPrbhIqfN1rkdhmEBslDIgct3wEhlfTY24boyNCSGG0/CGheSRim3ckhaqthddFSnSRzNiuM2JZdGFkMh3UJXYybnfXnCwW1HpsiK07JZ0+CHJkKgsNBAobiKGL0XTeHcm2TVFyvD1r2GyamvQj1bWn4D54lym7Fk40p19feMK6PPM8HxpNEQ3N7O8xOADu1PdfyTRmdXN73jphHay70eTMlXnY+DZLwaBkJfi2kO0aL25PhxZuPKI2teUZg5Y019Aej54apy0nD4g7HLifrDzMvKglVn3Ywyd2yOENrLRh+VpOzAV+qOAf5Hq/T8ikCMHLIofflmmXA06jfUtxHCzE/tFxxt/u/MCGGRTHktfCXVBckUxGjcfzLAlA4NRjQvN9Iq1X6RtE2b7bHu2mLhbVjL0T5fll4/9mQpuSiqdS6/Q1ovTkJrZEHog== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2eb684e2-4b6c-4415-3b79-08d86b826f3e X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2020 12:05:22.7356 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jnOzbPkA7KNul4gIHfcqug+DeoQcXomz3SuGPEBbc4hz/kt/0xmvhacZeQsnuoiTIHFEwMwsUqYrWE8Ecopazw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4698 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1602158712; bh=rWKtKkL4Dn8W7J3aEN2cMsbt36Wtk8qKJsleWZ2M2f4=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=P81y8AHmdnSkUIeGc/pOJQpd8gDGgRDoLPL0VVy4rwMEdsrUrYMH1BRCW/n6B9Qtb F+ZWFhgRI4Xny4Hw1MOrzrejrumWYEmn1EI65PASaf9nMKmaqj6Zv9IhexqqQx/J0n L9cOojxaeGhHyru5cB97cecsCe0yhTgbOseywhIejwGzUO82BjEGZSEtOn2YMSpbm8 9xOfsLHqJGu+69UX4ZsWBF7FH8pqJDiGVR8e7hI0eGxPrbUMrg4Ovf2cHLo8YWK8pq JOywpZ7NVcF3cBAEp0gszXNPWe19AsdMAVufT3VEYXd/XmTDxiaCDgbKUYL2JlUwrZ GJX4sFLhschBQ== Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix PCI location address routine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Sunday, September 13, 2020 10:55 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Ori Kam ; stable@dpdk.org > Subject: [PATCH] common/mlx5: fix PCI location address routine >=20 > mlx5 PMDs use the mlx5_dev_to_pci_addr() routine to convert > Infiniband device name to the Bus-Device-Function location > on the PCI bus. The routine returned success even in case of > not found identification string. On caller side it likely > caused the wrong match with the BDF of previous device > resulting in wrong representor and master recognitions. >=20 > Fixes: 79aa430721b1 ("common/mlx5: split common file under Linux > directory") > Cc: stable@dpdk.org >=20 > Signed-off-by: Viacheslav Ovsiienko > --- > drivers/common/mlx5/linux/mlx5_common_os.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/common/mlx5/linux/mlx5_common_os.c > b/drivers/common/mlx5/linux/mlx5_common_os.c > index 7bb3ba6..0edd78e 100644 > --- a/drivers/common/mlx5/linux/mlx5_common_os.c > +++ b/drivers/common/mlx5/linux/mlx5_common_os.c > @@ -39,6 +39,7 @@ > { > FILE *file; > char line[32]; > + int rc =3D -ENOENT; > MKSTR(path, "%s/device/uevent", dev_path); >=20 > file =3D fopen(path, "rb"); > @@ -48,16 +49,19 @@ > } > while (fgets(line, sizeof(line), file) =3D=3D line) { > size_t len =3D strlen(line); > - int ret; >=20 > /* Truncate long lines. */ > - if (len =3D=3D (sizeof(line) - 1)) > + if (len =3D=3D (sizeof(line) - 1)) { > while (line[(len - 1)] !=3D '\n') { > - ret =3D fgetc(file); > + int ret =3D fgetc(file); > + > if (ret =3D=3D EOF) > - break; > + goto exit; > line[(len - 1)] =3D ret; > } > + /* No match for long lines. */ > + continue; > + } > /* Extract information. */ > if (sscanf(line, > "PCI_SLOT_NAME=3D" > @@ -66,11 +70,15 @@ > &pci_addr->bus, > &pci_addr->devid, > &pci_addr->function) =3D=3D 4) { > + rc =3D 0; > break; > } > } > +exit: > fclose(file); > - return 0; > + if (rc) > + rte_errno =3D -rc; > + return rc; > } >=20 > /** > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh