Re: [dpdk-dev] [PATCH v2] net/mlx5: fix sample and mirror use incorrect devices

[Raslan Darawsheh <rasland@nvidia.com>]

Hi,

> -----Original Message-----
> From: Suanming Mou <suanmingm@nvidia.com>
> Sent: Thursday, November 19, 2020 3:20 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: [PATCH v2] net/mlx5: fix sample and mirror use incorrect devices
> 
> The sample and mirror action objects are maintained on the list
> shared between the ports belonging to the same multiport Infiniband
> device(between representors).
> 
> The actions in the NIC steering domains might contain the references
> to the sub-flow action objects created over the given port. The action
> deletion might happen in the context of the different port and on the
> deletion of referenced objects the incorrect port might be specified.
> To avoid this we should save the port on what the sub-flow actions
> were created and then use this saved port for sub-flow action release.
> 
> This commit saves the create device in the sample and mirror actions
> struct to avoid using the incorrect port device in releasing.
> 
> Fixes: 19784141692e ("net/mlx5: make sample and mirror action thread
> safe")
> 
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> Reviewed-by: Jiawei Wang <jiaweiw@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> 
> v2:
>  - Commit message updated.
> 
> ---

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh