From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69182A04DD; Thu, 19 Nov 2020 09:24:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EB7E34C90; Thu, 19 Nov 2020 09:24:49 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by dpdk.org (Postfix) with ESMTP id 917BEDED for ; Thu, 19 Nov 2020 09:24:47 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 19 Nov 2020 00:24:56 -0800 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 19 Nov 2020 08:24:45 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 19 Nov 2020 08:24:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jvc2ykrvmGlkc314/kXM5FOgfux/wriwKp2pfYp8g9wdyDdAhLNoKVbVFgBMZz4mXO0PhRNCmo0I1KX4xgNygw4cOBwCZ0xA1PNfJTSXDMGsYOMuIJVD/9KLZ6qqVx6mlNZ2GEBLNn1beJmlkqM83kpycEnXs2G+lZGu+XLDCd0HEd/yClogS2ABi53zp9ICCkgakZllc9OCTZLo88bWv+u7rZXQHCvvqepyzaA6RGIixT0kodoezGdd7weDRd4bDU2/RkWSboGLXEwP3rnxIxQNpMsSduCmBC5B8KnzsatZtntyh8czn6I280TlmoMhdbLiNQ9epA0/nHcw+Rm6vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tiKQPp/idacXzzb73sw0lxhPUMSpFaY2CmxwowFW2VI=; b=F5QYzAKKmKI969IIjP5sLWCfQO3VouwtuVA0u33E6vZStAFZ5LajSd3oVvTsdX7qa+Nn2a0yKLw2wIyPCRayus0ChgiT1Z7w0y7q9gtjJe4lCJYr/PUbcD9ycX8dkXcQEzp7MM2DsjtcTpT66t2UqFA0fHfDe2r1QE55Llztqoa2krnzKjx6+DnP7HzUz87jkWU/fA2uueirNWcFcnqag/tTh/OxBUsdZamBK/zMqpLj9AKYNE7mLgmCoxLQz6UWzL+bqokQ6I0U117mmdRWDQTCMUTdFr0F+C7rf7kHO65Sr0Y83j+9HIC1+Z/wjMasXXUgcdYI3VAx+f83a6F9YQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB3257.namprd12.prod.outlook.com (2603:10b6:5:184::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.28; Thu, 19 Nov 2020 08:24:44 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51%6]) with mapi id 15.20.3564.028; Thu, 19 Nov 2020 08:24:44 +0000 From: Raslan Darawsheh To: Suanming Mou , Slava Ovsiienko , Matan Azrad CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] net/mlx5: fix sample and mirror use incorrect devices Thread-Index: AQHWvhI1dtClvMTcvk+YD0bnVsE1VanPHpnQ Date: Thu, 19 Nov 2020 08:24:44 +0000 Message-ID: References: <1605493866-14673-1-git-send-email-suanmingm@nvidia.com> <1605748787-65361-1-git-send-email-suanmingm@nvidia.com> In-Reply-To: <1605748787-65361-1-git-send-email-suanmingm@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.230.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d8ca85e0-b439-4e43-8dc2-08d88c6491c6 x-ms-traffictypediagnostic: DM6PR12MB3257: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:449; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: e6wqLonKYmepBC7utat9IZ1AcZKbWlTI+jKh8771QfyabLo5eGOrcShFi8vXPPE66OGSs9RzNIwqOpPJNqruko3U/3eFpP5HxGRr/aFLnCJtSRgXfm+WnCd1OlujddX+rtGNihaKTC6Xeh1DJJRVg5SrxNdeysK5F2TFnWclOW1hG/D1dvPdWyk5qX55oEZAhjaThjBg6cIU05nJ5OE+GKVQY256C4+UtYXokE3RZA+eC8UdF5q9h63bXY9TjYNmwegNPb8G+6QNUhR2mrklbKQhnKopRu632MfBpMOGNNR6hx9ItGZYtaK5BaNOp8PnyKzlM5BzBZyG0my8bCUggw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(136003)(366004)(346002)(396003)(478600001)(52536014)(316002)(26005)(33656002)(76116006)(2906002)(7696005)(53546011)(8676002)(6636002)(8936002)(6506007)(66446008)(86362001)(4326008)(186003)(110136005)(83380400001)(64756008)(71200400001)(55016002)(66946007)(5660300002)(9686003)(66476007)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Jo5NAkKZV5pzYG0I9rNDZDDTS1N7Ujr7OZ6tb4ZNu7fkMMQxMyGTcYyJ+Q7RtlHEGabyadqA57NC024cRwvAh3b6VIjIx15BBKNf6RFRmbC4WICZ46gjcQ4j9MNV+rscBe/pKtOyEmf3++CSi9kU3S8DCI5Ss8GfT+J2i1aSstOAztYmDL7tETxiHQt1vzanLDWk3P+f5WmecmgTMas+haeSTcE4qzRXVWUvrPPfevf/8NLYUAnLL9u5HtiYdTAdr9XnvgdlPncHikrZetGhPjOj0QXg1HCjBNmMCqjSjm9ZUJ46YKloynkP8AVYt0ht2l6qUS4YGYs+7rCBU+zpVrAdsVUmydLXKvacT/SVVRc/2UGvi3goI8+8YOPvvlRvLtcHGbuYvj3BkNajUZKP/CE1iXyFb+0Ya4/YuaC9X5neHe5VT6GHd/fJEfBLdQhuRIlRfyteI3HCL3C7uNykn+VIP2pj7y8e8yW9/IQA7nba75YEI8qj5AX2p5wnMw2IphEtdjzXGp047YYWfkLxxhAr/v27eJu/aBwyXRUJ9tXgblMpUc7Q46xSUOiJf1BGf3nEU+YX30b8JSVYo2DSZ2mf9PUK1xAXzMlIrbn5S60jvr/0NyKk5wgqh6fSYxkUb4ozUuJogdTJNLSIwWRDSxMmeDBlwpr9UZsuwpiMvsG/O9iFb4t3du2WgjSjJJC/NQfcQxVZMLsLcohop6Z0pA5Dv9H9Obt0PidHUcfJ0l3WcS11B+NIqLRmKmhki4aT0ciKoheZ3ZggXArxZAZ8ctPfbXZcbyhWIOqbZg2T/LmapZMY3LRVxzAvsYi+n/u23iZdssoaNamTO9InVLUoXVezj2mvtdZi/DDcwwz8/Z+L8uvhh5y3O5lDjXIXu6dBQDDio2xi39/F3wsZfkAagA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8ca85e0-b439-4e43-8dc2-08d88c6491c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2020 08:24:44.2792 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UmE55sg095BQrNsJnGI8sEK0zFW5Ydtxb6IJMdQ9huDrMaC52fVyK09oipiP1wJ8hTinG0qrd9gSNPmZlcZe6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3257 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605774296; bh=tiKQPp/idacXzzb73sw0lxhPUMSpFaY2CmxwowFW2VI=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=Hq14nDpEjaV8YRycWY5m1U6gY0yQ18hJU3k+xoMuTv8yf7MyJ7LHc5Cg2FmBQI/sQ 1GB7Z2OGXINGFDCfKqPKnK7IrIaCS7HXz4zYBneqS/ZtcxiP75+gGYR/+6BW7wcM3K aVFJB/K6B7fyyW+Sde3A135wN1fmFHhjyBrCMa7yLnMRsx9EApCtnomPymZskqbA1i pvTaCAAFa2g7vw9gvDe0C7Mc/43iyhRxb1bwpnyyzfY2p31E5DiPLmA6+RBztusTeV EqyuHSOy8h+bnAU5x4WTG1zLJ0SQrQK1V6xY25msJTVDPE228K6L6SrPHHzby+jlz8 UExfeDwnqHtKA== Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix sample and mirror use incorrect devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Suanming Mou > Sent: Thursday, November 19, 2020 3:20 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v2] net/mlx5: fix sample and mirror use incorrect devices >=20 > The sample and mirror action objects are maintained on the list > shared between the ports belonging to the same multiport Infiniband > device(between representors). >=20 > The actions in the NIC steering domains might contain the references > to the sub-flow action objects created over the given port. The action > deletion might happen in the context of the different port and on the > deletion of referenced objects the incorrect port might be specified. > To avoid this we should save the port on what the sub-flow actions > were created and then use this saved port for sub-flow action release. >=20 > This commit saves the create device in the sample and mirror actions > struct to avoid using the incorrect port device in releasing. >=20 > Fixes: 19784141692e ("net/mlx5: make sample and mirror action thread > safe") >=20 > Signed-off-by: Suanming Mou > Reviewed-by: Jiawei Wang > Acked-by: Viacheslav Ovsiienko > --- >=20 > v2: > - Commit message updated. >=20 > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh