From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E5BDA04DD; Wed, 18 Nov 2020 14:46:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 40830C8B0; Wed, 18 Nov 2020 14:46:23 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 04CF45AA7 for ; Wed, 18 Nov 2020 14:46:20 +0100 (CET) Received: from HKMAIL104.nvidia.com (Not Verified[10.18.92.9]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 18 Nov 2020 21:46:18 +0800 Received: from HKMAIL103.nvidia.com (10.18.16.12) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 18 Nov 2020 13:46:18 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 18 Nov 2020 13:46:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i64yXLt7jm59fq6clMw+C9LQFzNZ3vM+2pWhdMUx8nxq02JYXWT9YK+b3Wz9ES7xq3WWpp4cDDQtcynroYG0XKiOtfBdyLbZeBFCcuIoe8KW3s0OINaVJoAthgtEImT3G8gwLGRfOj9mQIxHsgqYorqhRktG1uKk3Fbjt21ytgFAazd14kRwaILUAFS1Y2Uxx+5uhqZwciwaGqfzz5ha6DZk16I/FnQd3s7FhoIXMUb2qHB9TgbyLskqXWmdhOl841ToIYRTViMK/+W12sKOxjrT3uSVhG3x8ZQbPUVyzRI0VRmPGiqNLOUmRIiC91Krim7f9xyHBudMJc+gVzRxjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rd33a4RAMpiYEeXayEbfhSAZMSqJZZMIv5g83AOdkns=; b=HKGB2Ab/ZbaDM8okXxEuSrBRFu+OKuJNwQUVcahxha8B5mXQw80plSID7MG3I+PgoeMZVpwKJdjVsBZVhA+UmLzzA20ZgYsZyreQI7PIDFkVz8lxsrVTKHHiqxEob+8q9CNi8YdCAxe3caVGXGrNIqT2UcTpPsxQjh1jaXjNz52swEQNtiJtpPdCt3BqpBjVArmHfZBpcMevZRqLh1nHfudPGbGBtE8aCxYpjYaLOEqbwfIP8CviWmsx9vvy26n13t+/lHVicvJVExmh2m8f8WWqpswQ40jFhnm3A//RWhkyCp4nfK4/SAFjskvDqHf1qA/3a49FYqKUZtmb277YcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB4879.namprd12.prod.outlook.com (2603:10b6:5:1b5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20; Wed, 18 Nov 2020 13:46:16 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51%6]) with mapi id 15.20.3564.028; Wed, 18 Nov 2020 13:46:15 +0000 From: Raslan Darawsheh To: Suanming Mou , Slava Ovsiienko , Matan Azrad CC: "dev@dpdk.org" Thread-Topic: [PATCH v3] net/mlx5: fix header reformat action hash key Thread-Index: AQHWvVFr9s5QQ0JfPkSUVxmQtofaiqnN56LQ Date: Wed, 18 Nov 2020 13:46:15 +0000 Message-ID: References: <1605189343-363765-1-git-send-email-suanmingm@nvidia.com> <1605666024-307200-1-git-send-email-suanmingm@nvidia.com> In-Reply-To: <1605666024-307200-1-git-send-email-suanmingm@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.230.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a3d97391-dd15-4d05-8347-08d88bc85213 x-ms-traffictypediagnostic: DM6PR12MB4879: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /CJYa0kHAPOAkuMCgq9ZoxBU5cl5oKfcetzulUuwJ/LzdpnZnLrcWqBN4nKzCekMsbnlGk4BWCpv2JRn6iAUNxGXax/bzyVr3zSC/+5dr0KTuFz4VHDe6l7JJ++X49A9YtkdsA5XvkVMCKXzE6KWzCa2WM3Xj/2R4+uz91Gn6dGyCz/actW6NAEc09coWVg4y6Zw4l7WzmXa1DoD8gz8HGKfpQ0xgTvD+nY2uEoiriXxoQibQJ7/QDLNedEaKdn33GMtc8kJMuuD1Wio5d51+4odFrYy3empUrpXmc4FnzRm1sBTlK+uT0U9x8W0XJu9LKqXxJGb8zTXtFT88hnRtw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(9686003)(52536014)(7696005)(55016002)(8676002)(6636002)(83380400001)(53546011)(186003)(66446008)(6506007)(66476007)(64756008)(66946007)(76116006)(66556008)(26005)(498600001)(86362001)(5660300002)(8936002)(33656002)(2906002)(4326008)(71200400001)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: p9ffVez2mKAYDiaqsHUvk0n3vz3gj95V/B+BnUhnIf6mlArCpt+xjF+FPfCO3BleuBRD3ioeEPdBYJgZMS+ZvNKcnBlw8kXUKZcdRMYjVymV/qQ9pQ5WU8jj9gjwODrGZMs4Mcfj/JsNBCmpRyIqfNjTzeZDhrbHjAIvYekd428XascPgnNQ+5pfN5dSkn4z+28vmBWugzmm11Bi+kgZlvLmo/I3fx+EPMA+v7YcD1e4eznRrKXkCMft700CtWblGhITdFPsKiK9PzONt28XM0mn/o90o9A5QM0J85zW6AWdQNU5dQ2J6oFAVZUQBb4+mpE7w6Dmd4QE72ZdWFVbeUAxRbwM/asINRJopKX/wqyvhDkSt1rqE9mNfmY7Hu9GwXAbs4x8Ec5e6/VVg3MoegWaKQoiRFB+pCPQqm63NluiBoHoQfwUutZji687giHbgauUe42lwrDdq4xIy0x8Fy4jOBRnDc+5buE7VS4MWIA1evRSG1V5jsiLqk6AVY3jRgruByWhQ4eTXti4hMnxpJYNsbqnfkPdzIEteWX84lmrGqU5K6DAs3IxDxpU44wPWj79pQx22vcSSbC6BUCQbVcVnvHf5R/KUAQQ+gZdTectqBTJE5RxehNZntslqTO22DcM5tmai3wn3OBs8gOgtMf2xBjH3hOSAMp/YgA0YO8EXCP5LMMC4Zm4SoJXuHhbcePsolQUGDJZbiMGEgBhAFuUkYfWlGjdy3nr0tmqoTecL6BS5UPPa6KTCtKS3vGZor4vK9lSHxxFLr0KH2mBSQJ27JOBcCONcfCWs0bMLkAi5ljmRhGXa2omQzCkzgpcYfNFcmoxj0BVgM1cXIMJJH3IzYHqvPWlpuzpSAvNGowgbQwO06m9xxr7EqRzihzN+icyggwkdhlBX8bsr1XkrA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3d97391-dd15-4d05-8347-08d88bc85213 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2020 13:46:15.8086 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Tf6KCiMPbE7M3Bcn2s0DUHW60KLZwpk85pdVWw31lfscqURgbgn3Ki/9tqZCW14vzVjGRNuuxPu1KCWi5ew6Sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4879 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605707178; bh=rd33a4RAMpiYEeXayEbfhSAZMSqJZZMIv5g83AOdkns=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=ZmtgsAaltOfn4UOMhGS59cGgk54sIQcAglW8qZVIqUbYd0S9HsedXfVHqsxv4V0IW n8qLJ9uxfxuLHbrLOJvg576xyRtObOFiqIW8Cwjn2vxju+c50FIdHvXwN7+5bxO4Mc J6RddB6vq0ij4B4Qw2cmPhdqOFlEddgu/Qq8+SU0Arynnc0P56czSLqC3Rc2M1xWWy by/SQ5LnvZsmbg+5+MRBeMYoZxuZ19npPxE7TzELdRtqXwsqmT6MRdaeTVRHFn671Q 6CxKP36O7nh1w0vfbfD4g923T2Ags+7/5ZLF4iif3NgtOmFBlkw7xdOyy6tX4OzaaJ FSdntMv/U2xug== Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: fix header reformat action hash key X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Suanming Mou > Sent: Wednesday, November 18, 2020 4:20 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v3] net/mlx5: fix header reformat action hash key >=20 > Currently, header reformat action uses the hash list 32-bit key generated > in header reformat register function directly. The key will not be > recalculated in the hash list function. >=20 > As the 64-bit key is composed of the 32-bit attributes and 32-bit reforma= t > buffer csum, the hash list function only gets 32-bit key directly will ta= ke > the attribute part only, csum part will be ignored. For different header > reformat actions, the attributes can be the same, while the buffer will > be different. Only take the attribute part causes lots of the conflicts. >=20 > This commits adds the attribute part and the significant different csum > part for the key. >=20 > Fixes: f961fd490fd4 ("net/mlx5: make header reformat action thread safe") >=20 > Signed-off-by: Suanming Mou > Acked-by: Matan Azrad > --- >=20 > v3: > - add the missing ack. >=20 > v2: > - update key generate. >=20 > --- > drivers/net/mlx5/mlx5_flow.h | 12 ------------ > drivers/net/mlx5/mlx5_flow_dv.c | 31 ++++++++++++++++++++++++------- > 2 files changed, 24 insertions(+), 19 deletions(-) >=20 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh