From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C48FA04DD; Mon, 26 Oct 2020 19:07:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E65B21E2B; Mon, 26 Oct 2020 19:07:16 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 45CB0100C for ; Mon, 26 Oct 2020 19:07:12 +0100 (CET) Received: from HKMAIL104.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 27 Oct 2020 02:07:10 +0800 Received: from HKMAIL103.nvidia.com (10.18.16.12) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 26 Oct 2020 18:07:10 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 26 Oct 2020 18:07:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JaGQspx4VIVpYgDskbEftFzWGkpjLMpY1rzeRmMpxx82bHxXgSH/WO1h16G8KkE6cr/9rHbeJERxPDsgmv6DSy/0+LozkIO5gyQ7gqlc0b+isUGkEc8aoYP79ErWvbxZBgoZbCHHtW4zsSv0qiUaBWB/1ANununA3G19PFoTbnF2XrD5ohdjf/tRdk2YrliCJJj8rp/Ja16XA5C7pwje4fU97fKLyGJ+vBCruTfxAv7sW99l8wVd/0mYfbV1M5KkYraWExxSIuae1AhUqwSxJEkoadn06dL1XW62x8JOFmVaGiFcjxI4SnFBVtaAGY3uDjb46kRlVJLaELF+tbEFkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G+4hFtYUXpeGW+FKyNb5bvh4sPgjt+LQwpZLaaNIYdQ=; b=YyhxOrXeOVlO/5Tq9bOxMwtjqBbunS12eM8Qzc2iuj9EUvSBFH4s/OgUgKKjK2tMw7HZIMRa2YN9tWqfj4jVJ1Iru2xF1YGCQnix3H4xLEeVoIvnrlcxdZdTchqL5hSHroySxVNsyORjxm4hVLOBD3I5UQqnuubvvRF/4ztwoFzUg4OrtBL1ZuChZoFMnZYe7TD0x127PMjWoHC++QXHznwe2haQKsNmnwJQvrXpbPm+uNi9Xlgj9bXwsFa06WB9XsrENnllQiaCxr8UgfF6rMsIfGKZBdH5KhECRFC1dKaSyBBvPDP33lMUGKtozstbtTNzQhiRX3yQ6VajfDBytw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR12MB1897.namprd12.prod.outlook.com (2603:10b6:3:112::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Mon, 26 Oct 2020 18:07:08 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb%7]) with mapi id 15.20.3477.028; Mon, 26 Oct 2020 18:07:08 +0000 From: Raslan Darawsheh To: Bing Zhao , "viacheslavo@mellanox.com" , "matan@mellanox.com" CC: "dev@dpdk.org" , Ori Kam , "Andrey Vesnovaty" Thread-Topic: [PATCH] net/mlx5: fix bit field compiling error Thread-Index: AQHWq70AsPaX3hhKLkqdb8exWJHbyKmqLf/Q Date: Mon, 26 Oct 2020 18:07:08 +0000 Message-ID: References: <1603733085-271968-1-git-send-email-bingz@nvidia.com> In-Reply-To: <1603733085-271968-1-git-send-email-bingz@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.229.126] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2a0092a3-883e-41f6-d739-08d879d9f444 x-ms-traffictypediagnostic: DM5PR12MB1897: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:569; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JQSiKZUey5+5W9E+kCxgb4HgKizRIVZSFrxIdfrVnqzMPLTMV3ztW5pfLaUULvML8amqCMmPOOdqbwE3Cp2YjzyxAMZEJmsBT5I9JeoHOOPDGYj8UobSirLC+yVG7ySeQn9BZdgFm3StcsSYYgmSsNAWh38Ls4+j8hjBjC8tega46Jsqz1BcLirbOxBAnGXUb6eEhM71dp0Yk6kHOeCCctCBQ5Q60FA9bA/vd0gyIrAVxjqFbvkNTLNTB1WHxf6s/O2Ey5STt5gMXxUckemiwhDnnpYgWc2zE4GOkARAfDiWpn9g8LfGdZ2U/MhEEkwX4Bo3iL37DtEFo5RxiReMFA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(396003)(136003)(39860400002)(376002)(478600001)(26005)(86362001)(66446008)(66946007)(186003)(8676002)(107886003)(6506007)(5660300002)(9686003)(52536014)(66556008)(2906002)(66476007)(64756008)(53546011)(316002)(110136005)(76116006)(7696005)(33656002)(8936002)(55016002)(71200400001)(83380400001)(4326008)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: FMnaMxOvdbdlAZ0bUoilVxRo2+WTblD7ZA9lNiO8VTNqCveEga+DjEsaxyM+tvpA1PsGX3U8VSrubqqiIk4Ea17Zszq6muSOn0ToGPsCDNtLth0t7Q3FUvjS6yhLztmL8HfUKKrN3+wysmPvl1zLJNlKUpjyhrxbVrWlLXc5cuUWo71tHII3oJk0lCYhOavm//MHi+ZQSseNUsyqfeRfH8u4kLnRWBlKYEecIsuq3ZXjUKxCD52VfqGN0RuTCmAwoH9mv/QnJMZ76mKT828Da56U3RV1fmg0G4PyfxBfRvEAeq/jZxHuIsgQx5XJj7Tv2ESSlS35ZVIkBpsSML/KG0O3cKvc+tqi+J/hTSBGpO8tQ+v3n5xfUiyXTHzQ8O63XCZxZdsRiC0ISkczfFERJzLugBB7bS8P1EepI5ZoaT+a3QV1TR8D842bTH/aYukYrg4A1xtwpnjq38b3ymCPJFsfTaVJX9bj+cxE/zak7C98S80nGOtj3YtO6jq4cJ7FDigCfJFMcO/yZM51wtvXPg+YSIYQaPfzffQ4JkndX2WlczxAwno/iUReVtoMppT5LVCpHguhFwIp1WcaZsD0zFzNSCiD4jK4U/YTkspdQ1YMoM32t/M4WsrhKpFz6box/p3QO4L0qRxH2E2hMg1ujw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a0092a3-883e-41f6-d739-08d879d9f444 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2020 18:07:08.5102 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EtKYJ4gNA67wvaP4DeL4yt3+S816rUvvK9eJC72x8nutA17Xv56xncyR5k70z3PEC7nKxAzMgRnEfRKNvrdv+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1897 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603735630; bh=G+4hFtYUXpeGW+FKyNb5bvh4sPgjt+LQwpZLaaNIYdQ=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=hzcHQkgHHVBQ13ZmRbaWcoZFGtzaKNmKDldKoc41JvwH4vA+6EkEbz4+NSpp6svLJ QpHQLnuIFuFbCp+89J/88Ap8XWdPxYkKfKcpxNzCXSBE0KcaZ6eTtGVC7eJ50lS9Gd JeY455aQtMpt3v4VPe4QriUQjZkCTvdodXXwTfF8x1VPO6lO95piZOfkSf6Fz7ep9O WsQthgVtuIrxm3AFymgYZnHNbHuluHApj44PerH93v71CEhvFj1XVfztyChnaXzqTr 5x/3NPUdDwNoQXlDiZPToJ+OFQSuvQiD16PdBWMCmwAPdLIuUks+rxOfRTGgL9OkPA YazzeOC6rn7yA== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix bit field compiling error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Bing Zhao > Sent: Monday, October 26, 2020 7:25 PM > To: viacheslavo@mellanox.com; matan@mellanox.com > Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh > ; Andrey Vesnovaty > Subject: [PATCH] net/mlx5: fix bit field compiling error >=20 > Some old compilers and old specification will not support bit field > with other types except integer or unsigned integer. > Since the next and previous items are 64b and/or 32b aligned, bit > field with "unsigned char" type will not save any space and the > compiler will complain. > Changing it to "unsigned int" type bit field will solve the issue. >=20 > Fixes: f711b60d400b ("net/mlx5: modify hash Rx queue objects") > Cc: andreyv@nvidia.com >=20 > Signed-off-by: Bing Zhao > --- > drivers/net/mlx5/mlx5.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h > index c537af9..e5640c1 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -733,7 +733,7 @@ struct mlx5_ind_table_obj { > struct mlx5_hrxq { > ILIST_ENTRY(uint32_t)next; /* Index to the next element. */ > rte_atomic32_t refcnt; /* Reference counter. */ > - uint8_t shared:1; /* This object used in shared action. */ > + uint32_t shared:1; /* This object used in shared action. */ > struct mlx5_ind_table_obj *ind_table; /* Indirection table. */ > RTE_STD_C11 > union { > -- > 1.8.3.1 Patch squashed into relevant commit in next-net-mlx, Kindest regards Raslan Darawsheh