From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F685A04E7; Thu, 5 Nov 2020 18:41:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF4B8137D; Thu, 5 Nov 2020 18:41:31 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 3F20FF64; Thu, 5 Nov 2020 18:41:28 +0100 (CET) Received: from HKMAIL101.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 06 Nov 2020 01:41:27 +0800 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 5 Nov 2020 17:41:27 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 5 Nov 2020 17:41:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bwefrbKnmzSuquDMRxtbc+7OQVpRMCtYdHbmbRVvp/WbUXZvcdkEtPW60rXalw3KPtsFokLcqRq61+lFgSCKxPS784A6PRfL7azRyrMuK8RzY9EUyZy2iZJ8XVTDJYNLMo1FYug+O2uedXH9GcWMLyWZ0r9Oui88CSqPrs1vmuDcogFBRisHvgXbiCjrIKZBGH85Uj6PtNp3WtxrYpGb3tR8Ny+1zUID99Bn6Kz4QdHGydoD4ptaoliqRhYITxLdp3l0xo0LkDqnPui1zE26fJ+P9lBKcfc+OLResLwhpSXDpTtEU8/SHPY/eyYPgCj4q+6U0iG8yVIg4CcmirJBsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AsV9/xEef0Kbxh/1Ot+VZtje/iGWQq/I1X4lRqtCwck=; b=bS214GL3ezsNWhzzaBE616GuMk0knPux5MyH9V+mmceg93bB/Zmo5qroBNzOdP9Yqj30lCAkUYd3ESqbMIfVC1m+jgN0MoQOo0Ji1OUJu1dV6xYHqUos4iDBmwnQ0capqmgnL5Jr95M9aPKj1+cJ7ufvAZws6DLcsghDxuPVdeh7OuyVe1yJpFY3cXNnJRvOD9r33wJEG3K1vPGXi927QLJrNVAeTm9ab1mIvAgBjkZ/LUuG2Hvot4FZ8H+0UMNmMXKyjY1xFrN5kwSL1/6klp9esjIyMIWskSpQRMiZXpkYHk3omvETjJFR1pfr9fEMXraNu4D7Ykn4WIrzgGO0Hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR12MB1593.namprd12.prod.outlook.com (2603:10b6:4:10::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Thu, 5 Nov 2020 17:41:25 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51%6]) with mapi id 15.20.3541.021; Thu, 5 Nov 2020 17:41:25 +0000 From: Raslan Darawsheh To: Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix Tx queue stop state Thread-Index: AQHWsa1zZrRG07CJnUe1QwatMXaa+qm50kUw Date: Thu, 5 Nov 2020 17:41:25 +0000 Message-ID: References: <1604386112-342335-1-git-send-email-matan@nvidia.com> In-Reply-To: <1604386112-342335-1-git-send-email-matan@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.229.12] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7a03259d-669d-4058-724c-08d881b204a9 x-ms-traffictypediagnostic: DM5PR12MB1593: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:747; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B6vQQq/KaYh2aJMv3Ts3avfQepzs80teohWw9UaS2B1K5YlYEsUMLXSyx88Iv+evP3EoF/3cWCJjtRmQrAEA3Lo50tT/Bxdex/Msyy1RNQuIHiMmG2kMiwpbIoVrgJPRXD7yRhLwxYXZdIezWHbxjp8HzoWk5TuPscfYLBudI3KdUxRSYDnlchHaNpSPNRN88NvEvoXSpJERNDAqbsl1IjUyF571CLT2TnpXHHcwkJZqoxZVyd5OdJxApeH4PP0Xd8jWObQjDNP3oooN1wRlwMNPt+QH1dZq1U7aCWYMaFa+N8Z+/eRgTG8gjqZ1dolEAKLb9zKIF6KEenrPnVR7rQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(376002)(136003)(366004)(396003)(86362001)(71200400001)(4326008)(478600001)(450100002)(53546011)(2906002)(8676002)(66946007)(6636002)(76116006)(66556008)(66446008)(64756008)(66476007)(316002)(5660300002)(52536014)(54906003)(6506007)(110136005)(7696005)(8936002)(33656002)(9686003)(55016002)(26005)(83380400001)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: bsqOQQehxN3Wl9xyyxngyrkLEvMVYFRX6lgc+SUC+gk6yVJIEXQDmgJICV830P2qnFWfItyPlHHkc3TsJEDbcmgbiH9a7s3UkMmW1/0DHxOISSmL+8LvvBAxdSvcoW32gIAQf99q9T/472NuRSbtl5l0/SAtLg1LV+Q5IhKRJfl9IbsH4ijqUnIbo0dvyCgstCYjiDs5lcCWlb1DHsAs0HFoNQVghsLQFibbJXr8SZ+/6Yvg9jcpSkRHt4zcllxIFIRnLBxQLKz9Q00NdXHw1eqzllpTdJQ/nAClVPjVK3oYtR5wqQ4qbCNRl1yn31KYuCUiBwraNmjAeoEWmVHJGirtXc2BmDRhsXMZvdd4+HdiAqB6Jn6Y/xWKkZkIkTOua7tNft88YUKvDtQmnyzh08JlSpNGQKKeGU4m2BhbWiutObtk0WivU+vF3eDIHiFL4xeyHkqlY2gdOIXS316UqnC+fgKAWHUoOLQhalm1e6h5hpeflLRGnE5raSWb8CnHMQYsuI4PW8g0IxsvaCO5+A7afXa+hCbQpW93Ii5ECLWpTUNlMHWK9cqsctoyR9SKoUJ16fYYAgPJDnKQj3zEK2MAS6eG67CwVvqenC0wEZVxMm//VNlf5XvUHusRTKdfpGjwGGm0tssuFPmTFi//FA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a03259d-669d-4058-724c-08d881b204a9 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2020 17:41:25.3841 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9AX5e6aKo0RCR4EZciKLqIfE8QPYnidTLscgWU+WylrMzV3SVvbuo4itZjG6eot6s4n4iXRlVm4eirXd+bDlMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1593 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604598087; bh=AsV9/xEef0Kbxh/1Ot+VZtje/iGWQq/I1X4lRqtCwck=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=BCKvTT+KrJAFLKq6TroGc4leJkodCBdMeL3OVBZD3yYYJAsjtfOQjAsNnLenhSciH SVVCM5wEVW+hS6NRpleDzTSIYQfUZKtdyX+sC4jRzkkHSO/kZCtPAYrBs9FAMKqdN/ TzT1AEFME71L/2oKW9gcPo/rsZ9nHjS28W5zyp2i64kJPbqrtZ/bI0wye3F1PaVR2F da/7C66AAYNnLOPKrc+K15Nd+2fcNLBOGe55ZM/5w5C4415JRG7lYB1keSksVexVqX bSGyctLiyjXF0ALo/y/aPWwWKbCghYSyHMgMR0EmjnaFnco8Xoq7VE5e7OeLJx04tE Unu7/sY6eTs+Q== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Tx queue stop state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Matan Azrad > Sent: Tuesday, November 3, 2020 8:49 AM > To: Slava Ovsiienko > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix Tx queue stop state >=20 > The Tx queue stop API doesn't call the PMD callback when the state of > the queue is stopped. > The drivers should update the state to be stopped when the queue stop > callback is done successfully or when the port is stopped. > The drivers should update the state to be started when the queue start > callback is done successfully or when the port is started. >=20 > The driver wrongly didn't update the state to be started when the port > start callback was done what remained the state as stopped. > Following call to a queue stop API was not completed by ethdev layer > because the state is already stopped. >=20 > Move the state update from the Tx queue setup to the port start > callback. >=20 > Fixes: 161d103b231c ("net/mlx5: add queue start and stop") > Cc: stable@dpdk.org >=20 > Signed-off-by: Matan Azrad > --- > drivers/net/mlx5/linux/mlx5_verbs.c | 1 + > drivers/net/mlx5/mlx5_devx.c | 1 + > drivers/net/mlx5/mlx5_rxq.c | 4 +++- > drivers/net/mlx5/mlx5_trigger.c | 1 + > drivers/net/mlx5/mlx5_txq.c | 3 +-- > 5 files changed, 7 insertions(+), 3 deletions(-) Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh