From: Raslan Darawsheh <rasland@nvidia.com>
To: Dekel Peled <dekelp@nvidia.com>, Matan Azrad <matan@nvidia.com>,
"Shahaf Shuler" <shahafs@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix shared RSS translation and cleanup
Date: Mon, 1 Feb 2021 13:24:53 +0000 [thread overview]
Message-ID: <DM6PR12MB27486672EDD0203DE6678413CFB69@DM6PR12MB2748.namprd12.prod.outlook.com> (raw)
In-Reply-To: <ef797b9b97e64be8cc4d731f087a0a3029f8af6d.1612171517.git.dekelp@nvidia.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Monday, February 1, 2021 11:29 AM
> To: Matan Azrad <matan@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix shared RSS translation and
> cleanup
>
> This patch includes several updates of the shared RSS action:
>
> (1)
> The shared RSS action, introduced recently, uses existing definitions
> of the regular RSS action.
> The new defined value MLX5_RSS_HASH_IPV4_TCP uses existing definition
> IBV_RX_HASH_SRC_PORT_TCP twice, instead of using
> IBV_RX_HASH_SRC_PORT_TCP and IBV_RX_HASH_DST_PORT_TCP.
> --- ---
> The same is true for IPv4-UDP, IPv6-TCP, IPv6-UDP.
> As result, a shared RSS action with L4 type is specified as src-only.
> Flow rule using such shared action, while specifying L4 item in flow
> pattern, will fail to create.
> This patch updates the new definitions, to use the existing values
> correctly.
>
> (2)
> On shared RSS action destroy, in function __flow_dv_action_rss_release,
> the indirection table shared_rss->ind_tbl was released before
> shared_rss->refcnt was checked.
> This order is incorrect, since the indirection table should be
> released only when the shared RSS action is destroyed.
> This patch puts release function calls in correct order.
>
> (3)
> Variables declared of type "struct mlx5_shared_action_rss" are named
> "shared_rss", "action", and "shared_action".
> To improve code readability, this patch renames all to "shared_rss".
>
> Fixes: d7cfcddded61 ("net/mlx5: translate shared action for RSS action")
> Fixes: d2046c09aa64 ("net/mlx5: support shared action for RSS")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dekel Peled <dekelp@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2021-02-01 13:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 9:28 Dekel Peled
2021-02-01 13:24 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB27486672EDD0203DE6678413CFB69@DM6PR12MB2748.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dekelp@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).