From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0BE1A0A0B; Mon, 1 Feb 2021 14:25:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BAF6E160651; Mon, 1 Feb 2021 14:25:01 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by mails.dpdk.org (Postfix) with ESMTP id 18D2A40687; Mon, 1 Feb 2021 14:24:59 +0100 (CET) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 01 Feb 2021 05:24:59 -0800 Received: from HQMAIL107.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Mon, 01 Feb 2021 05:24:59 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Mon, 01 Feb 2021 05:24:59 -0800 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 1 Feb 2021 13:24:58 +0000 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 1 Feb 2021 13:24:56 +0000 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.59) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 1 Feb 2021 13:24:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WCL5KmpGxAo6HGdnTmyDtuiqrx2FttSnZaPQzpZ/fZqx9CvYmdx1dzXh0UUFSeOdghB7qpeXxZc07HRVlHcFXj9nE2RGrDvBtr/eVNkTZ2ukBUHqcpafugd/7cb69iovqQfRIxWKLLgLXnjLu/h9vQl5pqS6hgLUKgkJP+4kRFgHizDKZyeJuWm7NgyffvbO/7ogqCH/Z9+Md6NN/coMpM1Jl+erWXmCDYS02mtTg2r7Lw1MSWR10EvIqp9qT/tpeufZl1XwdiYsblO67oofeZwwHS9S0Xg/zO6RErKDVSIEUZnsvhz/UQdv9KN2JqI+i9wdeVooiyRagqg5YzpEQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9G9hxwI06uiFqZ/Qqf7CiCKeq2OZBCoMEH4ma3o0Kgc=; b=lxFRegHwcfWJSEj5gNinJn9S3cYIs33E9nX9GPf9iop77MGY72dKqwqUxs0ddJEGKwyhvWLDrCwm6IXOr5OjYPlEQsPOz4xKh7nidHd5hqptrqmcQwDDsQRRhW9jcgwP1ZtSjkfOEPzLgOhZUlXQriaTdsh3aMtjIpdyWNtnITnzI0FK1cZUDUMpUW/j7GWRD/uDdwfuz3oDbxon8PPSIxNhQt36voPt0HRueqkTC0sMnwCtPAM/lRclLhoS/Sn+CG0Vn87Y3E+z1J2nO/B4LIaUzu0LWaLt3ak//o12/eijneJjLoiML9DhNYolF3bza+NctF4rNUwo2WM4cwEYHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB4909.namprd12.prod.outlook.com (2603:10b6:5:1ba::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.17; Mon, 1 Feb 2021 13:24:54 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::759a:fb10:c6af:87a3]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::759a:fb10:c6af:87a3%7]) with mapi id 15.20.3742.015; Mon, 1 Feb 2021 13:24:53 +0000 From: Raslan Darawsheh To: Dekel Peled , Matan Azrad , "Shahaf Shuler" , Slava Ovsiienko CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix shared RSS translation and cleanup Thread-Index: AQHW+Hy2m5TE4PkkWEabjSK8lrxB4KpDSimQ Date: Mon, 1 Feb 2021 13:24:53 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.228.183] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d902a151-272f-42c3-2511-08d8c6b4c2f0 x-ms-traffictypediagnostic: DM6PR12MB4909: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-header: ProcessedBy-CMR-outbound x-ms-oob-tlc-oobclassifiers: OLM:2000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ChBQMgvQDJr1MwlR7VTqYndAn4/SS1ujj04c37b2uEUEXzN+28HBL7WS8RJfREqKBHPhKDrtgU8sCVYWoLnMtma2Zbqw9nALhrgfO48j7FmoR25oVpC07QcJY383dStX7BxMXLkPxuMd/XCvewWA6Qv7HkPG1vp1qHPHQ4HMgz3vtrgEXWJn0aqcGF9obaFK8WuNIX+Dpzv+F2gHFnsrV0zGESp3jFHiljO4Xu+mQQ5PBtnyoLstNvcsJ60hK/YRCD5/jD8f8wYCcGPlPIix+BZbHVeUYW/oGSc7Bq11vD6gbG3DpCksprvGDXeiIitubXWS6+403fmbruc+OMDSvO4jbTXXROqJy7zEtgikYnszj1mFJdR5iPRREe/3KntkKogyAph6vvDQXnZEp7LloRF9OR9OUj1838uvy6CwGq1+yre70FC7LJlQpe8nLffGfzaDvoS/HKLtOuv1buC5xFwcH0SsElY/sfhXdZaVrkKXyUbADQT/y/A/HgpwLNONA0jJ1TechBfOxTBKRigZOQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(396003)(366004)(39860400002)(376002)(26005)(86362001)(478600001)(53546011)(6506007)(186003)(71200400001)(6636002)(33656002)(9686003)(55016002)(8936002)(5660300002)(2906002)(4326008)(8676002)(450100002)(54906003)(110136005)(316002)(66556008)(66476007)(66946007)(52536014)(66446008)(64756008)(76116006)(83380400001)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?2YiYIxoVM/iZmSwVgBRZzj0sd1rUDEyftwX4xGDW3ZXKPoHZ9H3W4jTkdIjZ?= =?us-ascii?Q?/27HbL//6Y9bOlorel8WzPVHvu25KV442+zY9gT53BmMxf0Oc5eOWHMWy4i1?= =?us-ascii?Q?BKN6jFIreF4/zAugj3AytjXxx9mdnwaIjwRXn46a4B9jS4yZfmhrAx4jtG6i?= =?us-ascii?Q?oE7n1zi1Lj3dtgaor9HjXA+kpao06lQjPgbBYFuUddwHCZyqJkGX5tUhkl+I?= =?us-ascii?Q?pE41lx6jwS286XPJnyV8okpvRdvt6efYepnUE9Vr73EeunWZL78G1VOO4dDa?= =?us-ascii?Q?wKp2xYq2eAsuZ5hO/OXjrlzDpS5Brx1YchTIMP14CNWw9pl9sYqxMG1GN7QC?= =?us-ascii?Q?VQiAjm6w+hhnCvScb8+mIKqg+IpN8f+pKpygsY3ebts5BADuq5H1ea9Z6orM?= =?us-ascii?Q?bQr1I5QWMaZYFm89hYfXKWYVpg6BT8ll1LADZqSAI5/wgSqvl/1UY8uLuAg0?= =?us-ascii?Q?0gZLSne0ryv17dPOZfv7+hVOFpj8vguatSyU55L4OPD7SgiiZg6+J/nww72I?= =?us-ascii?Q?wzk6ECE6/Lx0p4SnoYC2v7QL3Kzn4aNRslczsw2fJLuqA3d+iTLBrs1cTez2?= =?us-ascii?Q?RN9aWAcPD8JAB2UwLNVLEkQhbAPIJj/3W0LV20lGjTRhGwvatB6I+t4RalO0?= =?us-ascii?Q?/r/Q2eWZWh8F/BmUsETxkjPu9XAeb5XqPli0Plos7g1P++1RayIrhyWVDfiJ?= =?us-ascii?Q?sw76aoZd2m9YCV8ZB8E1M9ppkjCyCOnVVD0DDmXkw4lRnPbUSbhOrjHUE3gg?= =?us-ascii?Q?JCjNCOKZBBdPEGaaTixCwYs4rnGT5i4XH/3c6IAuddgEyMpWKjgE+OFqF8zn?= =?us-ascii?Q?4o+A9dKqEruNcw7YsBJTUYImr93buP8IIIxqOiua0QmdPWC2tD3/xp6To1nE?= =?us-ascii?Q?RYdFpDjQrW4qfqkHRkAK7MTK37D43KeVplaeU9BCA7hIlpqJ+zk3qmoPj5d+?= =?us-ascii?Q?AgzIfBJ0EcvIUe+DlMW+yic9volbc1scqteqljWBKHDsD06lqoXaIHMlm4h8?= =?us-ascii?Q?Fkvl/NDetK2/fp3P0ehyRccYtKnRbITnwZi7/jqZRip6fUnZIq5JiJ5imtB5?= =?us-ascii?Q?eY/iPryQ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d902a151-272f-42c3-2511-08d8c6b4c2f0 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2021 13:24:53.8756 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fx+6T1EVujyXp0dcgw5ZxEB2rHTp08A0WdiENgmxHWSF+1vrVjlzfdvXJIaxAUC4YGGAAKyaqn9V9jcbeYmDAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4909 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1612185899; bh=9G9hxwI06uiFqZ/Qqf7CiCKeq2OZBCoMEH4ma3o0Kgc=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-header:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=c8DTDDxDmpvoAywTpPf8pbeG/0tI87fuUFBBVGYgLBBgvgPVtcr32SRW8Z0PNFq+P BxHYejzAIFpr0gMQaUps3O73sNy9ptDDCGoTFcVyFmN9GrvKJ9gK+4DmOO6KYvgURY RhpYTTUR3c1Ky02yOTY3xIX2UVIkqfHUYpWQLgpdXX7xBKY4vUDGi82X+kTifTaoyA Mwnvpc7L5ZqcGmpTwSCXcghKT7ZI0rqpz6VwrDU3eFHoTdESVxP/gcXL4hDv+zTNyW zoje9pKdyfwGehHfKO1rflI3HwS98QMbooPdPzlQL1HjK3Y+F25QjUvV5jp/3ibRl8 7W5+tRx45T67A== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix shared RSS translation and cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Monday, February 1, 2021 11:29 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix shared RSS translation and > cleanup >=20 > This patch includes several updates of the shared RSS action: >=20 > (1) > The shared RSS action, introduced recently, uses existing definitions > of the regular RSS action. > The new defined value MLX5_RSS_HASH_IPV4_TCP uses existing definition > IBV_RX_HASH_SRC_PORT_TCP twice, instead of using > IBV_RX_HASH_SRC_PORT_TCP and IBV_RX_HASH_DST_PORT_TCP. > --- --- > The same is true for IPv4-UDP, IPv6-TCP, IPv6-UDP. > As result, a shared RSS action with L4 type is specified as src-only. > Flow rule using such shared action, while specifying L4 item in flow > pattern, will fail to create. > This patch updates the new definitions, to use the existing values > correctly. >=20 > (2) > On shared RSS action destroy, in function __flow_dv_action_rss_release, > the indirection table shared_rss->ind_tbl was released before > shared_rss->refcnt was checked. > This order is incorrect, since the indirection table should be > released only when the shared RSS action is destroyed. > This patch puts release function calls in correct order. >=20 > (3) > Variables declared of type "struct mlx5_shared_action_rss" are named > "shared_rss", "action", and "shared_action". > To improve code readability, this patch renames all to "shared_rss". >=20 > Fixes: d7cfcddded61 ("net/mlx5: translate shared action for RSS action") > Fixes: d2046c09aa64 ("net/mlx5: support shared action for RSS") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled > Acked-by: Matan Azrad Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh