From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FA25A0524; Thu, 4 Feb 2021 17:41:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F13E2406DD; Thu, 4 Feb 2021 17:41:23 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by mails.dpdk.org (Postfix) with ESMTP id 7F0AF2406CD; Thu, 4 Feb 2021 17:41:21 +0100 (CET) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 04 Feb 2021 08:41:20 -0800 Received: from HQMAIL105.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 04 Feb 2021 08:41:20 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 04 Feb 2021 08:41:20 -0800 Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 4 Feb 2021 16:41:20 +0000 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 4 Feb 2021 16:41:20 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 4 Feb 2021 16:41:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V2rerEP6OOV7bv/jk1rn43KCfgOciB+QyIkKDvzzhUytnDBG4cZHQqDRkOyqgfOIF1m7re07sUiY/jz5nGnR/BbPOkPEYYp2iSZA6pf4aoNYTEHLpj37iQh2b4xARHhEvtmQKyOjTVAuNkZs1qaXBEidmv+Or5KzeeXkDM2CfXDqu4QElWxuvoZdMqok1HhUapnIBTy4rxJBthvqXplWqTq52WGyjZLTsZ2MSLKPImq/sgew6JdK59V/fn2375FTOjtjzSGRJ4DKYZCfVDTay4k0ruyuQzo/kKVtbx8tnmO9GqWnLcLeBlw+SSvMDLoKLCYYiOCLtlo+ULCWy6EfEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6MN8v9RjowQA+TFwhpv8qgiQulQ3hUgLsrtlRRZR2hc=; b=Si4J62ME/eMKqqwpUBiEkHX9CokqNkhAOyPDEw8G8eHm4D41h2Ayz/G0tRaQNr8KQnyA82CIMfFIA2fhBJIMWI08KaUXY06/1JkwCNWCD7QglCrzuA3REFdYfzT30BCC8A61WmOUnl8zJH1RGm3gFUCNI00qUJNa47zCErsugj2UaHpdW56c3F2SoMHZDvMT8Vo6HxvGZM5hRe8E9XInAp6brUFWiOur3XJzmXHBOtj8rmqT9oApwFMk/H62rnM1WIe/XgqZ7GCgAae4AImgu+5Ih9AFOvpTfJSk93VUbrfXUfBpQSCpSgwQh6R9YEnrK5E0q1JJpWkR/bB3kQ3xng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB2698.namprd12.prod.outlook.com (2603:10b6:5:42::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.17; Thu, 4 Feb 2021 16:41:19 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::759a:fb10:c6af:87a3]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::759a:fb10:c6af:87a3%7]) with mapi id 15.20.3742.015; Thu, 4 Feb 2021 16:41:18 +0000 From: Raslan Darawsheh To: Dekel Peled , Matan Azrad , "Shahaf Shuler" , Slava Ovsiienko CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix validation of hash Rx queue pointer Thread-Index: AQHW+hSobkOEz0A49EmbSrN3WlnF96pINMKg Date: Thu, 4 Feb 2021 16:41:18 +0000 Message-ID: References: <4135791adaa27d4cf7aba5792edfad33ebfa7c41.1612346495.git.dekelp@nvidia.com> In-Reply-To: <4135791adaa27d4cf7aba5792edfad33ebfa7c41.1612346495.git.dekelp@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.230.58] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 935ffd31-c1be-4352-aa0f-08d8c92bb294 x-ms-traffictypediagnostic: DM6PR12MB2698: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-header: ProcessedBy-CMR-outbound x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HCYQ1U0dxqcphF7dfaFUdGlH40NX6RlMj+lvJDwpS6Qww4nIbVUUWo0c2xa5W0KO4SBrOHbIhAg0zbI+bLcUJYVolsf83q2H6HBrOPLwVBdsM6I5yJfXSbNuFBXWOb35A5JpsVzG33s3mqC0Xg/qioPvAZBVJIL4qsG8ECaWWRuP4sOhVWPCIGj6SYbEjyy5mmO0BItNvxLDFiFHORQIlnvfb1ymBr4ZrBCE6TP4DEwJHR0JD3goAB07tHUIKacKR5E4rAyGL97GEkzolNrGwD798yCPhB2LF5p6fvhvkylIL8PrKBYVSC6WSHMLjRqagHBlkKd8drpUTN21h12e7qr0s2qsLd96O5Y1as7tGechM6Tuuly6O+oY/+ELpQya104dst6ctWHLRGiCiZZvPpf+ZZxn8fjusQT0i+pvvuGoUQaF9FFv3vPClSJ+wL63NG5jxdssK2trtN3GOKZGLoq+ly6UAf1MQKkZym1m1qG8P9lqFWq7k3K6e6lnmAtP4Ld0hh1aISujpkzsRxr8NA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(136003)(346002)(376002)(39860400002)(66476007)(450100002)(4744005)(316002)(110136005)(66446008)(8936002)(6636002)(83380400001)(7696005)(8676002)(71200400001)(33656002)(54906003)(9686003)(55016002)(4326008)(186003)(53546011)(76116006)(6506007)(86362001)(2906002)(26005)(5660300002)(66946007)(478600001)(64756008)(66556008)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?6xFmosQUzl54obVHYw2mnSxHkrWdBoCsj7/YxCGousGh9SHHA899fQFlpycw?= =?us-ascii?Q?s+Dk5i+37+PmQLuYmuuIYjXT0cEXSykLNvzzcsHUuYnLB4ETfxzLqT0OX1xU?= =?us-ascii?Q?TMkFwBqRKMMTed2lX1LL+oB+J25vOv6mnaXHQt3XmEM72gYnqE/thS/m9lAZ?= =?us-ascii?Q?f/lxfmVqEXhXuTPGxO0fHLUVE+MbouNnu6ehQJvCLGyXHK1ifc7z8KYws1W6?= =?us-ascii?Q?H/y+aKhVxNRFG71XKiq0tRXMsNQ/6XxvG6WIXh9p4PNUR5yHqoKmH1PxIbSM?= =?us-ascii?Q?7dbA7tgCV3uslkA5gaxeHFNWxwmoZMsQsQWVf0IuvwAnWyBLSgPIivy0L9Q2?= =?us-ascii?Q?Hj3IIk4ClVNGo6tWSNVJ0EWob8WDFxrs70qEOQOIMp0sKZhcKOv7EmZjxcOa?= =?us-ascii?Q?3R4dVwAGBcz7AZzSZzbzXvMMcoGKoXJ47GVtcM1i6gJd6ceK/7FGsFLmHjO4?= =?us-ascii?Q?MFlgjDYn1G+aZ7rZmguPWL0ADfp4i9MRsDB63qdK/dnR4MHR2OYiWNJ0sEqZ?= =?us-ascii?Q?lgM8rgyW0h8m/R9iYcwilLrD8u6elcnCpJ88dgZ2TZTGpUIF5Dw4K9eGS+ee?= =?us-ascii?Q?uCj4yo7s9zOIK47lGph1sAvS9sFmC/onl4ZMehEHA0t5KCOOrIKq/oUUasHc?= =?us-ascii?Q?X06WTXJmUmMGPQaEoU2K9SPGBc5w4Xm+f90Kmw2xFizdRnXfI0iW/8FzbIOK?= =?us-ascii?Q?M+n1b9otoYQdtgOsLiYb9GhyLtLSwkXrkxXlLHlHpUaYM9XNU2VD4h9VxGqa?= =?us-ascii?Q?9rh4h9miguNIX38HbGtEe/aF7qBITYcg87ib9f0GhY7hixzXrVyP5RIeCAwT?= =?us-ascii?Q?RMail06NyAbmoZaPLBzxkIj93jQP99gM05WAjtqzdUt7366+Yd30ofj33U4T?= =?us-ascii?Q?rXrCNmZkqGLw9y03ilHWK7rAX2FFvQzboU5cFWu9ERsw2VEWfbyGU4y/DD9P?= =?us-ascii?Q?50eIAd++5bpI07z7+w82LOzm4eRpZqwgbpbYmCgMQAcn6Jl2MtPQGAFIJAqW?= =?us-ascii?Q?QKcczUw47aSrmHVEhVlvitQ5W6IMBkjhI9A53hUeB+tXkDfmynIUgSEl2qb5?= =?us-ascii?Q?l3BoV00y4KPvXY8D+9nTj30SUNOz5fj6Js3w1t4CAQ+s8l3L8We6iHR6NktT?= =?us-ascii?Q?8OqYKrtJ206cZNio8fYYi0Kj/h+j22x8T7ponxqE7KPUEjgCo1wc4XcSE2xr?= =?us-ascii?Q?Pj7KWBAh/cthjR8R0hQEQnpthANP2iCZGpWAXH+YBY/zf8cVcm7PWzgFY96h?= =?us-ascii?Q?UQowyhgDFr2N5g61Z3HQ145hry1AGe4Mczd4zSUbD+vwUqsAchiFokKQgf6r?= =?us-ascii?Q?dZ/hjtzCet8F4X3vhrAI2hDG?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 935ffd31-c1be-4352-aa0f-08d8c92bb294 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2021 16:41:18.9089 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CyCL9TmI3406gPjlmynQSfk2vX/cPMWGuFrMMidLwWutskAv6cdim3Uc8lDm1Od1dfnb04UUWpqufzp4WIYajQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2698 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1612456880; bh=6MN8v9RjowQA+TFwhpv8qgiQulQ3hUgLsrtlRRZR2hc=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-header:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=AHpwbX3zHQXcYJJxrSEcadY/WnMtGVsNTkK72xFQSTg5XkTVZDZj7bVHd74WHqWYT dG5ddi9m51ZXiTGWVK05auxMU8t0jTvhWfSiobjXW0uGsL0DCmGOVjaNhRcsN3ufWX KJ9/3Q4RvaK80ZYgLISDB1fUFfLMPUmzkL67wzvTGj9MuQ75CUpMLyJz/qRLixR4q2 nj706gBgJq+eJffaJWamvL+QNv4iP9QJ8ZWZDFltBFlx/WuFlevUruzc9m7Mg2xOo4 DIQyqcR/IQfqQ3odPgEBqjwTtyt2XIjCr6lYBS+PSEDOVuurak/EK5XVL0nF6COp6t +D/MSkK6O1gyg== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix validation of hash Rx queue pointer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, February 3, 2021 12:09 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix validation of hash Rx queue > pointer >=20 > Implementation of mlx5_hrxq_get() tries to get pointer to a hrxq > object, by reusing an existing hrxq, or creating a new one. > There is no check of the obtained pointer, so using it might result > in error. >=20 > This patch adds check of the pointer before using it, and return 0 > if the pointer is NULL to indicate error. >=20 > Fixes: e1592b6c4dea ("net/mlx5: make Rx queue thread safe") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled > Acked-by: Matan Azrad > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh