From: Raslan Darawsheh <rasland@nvidia.com> To: Ori Kam <orika@nvidia.com>, Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Ivan Malov <ivan.malov@oktetlabs.ru> Cc: Slava Ovsiienko <viacheslavo@nvidia.com>, Shiri Kuzin <shirik@nvidia.com>, "ying.a.wang@intel.com" <ying.a.wang@intel.com>, "stable@dpdk.org" <stable@dpdk.org>, NBU-Contact-Thomas Monjalon <thomas@monjalon.net>, Olivier Matz <olivier.matz@6wind.com> Subject: Re: [dpdk-dev] [PATCH] ethdev: update qfi definition Date: Mon, 29 Mar 2021 09:06:41 +0000 Message-ID: <DM6PR12MB27489C20DEBED9CFC0DD6DBACF7E9@DM6PR12MB2748.namprd12.prod.outlook.com> (raw) In-Reply-To: <DM6PR12MB4987812D4397D24A563C0D66D67E9@DM6PR12MB4987.namprd12.prod.outlook.com> Hi, > -----Original Message----- > From: Ori Kam <orika@nvidia.com> > Sent: Monday, March 29, 2021 11:53 AM > To: Ferruh Yigit <ferruh.yigit@intel.com>; Raslan Darawsheh > <rasland@nvidia.com>; dev@dpdk.org; Andrew Rybchenko > <andrew.rybchenko@oktetlabs.ru>; Ivan Malov <ivan.malov@oktetlabs.ru> > Cc: Slava Ovsiienko <viacheslavo@nvidia.com>; Shiri Kuzin > <shirik@nvidia.com>; ying.a.wang@intel.com; stable@dpdk.org; NBU- > Contact-Thomas Monjalon <thomas@monjalon.net>; Olivier Matz > <olivier.matz@6wind.com> > Subject: RE: [dpdk-dev] [PATCH] ethdev: update qfi definition > > Hi > > > -----Original Message----- > > From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit > > Subject: Re: [dpdk-dev] [PATCH] ethdev: update qfi definition > > > > On 3/23/2021 12:11 PM, Raslan Darawsheh wrote: > > > qfi field is 8 bits which represent single bit for > > > PPP (paging Policy Presence) single bit for RQI > > > (Reflective QoS Indicator) and 6 bits for qfi > > > (QoS Flow Identifier) > > > > Can you please put a reference for above information? > > > Sure, will send in V2, > > > This update the doxygen format and the mask for qfi > > > to properly identify the full 8 bits of the field. > > > > > > note: changing the default mask would cause different > > > patterns generated by testpmd. > > > > > > Fixes: 346553db5bd1 ("ethdev: add GTP extension header to flow API") > > > Cc: ying.a.wang@intel.com > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Raslan Darawsheh <rasland@nvidia.com> > > > --- > > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 ++- > > > lib/librte_ethdev/rte_flow.h | 4 ++-- > > > 2 files changed, 4 insertions(+), 3 deletions(-) > > > > > > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > index f59eb8a27d..dd39c4c3c2 100644 > > > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > @@ -3742,7 +3742,8 @@ This section lists supported pattern items and > their > > attributes, if any. > > > - ``gtp_psc``: match GTP PDU extension header with type 0x85. > > > > > > - ``pdu_type {unsigned}``: PDU type. > > > - - ``qfi {unsigned}``: QoS flow identifier. > > > + > > > + - ``qfi {unsigned}``: PPP, RQI and QoS flow identifier. > > > > > > - ``pppoes``, ``pppoed``: match PPPoE header. > > > > > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > > > index 669e677e91..79106e0246 100644 > > > --- a/lib/librte_ethdev/rte_flow.h > > > +++ b/lib/librte_ethdev/rte_flow.h > > > @@ -1392,14 +1392,14 @@ static const struct rte_flow_item_meta > > rte_flow_item_meta_mask = { > > > */ > > > struct rte_flow_item_gtp_psc { > > > uint8_t pdu_type; /**< PDU type. */ > > > - uint8_t qfi; /**< QoS flow identifier. */ > > > + uint8_t qfi; /**< PPP, RQI, QoS flow identifier. */ > > > }; > > > > By design requirement, rte_flow_item_* should start with the relevant > protocol > > header. > > > > There is already a deprecation notice for using protocol header directly in > the > > rte_flow_item* [1] and Adrew/Ivan already fixed a few of them [2]. > > > > Your patch is not directly related on this, but since you are touching to the > > flow_item, would you mind create a protocol struct for it first, and use it in > > the "struct rte_flow_item_gtp_psc"? > > So the protocol related update can be done in the protocol header, instead > of > > rte_flow struct. > > > +1 Sure, I can create the new protocol and use it , and will send in V2. But, wouldn't it cause any ABI breakage ? > > > > > [1] > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.d > pdk. > > > org%2Fdpdk%2Ftree%2Fdoc%2Fguides%2Frel_notes%2Fdeprecation.rst%3F > h%3 > > > Dv21.02%23n99&data=04%7C01%7Corika%40nvidia.com%7C6391a4c064 > 0 > > > f4592b70b08d8f058e322%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0 > > > %7C637523611870497932%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA > w > > > MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sda > t > > > a=vU%2F5oO47zb9erTnZL1pl9j0nHCKzea3NJgOeo1FTW0Q%3D&reserve > d= > > 0 > > > > [2] > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.d > pdk. > > org%2Fnext%2Fdpdk-next- > > > net%2Fcommit%2F%3Fid%3D4a061a7bd70bfa023de23e8e654e&data=0 > 4% > > > 7C01%7Corika%40nvidia.com%7C6391a4c0640f4592b70b08d8f058e322%7C43 > > > 083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637523611870497932%7CU > > > nknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI > 6Ik > > > 1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=WurlQ5VSLqFGVthfRj363xZs > C > > No3xJuvxNQCFVcxdkk%3D&reserved=0
next prev parent reply other threads:[~2021-03-29 9:06 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-23 12:11 Raslan Darawsheh 2021-03-26 13:12 ` Ferruh Yigit 2021-03-29 8:53 ` Ori Kam 2021-03-29 9:06 ` Raslan Darawsheh [this message] 2021-03-29 11:14 ` Ferruh Yigit 2021-03-30 7:50 ` [dpdk-dev] [PATCH v2 0/2] fix gtp psc qfi support Raslan Darawsheh 2021-03-30 7:50 ` [dpdk-dev] [PATCH v2 1/2] ethdev: add new ext hdr for gtp psc Raslan Darawsheh 2021-03-30 8:00 ` [dpdk-dev] [PATCH v3 0/2] fix gtp psc qfi support Raslan Darawsheh 2021-03-30 8:00 ` [dpdk-dev] [PATCH v3 1/2] ethdev: add new ext hdr for gtp psc Raslan Darawsheh 2021-04-01 16:51 ` Ferruh Yigit 2021-04-04 7:17 ` Raslan Darawsheh 2021-03-30 8:00 ` [dpdk-dev] [PATCH v3 2/2] ethdev: update qfi definition Raslan Darawsheh 2021-04-01 16:54 ` Ferruh Yigit 2021-04-04 7:18 ` Raslan Darawsheh 2021-04-04 7:45 ` [dpdk-dev] [PATCH v4 0/2] fix gtp psc qfi support Raslan Darawsheh 2021-04-04 7:45 ` [dpdk-dev] [PATCH v4 1/2] ethdev: add new ext hdr for gtp psc Raslan Darawsheh 2021-04-08 12:29 ` Olivier Matz 2021-04-08 12:37 ` Raslan Darawsheh 2021-04-08 14:10 ` Ferruh Yigit 2021-04-08 14:10 ` Olivier Matz 2021-04-13 7:45 ` Raslan Darawsheh 2021-04-29 16:29 ` Tyler Retzlaff 2021-06-08 12:13 ` Andrew Rybchenko 2021-04-04 7:45 ` [dpdk-dev] [PATCH v4 2/2] ethdev: update qfi definition Raslan Darawsheh 2021-04-06 16:09 ` Ferruh Yigit 2021-04-13 8:14 ` Raslan Darawsheh 2021-04-13 9:24 ` Ori Kam 2021-04-14 12:16 ` Ferruh Yigit 2021-04-15 6:33 ` Raslan Darawsheh 2021-04-29 8:10 ` [dpdk-dev] [PATCH v5 0/1] add new hdr for gtp qfi Raslan Darawsheh 2021-04-29 8:10 ` [dpdk-dev] [PATCH v5 1/1] ethdev: add new ext hdr for gtp psc Raslan Darawsheh 2021-05-11 11:46 ` Ferruh Yigit 2021-06-08 12:17 ` Andrew Rybchenko 2021-06-08 12:18 ` Andrew Rybchenko 2021-06-08 14:07 ` Raslan Darawsheh 2021-03-30 7:50 ` [dpdk-dev] [PATCH v2 2/2] ethdev: update qfi definition Raslan Darawsheh 2021-04-14 12:40 ` [dpdk-dev] [PATCH] " Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DM6PR12MB27489C20DEBED9CFC0DD6DBACF7E9@DM6PR12MB2748.namprd12.prod.outlook.com \ --to=rasland@nvidia.com \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=ivan.malov@oktetlabs.ru \ --cc=olivier.matz@6wind.com \ --cc=orika@nvidia.com \ --cc=shirik@nvidia.com \ --cc=stable@dpdk.org \ --cc=thomas@monjalon.net \ --cc=viacheslavo@nvidia.com \ --cc=ying.a.wang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git