From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39DEFA0C44; Mon, 12 Apr 2021 14:57:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E36D2141188; Mon, 12 Apr 2021 14:57:44 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2087.outbound.protection.outlook.com [40.107.220.87]) by mails.dpdk.org (Postfix) with ESMTP id D5F53141187 for ; Mon, 12 Apr 2021 14:57:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XXI3HDNye5DecRSwWNEzdHh4hJ3Ia3d1Sbr8jFGa1+jlGG/gvq6+iIjaSu8DhO3yHl/QFRl8K8Nrgl5CH85z//O/YmFdP7NW0O9ZNiNVaSqdFOPrCMOpOjKIshP2TeZkdZzUPT01xSXO3RPbXiOMSsGULOyor7HWTM5zfNdPXnGwSUvyxXfgH5pM7L5kSb5H39Fe/41YcoK24b7r68UYDOJWZNU9XoanWCYGaD/pWbuB0V49aygqzbamezXoIB/ujs8Lh4fXg1GkWT9cGTUn8ygsPFU8DGLxv2tLEEAwQTVmhgmG0iYFBLupJkAyJC3yFCyV28o5SICKCg2H5oZnsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gJYCDJxtLV0IrgiudrFsG/pRKzPBhlptNJhnrkxXsV8=; b=KTQfTUR5RAhqUsTv9mL5iM+jY2i9SqUzUwfc8KGKZVwlVzm1dRPq61TpREbecDAKAJfUaf2gs6X/Ha346qODxwUO220avqHWgFOYdmHgEPH6cmMGEEuftLszIFD+ohIyomHmz1iwcessR2BlI0g1ZuOVSa/QDTe6ZuJZNFlr8JiR2NHbIfqP1767itxr2TgsIHP8Fl/Aud9UcIk9qoRNVR8EhjPKaDTkuKrMBokE7EtsiIdkSCub+eBig7NG6sDS/dBe/HWCum6GMznlMFHKXb1TdHYlj7tvAhCrASJhvkaklmpUbJyc2AnVlJk5DekzbHYG00NRFs+uxMsDNsr+dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gJYCDJxtLV0IrgiudrFsG/pRKzPBhlptNJhnrkxXsV8=; b=PhLQ/KwGLJR75thG1JXnIu1QN3HIhWAM67FimESdQ/P890BFt6DORRHPPmMKHmU1Z9dfB59p8SveocDhPFuObScRQ4qrkuR8AnqmEKxWXbNM8DVXaLzgckVNP2qKW1+z3S8x0PnTySdBfKv5R0FcTwlmI9T25xpfM0gulC/Fb9SPSd2sH4fBpeRCuOM/GQKVw8fWBAl8niSBYrt8ov6N/sC2o8YdRFU2Rf/5KrtIr5aEgmhOtu868TryvYLMhGFaWvi/1eWoAw0m9dLwUnOvIE+SnG15n2FRfu+FU/m2ywYyib1RRyB1Ig/QYWWTNubvNfRHFT32He8fJ78Gil8o7g== Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR12MB1818.namprd12.prod.outlook.com (2603:10b6:3:114::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17; Mon, 12 Apr 2021 12:57:17 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::d011:3b55:aafb:9280]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::d011:3b55:aafb:9280%5]) with mapi id 15.20.4020.022; Mon, 12 Apr 2021 12:57:17 +0000 From: Raslan Darawsheh To: "Jiawei(Jonny) Wang" , Matan Azrad , Shahaf Shuler , Slava Ovsiienko , "Jiawei(Jonny) Wang" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix resource release issue for mirror flow Thread-Index: AQHXLTyT7RTlaEWCUEeVfREU1Uqpeqqw0Uww Date: Mon, 12 Apr 2021 12:57:16 +0000 Message-ID: References: <1617971608-89460-1-git-send-email-jiaweiw@nvidia.com> In-Reply-To: <1617971608-89460-1-git-send-email-jiaweiw@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.230.40] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 198e05c6-0b40-43bf-774b-08d8fdb2803e x-ms-traffictypediagnostic: DM5PR12MB1818: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Jawv5PUtbkhTMFZOT3IeZEBOBfrtPK39nnrOCTRXW2s0S7J/3jPzRNpoWWhABkuh6RetCA0ehg6/URb6doSD6lzRq3KWX6TX94WuJvYZ3hLPeo0UnYVrsCMnV1eHr+k/kQjGlk8GMPWYy1qVMyhw682d5VhvYHFd8J2YA/h/gtSKP/2NY14q+i5ToqtLMWnlTo5Etyn+D+uaf2QS6gbusK+9ryk7I4QLPjEl13qxaMZIuWCM/TxxTTjzaziMUF86iVuPkmLTxekmRnlZ0Q6j1ai0x0k5bq+DG5lmAx5lKLxeFWbfVOAKHLZNoJEgfR9IqxB2lwNJylcLssz98Mv5OnWGGURgCI0BAoiccydhecBGpEzbVUvF6+n6yxE3Sl7uDgIy+8udbskFotynVqPewhig7IWEjecEC6ICt3LmF5JZ3CfKhH5HtqjH+EQKhX7XIONEirMoyqJ20KdDrquGUahz3Ck0F+iXNM/YKgruQajvfCDWNPD8YxpK/qg4COcLXdhw+vUF9JHEZBrnqQKCGmejeBNEd4muo+dY9F044UQVPgdELexhFmN8ql0Gu9GRhZpa/AYZD/aak2l7E3Lq9VZqAC5jowxA6x6ScVkBLfo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(376002)(366004)(396003)(136003)(9686003)(450100002)(54906003)(52536014)(66556008)(66476007)(6506007)(55016002)(4326008)(66446008)(83380400001)(76116006)(186003)(2906002)(64756008)(6636002)(33656002)(110136005)(38100700002)(8936002)(7696005)(8676002)(5660300002)(86362001)(316002)(53546011)(71200400001)(26005)(66946007)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?P3J5OPo5x++Rp36nbQrh6TJ4Q7T4WhxzMPH6WbulsIhIk9ONnBNyc3+itcGn?= =?us-ascii?Q?ajoZ9e5UXona9ipuO9DETX7bGV4JLrJwv04eV2Sd98y36kMmqCvU7Bccpwys?= =?us-ascii?Q?/MnDDqW94QzRSU6P6LuKMUPxY6jRTSvoACWn76GKAM7+TdAwU2o8Sm0m9IG4?= =?us-ascii?Q?0wBATX8F7slMenxT4ORp/sQF73jd9CdTAUBJl9R+yk8KjWb1AV/HP65r/pbi?= =?us-ascii?Q?59cQybuGdU8sS0BhgEd5iDAxhBEjKdtscdArkAVbSUEL+G8jRbNULLlFwuMM?= =?us-ascii?Q?/iCF0/eHwq1+M1gtckqxC05t4z3m8E2rUfUiMpRJUcRpIcksGcKhJSkYCwcY?= =?us-ascii?Q?6ZrnrA+HIbUeq01tVleJnVg6i/AxkaEXKY0lQQ6aDQ6mcdrUJNfW0Qvlaa8b?= =?us-ascii?Q?fZWz5giv2aQVbjbFROs02aveYjAtGCXIE+gAg0F0lMNoz7GpLMBDSQBDbY6O?= =?us-ascii?Q?eSuZ8FbDhpkF9e3akeLWYUTJ5KmhvffqRNfdvxidRTA1FU+Kk1v29iID9AoO?= =?us-ascii?Q?xwNbK2PqpR5e3ymIgx0vNk2ByjfxSQ+Pg4cbUvIeNwO4Kdwdkalu1AxuSjJb?= =?us-ascii?Q?q6Opt4UswaVfwApFbQ9NsY+Xotagt3SmiDngj41ixps9id7b+igJTKunKaGx?= =?us-ascii?Q?ZeV/ZjGDF4SCPJ3aRRjkyCSsrlzIE4fm+MNfscDMWjwoZFmqpBW9xv1pcbUl?= =?us-ascii?Q?AodH3phVENgUsF21UWGQ270PFA1dx49FhUHYsf/WXxpokE47IC6l5K5mQ+bE?= =?us-ascii?Q?YGVRQJZPxxnc1hXzS+fTvLjCp0IAUbwEeDWu5XS0iC5IeTF+pc0e67BbkzD2?= =?us-ascii?Q?BiS9CXcXwGphM6FWBYJ55t7VPSEKC+hjrJKP70W9TfmW+c7lXnrRFC4Ym+iF?= =?us-ascii?Q?rbF9ajB+O6v4B57xxgwLuD9OcRjQOjwiuX7cRm7PpD8crgmg4d5AV7CQg/FY?= =?us-ascii?Q?Bi8y7ReONbS+Vl2a5987dFL8R67o0M1caWSac22M7P0utvcH4dC5k1tfCIbM?= =?us-ascii?Q?hUpZY8pT2QCw/cVhULx39C/zz3fgl7GWvOhJQdCclR2bK/Eq3NONtiPvuFCC?= =?us-ascii?Q?PZHfORxsfmLgHWEDp8bXOxlnuWL76RS5Vu/CiK/pH8QkdKe68s8x63g6CRL8?= =?us-ascii?Q?8FloNxILKW6kE8A2NCVODsnT+ikhxllxsy9aStIeqCrfEaNlEc4EBhkp9pwO?= =?us-ascii?Q?AxuV7dDVBDdsJ3Weke4qZPbF3Kqv9LPRDp1EdA49imPhSfQayJ/RqtHR/ZU7?= =?us-ascii?Q?gl7MxUxJvwIo+Li6WL6gPP4b/zd8pHdZ5gCFUqPRxp3zPXh0H/kx4cshXp73?= =?us-ascii?Q?TXYYT4+0VSZGW0tEm2iWP5yH?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 198e05c6-0b40-43bf-774b-08d8fdb2803e X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2021 12:57:16.8189 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4wltObn6ZMtwp5Cpsw9zUrXDWVfi0E2hjpwzQBjLBL5n7WF+b7+PocDXFf5DzjruXMyZsg6C5yW82XOops5aYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1818 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix resource release issue for mirror flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Jiawei Wang > Sent: Friday, April 9, 2021 3:33 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; > Jiawei(Jonny) Wang > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix resource release issue for mirr= or > flow >=20 > The mlx5 PMD allocated the resources of the sample actions, and then > moved these ones to the destination actions array. The original indices > were not cleared and the resources were referenced twice in the > flow object - as the fate actions and in the destination actions array. >=20 > This causes the failure on flow destroy because PMD tried to release the > same objects twice. >=20 > The patch clears the original indices, add the missed checking for zero > and eliminates multiple object releasing. >=20 > Fixes: 00c10c22118a ("net/mlx5: update translate function for mirroring") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jiawei Wang > Reviewed-by: Suanming Mou Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh