From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 583C4A04E6; Sun, 8 Nov 2020 10:11:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D3AA21E2B; Sun, 8 Nov 2020 10:11:13 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by dpdk.org (Postfix) with ESMTP id 6BDB8F90 for ; Sun, 8 Nov 2020 10:11:11 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sun, 08 Nov 2020 01:11:14 -0800 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 8 Nov 2020 09:11:09 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Sun, 8 Nov 2020 09:11:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gIrOFn7/3WVyMVkB5f30HRwEkkDtaPjMo30l0sC0kd7+Ezkyo8lB/Uc1J3PGvoZC64BdyTrzuzHcccbSCK3WKohip+1lJdhsLY+8R8iwXY6RfrYZDHlux0q8ZtmZLXyFlvoRaVqfLf73c+Np5WokWxEriwv8oXK4Bajdfuiir+rWb2cTq7FmzizhcAFJ+kMw1DctVQC76LZbng1SpZ2fjzYScsDdMkc11qnx6cd0BWZddfKepq9pI58XmVkhxkSU5eFLbpjzcSKa7CxGEI+3MsMXBw9EVYvNkM0HzDIxZ8nsMG8uPGtBuyJLkgRrsejXkrL8e/3n2isRKFZWog4JPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xkTV2zqyOxb6J33E5tg8Ww/IEzyuaemAUjESjHsYCGQ=; b=AS1jvZWvZAPog44siMcaIZJiQ8W7uJkPM97/w2basER4LaViZBjZ2fDBxZM8qasFA3n4AukKrxSYGC3U5LlF94QBxdSiPsp/W9MN1AGa0zFlbJEvjjajiTmOELsjxyasXxK10RhL1XiL8e8hOwOS0g2K7z7jmJnlFp3Dh0UNYutA71sEDGdlKz1YLV2MlqdNYaDpjG1GclHF3xPmMzAH6Cis+9CefgCTCK+TxYYE5duya7gmkz0NghWXw6mg8A59wmrcYWkLg30zLI3PAgCewtEVV1o5irhfCp1+qWssMgWyDnIJhpGmxmJ9wREb5kUEPo2Gp+31LqkF5Oeos/9hmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB4731.namprd12.prod.outlook.com (2603:10b6:5:35::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.29; Sun, 8 Nov 2020 09:11:07 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51%6]) with mapi id 15.20.3541.023; Sun, 8 Nov 2020 09:11:07 +0000 From: Raslan Darawsheh To: Dekel Peled , Slava Ovsiienko , Shahaf Shuler , Matan Azrad CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix aging queue doorbell ringing Thread-Index: AQHWsc2usUPe1XjelU6xuP6SJQEsAKm9+kEQ Date: Sun, 8 Nov 2020 09:11:07 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.229.165] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: acb96299-0977-408a-b279-08d883c63a5f x-ms-traffictypediagnostic: DM6PR12MB4731: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V9oiK4goUNv+swD1Kx6fWCm8hHrArDKK7SfXNoHf842RFzIu4p79SIugZL7VTle2I6gxQJaqKX+smt3OLyGt634AWMV7L0QFb3iKKmrrghx6Hx3jsCGYHg16OJq7vLtOSmJ9Ygmmm3DjilNqHnoIRSJe87lq7Dgu0fCoK/JEmzifBQxo54xlL4AUGPxkVqN700La8j07hgqJubscUkkM6gjPrUoMBedo90fRrnOw6cOE8QKrgTd/tLLzFbEpHqun3uUFt5hwdf8/GVqhjnyuxcwIQTqJYzsKQW+8bziR5e5DdXPwYqhBYCC1jKP2R67wSw4VHJsN8J5Xe84MH/gRgw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(376002)(346002)(39850400004)(366004)(53546011)(64756008)(76116006)(26005)(66946007)(6506007)(2906002)(86362001)(7696005)(110136005)(8676002)(33656002)(71200400001)(9686003)(66446008)(8936002)(55016002)(83380400001)(66476007)(316002)(5660300002)(186003)(52536014)(478600001)(6636002)(4326008)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: /+hFZTvbGyLVLd36AdMPPWN6rIPHu48beca0zpHEd4tjJI1iZ/k7y6IP9Zl1PE6l672iph4b9ElTHe10EN3bbUkhlzi3lz0QlDvImng9FXKrCWXjfF4ECwICUYc0skS5qRPHI2vG1xjtTT2TWlYRrPpso5knn7rag/b0YZKlXa3KDM9jcPt6mj8fc5DQFKsnvHGgnMH7p4uEUc/gSfbA0kMLiztgi60skwGkNtOdoyPl42iqh0LlUBcFp8TSmiXluhV1imNtq8D2Jjq9IZUbLnalypD4klep6Yax0ijZkcI6K+on7vBclmCyGNT8F8knOA7SQrCjIGMf6yWB9vuKjG5T7ss/rnTiBTUhOsiUyFJ+Xvt8sNJ7LkjWC0r0oULtCi7AC1hRfiz7i0jI5K0vQCpVy/XaYa4TxuWLC9FQQ5I5awCNZ4TDfOqq3xJUzdXV7mhfF/JdYEwIopkZekcuVTCqYUv5IgcuubVVS5ETYnhXLek3wbMi2swnAADRBTJLJqKGdKTcAx+7y14OjEvRTF892cha4O7BWH2Ed9yxYqeQpPwENt1bpZTdGFCT07CuqhDCqKl27rh3QXj1OpP7pxApD/JVX0Jku+US8fMTCA4pu2AyXWeeb6zxT6vQ5taFYNUHZOX9ehb2qQRhxQJQgQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: acb96299-0977-408a-b279-08d883c63a5f X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2020 09:11:07.5740 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BmyTOyk6ho+5dkIg0cjNOZpKFJC2DZgzW75iLukwy/Ks1v90xkSGi62zSuA+iUApF6zWvf3JBUEjOIYZvDqXQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4731 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604826674; bh=xkTV2zqyOxb6J33E5tg8Ww/IEzyuaemAUjESjHsYCGQ=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=J0oQ+87hn6onn1xMIlqk8/THw2kkFa816DsNSoxVtaxQ3m5I2GIuWlOex5hMD5/Y7 E1mxbnZjj4S/PjrDUkBkCL5jtbzcWlhiSaBBrSrVpehosRQnYVIcdtOkfzicQ2td8X mDvDWl+JZBoLukoxu6jca2vWpQXYMYAAfogslAypfsKrjMhGJQ7G59VaUedNlaUiVU D9yNYfXYrkgun1YzvkKXvenyU+3crLbc2L2SvgL7yL7BDPQlDQ/D+7w2DBLyknzvMH aibQZB9yKHMU0E1qhdh+pnXmMCPSFw4z7zWehnfSTuLDE8a0il2ByLVxEzydzUK4Fb KzfJayFqExhPw== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix aging queue doorbell ringing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Tuesday, November 3, 2020 12:38 PM > To: Slava Ovsiienko ; Shahaf Shuler > ; Matan Azrad > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix aging queue doorbell ringing >=20 > Recent patch introduced a new SQ for ASO flow hit management. > This SQ uses two WQEBB's for each WQE. > The SQ producer index is 16 bits wide. >=20 > The enqueue loop posts new WQEs to the ASO SQ, using WQE index for > the SQ management. > This 16 bits index multiplied by 2 was wrongly used also for SQ > doorbell ringing. > The multiplication caused the SW index overlapping to be out of sync > with the hardware index, causing it to get stuck. >=20 > This patch separates the WQE index management from the doorbell index > management. > So, for each WQE index incrementation by 1, the doorbell index is > incremented by 2. >=20 > Fixes: 18c88cf29c29 ("net/mlx5: support flow hit action for aging") >=20 > Signed-off-by: Dekel Peled > Acked-by: Matan Azrad > --- > drivers/common/mlx5/mlx5_prm.h | 21 +++++++++++++------ > drivers/net/mlx5/mlx5.h | 3 ++- > drivers/net/mlx5/mlx5_flow_age.c | 36 ++++++++++++++++++-------------- > 3 files changed, 37 insertions(+), 23 deletions(-) >=20 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh