Re: [dpdk-dev] [PATCH v4] net/mlx5: fix incorrect group value of sample suffix flow

[Raslan Darawsheh <rasland@nvidia.com>]

Hi,

> -----Original Message-----
> From: Jiawei Wang <jiaweiw@nvidia.com>
> Sent: Wednesday, November 4, 2020 3:30 PM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Ori Kam <orika@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: [PATCH v4] net/mlx5: fix incorrect group value of sample suffix flow
> 
> mlx5 PMD splited the sampling flow into prefix flow and suffix
> flow. On the sample action translation function, the scaled
> group value of suffix flow be attached into sample object and
> saved into sample resource.
> 
> mlx5 PMD fetched the group value from the sample resource to
> create the suffix flow. On the mlx5_flow_group_to_table
> function the group value of suffix flow was scaled with table
> factor again and translated into HW table. That caused the
> incorrect group value of sample suffix flow.
> 
> The fix introduces a 'skip_scale' flag and sets it to 1 for the
> sample suffix flow creation. On the mlx5_flow_group_to_table
> function skips the scale with table factor to use the correct
> group value.
> 
> Fixes: b0c8d823552a ("net/mlx5: implement tunnel offload")
> 
> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> v4:
> * Init the flow split data for each dev_flow
> * Rebase
> 
> v3:
> * Rebase
> 
> v2:
> * Update commit message
> * Rebase
> 
> ---
>  drivers/net/mlx5/mlx5_flow.c    | 159 ++++++++++++++++++------------------
> ----
>  drivers/net/mlx5/mlx5_flow.h    |  15 +++-
>  drivers/net/mlx5/mlx5_flow_dv.c |   2 +
>  drivers/net/mlx5/mlx5_rxq.c     |   2 +
>  4 files changed, 91 insertions(+), 87 deletions(-)
> 

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh