From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5EC31A04B5; Wed, 28 Oct 2020 23:01:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AF9725AA4; Wed, 28 Oct 2020 23:01:03 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by dpdk.org (Postfix) with ESMTP id AE5B75A8C for ; Wed, 28 Oct 2020 23:01:00 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 28 Oct 2020 15:01:05 -0700 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 28 Oct 2020 22:00:58 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 28 Oct 2020 22:00:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iq37ItJoZW72Vtxu6zep4dh2i683Zy56abX1a/swm/SA87jo3pQKRXaahkUGiqHjFO2W2StE9waua1Dy4negArIsCxcvTcN2XCpb37haCzrOq7bDjSVgZ7o45OlV5IdU8lYQx+2q+sPhHC+brh4nxmCZkMyzyl6ZvDa1pUS8+CxdLUCKD0/yrAqvJ6xzVR5nrWy4LYt9pW6ebiYQHQYNkjacv1Eek7xI+LoUTvyt7CApLzSE7z3CbZjfXLB4RUTtpfoE+VnhU7ncyYX6p904QiMBWmJXqI/ySF8i2gbBNykt0teUiqWuBLtvnORZ1wa8P0mhtIVUNapEKs9ls/pv+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LbTxsQJp29aEuob6pnSD1ufjSs5NS+YbdkBnnr0ZXGs=; b=kWCSDAOk+LjGWMu/hGLqTld3HskvM5kj5IXy6aIl1G7tYpGdHCYJlN36bhC0r6psTF1Z3QC+6pXFsMTLpzuKvbIcf9DVi3sVYObfQRSztW6LJRk/u6FBsKfhHEa6K6p9sAH1oaCRZa+YRiYD4rTCLPxPhwvbPqS4+X85ogjHHRZLb8ZbC8GKhTQE9r4IDu6YgLZfGl8Q7HYyNQn0z/HeMtZEVEpMEYVTgqJuu7MU2Xy6kTagLp5T6rYw901shiRugVuj+DLMVPIuT94gtL8UVxR7+TyV91v2BWUjycYUwdD518HcZxO5K6Og1HAVgu3UjxCvz+llRkO0cIrrMaB3jQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR1201MB0091.namprd12.prod.outlook.com (2603:10b6:4:57::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Wed, 28 Oct 2020 22:00:57 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb%7]) with mapi id 15.20.3477.028; Wed, 28 Oct 2020 22:00:57 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" Thread-Topic: [PATCH v3] net/mlx5: use C11 atomics in packet scheduling Thread-Index: AQHWrSgjByBKEPPsAkWr39KN8VT9JamtkSsA Date: Wed, 28 Oct 2020 22:00:57 +0000 Message-ID: References: <1603825399-29715-1-git-send-email-viacheslavo@nvidia.com> <1603889087-21760-1-git-send-email-viacheslavo@nvidia.com> In-Reply-To: <1603889087-21760-1-git-send-email-viacheslavo@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.229.126] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d5390532-2601-49bf-e210-08d87b8cf2cb x-ms-traffictypediagnostic: DM5PR1201MB0091: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rRVgd2x8I8tYcLxuL2JayayMhuqnqpq3Vk1EKsLLB+xPg3g71YO1gksbH66gP4eV4mQivE1q7jyQ9nSZcB/yUHp+SWcMXqnm3B08M3Kw37DyXyafdPqzzV8NckN9KqAS+15ATRY0FalhTeGPd00ZrNpEgePg8A0Jiwmq5YTvpXu7YtdHhqs4ygP+RcxTh4q4byiutO1wPGy8UczWM/sibpObYu25Zog6qv6VSS78+876qgrUMhc1TLJ+sbFGtALrGvSxWMxPhlr9QP0TOszgJ7LG29TwIOprUEY3xzT7vKKsRnD7kXGPcQ3t/MCY1AK5bQufnRIx3qv2BkTnt9yQDCYJ5hQqtvDXgQ/AmMMTJriY4jRqC3Qit+AAWekSEzSYsraIgeJBEYwmrSDNyfWj0A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(376002)(366004)(136003)(346002)(53546011)(8936002)(186003)(64756008)(66476007)(55016002)(76116006)(66556008)(66446008)(66946007)(86362001)(478600001)(7696005)(45080400002)(2906002)(30864003)(52536014)(33656002)(83380400001)(966005)(26005)(8676002)(6506007)(9686003)(316002)(71200400001)(5660300002)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: GUw9rE4jEhfxY7hTec+nZIQgEN9YGYxaD5UcyumxGpAlS95rzO6EaTPD+N1HXEZ+fPd1wS9UB6DdablMvMqv31nx7rZ3cWPj8MhR3Y7lqriyJh5GqAUJCSUMBco7ugAfyJ2YVkMWiGzUiWhWZ5AeSDyUE5EIT/SCa6yXkPj1SbAPzF2BCa4pFaUMJ3eIDGufQ59PqC93uqurB+ZFXajc+NnO75V59DNnrw3ituwnwsqmY6W9i7l1S+kGIUWwysG9dgkv5iba/4vLFAHNA0dE2nSE5Z3908Fnpi3PgvI8BgL4wDJGJ8MQlw8gZ1AexX96fy1khKDahonyu0TZ0D2IjOew3HMhE6rufLVwf1OzpXVpTzonCe6K+RSvMZW1AYTe5HESQnTP2yLpN2nsUiNcOuNR6KOTAkZUcDu4G2DQz8jH6HY78+NCTIRllmXFUoz5rZ7b0mQKZcAuSFYSGYUNj9GukOBb/9G5rPIW7h3a/6KUF8eqxIZ6tFC202p+rw4Po/96MW3i/5GjrQwpqpyTo/Mz1Z4eaOUKkC0zZ4Yh3quPoby48sLwUuOnaEhL5kZibdwnepR7lcl+eEVB1YQmXVUfwGepzIBkSEuDGMZw7O0iMwidiG8bjgaUxJgpfLGiQ3YfNTyZY/bisebGaUYyoA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5390532-2601-49bf-e210-08d87b8cf2cb X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2020 22:00:57.1051 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +aqNZdVW/1DmKfNNKMNvdK1/934EqZ3eM/R5e6kdKJn11uCTLD8KWL1kJ2Vz+gRtCTjuAebpAEg164oXhwXm4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0091 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603922465; bh=LbTxsQJp29aEuob6pnSD1ufjSs5NS+YbdkBnnr0ZXGs=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=KbDsolnoZthI9Do+gN7iWf88Klx56aQq3ElCOwQfAXskYprNY8CS3Mi+M99cw20BD D/3SMYtWX//K45oOS2eSURK7LzCvtOUYDBcFKvZeGjM9qwnNDBPBNSdNEfJquaoOaU OpzAxwXxqvP5vKN0hPwYrhTrKlQEtk8AntJLRCnma811dg3p30VvURScmk7uSOCjM1 V3M9tyL+pLp41bSLfYAKCzTeqV0SoAk3EEUYmG/PhUF6kjMi61ct3hOO0F46gUUEMA /heIXa8TbZQA2VMaKy2/6pAnOxfDdf+EDDpT7vVa+87t601mPWwVi+u/4buMsYHs+t WAe7iJvC/1VmQ== Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: use C11 atomics in packet scheduling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Wednesday, October 28, 2020 2:45 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh > Subject: [PATCH v3] net/mlx5: use C11 atomics in packet scheduling >=20 > The rte_atomic API is deprecated and needs to be replaced with > C11 atomic builtins. Use the relaxed ordering and explicit > memory barrier for Clock Queue and timestamps synchronization. >=20 > Signed-off-by: Viacheslav Ovsiienko > --- > v1: > https://nam11.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fpatch > es.dpdk.org%2Fpatch%2F82362%2F&data=3D02%7C01%7Crasland%40nvid > ia.com%7C1cb693934b224c739c1208d87b3f458d%7C43083d15727340c1b7db3 > 9efd9ccc17a%7C0%7C0%7C637394858963308699&sdata=3DfKfJ%2FCcmrV > MIBJrWNb2YDVYUysbxbdXEGPBPB1Bi64Y%3D&reserved=3D0 > v2: > https://nam11.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fpatch > es.dpdk.org%2Fpatch%2F82612%2F&data=3D02%7C01%7Crasland%40nvid > ia.com%7C1cb693934b224c739c1208d87b3f458d%7C43083d15727340c1b7db3 > 9efd9ccc17a%7C0%7C0%7C637394858963308699&sdata=3DHMJWvjT%2Bc > AYrQeJ%2BrNfka9Id%2FVmIuzQX%2BF%2BHH2ndKUI%3D&reserved=3D0 > fixed the issue of missing __atomic_compare_exchange_16, > replaced with local copy of existing DPDK implementation > of rte_atomic12_compare_exchange being deprecated > v3: minor compilation and codestyle issues >=20 > drivers/net/mlx5/mlx5.h | 14 ++--- > drivers/net/mlx5/mlx5_rxtx.h | 11 ++-- > drivers/net/mlx5/mlx5_txpp.c | 136 ++++++++++++++++++++++++++++---- > ----------- > 3 files changed, 102 insertions(+), 59 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h > index 8de5842..570cc2b 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -563,8 +563,8 @@ struct mlx5_txpp_wq { >=20 > /* Tx packet pacing internal timestamp. */ > struct mlx5_txpp_ts { > - rte_atomic64_t ci_ts; > - rte_atomic64_t ts; > + uint64_t ci_ts; > + uint64_t ts; > }; >=20 > /* Tx packet pacing structure. */ > @@ -587,11 +587,11 @@ struct mlx5_dev_txpp { > struct mlx5_txpp_ts ts; /* Cached completion id/timestamp. */ > uint32_t sync_lost:1; /* ci/timestamp synchronization lost. */ > /* Statistics counters. */ > - rte_atomic32_t err_miss_int; /* Missed service interrupt. */ > - rte_atomic32_t err_rearm_queue; /* Rearm Queue errors. */ > - rte_atomic32_t err_clock_queue; /* Clock Queue errors. */ > - rte_atomic32_t err_ts_past; /* Timestamp in the past. */ > - rte_atomic32_t err_ts_future; /* Timestamp in the distant future. */ > + uint64_t err_miss_int; /* Missed service interrupt. */ > + uint64_t err_rearm_queue; /* Rearm Queue errors. */ > + uint64_t err_clock_queue; /* Clock Queue errors. */ > + uint64_t err_ts_past; /* Timestamp in the past. */ > + uint64_t err_ts_future; /* Timestamp in the distant future. */ > }; >=20 > /* Supported flex parser profile ID. */ > diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h > index 1b5fba4..84eaef7 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.h > +++ b/drivers/net/mlx5/mlx5_rxtx.h > @@ -14,7 +14,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -677,8 +676,8 @@ int mlx5_dma_unmap(struct rte_pci_device *pdev, > void *addr, uint64_t iova, > * the service thread, data should be re-read. > */ > rte_compiler_barrier(); > - ci =3D rte_atomic64_read(&sh->txpp.ts.ci_ts); > - ts =3D rte_atomic64_read(&sh->txpp.ts.ts); > + ci =3D __atomic_load_n(&sh->txpp.ts.ci_ts, > __ATOMIC_RELAXED); > + ts =3D __atomic_load_n(&sh->txpp.ts.ts, > __ATOMIC_RELAXED); > rte_compiler_barrier(); > if (!((ts ^ ci) << (64 - MLX5_CQ_INDEX_WIDTH))) > break; > @@ -688,7 +687,8 @@ int mlx5_dma_unmap(struct rte_pci_device *pdev, > void *addr, uint64_t iova, > mts -=3D ts; > if (unlikely(mts >=3D UINT64_MAX / 2)) { > /* We have negative integer, mts is in the past. */ > - rte_atomic32_inc(&sh->txpp.err_ts_past); > + __atomic_fetch_add(&sh->txpp.err_ts_past, > + 1, __ATOMIC_RELAXED); > return -1; > } > tick =3D sh->txpp.tick; > @@ -697,7 +697,8 @@ int mlx5_dma_unmap(struct rte_pci_device *pdev, > void *addr, uint64_t iova, > mts =3D (mts + tick - 1) / tick; > if (unlikely(mts >=3D (1 << MLX5_CQ_INDEX_WIDTH) / 2 - 1)) { > /* We have mts is too distant future. */ > - rte_atomic32_inc(&sh->txpp.err_ts_future); > + __atomic_fetch_add(&sh->txpp.err_ts_future, > + 1, __ATOMIC_RELAXED); > return -1; > } > mts <<=3D 64 - MLX5_CQ_INDEX_WIDTH; > diff --git a/drivers/net/mlx5/mlx5_txpp.c b/drivers/net/mlx5/mlx5_txpp.c > index 37355fa..8aad92f 100644 > --- a/drivers/net/mlx5/mlx5_txpp.c > +++ b/drivers/net/mlx5/mlx5_txpp.c > @@ -642,6 +642,32 @@ > aq->arm_sn++; > } >=20 > +#if defined(RTE_ARCH_X86_64) > +static inline int > +mlx5_atomic128_compare_exchange(rte_int128_t *dst, > + rte_int128_t *exp, > + const rte_int128_t *src) > +{ > + uint8_t res; > + > + asm volatile (MPLOCKED > + "cmpxchg16b %[dst];" > + " sete %[res]" > + : [dst] "=3Dm" (dst->val[0]), > + "=3Da" (exp->val[0]), > + "=3Dd" (exp->val[1]), > + [res] "=3Dr" (res) > + : "b" (src->val[0]), > + "c" (src->val[1]), > + "a" (exp->val[0]), > + "d" (exp->val[1]), > + "m" (dst->val[0]) > + : "memory"); > + > + return res; > +} > +#endif > + > static inline void > mlx5_atomic_read_cqe(rte_int128_t *from, rte_int128_t *ts) > { > @@ -650,31 +676,33 @@ > * update by hardware with soecified rate. We have to > * read timestump and WQE completion index atomically. > */ > -#if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_ARM64) > +#if defined(RTE_ARCH_X86_64) > rte_int128_t src; >=20 > memset(&src, 0, sizeof(src)); > *ts =3D src; > /* if (*from =3D=3D *ts) *from =3D *src else *ts =3D *from; */ > - rte_atomic128_cmp_exchange(from, ts, &src, 0, > - __ATOMIC_RELAXED, > __ATOMIC_RELAXED); > + mlx5_atomic128_compare_exchange(from, ts, &src); > #else > - rte_atomic64_t *cqe =3D (rte_atomic64_t *)from; > + uint64_t *cqe =3D (uint64_t *)from; >=20 > - /* Power architecture does not support 16B compare-and-swap. */ > + /* > + * Power architecture does not support 16B compare-and-swap. > + * ARM implements it in software, code below is more relevant. > + */ > for (;;) { > - int64_t tm, op; > - int64_t *ps; > + uint64_t tm, op; > + uint64_t *ps; >=20 > rte_compiler_barrier(); > - tm =3D rte_atomic64_read(cqe + 0); > - op =3D rte_atomic64_read(cqe + 1); > + tm =3D __atomic_load_n(cqe + 0, __ATOMIC_RELAXED); > + op =3D __atomic_load_n(cqe + 1, __ATOMIC_RELAXED); > rte_compiler_barrier(); > - if (tm !=3D rte_atomic64_read(cqe + 0)) > + if (tm !=3D __atomic_load_n(cqe + 0, __ATOMIC_RELAXED)) > continue; > - if (op !=3D rte_atomic64_read(cqe + 1)) > + if (op !=3D __atomic_load_n(cqe + 1, __ATOMIC_RELAXED)) > continue; > - ps =3D (int64_t *)ts; > + ps =3D (uint64_t *)ts; > ps[0] =3D tm; > ps[1] =3D op; > return; > @@ -690,8 +718,8 @@ > ci =3D ci << (64 - MLX5_CQ_INDEX_WIDTH); > ci |=3D (ts << MLX5_CQ_INDEX_WIDTH) >> MLX5_CQ_INDEX_WIDTH; > rte_compiler_barrier(); > - rte_atomic64_set(&sh->txpp.ts.ts, ts); > - rte_atomic64_set(&sh->txpp.ts.ci_ts, ci); > + __atomic_store_n(&sh->txpp.ts.ts, ts, __ATOMIC_RELAXED); > + __atomic_store_n(&sh->txpp.ts.ci_ts, ci, __ATOMIC_RELAXED); > rte_wmb(); > } >=20 > @@ -713,7 +741,8 @@ > mlx5_atomic_read_cqe((rte_int128_t *)&cqe->timestamp, > &to.u128); > if (to.cts.op_own >> 4) { > DRV_LOG(DEBUG, "Clock Queue error sync lost."); > - rte_atomic32_inc(&sh->txpp.err_clock_queue); > + __atomic_fetch_add(&sh->txpp.err_clock_queue, > + 1, __ATOMIC_RELAXED); > sh->txpp.sync_lost =3D 1; > return; > } > @@ -758,7 +787,10 @@ > if (!sh->txpp.clock_queue.sq_ci && !sh->txpp.ts_n) > return; > MLX5_ASSERT(sh->txpp.ts_p < MLX5_TXPP_REARM_SQ_SIZE); > - sh->txpp.tsa[sh->txpp.ts_p] =3D sh->txpp.ts; > + __atomic_store_n(&sh->txpp.tsa[sh->txpp.ts_p].ts, > + sh->txpp.ts.ts, __ATOMIC_RELAXED); > + __atomic_store_n(&sh->txpp.tsa[sh->txpp.ts_p].ci_ts, > + sh->txpp.ts.ci_ts, __ATOMIC_RELAXED); > if (++sh->txpp.ts_p >=3D MLX5_TXPP_REARM_SQ_SIZE) > sh->txpp.ts_p =3D 0; > if (sh->txpp.ts_n < MLX5_TXPP_REARM_SQ_SIZE) > @@ -799,7 +831,8 @@ > /* Check whether we have missed interrupts. */ > if (cq_ci - wq->cq_ci !=3D 1) { > DRV_LOG(DEBUG, "Rearm Queue missed > interrupt."); > - rte_atomic32_inc(&sh->txpp.err_miss_int); > + __atomic_fetch_add(&sh->txpp.err_miss_int, > + 1, __ATOMIC_RELAXED); > /* Check sync lost on wqe index. */ > if (cq_ci - wq->cq_ci >=3D > (((1UL << MLX5_WQ_INDEX_WIDTH) / > @@ -814,7 +847,8 @@ > /* Fire new requests to Rearm Queue. */ > if (error) { > DRV_LOG(DEBUG, "Rearm Queue error sync lost."); > - rte_atomic32_inc(&sh->txpp.err_rearm_queue); > + __atomic_fetch_add(&sh->txpp.err_rearm_queue, > + 1, __ATOMIC_RELAXED); > sh->txpp.sync_lost =3D 1; > } > } > @@ -877,11 +911,11 @@ > int ret; > int fd; >=20 > - rte_atomic32_set(&sh->txpp.err_miss_int, 0); > - rte_atomic32_set(&sh->txpp.err_rearm_queue, 0); > - rte_atomic32_set(&sh->txpp.err_clock_queue, 0); > - rte_atomic32_set(&sh->txpp.err_ts_past, 0); > - rte_atomic32_set(&sh->txpp.err_ts_future, 0); > + sh->txpp.err_miss_int =3D 0; > + sh->txpp.err_rearm_queue =3D 0; > + sh->txpp.err_clock_queue =3D 0; > + sh->txpp.err_ts_past =3D 0; > + sh->txpp.err_ts_future =3D 0; > /* Attach interrupt handler to process Rearm Queue completions. */ > fd =3D mlx5_os_get_devx_channel_fd(sh->txpp.echan); > ret =3D mlx5_os_set_nonblock_channel_fd(fd); > @@ -1116,7 +1150,8 @@ > mlx5_atomic_read_cqe((rte_int128_t *)&cqe->timestamp, > &to.u128); > if (to.cts.op_own >> 4) { > DRV_LOG(DEBUG, "Clock Queue error sync lost."); > - rte_atomic32_inc(&sh->txpp.err_clock_queue); > + __atomic_fetch_add(&sh->txpp.err_clock_queue, > + 1, __ATOMIC_RELAXED); > sh->txpp.sync_lost =3D 1; > return -EIO; > } > @@ -1147,11 +1182,11 @@ int mlx5_txpp_xstats_reset(struct rte_eth_dev > *dev) > struct mlx5_priv *priv =3D dev->data->dev_private; > struct mlx5_dev_ctx_shared *sh =3D priv->sh; >=20 > - rte_atomic32_set(&sh->txpp.err_miss_int, 0); > - rte_atomic32_set(&sh->txpp.err_rearm_queue, 0); > - rte_atomic32_set(&sh->txpp.err_clock_queue, 0); > - rte_atomic32_set(&sh->txpp.err_ts_past, 0); > - rte_atomic32_set(&sh->txpp.err_ts_future, 0); > + __atomic_store_n(&sh->txpp.err_miss_int, 0, > __ATOMIC_RELAXED); > + __atomic_store_n(&sh->txpp.err_rearm_queue, 0, > __ATOMIC_RELAXED); > + __atomic_store_n(&sh->txpp.err_clock_queue, 0, > __ATOMIC_RELAXED); > + __atomic_store_n(&sh->txpp.err_ts_past, 0, __ATOMIC_RELAXED); > + __atomic_store_n(&sh->txpp.err_ts_future, 0, > __ATOMIC_RELAXED); > return 0; > } >=20 > @@ -1196,19 +1231,21 @@ int mlx5_txpp_xstats_get_names(struct > rte_eth_dev *dev __rte_unused, > struct mlx5_txpp_ts *tsa, uint16_t idx) > { > do { > - int64_t ts, ci; > + uint64_t ts, ci; >=20 > - ts =3D rte_atomic64_read(&txpp->tsa[idx].ts); > - ci =3D rte_atomic64_read(&txpp->tsa[idx].ci_ts); > + ts =3D __atomic_load_n(&txpp->tsa[idx].ts, > __ATOMIC_RELAXED); > + ci =3D __atomic_load_n(&txpp->tsa[idx].ci_ts, > __ATOMIC_RELAXED); > rte_compiler_barrier(); > if ((ci ^ ts) << MLX5_CQ_INDEX_WIDTH !=3D 0) > continue; > - if (rte_atomic64_read(&txpp->tsa[idx].ts) !=3D ts) > + if (__atomic_load_n(&txpp->tsa[idx].ts, > + __ATOMIC_RELAXED) !=3D ts) > continue; > - if (rte_atomic64_read(&txpp->tsa[idx].ci_ts) !=3D ci) > + if (__atomic_load_n(&txpp->tsa[idx].ci_ts, > + __ATOMIC_RELAXED) !=3D ci) > continue; > - rte_atomic64_set(&tsa->ts, ts); > - rte_atomic64_set(&tsa->ci_ts, ci); > + tsa->ts =3D ts; > + tsa->ci_ts =3D ci; > return; > } while (true); > } > @@ -1244,9 +1281,9 @@ int mlx5_txpp_xstats_get_names(struct > rte_eth_dev *dev __rte_unused, > rte_compiler_barrier(); > } while (ts_p !=3D txpp->ts_p); > /* We have two neighbor reports, calculate the jitter. */ > - dts =3D rte_atomic64_read(&tsa1.ts) - rte_atomic64_read(&tsa0.ts); > - dci =3D (rte_atomic64_read(&tsa1.ci_ts) >> (64 - > MLX5_CQ_INDEX_WIDTH)) - > - (rte_atomic64_read(&tsa0.ci_ts) >> (64 - > MLX5_CQ_INDEX_WIDTH)); > + dts =3D tsa1.ts - tsa0.ts; > + dci =3D (tsa1.ci_ts >> (64 - MLX5_CQ_INDEX_WIDTH)) - > + (tsa0.ci_ts >> (64 - MLX5_CQ_INDEX_WIDTH)); > if (dci < 0) > dci +=3D 1 << MLX5_CQ_INDEX_WIDTH; > dci *=3D txpp->tick; > @@ -1284,9 +1321,9 @@ int mlx5_txpp_xstats_get_names(struct > rte_eth_dev *dev __rte_unused, > rte_compiler_barrier(); > } while (ts_p !=3D txpp->ts_p); > /* We have two neighbor reports, calculate the jitter. */ > - dts =3D rte_atomic64_read(&tsa1.ts) - rte_atomic64_read(&tsa0.ts); > - dci =3D (rte_atomic64_read(&tsa1.ci_ts) >> (64 - > MLX5_CQ_INDEX_WIDTH)) - > - (rte_atomic64_read(&tsa0.ci_ts) >> (64 - > MLX5_CQ_INDEX_WIDTH)); > + dts =3D tsa1.ts - tsa0.ts; > + dci =3D (tsa1.ci_ts >> (64 - MLX5_CQ_INDEX_WIDTH)) - > + (tsa0.ci_ts >> (64 - MLX5_CQ_INDEX_WIDTH)); > dci +=3D 1 << MLX5_CQ_INDEX_WIDTH; > dci *=3D txpp->tick; > return (dts > dci) ? dts - dci : dci - dts; > @@ -1325,15 +1362,20 @@ int mlx5_txpp_xstats_get_names(struct > rte_eth_dev *dev __rte_unused, > for (i =3D 0; i < n_txpp; ++i) > stats[n_used + i].id =3D n_used + i; > stats[n_used + 0].value =3D > - rte_atomic32_read(&sh->txpp.err_miss_int); > + __atomic_load_n(&sh->txpp.err_miss_int, > + __ATOMIC_RELAXED); > stats[n_used + 1].value =3D > - rte_atomic32_read(&sh- > >txpp.err_rearm_queue); > + __atomic_load_n(&sh- > >txpp.err_rearm_queue, > + __ATOMIC_RELAXED); > stats[n_used + 2].value =3D > - rte_atomic32_read(&sh- > >txpp.err_clock_queue); > + __atomic_load_n(&sh- > >txpp.err_clock_queue, > + __ATOMIC_RELAXED); > stats[n_used + 3].value =3D > - rte_atomic32_read(&sh->txpp.err_ts_past); > + __atomic_load_n(&sh->txpp.err_ts_past, > + __ATOMIC_RELAXED); > stats[n_used + 4].value =3D > - rte_atomic32_read(&sh- > >txpp.err_ts_future); > + __atomic_load_n(&sh->txpp.err_ts_future, > + __ATOMIC_RELAXED); > stats[n_used + 5].value =3D mlx5_txpp_xstats_jitter(&sh- > >txpp); > stats[n_used + 6].value =3D mlx5_txpp_xstats_wander(&sh- > >txpp); > stats[n_used + 7].value =3D sh->txpp.sync_lost; > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh