From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6F7AA0A0E; Wed, 28 Apr 2021 11:15:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9F51411AD; Wed, 28 Apr 2021 11:15:45 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2051.outbound.protection.outlook.com [40.107.92.51]) by mails.dpdk.org (Postfix) with ESMTP id 239C740147; Wed, 28 Apr 2021 11:15:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a9E+B1T1V/SfRMbY9dwKE3YeRnyPssi/fTnZfOyuVByQOsPbQy+KL1GHNyKEBibC55QZrGFXf3kUuwRYTyPBlBhUST45i83BIBn2cJatoWOUkXx1tiEyqJPgDMaabwdz0/dAjLh5gH5FoEabIJ4C/sqh6V598eWfuj7mtHvXpTCCpkEc6RECFWjLJhoAq4Pyt1+CGNvEdOx+S27GFSOUPhg3FbzCKSTi0Hc66/zcn1cm1D4Z2wWFiX00HgJ4zwscE1JMZJ9n6urQhWJ2pqhm2JGb/qdHZy9fRiB70ZVqKRwZXUC50tdWJoyRDxeAFHpcmUFr9HR7vOVSuIKYP+eFmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hNHgtmSo8s0u/hiO7U+c6eK6+R5TMRRKyefQaY69dEc=; b=O+5eSwPLTgBBHUFVJme8KNjZjsDNyvBm0kM+VOXN792JJQl/CZ1CbaQFJQsZKAN/bFRMYgmWbPE8zLy2ZR/EOrZNpcJIE+lQ5qO2a25/MKcAh7heRYFtApH4rgdPYiI4AGVPgZrwW9qBZSMwXl1Sp42kD6dpqbTSDe8Rhv00tbOftWlSzEv8AHf49REOEKv/8a4heCVF71j4Zs2O78pTre3SMe/qM5nHNT7w1W1kvmHQzORbpWnHtKbhrLGJINYRHZ+0+/WP1/9Z5QYefKRb68YSv3mrkHsou/nyHlho7OVg1ekNK0a0D4Lf1/zQOGPRbnGDNHfG+OyzyjRmSd7eTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hNHgtmSo8s0u/hiO7U+c6eK6+R5TMRRKyefQaY69dEc=; b=Y3jALvah+g5CQTcB5abeXo4rFiTaXdQABoHck/eZajytDhfAHSfP0ZDx3bosMkmM2od7JjnQuijgVPmMPSDHkf+L1D/No/FluE4Ngy5rarY3TTboH005Y3L+0yyoWhdEvDvZu70wOU+S9PLsD1rXKEvpdlMQKZYutrOfuPhizAaV2cVO2p2H15S/qGSi7xkx29CEOcFKgbE5JOqDMJsbRVeFO1LEGhkAnOIntVaQIG3dQjgwKzOhvGHGph7ThBI5eXSk+Lb6fnTJRvFMV4mFMStKya+FoXrkRMeoI9Hz1UO34298NxZzS69+0GXFPgC2FGkTSWuBRxAMrIbcv7jL/w== Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB4026.namprd12.prod.outlook.com (2603:10b6:5:1cc::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.23; Wed, 28 Apr 2021 09:15:43 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::d011:3b55:aafb:9280]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::d011:3b55:aafb:9280%5]) with mapi id 15.20.4042.030; Wed, 28 Apr 2021 09:15:43 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: "stable@dpdk.org" , Matan Azrad , Ori Kam Thread-Topic: [PATCH] net/mlx4: fix buffer leakage on device close Thread-Index: AQHXM60bCQzzOb2K6UGMzo6A7vO9EKrJtrXA Date: Wed, 28 Apr 2021 09:15:42 +0000 Message-ID: References: <20210417171414.6117-1-viacheslavo@nvidia.com> In-Reply-To: <20210417171414.6117-1-viacheslavo@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.229.85] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2e0479d0-62f8-4f72-9f06-08d90a263323 x-ms-traffictypediagnostic: DM6PR12MB4026: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a9tdnWf4LDY5KvTsZK7dyyJrGiemcHcm5tFtvUBMshGHc9vPJg970Xs3r3x0Y0H9MLBNuCocLuTUUMWDt/hd1pnq4ZR/3aV6CXaj7SkZjEh5XaSCsmRTtXKMVSmXFOLF60FRRKzIqtRn3aaswMjNFWGq9p/RNhMx01EnHwDC8E2cLFRdUdMqohqKhPYdzFyldR9//o7hAUWl1h5dtz8FZk7l9FAkF8DP7vZt/8TkVCmAntiyd+YUOSPTekjcpA9W0aKCx8E+ei4ehF2FlESVbtfrvqk1T286TCFqQyowLM5JNE8DppxdaKiKtUNxzCc6S162ut++KcOkwRpDdb5jffjmCNx+PKB9rzuFcNr7HEll5vwKpyUp1XnMZ829Wp/iYtwuQdhxK0zakZc/tmtLalQYY8u3Ie5AYwQ8PrkRcolddRpe4NQOA6MISFlYiKkxtb9wlioEqZWgFPQj/QvS3h1NzTR4uOCdvgZXZgTiyXLTndOm+ZHAKLHgf+ILmYuVQ9Ll1a5cwJqxodasxA/4eAGQRCRSB6308+g962hzOswTzhILBylbgqvqrp1m4A2nbElNOSEUmVOxCBDbL5UgA8t+sdzPbiqGXQfwnZNamuQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(39860400002)(346002)(396003)(136003)(316002)(186003)(107886003)(7696005)(66446008)(450100002)(478600001)(33656002)(2906002)(86362001)(64756008)(122000001)(4744005)(9686003)(53546011)(55016002)(76116006)(38100700002)(26005)(4326008)(5660300002)(66946007)(6506007)(8676002)(8936002)(54906003)(66556008)(66476007)(52536014)(83380400001)(110136005)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?5ioriPPM8P6arhPHwgziTVOTCX2wRMohcx7WTQS1ngsLsk/SAcMVsa2A0E3I?= =?us-ascii?Q?Zcgrx0t0TnIVVcgvdn4XBvdMDSSn0Fj6PE/3Y76mRWs17LhC6KbDM0zq1Div?= =?us-ascii?Q?p/Yjin6Zaol44eLMmh7mpZEBjfuJzXrNGD1AYuvj9iM/jC4rKusFcBKXEXzU?= =?us-ascii?Q?wH5o8L3yNsgCqLntawghTj4nzIBwTy4F82u7RyyuXoHvWZDD69cQKdBdGoC/?= =?us-ascii?Q?2h/gtwi3f/2ynNuPFOBlC8dw+c8eCdJi5hKpDuBGdJUkoukr5WbraiaeYOpE?= =?us-ascii?Q?2INkrLZMAR8Y5lt8DvIamfJlF5hQAc6yw4DGSN3hviD8muPTNAoPImhstPcp?= =?us-ascii?Q?nBBxkeYbq6c5gPAo4I0Pi6FBps2OTDRu6Hq7nrBJ+QjjvBOnyT4tKQsYZANe?= =?us-ascii?Q?gwrJuVg3zJ7rWeSLvOntfBy4+I4CnMFMIsuwF43j2uRbNCBeYpuWzOyurot8?= =?us-ascii?Q?8cJkV8lS+REXACzGa/4JxttRjK1mhOOmNy9d7SBy+EcG+dzyhB/fYu0uzS4P?= =?us-ascii?Q?y7uyhD6QLbZ6vaiGzJExCwyfVH6s1li32Y2Q275JnUwkM+R9xONQDaO08Z0/?= =?us-ascii?Q?dZlfvKFhhN5PWyBCou5shmY0mH8Vzpw47daE+OovXg382C0+YWOFzm6hM1T3?= =?us-ascii?Q?5VhpBKHpPoPz5871tn/X+5cYo66fDvbtSmA/IqGWP+xD/0oqLLubqYtucAEm?= =?us-ascii?Q?GFS1Tep3FN+kq0JMxgGU7pyFwNfv4oJH68ag7y4pmH4/r0mImRtSNt+uYTSB?= =?us-ascii?Q?wMFO9UAsm1lErEsE9vp+KovQguT+u2cqj2TBlAQcPZA+Mu5jfvlIzoF5oieS?= =?us-ascii?Q?2EzY+HIzMaLvsM8ZReD+ZEvdau8+4pD4Q/ulCnW72uWgaUFTOrurWhh/NceT?= =?us-ascii?Q?tfJJlxFpmnJS8nGGXQKJTrwI71uQsgjFaX0tvPp4P/wjMnCtW0vup+V7tEZw?= =?us-ascii?Q?XMnKczNd8Psl36F+PdtN4e6rl391h4mHF68vHSGrFTqsV6FmO+xIG93vNq1I?= =?us-ascii?Q?PBbF/yixFNDrC8cGasisSoNw6ZXd6OfXMrX8JPi8A4U1BBsO73DrJ5EM5NZx?= =?us-ascii?Q?k8ZLxYgemwzwTobPSFN2bsGjn68ZeTk6hblFa5BSQvd/qD6jUb7kQLHnf3vh?= =?us-ascii?Q?RrcQUNmIfyCBVuapTX8+l1Y12fVvFCDAVYp7q0lKJOpaO/f6LJXSRXRiiM1S?= =?us-ascii?Q?4Rq88G/BsYTtTgfd/5BbGSX/FhT0UmJyeaXFDngfvkw4eR3ZeUbm1WKU5tA/?= =?us-ascii?Q?SOoLhyWyu+yNR9vJNXFNrz23Z5mpmmr01RXl+zGGG+PbvyIWATJwbd0HHU/f?= =?us-ascii?Q?Z7cDGOU9kybnGvazeA4aQb0r?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e0479d0-62f8-4f72-9f06-08d90a263323 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2021 09:15:43.0414 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FfHpO2dbA77C0jvMjmYJh5v2hwUV9natnzORilx0ObsQ8muh0lyKtR7FSHummdu2BYn7VCbHF/17zCEhghmewQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4026 Subject: Re: [dpdk-dev] [PATCH] net/mlx4: fix buffer leakage on device close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Saturday, April 17, 2021 8:14 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Raslan Darawsheh ; Matan > Azrad ; Ori Kam > Subject: [PATCH] net/mlx4: fix buffer leakage on device close >=20 > The mlx4 PMD tracks the buffers (mbufs) for the packets being transmitted > in the dedicated array named as "elts". The tx_burst routine frees the mb= ufs > from this array once it needs to rearm the hardware descriptor and store = the > new mbuf, so it looks like as replacement mbuf pointer in the elts array. >=20 > On the device stop mlx4 PMD freed only the part of elts according tail an= d > head pointers, leaking the rest of buffers, remained in the elts array. >=20 > Fixes: a2ce2121c01c ("net/mlx4: separate Tx configuration functions") > Cc: stable@dpdk.org >=20 > Signed-off-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh