Re: [dpdk-dev] [PATCH v4 10/14] net/mlx5: initialize the flow meter ASO SQ

[Raslan Darawsheh <rasland@nvidia.com>]

Hi Li,

> -----Original Message-----
> From: Li Zhang <lizh@nvidia.com>
> Sent: Wednesday, April 14, 2021 5:58 AM
> To: dekelp@nvidia.com; Ori Kam <orika@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Shahaf
> Shuler <shahafs@nvidia.com>
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon
> <thomas@monjalon.net>; Raslan Darawsheh <rasland@nvidia.com>; Roni
> Bar Yanai <roniba@nvidia.com>
> Subject: [PATCH v4 10/14] net/mlx5: initialize the flow meter ASO SQ
> 
> Initialize the flow meter ASO SQ WQEs with
> all the constant data that should not be updated
> per enqueue operation.
> 
> Signed-off-by: Li Zhang <lizh@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>  drivers/net/mlx5/linux/mlx5_os.c              | 17 ++++
>  drivers/net/mlx5/meson.build                  |  2 +-
>  drivers/net/mlx5/mlx5.c                       | 68 ++++++++++++-
>  drivers/net/mlx5/mlx5.h                       | 22 +++--
>  drivers/net/mlx5/mlx5_flow.h                  |  4 +-
>  .../mlx5/{mlx5_flow_age.c => mlx5_flow_aso.c} | 96 ++++++++++++++++---
>  drivers/net/mlx5/mlx5_flow_dv.c               |  7 +-
>  drivers/net/mlx5/mlx5_flow_meter.c            |  7 +-
>  8 files changed, 191 insertions(+), 32 deletions(-)
>  rename drivers/net/mlx5/{mlx5_flow_age.c => mlx5_flow_aso.c} (85%)
> 
> diff --git a/drivers/net/mlx5/linux/mlx5_os.c
> b/drivers/net/mlx5/linux/mlx5_os.c
> index 6ac334263e..ee0d45796a 100644
> --- a/drivers/net/mlx5/linux/mlx5_os.c
> +++ b/drivers/net/mlx5/linux/mlx5_os.c
> @@ -818,6 +818,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
>  	char name[RTE_ETH_NAME_MAX_LEN];
>  	int own_domain_id = 0;
>  	uint16_t port_id;
> +	uint32_t log_obj_size;
This would raise this compilation error:
rivers/libtmp_rte_net_mlx5.a.p/net_mlx5_linux_mlx5_os.c.o -MF drivers/libtmp_rte_net_mlx5.a.p/net_mlx5_linux_mlx5_os.c.o.d -o drivers/libtmp_rte_net_mlx5.a.p/net_mlx5_linux_mlx5_os.c.o -c ../../root/dpdk/drivers/net/mlx5/linux/mlx5_os.c
../../root/dpdk/drivers/net/mlx5/linux/mlx5_os.c: In function 'mlx5_dev_spawn':
../../root/dpdk/drivers/net/mlx5/linux/mlx5_os.c:823:11: error: unused variable 'log_obj_size' [-Werror=unused-variable]
  uint32_t log_obj_size;
           ^~~~~~~~~~~~
When compiling with rdma-core-33

Kindest regards
Raslan Darawsheh