From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2373A0C3F; Thu, 15 Apr 2021 15:05:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B826162276; Thu, 15 Apr 2021 15:05:28 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2045.outbound.protection.outlook.com [40.107.220.45]) by mails.dpdk.org (Postfix) with ESMTP id 4324C162275 for ; Thu, 15 Apr 2021 15:05:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nSG83dJI8hmXo03sGstbouFGk8TimxImgTURKr7VpNw74fUuyJkJbNMZ0E9AEHNO/CJM1MFygP1EcSBRV+vlzChBSzk975cxyEK3OQGrGkR8krOgXqA0c3FQKcjJgDonY/CBcUo9tlVbOF/KG++6XVyP7KSUhFTBbUsMXtOssYrvF8xZzNgtn63UzFbq1JzjAFNXHB16zgopuW92pdMqul+IsGqBrLLPpWGf7V/gu1++K4g+yyy0MUNnVGO9KKe0HhJ69eUgEIKvSmMSDVJjQuCUmt+PhM1b7+e9nWqApLJXGMs6XrmyTM92chn/mvJeinqqfEuFJudpZEBS2wUn8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vu6VYhbDkMzkmb6sYMY4vqjnRQHhZpAEXO8J1qw55HM=; b=VLKqdHIiuH2WwqJfE7RXEYAO2bs3lLv6o1Tq72pXosRVF1h9mGMxURrw8zHmhmk1iMyZnwb6pfv5vtsuYzIVJipdBpxjBpEgcuBtCWUwVDgkOKxqJKho0WPTrCH2NS5ic8aPIzvTTrdeaBEsslIgZ338oJwvdPPHlhQ+2vIShOJj48MNjl0T5rKoOA3YA3caFiy82CbSzekm0tir5Ti/wlymNMHn1jrqgrqRWfwp5XVt/b0pgulowm9ukF5vuOAT+I1eFOtUM8IrOipLDZj47Kdy5HwfAB6BkaNkUw+Ntvkc9IzV+cyXFHxmD/EgXzKzKSx7peB42aVDdv9E7DiWXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vu6VYhbDkMzkmb6sYMY4vqjnRQHhZpAEXO8J1qw55HM=; b=gznr8Yt7I9I8BQcTIq0VfzZo9XSGSG0IlDWOpS3EQjo+/ozU5AEdO05T/VePtL/Nz1Z/U7gm8fgNwfuLKrhkD5BwvFj+9C7RPXEpEtKF5GXTVU/sYAKY8m2SgLLsazbUSu+4r3nu7LppG7VGfGgkc4IPDxjoozJPocKhO9ZTNeJpJLrGr2yVLOxLkAPDKdFI6Zg33HyVyKoXUFTBldYTAsoHOZ8fCehLCQ+yW/Yn+9vCHvgaX7ayk3VXTR8KIG267KPQ7QgTBgv8rYelPl2ZYOi0OpzzUAm6O2P5JSMgdc/ECDpzc9JqdnqOAIdYAiGcO/zBmAevv0GQ1qtsmQ4mDA== Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB3530.namprd12.prod.outlook.com (2603:10b6:5:18a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Thu, 15 Apr 2021 13:05:25 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::d011:3b55:aafb:9280]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::d011:3b55:aafb:9280%5]) with mapi id 15.20.4020.022; Thu, 15 Apr 2021 13:05:25 +0000 From: Raslan Darawsheh To: Li Zhang , "dekelp@nvidia.com" , Ori Kam , Slava Ovsiienko , Matan Azrad , Shahaf Shuler CC: "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , Roni Bar Yanai Thread-Topic: [PATCH v4 10/14] net/mlx5: initialize the flow meter ASO SQ Thread-Index: AQHXMNn2MU2e8uKFUE64HPhxcGWb1aq1jZfg Date: Thu, 15 Apr 2021 13:05:25 +0000 Message-ID: References: <20210331073632.1443011-1-lizh@nvidia.com> <20210414025736.31142-1-lizh@nvidia.com> <20210414025736.31142-11-lizh@nvidia.com> In-Reply-To: <20210414025736.31142-11-lizh@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.230.40] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 75566699-c48b-48e7-8979-08d9000f22c5 x-ms-traffictypediagnostic: DM6PR12MB3530: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:619; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lwN/v/+v1iaaKJO6DlxIOnG8IhnjrgMfdVZcbw52g2opNCXgC3CUWYmgJ7WGS5LNWgy08MbB7xl89UZytHZWXAQggbHbdYAxX40nF64GcUiBG01LHK5fBjGEoLlvVyd4clhVDedDaGQY8BCUx+Lk92fVwPe8VljpRV1QxUguq+KpcXy6pe1P5c/ckBGn8ejlM+oJaX2/u7+96rS4Fpk9TGa/GdUHGGrX4lWIxtyh3VXov/vohr7U6Yikzo6FVvjZL7WvjVQhsV9R8ooSnkLvcSAavMcF7gVqhk93asWFjrEMZiemwimhVYpbetUc6pMwPK0Nzw7suUv3eaiDczZE9E9Rjklc3nm1GrIVWUOUbYyXOGgop5un3qAGTiSEV2vNkNucVKwMfuEm+Dh2LbkxEfgCWJ2aAXBkw+K6d8ndJ0eKN2XUzTEX1cNB+BL1TVGbIG/nX1AaTQgddzFB1pSiYgKZP1ovnLoWDq5C2xEFd1v/OgGyjk0nzE5ITDTyWkehOzJFnTmkooLvJ8BfOLQ7gE2MqTFDARsiIidtqT2R1E5spGGeolmEHlkkjdVUvAC1a0FG4PDUwitmEj4bZJJbtapsY998ikRbFzGowfpZv+A= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(346002)(366004)(136003)(396003)(478600001)(26005)(186003)(53546011)(38100700002)(6506007)(52536014)(2906002)(83380400001)(316002)(110136005)(7696005)(122000001)(8936002)(71200400001)(64756008)(66476007)(33656002)(6636002)(54906003)(107886003)(66946007)(9686003)(8676002)(66446008)(66556008)(55016002)(76116006)(4326008)(86362001)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?87j4XuOvS3AVcyaFOwpXKEurhVmSoNJv66SwPBAlsJDAgd4Z7qObZCXZd5SE?= =?us-ascii?Q?wkuF3arVaL6Eo0MIe89Ln33gccUDoCDaA/IYe5NKz7c/jMSmGDGwgeDAFkkt?= =?us-ascii?Q?YYZ2pFWxncS76JAaWK/10toKMfNm/ejRr2EsICizb6KIpARohqc9ECUm16Du?= =?us-ascii?Q?aOGxSDURQ+JwVBAW205RQbKnhwjyAFiPEA/KjxZSX/WmDYFyCEljuJsZeuFx?= =?us-ascii?Q?kIsg447AmThw0D/lsnKahccaSQyarVAWKPlslOWyPBwEqtxwtH4g1f2+g4WX?= =?us-ascii?Q?5sDYpF+PwZJEBpo036QtbCZJqey/StNk5s5iuGJfmDtlem4ovy8U3IIsZIRg?= =?us-ascii?Q?HY/hOhSJTFe05kZsEWC14qkWZebGHnx35yy2Mes7cJ0KFYETuR50xiHxYKZz?= =?us-ascii?Q?CSa5GEef5nGvEqBaeFolGk19pM7WrvQRKdnkpNyvft0J2+HcGDbIiFLrzpNC?= =?us-ascii?Q?m8N5xVWXkZyKcojZgx5ixisH/SbmSE3Jvid4LlvczeRd1/n3WfMQxj4WZHX7?= =?us-ascii?Q?ycmf2gusWy0NHkycaJjrjHKhpADJnbaxVDucZl21qhyjwxc2hujHevxuMUQH?= =?us-ascii?Q?QElHKy0scwCNHTsbe4csbULGVjwOaKdObOxlp46qP1ugNxqvWaAa649Wj6jV?= =?us-ascii?Q?V99KsY1MwgjjEkBQ14DMZDdAEoNABng8ZEo4FDdzGTUoksPCMGjl3OBZNa6a?= =?us-ascii?Q?w5JSepBE4RzmqbDI84CoYOfpPoei0AaRR/ndeIf7TYNQAJLS2w6NK11WNG8r?= =?us-ascii?Q?sZrxCctKEUUhgQ3axJNnt97+l4VVl+XsEmRAERVbMyxDu5KCB9oVTRx8d67X?= =?us-ascii?Q?SYRhsIwbNWXJd3ljZvGwL38c5Ur7WkUi4ymSfYLx2KoQ9ZlyTpqdnLhOvYgS?= =?us-ascii?Q?ZKUE6zzkNfSbUCQ6fV4VbODLvQR6iuYRQgJkpUOUxLVBUTiYn7QDvjx/A7IP?= =?us-ascii?Q?SyRm7vv4p+eCmlEFe1ngcb2ikXTIr/YfA5MYZB+xZL99A5//+fcvzgg39zkd?= =?us-ascii?Q?9d0u03ze4AGG+5scmFedIFMU6xljP4cWwKIUYJzJyeQzvynxRpynqmZ9hM+r?= =?us-ascii?Q?GiXNn/c1CZN4RlKEEkq/NjjETQ8kMVqJypyGgPf6p79YUDR4CZ+lt21Um3hy?= =?us-ascii?Q?B8aqQdl+PbfhHugCi3SeAa/XrC1rcOHJNhHvX1bHPmvaX1N+gOMh3DCKPtc0?= =?us-ascii?Q?o5zfASYe8ku+E/wY+85MVX5pR3n4cpz6gV4cYUevEjyIzCVm9/lNOQFZ1rCj?= =?us-ascii?Q?IIVzERMvuUOm0RLF/mvCDLmhaXox6rKKLgPYaQ4uXsW4ELkC4XhzHh6LiM+8?= =?us-ascii?Q?1TlHhkciC7HLdeUPfknSQ2GB?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75566699-c48b-48e7-8979-08d9000f22c5 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2021 13:05:25.6357 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MeMRsq9++pWObUZP9Q5frkaQkOfaRXPpWvElAm92pLSNxiu/8npO6CNo82VKK8fEn4px0gP0+ZM7+p59JlheQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3530 Subject: Re: [dpdk-dev] [PATCH v4 10/14] net/mlx5: initialize the flow meter ASO SQ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Li, > -----Original Message----- > From: Li Zhang > Sent: Wednesday, April 14, 2021 5:58 AM > To: dekelp@nvidia.com; Ori Kam ; Slava Ovsiienko > ; Matan Azrad ; Shahaf > Shuler > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; Raslan Darawsheh ; Roni > Bar Yanai > Subject: [PATCH v4 10/14] net/mlx5: initialize the flow meter ASO SQ >=20 > Initialize the flow meter ASO SQ WQEs with > all the constant data that should not be updated > per enqueue operation. >=20 > Signed-off-by: Li Zhang > Acked-by: Matan Azrad > --- > drivers/net/mlx5/linux/mlx5_os.c | 17 ++++ > drivers/net/mlx5/meson.build | 2 +- > drivers/net/mlx5/mlx5.c | 68 ++++++++++++- > drivers/net/mlx5/mlx5.h | 22 +++-- > drivers/net/mlx5/mlx5_flow.h | 4 +- > .../mlx5/{mlx5_flow_age.c =3D> mlx5_flow_aso.c} | 96 ++++++++++++++++--- > drivers/net/mlx5/mlx5_flow_dv.c | 7 +- > drivers/net/mlx5/mlx5_flow_meter.c | 7 +- > 8 files changed, 191 insertions(+), 32 deletions(-) > rename drivers/net/mlx5/{mlx5_flow_age.c =3D> mlx5_flow_aso.c} (85%) >=20 > diff --git a/drivers/net/mlx5/linux/mlx5_os.c > b/drivers/net/mlx5/linux/mlx5_os.c > index 6ac334263e..ee0d45796a 100644 > --- a/drivers/net/mlx5/linux/mlx5_os.c > +++ b/drivers/net/mlx5/linux/mlx5_os.c > @@ -818,6 +818,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, > char name[RTE_ETH_NAME_MAX_LEN]; > int own_domain_id =3D 0; > uint16_t port_id; > + uint32_t log_obj_size; This would raise this compilation error: rivers/libtmp_rte_net_mlx5.a.p/net_mlx5_linux_mlx5_os.c.o -MF drivers/libtm= p_rte_net_mlx5.a.p/net_mlx5_linux_mlx5_os.c.o.d -o drivers/libtmp_rte_net_m= lx5.a.p/net_mlx5_linux_mlx5_os.c.o -c ../../root/dpdk/drivers/net/mlx5/linu= x/mlx5_os.c ../../root/dpdk/drivers/net/mlx5/linux/mlx5_os.c: In function 'mlx5_dev_spa= wn': ../../root/dpdk/drivers/net/mlx5/linux/mlx5_os.c:823:11: error: unused vari= able 'log_obj_size' [-Werror=3Dunused-variable] uint32_t log_obj_size; ^~~~~~~~~~~~ When compiling with rdma-core-33 Kindest regards Raslan Darawsheh