From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 679EFA04DD; Thu, 19 Nov 2020 11:52:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5DC274C90; Thu, 19 Nov 2020 11:52:38 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 0B3DC3B5; Thu, 19 Nov 2020 11:52:34 +0100 (CET) Received: from HKMAIL101.nvidia.com (Not Verified[10.18.92.9]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 19 Nov 2020 18:52:32 +0800 Received: from HKMAIL103.nvidia.com (10.18.16.12) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 19 Nov 2020 10:52:32 +0000 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.54) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 19 Nov 2020 10:52:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M4EFDOSFgVXpadU0zySsrIBwYavxsIOuYAro3jVGGgUMfE3IMaiAKsOn6o5PIMau7j9XAGzbqAPT7Ku0XwHJfaZJjZo/3ywo9Lss4t+mwHt3BslwRNv7rzdZQc7k6rVdqWEd5/ijDLS9ug1ST8I04+mbQNNqjAbU9VqMeLSxIATew+c9fenbA//R2hI+rwp1oDcy2K5zykeqi7FtmyyxjiRrO7xxe2ISASCvKWZvf7781b1XlR6sG5EYoIMeBLY9Cn5fzHJyjETXn+RBg8f1yPnS5UCPnxY8LAJ7oi6M8QZu7oukzZS3Rf5FdYpECrFk0C1LsF6tn5SdgxNjolPPTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a74J+LcTgoLsSLTuzOfDN+kQJRK1GZ/AjqN1jjPGd68=; b=RZXmV8gpo4vIBwJNg55mPEtbrQ1CDxNIGAi+U2+iSQSP4EQH5AzakUbs8VKmJ8v5vUCpi327rywBQnnUWjeEAMk/jobiM/p4x7+q3Ovhj+nDmXi+3h/de/as1YYWeHmZZNujorNSvMrNFPX/FljH7YyftKk1YipHh0YcsoM6zr43UEB5mLJeZ2aMMLlebCsSowkCoNO/PXeFuxkXvGgm2Bih9a1EfakeBOvzrSELz0DpP5e0EoP4TflU1keTaJufdZpcBU4Mlr78mKJrCpOFw27ND9leOeiTZUEMRNOUDF48gQUJAdkIEtsYsk/Qv57EGH2gpz6E3cJw57mhlZCwXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.28; Thu, 19 Nov 2020 10:52:29 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51%6]) with mapi id 15.20.3564.028; Thu, 19 Nov 2020 10:52:29 +0000 From: Raslan Darawsheh To: Bing Zhao , Slava Ovsiienko , Matan Azrad CC: "dev@dpdk.org" , Ori Kam , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix eCPRI item value with mask Thread-Index: AQHWvh9y1VOm9LvXpEC8Vly362A7qanPR80w Date: Thu, 19 Nov 2020 10:52:29 +0000 Message-ID: References: <1605753692-311910-1-git-send-email-bingz@nvidia.com> In-Reply-To: <1605753692-311910-1-git-send-email-bingz@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.230.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e8ddb347-2fd1-4402-dac3-08d88c793603 x-ms-traffictypediagnostic: DM6PR12MB2748: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NonOXquoy8KnWG8XacXc3/2/lApRH3pg5ziy5Uk6y3zc6TfsI9W7vtorEJw1R/8DWH6svUdsjbYUdI0GKHUl9btQKnutaCBaWrJCYZQU0eUNYqjs5taxe0ne/ixIjoDPeZAaf2/OzbH4MH0b8+byPdzusYizJT/TrArKvvHfMT99ZxGCeu0+2n+Dbgp0apjM3KFcLRR5nBuUyhACUNl9DZXmlIY9Ch37ewR9QDqLbzJhHfGoAMJzPm7aYr0LoGyTGwhJ/btg/hYYjn59wJGhcl9MyTgCnpdIk7O9+ZNQdmS/EARjo7P73376YEwISZjKP0oUrdonF7VHyihilH/lOg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(376002)(346002)(39860400002)(396003)(450100002)(478600001)(4326008)(9686003)(6636002)(53546011)(110136005)(8936002)(8676002)(26005)(7696005)(55016002)(316002)(186003)(54906003)(6506007)(66476007)(66446008)(86362001)(83380400001)(2906002)(66556008)(76116006)(52536014)(66946007)(71200400001)(5660300002)(33656002)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Yyy3LCleTDSzyL0yRzt9g8Jw3cM8rhjR0YUp1vcMFx00wTrjKlQ7wCEnPt/IuV5SWIJq9E4Cd+qzSe3waedQxUo5BTd8EMGI4phtW+nuzzg8iABTNEQyjKCQscj39ne+VcTxe7TRzvLBoTx3+6td2xq0g4PSB6eHYHV0P4DHr+n8fiFc/W+5wR076nMuOWFWoG1kPvQq6irvptMuhR7Qxba/BPOF488UGxDcNLMU1V2SQqRTIPSC7hx7Rt2GJB2DfC8xDnQvQANE1HdFYliToaqxiaa2UiBULhJ38BKroMtCOdhej8teEADhAv6aAt5vlrTqqLCoW5ohH8orEv/3redRR3r/fQm1VTFqrau4xQeiaY5I2yh9vpjtWpttDBys6jL+RjsBV5lzyWOLWEaNtVDljAZRRAQ4hoSFNZKXdFiTx2SsRj3FbJRsOxAsB6W+b1AOM6AtmFAXJIR9XFuxe70LJDENA1KHXb3ujWhVmfVhsSYLjGJERJNr8qQxBz82A3MyS5PvTfL0CO8urjaM0DbQ07DX7ycQvSUFeop0/kQKiXRAF2F2YmtdKPQhXC3ez2Dtun/vh0/644KgZGL3vBveH3SI8Zq4w+OZb6Vz9UT3n+SvOg7S3bPt77/G1mzyOgjYntMTHxhIixHZQIO/b7D3MohyaSC8gmO2f3qyoEk+xIiXqZ7tpkjnT1+XU01hGwPwvtFiIJmSFAUbL1tUI1wHiLPKfRzfs/f110RFEUhsK1kYiDcU3FF/gDmx5XAeLtRNvIX8JFJjCxvaTHPznqQnISGbCkBP1K157XBKfroiE55vEG771TIp0gPk35Cay3QmGy61NYSTJEG6/O/nr5COfIXfTfze/dZN/vIXphYHXqjr9a17OkLbZdNxAnDilKP4JghrOr+O9QXkHi/QCQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8ddb347-2fd1-4402-dac3-08d88c793603 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2020 10:52:29.7129 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4A9rZpld0FspjtwA+klr1841237T82Y5WfOeNCMo7oc2YbYxGpqYOW0cDinefaaoKgdyi/oVOKvG2L2LqGQJNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2748 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605783152; bh=a74J+LcTgoLsSLTuzOfDN+kQJRK1GZ/AjqN1jjPGd68=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=jvhPTXTf9s0RhP5I38uS1rwMg/NuE+LuTgF7Wsfnuj1U9tNUljWnUBA0nFAuISlQi cYVjVSc3h9WYYxuPHKKKKSRcUMwD3z4uk68nna7FnsOwUndfp+iPZCk8KaRuwirDLo Funi76Wwo1S0cF73tA8zYvmGl+uhPsc23TEvZpnJ/M2EtFr27frt8gPNuaSToxgxPo Xkd7u876SDCE3V+jTrVbIt5TIyzo87iAwsH/uHFMtB8/gRk6UfAa66HWKKBuOxH0sI p4Uu2ggdD7jSYM2+GXlNbQ5ClWXx5S8Y7VRIEnRKafkcINdQfkEkKpSi9UjRT8PXVn 2lNtjGdk4XeoA== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix eCPRI item value with mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Bing Zhao > Sent: Thursday, November 19, 2020 4:42 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh > ; stable@dpdk.org > Subject: [PATCH] net/mlx5: fix eCPRI item value with mask >=20 > When creating a flow with eCPRI item, the mask and the value are both > needed in order to build the matching criteria. >=20 > In the current implementation, the unused value bits clear operation > was missed when filling the mask and value fields. For the value, the > bits not required were not masked with the mask provided. Indeed, > this action is not mandatory. But when creating a flow in the root > table, the kernel driver got involved and a check would prevent this > flow from being created. The same flow could be created successfully > with the userspace rdma-core on the non-root tables. >=20 > An AND operation needs to be added to clear the unused bits in the > value when building the matching criteria. Then the same flow can be > created successfully no matter with kernel driver or with rdma-core. >=20 > Fixes: daa38a8924a0 ("net/mlx5: add flow translation of eCPRI header") > Cc: stable@dpdk.org >=20 > Signed-off-by: Bing Zhao > Acked-by: Viacheslav Ovsiienko > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh