From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03F9DA04BB; Tue, 6 Oct 2020 17:24:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EB7371B80B; Tue, 6 Oct 2020 17:24:31 +0200 (CEST) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by dpdk.org (Postfix) with ESMTP id A05E91B733; Tue, 6 Oct 2020 17:24:29 +0200 (CEST) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 06 Oct 2020 08:23:33 -0700 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 6 Oct 2020 15:24:28 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.44) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 6 Oct 2020 15:24:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lBNB4jnB8g9qCA6XQ7SXTojCRFCWJwM8vx6ibL4WwlmMPF2uymvUNwWXomOdl0KmjnCqkYHgBVeegV+Jx8T1oQh9vU6skUWgP704psn+MAUm1JywKPVRWAEJK5A+VlnAveCfqhZJegse2Bd3aNzVVBkPjbUm4740VC7f5IUiPb5NlTnbGODeJsraV+8kJtHl/oT/Sh1K20UOvRIzLtDa+VZXKS5VexsAWidf57Yvl8fyb05g5sjcwnVA5oKYrcrTnHpCvlsqXwr+G9AIwhzxjCWjpfUyNkJcxsjzhUD7vwaDBlmS4tIa9LiuiizfwaRzkUb6+74aB64ULlrVe9O6Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HC2+y5KapgfW1JGc7USOWdu9jds02D7Y0Ow/RQ8XZsc=; b=IHNSlG4BU2g7GuyE5484Hla9rREJALRlkJC6E0TuDvaUY7HiV+VtDP0Pm2g3poSzZGvpehPhQct9wMpbCq5z26DIbDjN8kShJVvYVrYsTjNvoq942cJWAGJTgpzOmG6XkAyEnOahS2QqZeBO7XP5rMyyvBHp9+1SU8S1gVKry3t2r55R6vX+vJeVckbEqJBKWpuw7mJOhTboHE9qsgpL1itFhy10MLl3bVFZKU4Dw2hQt9Ugg640jJt1cq3VqMTeBpBpAoUqrd1E/AYLkfcqWooWm/+ZYJ/N+Jo/KxXs66S7jzGhkKYEg0TL/z5Wd7EAJXriFFdggyfNXjBv5fCsZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB4420.namprd12.prod.outlook.com (2603:10b6:5:2a7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.32; Tue, 6 Oct 2020 15:24:27 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb%7]) with mapi id 15.20.3433.045; Tue, 6 Oct 2020 15:24:27 +0000 From: Raslan Darawsheh To: "Xueming(Steven) Li" , Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" , Asaf Penso , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: disable flow dump for Verbs flow Thread-Index: AQHWhypyHtp5bqM2NUOpAdrtYie64qmK2xwg Date: Tue, 6 Oct 2020 15:24:26 +0000 Message-ID: References: <1599711897-21330-1-git-send-email-xuemingl@nvidia.com> In-Reply-To: <1599711897-21330-1-git-send-email-xuemingl@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a7fb0b7d-9e5c-420e-f7d0-08d86a0bea05 x-ms-traffictypediagnostic: DM6PR12MB4420: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2201; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: byJl0/yUQovdgrOzxMV6U5rgrEgLn+qWoGZTBquyA6LUzye7dYRiBzO6G1IhoxztGeWDgHp2LX7BOwYsUSvB4n0Rm1umOENmwaGuR69KX8nFkNVp1dHV8l5/mXF9u3EjO3z4UJ5bTbko0j9lDa9/AQEb3FZNA/JBiVVOxLDBZJ+sp8k3ajmdC42q1RZ9h5nvrGuE07MlmbI0vAz3imQ1otUzLDJVE0vWINDVpgAmdJqS0dimdHjRP3bxnIarDmjii6vPcQlpLz54h3QpNqTaVWcuTk3To7ywDKLCdP0QzYNbWFVbbmgrxD6hUddZC75C5t9WJkvBQEMZZ1UvxXcJ8Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(39860400002)(396003)(346002)(136003)(6636002)(86362001)(33656002)(316002)(52536014)(54906003)(5660300002)(110136005)(55016002)(186003)(26005)(8936002)(450100002)(478600001)(7696005)(76116006)(4326008)(2906002)(83380400001)(71200400001)(66946007)(66476007)(64756008)(66446008)(66556008)(9686003)(8676002)(53546011)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: IIxkUiKnnaUiSmQPHOZL34JEAybl3KnEFyzB8jycnDGNgU/5nROCIBbqzVzWIw3e1SwX/dr+oHkduYSRjRi07/R+F/UlD+JksApHhUtvKRQAyzlsjkNZn4l4YJmzXLKMkEQhm+8FsNqEXS9aEO9G7lJrIYo9dHZMv3vQMwI4gVj+/INQNhrturb4a1AwaLjiCBMgydypjT5RpErhWUlFgwV4jtRGvyVIeO0vv/EUhK9dM+3EBlKFn+lZXGsbLAQDOBN40/vEe6lDsk+vHG4I+mL42BqvGa5X5p6w9LVIbuGk+Wja0wL6N416+LEftSO1eGJfFgW0T0vuA2A4BUF5eCZh4PhaynmG96+IT2jy7290AMHvDHtvQIvT4AZ2W6SFK8UbuV3nbhO4HBGljpxnTxKrbxTf0x1uBMWOWn/+4ccU8Beg8UK7hBasduo1NA+wi6gTBjP7mOSwKaFsdeTBcX26UddZ0edPoa952mBkOlwyI4/r6LhnlcZ9pXNNUL57NLOYmv4WvlfbK3lvm6cQW0HdA8v0nnu37hC9pasghBXSBfpeKJjTZu2MwHnw3vKeKOpu/RkGve3BHMHKPUu3+V80XGOte0cmybGKw05fvsMBjgUcqkIxZ0Z0Jz5DnjQiq87gGafzoSz6xMClE+xYTg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7fb0b7d-9e5c-420e-f7d0-08d86a0bea05 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2020 15:24:27.3021 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W081GbDapsqspNd4J/Ka5CyZO8eJuwCHGWjHsD18SlIuK3F5YFBINCETFp1PERyrMUAhln0TsPoopcHszUsUmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4420 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601997813; bh=HC2+y5KapgfW1JGc7USOWdu9jds02D7Y0Ow/RQ8XZsc=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=nicrU7GGkfqALvkJyp2H2DhLl1vqu74Pd9JQg4RiZdhsXAZpF/AEEovaNprRtGFks mpXsHJ4R+eBLjg6L9ez6MflE3rbLGbny1BmNVeL2HUC+UbsqylC1LizM11zmmLSeyx c6fPugnPGoHOe8zWw9TSoq2krhkZm5D7wK7bLaWPN8X6T+K2VjxB/Cw1LYudpce/0m pgLxo9G6cLxTKWw/+KaXLBPx4ARCC4kUiD+jr+5vPwl5WowW07C3TbRFZARj2OpLBm SHRR1Xd5eEPDlLyNvXRQpe5Zq7/W8lZT+kvVASR3/BJmjx6r57qHvV5orhU5jkOtrQ bIgg4k8EDO37A== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: disable flow dump for Verbs flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Xueming Li > Sent: Thursday, September 10, 2020 7:25 AM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; Asaf Penso ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: disable flow dump for Verbs flow >=20 > There was a segment fault when dump flows with device argument of > dv_flow_en=3D0. In such case, Verbs flow engine was enabled and fdb > resources were not initialized. It's suggested to use mlx_fs_dump > for Verbs flow dump. >=20 > This patch adds verbs engine check, prints warning message and return > gracefully. >=20 > Cc: stable@dpdk.org > Signed-off-by: Xueming Li > --- > drivers/net/mlx5/mlx5_flow.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 4c29898203..5a28b80ee4 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -6268,6 +6268,11 @@ mlx5_flow_dev_dump(struct rte_eth_dev *dev, > struct mlx5_priv *priv =3D dev->data->dev_private; > struct mlx5_dev_ctx_shared *sh =3D priv->sh; >=20 > + if (!priv->config.dv_flow_en) { > + if (fputs("device dv flow disabled\n", file) <=3D 0) > + return -errno; > + return -ENOTSUP; > + } > return mlx5_devx_cmd_flow_dump(sh->fdb_domain, sh- > >rx_domain, > sh->tx_domain, file); > } > -- > 2.25.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh