DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx4: fix RSS action hash key null pointer
@ 2021-04-07 15:30 Viacheslav Ovsiienko
  2021-04-08  9:36 ` Matan Azrad
  2021-04-11 12:35 ` Raslan Darawsheh
  0 siblings, 2 replies; 3+ messages in thread
From: Viacheslav Ovsiienko @ 2021-04-07 15:30 UTC (permalink / raw)
  To: dev; +Cc: rasland, matan, orika, stable

If RSS action contains non zero hash key length and NULL
key buffer pointer the default hash key should be used.
The check for the NULL pointer this was missing in the mlx4
PMD causing crash, for example, in testpmd with command:

flow validate 0 ingress group 0
  pattern eth / ipv4 / end
  actions rss queues 0 end key_len 40 / end

Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
Cc: stable@dpdk.org

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 drivers/net/mlx4/mlx4_flow.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c
index 43a65abcc0..71ea91b3fb 100644
--- a/drivers/net/mlx4/mlx4_flow.c
+++ b/drivers/net/mlx4/mlx4_flow.c
@@ -791,7 +791,8 @@ mlx4_flow_prepare(struct mlx4_priv *priv,
 			rss = action->conf;
 			/* Default RSS configuration if none is provided. */
 			if (rss->key_len) {
-				rss_key = rss->key;
+				rss_key = rss->key ?
+					  rss->key : mlx4_rss_hash_key_default;
 				rss_key_len = rss->key_len;
 			} else {
 				rss_key = mlx4_rss_hash_key_default;
-- 
2.28.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx4: fix RSS action hash key null pointer
  2021-04-07 15:30 [dpdk-dev] [PATCH] net/mlx4: fix RSS action hash key null pointer Viacheslav Ovsiienko
@ 2021-04-08  9:36 ` Matan Azrad
  2021-04-11 12:35 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Matan Azrad @ 2021-04-08  9:36 UTC (permalink / raw)
  To: Slava Ovsiienko, dev; +Cc: Raslan Darawsheh, Ori Kam, stable



From: Viacheslav Ovsiienko 
> If RSS action contains non zero hash key length and NULL key buffer pointer the
> default hash key should be used.
> The check for the NULL pointer this was missing in the mlx4 PMD causing
> crash, for example, in testpmd with command:
> 
> flow validate 0 ingress group 0
>   pattern eth / ipv4 / end
>   actions rss queues 0 end key_len 40 / end
> 
> Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx4: fix RSS action hash key null pointer
  2021-04-07 15:30 [dpdk-dev] [PATCH] net/mlx4: fix RSS action hash key null pointer Viacheslav Ovsiienko
  2021-04-08  9:36 ` Matan Azrad
@ 2021-04-11 12:35 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2021-04-11 12:35 UTC (permalink / raw)
  To: Slava Ovsiienko, dev; +Cc: Matan Azrad, Ori Kam, stable

Hi,

> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Sent: Wednesday, April 7, 2021 6:30 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Ori Kam <orika@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx4: fix RSS action hash key null pointer
> 
> If RSS action contains non zero hash key length and NULL
> key buffer pointer the default hash key should be used.
> The check for the NULL pointer this was missing in the mlx4
> PMD causing crash, for example, in testpmd with command:
> 
> flow validate 0 ingress group 0
>   pattern eth / ipv4 / end
>   actions rss queues 0 end key_len 40 / end
> 
> Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---

Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-11 12:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 15:30 [dpdk-dev] [PATCH] net/mlx4: fix RSS action hash key null pointer Viacheslav Ovsiienko
2021-04-08  9:36 ` Matan Azrad
2021-04-11 12:35 ` Raslan Darawsheh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).