From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22637A04DC; Mon, 19 Oct 2020 13:40:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B44B9C90C; Mon, 19 Oct 2020 13:40:47 +0200 (CEST) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id BE834C8B0 for ; Mon, 19 Oct 2020 13:40:45 +0200 (CEST) Received: from HKMAIL102.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 19 Oct 2020 19:40:43 +0800 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 19 Oct 2020 11:40:39 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 19 Oct 2020 11:40:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M8qahiEp+gyonYbyXnIHRojUzWGlVDbeaTxixIERMCZZK+m1oN3sDXTngYdcNo3Ktz7Ar01wIFx+4xLq/gsj/CHAzisXq5XjxKQSnJWlUog9K05ElczaK9rNj0p7GYvlzjQR9jO0UskVHXox6dNpP/iOIoitAntcBSq0ih2VbPQFJHPHzpZBuMWqCNUQsHF5WN1HrjRIZ9MAwDA5tOWknD1BBqbunp1j8SPPLhw9jib4CAmD4paMppxvR8XB1GThcicu/QDp/SfyRYMRrD6pUOpoMv0tNUTfItNiQ8aPYjN3cnOoTBn4Qo/afOsq/VjQ2VB4pJfazH/DOauzYSSAEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=daiOp7IitbRUOdd6vldzlmrrJOLEGLD5BlZslOmpHas=; b=F88b2T+LaQrTOP3ZfEouPs7Tvjg1XppUcRErIwR5/D+8fCJa1qz4phuYx5MyTTkR1x0s7YvYUeBPEwU0HrlIBI9jC1L7iTvhDRUnO2/pS23zazUmGM32HG3F/0W7Fr5WkkSsOLtMVP0Hn+m74siCYbXZvLWbbmDvAELiKUzRs4R2JW4J3K3GSXPJANMc7pChiQIeSTwwjUhyYFBXeKEVsqkDezFh0WHujpG5KTex+T3se6FopcVYE0ywxGH1HvLsdrurVLYTW3A/2RjimqAQLAJwhefRbqVsmSUSBQfzljETqv6HIm5K5otGKOa7CPlAbcGcvU+3CCDvLLbLGCJElA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR12MB1820.namprd12.prod.outlook.com (2603:10b6:3:10d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Mon, 19 Oct 2020 11:40:34 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb%7]) with mapi id 15.20.3477.028; Mon, 19 Oct 2020 11:40:34 +0000 From: Raslan Darawsheh To: Dekel Peled , Slava Ovsiienko , Shahaf Shuler , Matan Azrad CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/mlx5: add debug print of LRO minimal size Thread-Index: AQHWoviDIh0qj6jhLUaD6Fromf/tvame0zaA Date: Mon, 19 Oct 2020 11:40:34 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c5ac1416-3230-4ec2-2777-08d87423ca97 x-ms-traffictypediagnostic: DM5PR12MB1820: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jOgR3YX3ZRD+QpZkzaqM91pqSYVal8hnpuEzJo7tlx7MYDb01gVTICZHTP4QdYxkiWf4FwhHIdLjycW7XHmpaqf3zCGOZQosB7b/BDReoqm1nUiORbN/VUsCmVjffSr8BQlWqebEin4IeVHgbuKM2xBLOHOs5jhr+nTGGDWtiLgt7/bKI4Cf8I6ApxB6t+7vWAoCTaHcIwXztDl9xPfgR/gkRDycJODiJSm4qIR0Q6M5NX7bSqEN8uEaXi1HBjIkHQun9Qlx1KmtAAvsRIHUxgFoiz0HieMnupqx7HesrGQFvY2Jye9V2qtXaS7YB79Ixtzv+VWtUK3edplswrq/lg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(376002)(366004)(396003)(136003)(110136005)(478600001)(76116006)(316002)(71200400001)(7696005)(86362001)(6636002)(8936002)(55016002)(6506007)(9686003)(5660300002)(2906002)(53546011)(33656002)(26005)(52536014)(186003)(4326008)(64756008)(66446008)(66556008)(66476007)(66946007)(83380400001)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: yzScmjEKnhBKMqmrXgFGeZjJDV95Axf+pzu/jHU8G8auaxUOg375F3k67DVrqls2MkPUBJiJjIuG+Xkar8cr3tMjQsC9O/4KO+mYbiQhstw2gUGOiL4yiILnjidgnm1tJYnK0p8lo9eBHeg432q9jZzfX72CNSoGxlt9lNcNd7pQVGuuGTnY9fNZww0DnmWL6CvKcdiIGRBAj7qm7f6FToE9rf98OP/9gH7fjLg7TyCi6q8HdkL2hFGwx8NCXN2keTAyeH24ig9IDncpSIQq/k8Kg1D+eWwIFDWEtWBIinhsEGtSXBLnJzOsP4mYTDfrTgLSySx/FPO0DqGMEyLLSlC/SK/QGNOH7Y5gAVGOta0L/CFI70EohYAXBznYLp2PdmXT6rmvrBScqyXN4QxcN0jNiCJfuCjobseVRgBQCZdQAW37LC/jxbrYdjlst2JEMD1GqybEgP4Jr5XD5xzEd0nU23HWjBZ7MIg4P7f+FPD1ro3ETByY8/SRXLS7LrDG7H1KJMDdKYbKiXDulPakN1ZwzF1FezVuO0C/Ri57k7Ul4XEvWlUW7TGGpwp96CpQYL9bSP2i+0sQ0OTvnS5XqwH5rorGg/F1G9aFGq8gdJNmE6B5v08IYGRgCGKE0sddLfVztX2aHPmGaC3P0K7VHg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5ac1416-3230-4ec2-2777-08d87423ca97 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2020 11:40:34.3017 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ashvod84ISMbKMfd9DOCLrASqW5tcGP43fbGCpYmwpYQis5c819Dew9nOBfxYX/9pitksN+epxtSXOlt7Zfl3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1820 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603107643; bh=daiOp7IitbRUOdd6vldzlmrrJOLEGLD5BlZslOmpHas=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=StIssADKk7dMWDy7GKYyRtN4zpWFBmImDlsOVDwdDitLr9Wx20LJQBttDPiXzxtSJ XiA7mPuxfmAhL2K3gZEeNJOlfUtqcFOY/S0LMFUk8n3zyUSpnPvWqjs9SlWSZoiHbk MEhScCw4OqhA/tyX0qXn26/zGtPRIj1PCZgknxIXhPiQm5anOo2bd56fbpYa0B99v4 dIFllJb1ENVXvaAasNDtKZj/zhnTRJiwhWgFB1TOgDu/wfdFtqMEDfeKvXh9EmapAB aT4RrttfqNNtu6NgOoImoKITiBo8RP5iBG4FWj/0HXiCVxyP/fR7JI73JCoPJy/Ucb 4MnLflQgdq34Q== Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: add debug print of LRO minimal size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Thursday, October 15, 2020 4:37 PM > To: Slava Ovsiienko ; Shahaf Shuler > ; Matan Azrad > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/mlx5: add debug print of LRO minimal > size >=20 > Add debug printout showing HCA capability lro_min_mss_size - the > minimal size of TCP segment required for coalescing. > MLX5 PMD documentation is updated to note this condition. >=20 > Signed-off-by: Dekel Peled > Acked-by: Matan Azrad > --- > doc/guides/nics/mlx5.rst | 3 +++ > drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ > drivers/common/mlx5/mlx5_devx_cmds.h | 1 + > drivers/net/mlx5/linux/mlx5_os.c | 3 +++ > 4 files changed, 9 insertions(+) >=20 > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst > index a071db2..f3afb24 100644 > --- a/doc/guides/nics/mlx5.rst > +++ b/doc/guides/nics/mlx5.rst > @@ -304,6 +304,9 @@ Limitations > eth (with or without vlan) / ipv4 or ipv6 / tcp / payload >=20 > Other TCP packets (e.g. with MPLS label) received on Rx queue with L= RO > enabled, will be received with bad checksum. > + - LRO packet aggregation is performed by HW only for packet size large= r > than > + ``lro_min_mss_size``. This value is reported on device start, when d= ebug > + mode is enabled. >=20 > - CRC: >=20 > diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c > b/drivers/common/mlx5/mlx5_devx_cmds.c > index fd4e3f2..d3e90b5 100644 > --- a/drivers/common/mlx5/mlx5_devx_cmds.c > +++ b/drivers/common/mlx5/mlx5_devx_cmds.c > @@ -819,6 +819,8 @@ struct mlx5_devx_obj * > MLX5_GET(per_protocol_networking_offload_caps, > hcattr, > lro_timer_supported_periods[i]); > } > + attr->lro_min_mss_size =3D > MLX5_GET(per_protocol_networking_offload_caps, > + hcattr, lro_min_mss_size); > attr->tunnel_stateless_geneve_rx =3D >=20 > MLX5_GET(per_protocol_networking_offload_caps, > hcattr, tunnel_stateless_geneve_rx); > diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h > b/drivers/common/mlx5/mlx5_devx_cmds.h > index cfa7a7b..c2d089c 100644 > --- a/drivers/common/mlx5/mlx5_devx_cmds.h > +++ b/drivers/common/mlx5/mlx5_devx_cmds.h > @@ -85,6 +85,7 @@ struct mlx5_hca_attr { > uint32_t tunnel_lro_vxlan:1; > uint32_t lro_max_msg_sz_mode:2; > uint32_t > lro_timer_supported_periods[MLX5_LRO_NUM_SUPP_PERIODS]; > + uint16_t lro_min_mss_size; > uint32_t flex_parser_protocols; > uint32_t hairpin:1; > uint32_t log_max_hairpin_queues:5; > diff --git a/drivers/net/mlx5/linux/mlx5_os.c > b/drivers/net/mlx5/linux/mlx5_os.c > index 09d0944..e0a5a21 100644 > --- a/drivers/net/mlx5/linux/mlx5_os.c > +++ b/drivers/net/mlx5/linux/mlx5_os.c > @@ -1071,6 +1071,9 @@ > config- > >hca_attr.lro_timer_supported_periods[0]; > DRV_LOG(DEBUG, "LRO session timeout set to %d > usec", > config->lro.timeout); > + DRV_LOG(DEBUG, "LRO minimal size of TCP segment > " > + "required for coalescing is %d bytes", > + config->hca_attr.lro_min_mss_size); > } > #if defined(HAVE_MLX5DV_DR) && > defined(HAVE_MLX5_DR_CREATE_ACTION_FLOW_METER) > if (config->hca_attr.qos.sup && > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh