* [dpdk-dev] [PATCH v1 1/1] net/mlx5: fix port id / push VLAN actions index incorrect
@ 2021-03-16 12:05 Li Zhang
2021-03-16 12:21 ` Slava Ovsiienko
2021-03-17 16:16 ` Raslan Darawsheh
0 siblings, 2 replies; 3+ messages in thread
From: Li Zhang @ 2021-03-16 12:05 UTC (permalink / raw)
To: dev, orika, viacheslavo, matan, suanmingm; +Cc: thomas, rasland, stable
When using port id or push VLAN action index to find
the action in cache, it will fail to find actions.
The root cause is the index is not saved in cache when
creating the port id action or push vlan action.
To fix these issues, update the index in cache when creating.
Fixes: 0fd5f82aaa0 ("net/mlx5: make port ID action cache thread safe")
Fixes: 3422af2af2e ("net/mlx5: make push VLAN action cache thread safe")
Cc: stable@dpdk.org
Signed-off-by: Li Zhang <lizh@nvidia.com>
---
drivers/net/mlx5/mlx5_flow_dv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 1a74d5ac2b..23e5849783 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -3612,6 +3612,7 @@ flow_dv_port_id_create_cb(struct mlx5_cache_list *list,
"cannot create action");
return NULL;
}
+ cache->idx = idx;
return &cache->entry;
}
@@ -3703,6 +3704,7 @@ flow_dv_push_vlan_create_cb(struct mlx5_cache_list *list,
"cannot create push vlan action");
return NULL;
}
+ cache->idx = idx;
return &cache->entry;
}
--
2.21.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH v1 1/1] net/mlx5: fix port id / push VLAN actions index incorrect
2021-03-16 12:05 [dpdk-dev] [PATCH v1 1/1] net/mlx5: fix port id / push VLAN actions index incorrect Li Zhang
@ 2021-03-16 12:21 ` Slava Ovsiienko
2021-03-17 16:16 ` Raslan Darawsheh
1 sibling, 0 replies; 3+ messages in thread
From: Slava Ovsiienko @ 2021-03-16 12:21 UTC (permalink / raw)
To: Li Zhang, dev, Ori Kam, Matan Azrad, Suanming Mou
Cc: NBU-Contact-Thomas Monjalon, Raslan Darawsheh, stable
> -----Original Message-----
> From: Li Zhang <lizh@nvidia.com>
> Sent: Tuesday, March 16, 2021 14:05
> To: dev@dpdk.org; Ori Kam <orika@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Suanming
> Mou <suanmingm@nvidia.com>
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Raslan
> Darawsheh <rasland@nvidia.com>; stable@dpdk.org
> Subject: [PATCH v1 1/1] net/mlx5: fix port id / push VLAN actions index
> incorrect
>
> When using port id or push VLAN action index to find the action in cache, it
> will fail to find actions.
> The root cause is the index is not saved in cache when creating the port id
> action or push vlan action.
> To fix these issues, update the index in cache when creating.
>
> Fixes: 0fd5f82aaa0 ("net/mlx5: make port ID action cache thread safe")
> Fixes: 3422af2af2e ("net/mlx5: make push VLAN action cache thread safe")
> Cc: stable@dpdk.org
>
> Signed-off-by: Li Zhang <lizh@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH v1 1/1] net/mlx5: fix port id / push VLAN actions index incorrect
2021-03-16 12:05 [dpdk-dev] [PATCH v1 1/1] net/mlx5: fix port id / push VLAN actions index incorrect Li Zhang
2021-03-16 12:21 ` Slava Ovsiienko
@ 2021-03-17 16:16 ` Raslan Darawsheh
1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2021-03-17 16:16 UTC (permalink / raw)
To: Li Zhang, dev, Ori Kam, Slava Ovsiienko, Matan Azrad, Suanming Mou
Cc: NBU-Contact-Thomas Monjalon, stable
Hi,
> -----Original Message-----
> From: Li Zhang <lizh@nvidia.com>
> Sent: Tuesday, March 16, 2021 2:05 PM
> To: dev@dpdk.org; Ori Kam <orika@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Suanming
> Mou <suanmingm@nvidia.com>
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Raslan
> Darawsheh <rasland@nvidia.com>; stable@dpdk.org
> Subject: [PATCH v1 1/1] net/mlx5: fix port id / push VLAN actions index
> incorrect
>
> When using port id or push VLAN action index to find
> the action in cache, it will fail to find actions.
> The root cause is the index is not saved in cache when
> creating the port id action or push vlan action.
> To fix these issues, update the index in cache when creating.
>
> Fixes: 0fd5f82aaa0 ("net/mlx5: make port ID action cache thread safe")
> Fixes: 3422af2af2e ("net/mlx5: make push VLAN action cache thread safe")
> Cc: stable@dpdk.org
>
> Signed-off-by: Li Zhang <lizh@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-17 16:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16 12:05 [dpdk-dev] [PATCH v1 1/1] net/mlx5: fix port id / push VLAN actions index incorrect Li Zhang
2021-03-16 12:21 ` Slava Ovsiienko
2021-03-17 16:16 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).