Re: [dpdk-dev] [PATCH v2 0/4] Shared action RSS PMD impl

[Raslan Darawsheh <rasland@nvidia.com>]

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Andrey Vesnovaty
> Sent: Friday, October 23, 2020 1:24 PM
> To: dev@dpdk.org
> Cc: jer@marvell.com; jerinjacobk@gmail.com; NBU-Contact-Thomas
> Monjalon <thomas@monjalon.net>; ferruh.yigit@intel.com;
> stephen@networkplumber.org; bruce.richardson@intel.com; Ori Kam
> <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>;
> andrey.vesnovaty@gmail.com; mdr@ashroe.eu; nhorman@tuxdriver.com;
> ajit.khaparde@broadcom.com; samik.gupta@broadcom.com
> Subject: [dpdk-dev] [PATCH v2 0/4] Shared action RSS PMD impl
> 
> This patchset introduces Mellanox PMD implementation for shared RSS
> action. It was part of the 'RTE flow shared action API' patchset [1].
> After v3 the ptchset was split to RTE flow layer [2] and PMD
> implementation (this patchset).
> 
> PMD implementation of this patchset is based on RTE flow API [3].
> 
> v2 changes (v1 was a draft):
> * lots fo cosmetic changes
>   * fix spelling/rephrases in comments and commit messages
>   * fix code styling issues
>   * code cleanups
> * bugfix: prevent non shared action modification
> 
> [1] RTE flow shared action API v1
> https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Finbox
> .dpdk.org%2Fdev%2F20200702120511.16315-1-
> andreyv%40mellanox.com%2F&amp;data=04%7C01%7Crasland%40nvidia.co
> m%7C7b680d1b14f54e64ea6308d8773ddcb4%7C43083d15727340c1b7db39ef
> d9ccc17a%7C0%7C0%7C637390454872691372%7CUnknown%7CTWFpbGZsb3
> d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0
> %3D%7C1000&amp;sdata=vt5%2FEROn9p1F2g%2FklmD%2Fr5TqThYS4ldui6y
> wdK51cdc%3D&amp;reserved=0
> [2] RTE flow shared action API v4
> https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Finbox
> .dpdk.org%2Fdev%2F20201006200835.30017-1-
> andreyv%40nvidia.com%2F&amp;data=04%7C01%7Crasland%40nvidia.com%
> 7C7b680d1b14f54e64ea6308d8773ddcb4%7C43083d15727340c1b7db39efd9cc
> c17a%7C0%7C0%7C637390454872691372%7CUnknown%7CTWFpbGZsb3d8ey
> JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%
> 7C1000&amp;sdata=1ats9R%2BuNxzEakcT3BhwaWc3xk6Swv33WVm5q11Hc
> %2FQ%3D&amp;reserved=0
> [3] RTE flow shared action API v8
> https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Finbox
> .dpdk.org%2Fdev%2F20201014114015.17197-1-
> andreyv%40nvidia.com%2F&amp;data=04%7C01%7Crasland%40nvidia.com%
> 7C7b680d1b14f54e64ea6308d8773ddcb4%7C43083d15727340c1b7db39efd9cc
> c17a%7C0%7C0%7C637390454872691372%7CUnknown%7CTWFpbGZsb3d8ey
> JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%
> 7C1000&amp;sdata=HyQu2GHjHbtOJcSueXb9i9wrZ%2Fz5BxUN2pOOQ5TV4e
> c%3D&amp;reserved=0
> 
> Andrey Vesnovaty (4):
>   common/mlx5: modify advanced Rx object via DevX
>   net/mlx5: modify hash Rx queue objects
>   net/mlx5: shared action PMD
>   net/mlx5: driver support for shared action
> 
>  drivers/common/mlx5/mlx5_devx_cmds.c |  84 ++++
>  drivers/common/mlx5/mlx5_devx_cmds.h |  10 +
>  drivers/common/mlx5/mlx5_prm.h       |  29 ++
>  drivers/common/mlx5/version.map      |   1 +
>  drivers/net/mlx5/mlx5.c              |   1 +
>  drivers/net/mlx5/mlx5.h              |   7 +
>  drivers/net/mlx5/mlx5_defs.h         |   3 +
>  drivers/net/mlx5/mlx5_devx.c         | 151 ++++--
>  drivers/net/mlx5/mlx5_flow.c         | 499 +++++++++++++++++--
>  drivers/net/mlx5/mlx5_flow.h         |  86 ++++
>  drivers/net/mlx5/mlx5_flow_dv.c      | 705 +++++++++++++++++++++++++-
> -
>  drivers/net/mlx5/mlx5_flow_verbs.c   |   3 +-
>  drivers/net/mlx5/mlx5_rxq.c          | 110 ++++-
>  drivers/net/mlx5/mlx5_rxtx.h         |   7 +-
>  14 files changed, 1596 insertions(+), 100 deletions(-)
> 
> --
> 2.26.2


Series applied to next-net-mlx,
With small comment that you are still using rte_atomic operation but since we have a commitment on changing this for all MLX PMD's need to take into consideration this one as well.

Kindest regards,
Raslan Darawsheh