From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE431A034F; Sun, 21 Feb 2021 09:14:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71D9622A25A; Sun, 21 Feb 2021 09:14:17 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by mails.dpdk.org (Postfix) with ESMTP id 47A1240696; Sun, 21 Feb 2021 09:14:15 +0100 (CET) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Sun, 21 Feb 2021 00:14:14 -0800 Received: from HQMAIL105.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Sun, 21 Feb 2021 00:14:14 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Sun, 21 Feb 2021 00:14:14 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 21 Feb 2021 08:14:14 +0000 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 21 Feb 2021 08:14:13 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Sun, 21 Feb 2021 08:14:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XWMvDfFcIswo9rOFE1ic1O/Y/NAukV0sQ+SbSM3mmVzi2wNj57XAQy4WCzM66dWFQaWkBCj6k9IpHEk1DAtFESIIoIkDZzwudwhOAMOqGpg+Pl9zbBivpQFBDewtToowM6nToDmisfx1gzr0OubJ5enorpJF+EVap/AKmEq2kkCn7xB9byXAtlVVQXV+NDKeqRuEqsa3fvSa9mPoZj24JLJw/LaVVfEwH78B4bF3bQV/bXohXFWi0Lb54F3GCfp1Z+Alu77wpNV70pzv+XB/+Il+dxq3Sqhp20u617ba05vak9/COQERXvnmziMaqjzhn/J74fBe3BFzvmpVcNch/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LGuJ+Uxf7/tiJ5dwnyVpnrXSTpqOVKqmkSGxUQQ6n1E=; b=YEa7C2uEuwdnpJq+gGrhwv6mF8INzxiwG0KoVDMfqeGSR7SPxkUlzbo+vXwx8dFQIpxcLVfp3bNBT1tQedwiVj+c7pLfK+BZqgumuHE/KaYRMDcwElpXb/DB8o/zT/CGw3kPt53PnClmRRlRIeUHsAJ6XUCnX7ySQVTODnJ3Fsa3R087XjOamTTns7zeYpV1PWIeN9K5g+qn1Z9fHRlCSpAhgZKZIZNvbPLxUt/Fw9Zrazj+rLernagDRy6OxUC3hml8A9tc16DR3u8m6atk1zx3YA8XKT47E4vEpCeU0XEBODai+kzEB7qpqOeyZ5RXKcsAptSdeu4GATzWnT2keQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB4841.namprd12.prod.outlook.com (2603:10b6:5:1ff::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.27; Sun, 21 Feb 2021 08:14:12 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::3d94:1f7f:178f:aba2]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::3d94:1f7f:178f:aba2%7]) with mapi id 15.20.3846.039; Sun, 21 Feb 2021 08:14:12 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix external buffer pool registration for Rx queue Thread-Index: AQHXAS8iZLxXVsfbs0O2hEsPWG/+capiUJrA Date: Sun, 21 Feb 2021 08:14:12 +0000 Message-ID: References: <20210212110630.2605-1-viacheslavo@nvidia.com> In-Reply-To: <20210212110630.2605-1-viacheslavo@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.229.248] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 43fb052a-6b9a-4f77-a794-08d8d640ac36 x-ms-traffictypediagnostic: DM6PR12MB4841: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-header: ProcessedBy-CMR-outbound x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wqeacs6n2fSlJWNGIFHqY/ldqlW/kh5FVopFPQw40JlOrN0fEvMnLKooBrZlhd7pDUVVm/9gPUPzlY2VZ1Er339q5a+eT7kCnKF3pcvyoycWvU4+88Z61wzoSCK5SW2aFosQ/rTd4lMqvL7AdzyD1+YTwsUV5EfArVeH0GD5Z6SlFScufEVvwfyI34RwivnlFIoEKIGtx5ji2f82AgRRDWE5+FgG0Lf1/IMvJqJAehsqA+3DXYDd96Y6Wph8msiCp2HSqskQzvJ3YP4ooWSW884TqBdtGE1MxNtYwb9CkFHPJlK7g9GM67M6gVHqIoO9dsrAzt1Iedim8YGVTxOt7YIzzlf7g/ffTi9rkehG6ddvPnEFoHwnGUu08PLN1x1oIFu4+awF7lv7qSs1WqeYBPD//MwLTOg0mj4egh6NXlfIy59b58EWqPhBYPVArEfrmTjfQ1BnCq9FMYs5kwehbsuSx9dcegdQbPvTCtFDcEev2iwHBRf5AziPwCiqsIpMfBz+FuhBVoJvjXi6qavWgA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(53546011)(8936002)(66946007)(450100002)(478600001)(4326008)(110136005)(6506007)(83380400001)(54906003)(316002)(26005)(76116006)(2906002)(7696005)(66556008)(86362001)(52536014)(33656002)(66446008)(66476007)(55016002)(5660300002)(64756008)(186003)(8676002)(71200400001)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?l7SqGH4xIfuCI3ZtZvMtAucKJOeeW2+kppUiGMDI3JVpQapOjWaJr4jc9c2f?= =?us-ascii?Q?rRxYXcaR3VtOnPZvZ3JDomQ9c/SNdBYxa4CRtTy8dAEKw855Xn4WQsm7jOnZ?= =?us-ascii?Q?+pUPGkRCorz/A0ZpLFHp3cB+LcEetWK8S0zsDkWZThbEes5aG53vMziGRH/9?= =?us-ascii?Q?B2AUxlzRGtkTG737b1gyS4wXW6rGJCAEKB3SiY6nMS/HkPKayn+pPDRtpn07?= =?us-ascii?Q?xK+Q4sPzgiN1HEIAc9Dln603Nlp19XmWeqya5RRiVJ8ZwdkY0OIX3Tetitq1?= =?us-ascii?Q?xalRl73rPsPO1DfN59fxQDRkoAK2ZdKVxzcW7LB4wHFKRcepiXE+r82nS+zP?= =?us-ascii?Q?3jbxxbBGLZ3sr3hQKGO27ZcsboT0nwdWepMbcR25BGzrhyz4YOYHH4zbOY67?= =?us-ascii?Q?r9Uoeq4Oh01IPigCdzHIABqNMlH6w3mLXC+H5oAqXc8TlkJ1xtWWK1SjsVfF?= =?us-ascii?Q?w0yzzSNJwM8VLJBaAvFtgDe1PlPC6jZrVLehGAev2O/+O6mDgiFgxlUqLno4?= =?us-ascii?Q?Pt/Aha30vDXBhrzB6Iys6ZOB+hSqj9y2h3Jf1ChUpV9lyyTIfrBpwZ9CjxIa?= =?us-ascii?Q?kb++xB3jqbGFVmkT9Q1G8ZYxk9RYFqTgtEmGRoEnCz6Zozr3dUNskkiWZCwV?= =?us-ascii?Q?zad4re73X82S8WnVk8Su/8mM5ztJNavN82hdIjj09a3GZXLaht16DruQLZs8?= =?us-ascii?Q?pJbC0H8wxOOoII0vPcF/aaFIqqOOKxc5qD/Ma1aJxNgvMBxv2zC1U0T9z4Mp?= =?us-ascii?Q?rgakDc0EsjbY344qgNuell5/rMzVltEq91BDJx995p56dKaf1YzPSLDhcUIb?= =?us-ascii?Q?2PoW0S7EdsdTFpmIA0cfBmeda4gvPLId0Yrgr1agf0N3HU4xTAY+UKYSjEf6?= =?us-ascii?Q?Z5ydjJeYSyVVJbkt8rYiO7VjNLTdOWXpLcO402VYufS6lFiQ+CdEnF1ecFVW?= =?us-ascii?Q?Gauc0CL93lloYfwqAqKF55/YOw6JFA5b3SfjqLjX09e2/Yso1XkuLByqL6A0?= =?us-ascii?Q?m7cL5ccj6gfgtS7KsAbvAcFR7rR4NAMLcGzQT4PmBHgzqya6xvMLd95e1MlP?= =?us-ascii?Q?m0JT0pS+qLzxq1FQmafsO4G2b8EdjXVDXXp+qFr7c0zyrO+6BoaRjkT0FIRM?= =?us-ascii?Q?sNV20F3QW2qpF7k2bVxKpJdeM8JTmujzJAaYw0qJJ9yOZUlyef58GIITXYMO?= =?us-ascii?Q?+1DvNEmrmIxfs050250iv79XrRGunJRKxlqoylkjzQfiL74b8TxFqYqL6Hbo?= =?us-ascii?Q?Gl2Nlo2uPl0tD7EEM/Bai2BMFVRl2WkiVlCwknCoj0OvSSPLSgJ60htygAe+?= =?us-ascii?Q?Mc+HiWw3CFFQO8UpGdX5wLwV?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43fb052a-6b9a-4f77-a794-08d8d640ac36 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2021 08:14:12.7439 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ntNEB3rZQpC1jKlBEEzy67GOWsWnOW5h/0m6g0aBNBF3tY1B2hu4YcgsVlb1U09OMsrUAPLDBkTzKoC9xBAazw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4841 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1613895254; bh=LGuJ+Uxf7/tiJ5dwnyVpnrXSTpqOVKqmkSGxUQQ6n1E=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-header:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=bBh6KJ6ND1QEW3b66JknlU0AiuKI88qHDejm3JNKbOpcKkBiFy0TAuJvsHjO1el+X UgQMQFkNh16z48S7jC7c4DbGIaF1srPlWe8Z9bqhzc+IvFlQnzS+o+nyat+xwQ0+Ly JmdL1csOtHFe0ZLUfAtFWdZ9sNaTLwBbQsxtMyTD1UDh2Us+euD2r3zWS8rUnicA1F M6JXkgyjHQtiDozD4kZ0otHwALT3Yf/nZIVmWApb7ntBQ7wjTSBiPuyIsaX4G3CDFz ExkjcZG8lCIzUQhb84xx0RHg5/ttJa41V65Xr3ZaHDXUmWtdF/pgAM9KlIBpGVEuYa iex3XPOmxKLvQ== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix external buffer pool registration for Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Friday, February 12, 2021 1:07 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; stable@dpdk.org > Subject: [PATCH] net/mlx5: fix external buffer pool registration for Rx q= ueue >=20 > On Rx queue creation the mlx5 PMD registers the data buffers of the > specified pools for DMA operations. It scans the mem_list of the pools > and creates the MRs (DMA related NIC objects) for the chunks found. > If the pool is created with rte_pktmbuf_pool_create_extbuf() and > refers to the external attached buffers (whose are in the area of > application responsibility and it should explicitly register the > data buffer memory for DMA with rte_dev_dma_map() call) the chunks > contain the mbuf structures only, w/o any built-in data buffers. > Hence, DMA with mlx5 NIC never happens to this area and there is > no need to create MRs for these ones. >=20 > The extra not needed MRs were created for the pools with external > buffers causing MR cache load and performance was slightly affected. > The patch checks the mbuf pool type and skips MR creation for the > pools with external buffers. >=20 > Fixes: bdb8e5b1ea7b ("net/mlx5: allow allocated mbuf with external buffer= ") > Cc: stable@dpdk.org >=20 > Signed-off-by: Viacheslav Ovsiienko > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh