From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E33D9A04B5; Wed, 28 Oct 2020 21:44:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 328324F90; Wed, 28 Oct 2020 21:44:22 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id AC7F24CBD for ; Wed, 28 Oct 2020 21:44:20 +0100 (CET) Received: from HKMAIL101.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 29 Oct 2020 04:44:18 +0800 Received: from HKMAIL102.nvidia.com (10.18.16.11) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 28 Oct 2020 20:44:18 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 28 Oct 2020 20:44:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UTF4QH35qPmbR79MmPeJ4ab3dYGQXyXWKX98ukz9IJsXl7Z0n1YVzoXmq49jOqeXQnBBWjZcvGwq1pyJ/VTMaZR2BuSdAp74mThZrpo8ob/rq9Vbx0IdCocAGuyGbxPxqXi9rapU6vXsgbXXFoYaNtKVxrzwkcQJYjLV8SFltcoUqy1chbOxxNTvR+KCQRmFYRrgKWseZWiuD2ctwetI4OX6fcAl7CfjFLZZq3GJo9DkzFZ/5Szpl7uAHVVTfJCj3bffE7OHAap6fEr09JiEeZn+UxzS6ved0UckBD0TSRBbMRbSJOZ72NsnTqatOa8mhHCzn2GXVeolAzXbud/4PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dFTtj+sGwswL7BDro3KiyZOmZPVXThHVtshryuRN1vM=; b=fmf/z+sOBBMtauEn80dEKcBZdcXTK3K55V387c1DJ14jpl9hO3fiM9YwZAUzUiw5hK9Du8d2qoHRV+U2kyrbQvNj8C5H4TASjoUhHe33laEOiZRT2+XzMDhgcSHas7uS5GUwiKVDrXouycrhh6SS4Dd0QVniQcu6L33tf8X3StH2eVvo6mBOCL2hA8da7Wjd7pIKa+d7A1crhSEQIbm4WXCIq0tATcG0lRpLyQyZWpRflfMNmhKxDu1Q+zWGNQL7a7rVbzma8Hy/5uOIs5O+XvkybekIUC3qWlu3hhNLVyYTaEEcE/y67J+ufBanpgC1NwZZ+ufg9zcl+LsIGSOh1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR12MB1722.namprd12.prod.outlook.com (2603:10b6:3:107::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Wed, 28 Oct 2020 20:44:15 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb%7]) with mapi id 15.20.3477.028; Wed, 28 Oct 2020 20:44:15 +0000 From: Raslan Darawsheh To: Alexander Kozyrev , "dev@dpdk.org" CC: Slava Ovsiienko , Matan Azrad Thread-Topic: [PATCH] common/mlx5: fix memory allocation debug stats Thread-Index: AQHWrVcj3ohbrFRyrEebzzcsmOUs0amte2bA Date: Wed, 28 Oct 2020 20:44:15 +0000 Message-ID: References: <20201028182100.12312-1-akozyrev@nvidia.com> In-Reply-To: <20201028182100.12312-1-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.229.126] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e85c6861-902a-40fa-0857-08d87b823c15 x-ms-traffictypediagnostic: DM5PR12MB1722: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:541; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L9yao646ZlceLAecO+1qEI2s+Mkc26cPa69L2pFVDj82/gTtp/U2xvV/uyucN8U275JVR49l/zW7S5oljNTkZ5l/qdySr7TjToFZ1EcWi9GjfNJWXzqI4q7B1LAVFet7abY/MoERoQOsvqw2V1Zui4XFviSAJ4gPTdKrsWpLeY1NVWhsChT5cm3W63hZ2BhkxNHXyw6M42OxRV+lKKaxP9XFZ0Iq7uUrjPaptb8jOWk1UTwfiWvPiGFnnfVUyBZRAb0lzBE7l4Dgkr6UhazyU9nN2OuV55oIpjNqPTvLkkQL/x2sEMvDf8q0C/MDcXwf5+cP4FJJwOihHmSIuCHQbw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(376002)(366004)(346002)(8936002)(4326008)(7696005)(478600001)(52536014)(8676002)(110136005)(5660300002)(54906003)(9686003)(71200400001)(83380400001)(186003)(107886003)(66446008)(64756008)(66476007)(66556008)(76116006)(66946007)(316002)(6506007)(86362001)(26005)(53546011)(2906002)(55016002)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: +9hTx/JkA8tAAcL2QQmXdp2zQvYjibn2lkkQZhDSW6dyDOI/DDU248rpGJ5MWQEH8Y1Zm5pNH9KU2lyyKCne13KnvHy2W+N5YrOxsZzH3Bt1txbJ6OEP6nVOV9KQ4iL6T9t66zIAQUtTD/iAzQbna5uLV/oF5mmjjaOOtv082Nc3AWdhnG3u87jjPN4rrBZ1wULJ88WTnA78lrOjFxgAMCIyKHxqjC2azwFqMF7nXOZpbdzL2sghQb0bghBzPB9VoeGSSnWLsYPXW/06g1ymVvQBtIkL5QgWWBM84XhBhIl+hEKIqnDoD6yR8vyYiox4TKqg/rQBIgQ4PjYARcb4p1useEkAE9jJ3wjSuRPe4A63OFG8IM1GIAHj1kBp2+RR1hzg458udBLptHjBA1846IE/WB9AmU4doi/UoY/o61ENj8zaiudpkfz4cQEvdwnPMEJtlhMB19wu3BMYfkafaW15vAvjrXMHftcUHusTN3P3DKffuEU20cecqji2h8uwuR+Tw25JOlgwjzLMvtNvQRAAMpIDLyc9GO+TMwqZFHQi0qv7o06z2H/rR+zuznRx66w1gIMKGAnozGQkmE9Nzsjr4LVKgCQdl8J6ONrOToWVLzalCcrrxux8HDhEuJdUus8/bGGKDu2YclNT9YOv6A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e85c6861-902a-40fa-0857-08d87b823c15 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2020 20:44:15.5262 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TLtIlzB7yilkzh+z8AJ3sQVeSDguVS1A42m5gpkjClImnNUGUHcua0Nw4+2SRXpiA1z2CcLpCPC6gVw2JXmoqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1722 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603917858; bh=dFTtj+sGwswL7BDro3KiyZOmZPVXThHVtshryuRN1vM=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=k6qJS+mUk+Ht2CXTs/V4PREEhO+rjlnD4RpblQMxNPWxInkW3zLaQEWgKPoutTbPT tKYL8BjBiKly97QVtTwtt65J5xK8A2FqLFv3Xr+vupL2q7qtKn4t7c2m3L0ZFqCgVR fd6br07HKEilRczwgr9s/IjRXAcZcjxlJtNe6c/AoZ9p+CQNnQY61JNyuT+XfbpvbA AF5t7fmGxa7IqLJsSp2niIvE5jQcByNA3Jc8JjVycBFxvAEBYRST4B0P/PpaBQ9Y6z e3Y7ywYC6F5KzbBhDV0gOmC8Mwm9J7RminfodGbz1suYMLBVN9xMt/LQcBeY6FbiKx kfg1rJ/Dojciw== Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix memory allocation debug stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Alexander Kozyrev > Sent: Wednesday, October 28, 2020 8:21 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad > Subject: [PATCH] common/mlx5: fix memory allocation debug stats >=20 > Fix compilation issue for memory allocation stats in case of the > RTE_LIBRTE_MLX5_DEBUG is enabled. The mlx5_sys_mem is static and > its members should be accessed via member operator, not a pointer. >=20 > Fixes: 1f34e138f8 ("common/mlx5: use C11 atomics for memory allocation") >=20 > Signed-off-by: Alexander Kozyrev > --- > drivers/common/mlx5/mlx5_malloc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/common/mlx5/mlx5_malloc.c > b/drivers/common/mlx5/mlx5_malloc.c > index f64c15fceb..5a3267f730 100644 > --- a/drivers/common/mlx5/mlx5_malloc.c > +++ b/drivers/common/mlx5/mlx5_malloc.c > @@ -187,7 +187,7 @@ mlx5_malloc(uint32_t flags, size_t size, unsigned int > align, int socket) > mlx5_mem_update_msl(addr); > #ifdef RTE_LIBRTE_MLX5_DEBUG > if (addr) > - __atomic_add_fetch(&mlx5_sys_mem->malloc_rte, > 1, > + __atomic_add_fetch(&mlx5_sys_mem.malloc_rte, 1, > __ATOMIC_RELAXED); > #endif > return addr; > @@ -201,7 +201,7 @@ mlx5_malloc(uint32_t flags, size_t size, unsigned int > align, int socket) > addr =3D malloc(size); > #ifdef RTE_LIBRTE_MLX5_DEBUG > if (addr) > - __atomic_add_fetch(&mlx5_sys_mem->malloc_sys, 1, > + __atomic_add_fetch(&mlx5_sys_mem.malloc_sys, 1, > __ATOMIC_RELAXED); > #endif > return addr; > @@ -235,7 +235,7 @@ mlx5_realloc(void *addr, uint32_t flags, size_t size, > unsigned int align, > mlx5_mem_update_msl(new_addr); > #ifdef RTE_LIBRTE_MLX5_DEBUG > if (new_addr) > - __atomic_add_fetch(&mlx5_sys_mem->realloc_rte, > 1, > + __atomic_add_fetch(&mlx5_sys_mem.realloc_rte, > 1, > __ATOMIC_RELAXED); > #endif > return new_addr; > @@ -248,7 +248,7 @@ mlx5_realloc(void *addr, uint32_t flags, size_t size, > unsigned int align, > new_addr =3D realloc(addr, size); > #ifdef RTE_LIBRTE_MLX5_DEBUG > if (new_addr) > - __atomic_add_fetch(&mlx5_sys_mem->realloc_sys, 1, > + __atomic_add_fetch(&mlx5_sys_mem.realloc_sys, 1, > __ATOMIC_RELAXED); > #endif > return new_addr; > @@ -261,13 +261,13 @@ mlx5_free(void *addr) > return; > if (!mlx5_mem_is_rte(addr)) { > #ifdef RTE_LIBRTE_MLX5_DEBUG > - __atomic_add_fetch(&mlx5_sys_mem->free_sys, 1, > + __atomic_add_fetch(&mlx5_sys_mem.free_sys, 1, > __ATOMIC_RELAXED); > #endif > free(addr); > } else { > #ifdef RTE_LIBRTE_MLX5_DEBUG > - __atomic_add_fetch(&mlx5_sys_mem->free_rte, 1, > + __atomic_add_fetch(&mlx5_sys_mem.free_rte, 1, > __ATOMIC_RELAXED); > #endif > rte_free(addr); > -- > 2.24.1 Patch squashed into relevant commit in next-net-mlx, Kindest regards, Raslan Darawsheh =