From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2916CA0032; Wed, 17 Aug 2022 09:21:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C569C40694; Wed, 17 Aug 2022 09:21:51 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2065.outbound.protection.outlook.com [40.107.237.65]) by mails.dpdk.org (Postfix) with ESMTP id E9D9340691; Wed, 17 Aug 2022 09:21:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VvGmWxr4llQR5Nu0ypS0+WROm86I98ueayGknQH2/LmebjYww1MZMmUKUFPFoxQjYJVZT/dFQBmmQrPZl0J5PxKHIFWExkx1S2u9Jsv87bTpRMzFkBGd50eoD1Da1AX1veFmDsXeDK7i+kWGcSe9x3P5h124HX/gEJDqUTMEp28oXlNu7KIteE7vgrlE5ekKD1cHlhxPmSoak8K3obWShBhpYpa+8o69wZ1McQJb3wWRyzIGMsyDlBg1E/bdGqntKQIfJFtudXTqPI+IV5SY5z3tH8+lZhECGd2d0Pfh/D6l8tAbKt9e+hUjntNH0ZDyJOFUmAC7ydHVWyig3l7RCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P0hugSb4DHSasM6zeIUaYpwu+8p4+JBXgaq4RFzWzqg=; b=QZNJOC5EmOG50H7CL9uz0VIaZsfJOvmOpYeO90tzQnB0dcE6Ljhye+kM1UjxoAeuKvhc27U8oXuwwnZV3N+iJVVVUNrA/8Brht8tphVNQ7eTbPYhrwsSAmDtJymj0yTfPuoEo3o61ByQp6wlF2h/xQAn73tsiMBmqbh0TnsOuDPIcWGlSbGHVWFKnOnPz0hex65u2w9BoIDKta65igz53Nuvvt9bmMx+qspikOOiusS9LyCaNZS76YsnJjN+cg8vYih9o4+HLqCjO6VituiZEewES+0sLV63n+LAaJ5EcNu1CmPrO8M12u2npLIer0wb4vUufB93917n3gUlKyMOxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P0hugSb4DHSasM6zeIUaYpwu+8p4+JBXgaq4RFzWzqg=; b=TsEKwVj/UCRw08eZPGjXXphoYDPqE2ZQ3hO0xg3CXoPyauKKByD2YtTGZZ54vD3GoPWlRlRSx2XIOPTyE1acV0/Jcs8FWjc0uB7lbpphHkrkYKG2tM8rPAeQq1lVGQiFSZkveiw1S2M2qO0grzzrlZsTFMFOnc4O4xnKQIeoY6fzvFMe3TtQlugi41F1g8g4KZKfOrzBEblCHVCAOa1qCY8umAM2BTNHDc8IDu8l44OktbY+QceUYrV8aCFl4kjSlYYlmmO4lYCIGd4yAgiCHFyFU+f1Pv4Xm5nY4aWiVYqFA1Eswz6ym3ScdK1FRaDF4M0Wu/XwkEvwgHbk4knT+Q== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by MWHPR12MB1214.namprd12.prod.outlook.com (2603:10b6:300:e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.19; Wed, 17 Aug 2022 07:21:48 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::e9b7:1efb:7b94:2f14]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::e9b7:1efb:7b94:2f14%7]) with mapi id 15.20.5504.027; Wed, 17 Aug 2022 07:21:48 +0000 From: Slava Ovsiienko To: Bassam Zaid AlKilani , "dev@dpdk.org" CC: Raslan Darawsheh , "rzidane@nvidia.com" , "stable@dpdk.org" , Matan Azrad Subject: RE: [PATCH] net/mlx5: fix matcher priority for esp item Thread-Topic: [PATCH] net/mlx5: fix matcher priority for esp item Thread-Index: AQHYoowkgUTzmI4PbUekUkl8Y9FoK62yzrUw Date: Wed, 17 Aug 2022 07:21:48 +0000 Message-ID: References: <20220728141203.3191-1-bzalkilani@nvidia.com> In-Reply-To: <20220728141203.3191-1-bzalkilani@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e9723339-231a-491e-54cd-08da802125bb x-ms-traffictypediagnostic: MWHPR12MB1214:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2iqwe+CFsLXV38YQyQ/FDC+WARsneHblT48BuSEDTVldY9x5OEHlhYTFMn/mFF4wqawWOdvJbzbk8SDipLajd5/EGVuEuB7HD+rZlwolg4Q8GLhlQ/Y2sNbmdsXWPfcrfVJGYosL7XdjG4ymlU5d3VFB6Ag/VHUY3qPibk6U3stAQ8OXXYCSBW3fcslAtUgQJbV0vs7EVTJawqwqw3cT0AQLyIenz27AzJm5ckz/w9h/1Dg5qiSQe28RzbKJYoUSE/ZrsSnWYrfrhH9Zc2YefLRU0hGFQa2xfnzZ+TY1aVGmSZ/sy7sXcH6vhPLsBCzq8zyzF0tgvCWG1eH76Hpy4z1BhanbQGnrAteFYe+gj1kWsVFkwO+DfVxNvQER8CtN3PKNAQDEWm94ifzElhDy0YEDb6FYa77fwgYJrU6ZPeIV8OfHK/QLAqr43v7l2iPSp+FoPXu2v5WyFfx8ByScFJ5iYO5H2xSWm0JIqSAAFctvhoJPH0QJBd2YIGLfk/sKYYbpde1WgN1MhfqMaueMF9H5BGdU3a1afTclQB9XhyBdETOq/Ytmpgb2hHclmZ76hqur3oZ/4tFjtna7Muk/LN8V/RZDWBRGR/tupltzMDHi5VarsdKjee3rPR2SO4+tFpJ3VcRlAdelRGDpVOyrqjK+nP7hYEbl3aHxMvFnYilYuhsNipvPxVJUMzK7P/TtGO5HFvwmfDKc7U1Jcm1kTnL62uTgg+wDNa6IwcZuB+MIrZRg9mkU93TKmrMT/3+PskLRvj7w1cr4y/iUQHBbU5Q5qa7z21+lK2ULN6Lvjp+pvhbmuyt7GBAyodWi69Ml x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(136003)(366004)(396003)(376002)(346002)(9686003)(53546011)(6506007)(7696005)(26005)(86362001)(33656002)(38070700005)(186003)(38100700002)(122000001)(83380400001)(55016003)(71200400001)(450100002)(5660300002)(478600001)(52536014)(66946007)(8936002)(76116006)(64756008)(8676002)(4326008)(66446008)(66476007)(66556008)(2906002)(107886003)(110136005)(41300700001)(54906003)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GzrBZFpxHnTaXNcQrhknI/pbTynCW8wQ5w+jibDDiJjNac5Mc3dZezkZJQ2M?= =?us-ascii?Q?ohWP0ZvpGLPLUWuHZhEOZccN+dAhXrnPbJ0IUf+Bzs12CtE/hWtd+vy+RNo2?= =?us-ascii?Q?Gw+tfQ/EL5znLXXdSeINWHWQMnA61LLdMo9dQ66JyDbDYDOwbh/cDiTXbd0Q?= =?us-ascii?Q?zy2qFVBFu+/kfgftGE2lSxrSlyvhgDQH0Wc1F1iqxq2UJLmHo0rVv6EUCcbO?= =?us-ascii?Q?Ie0k5Ag6RHjbx/QRgZEDACG5qkbLV4+J60dkQUh/a1yqEdEQk2oE9LyydOOe?= =?us-ascii?Q?b1tXvSuCjm3PLC5PMwvtjXrKfVWFLpvOtFa00dBALOR5hGFFHclA3TRgHUxR?= =?us-ascii?Q?zRL98jNH11KP0HErvN/vDnKhZ20aJ8vSjrlvqptb8uEqFQcrJcNJcMVDh1RT?= =?us-ascii?Q?+mEa8DBN+Uc79Tqrk1cBMfw35fomRHd5USJfqIhXvGTKPW0xFkL5kd1YI06Q?= =?us-ascii?Q?8x9OB02oEG+PQGbqAHWWDrFyT7l9jz9Dme2L79rnompclMYyib1HNYfRLuHT?= =?us-ascii?Q?afx9RMv1TjY2eLrmheEN/Z/lcZZeaobo/WlH5ae37KW7gQkMuX7Swkvd3W33?= =?us-ascii?Q?nOuLpY8uLduv8IMqG/KYs/SpLqKP5EAcFJXI50frBAdB5SshFozsyk4z3utk?= =?us-ascii?Q?YoKzV1zZwkGJCDGibLyQ6ddjrlVYNdGiDsrab1QsaeUfqdgS+93/WhhNW+Jd?= =?us-ascii?Q?bpdPmCFebACF+Hqlelhf5YM3FA8Tta+Nk6WpYRygjGX2LNRE66blnpDPB5zc?= =?us-ascii?Q?TYw43P0XtLNXXYvYFk38IMEpVaHP3M5zGrhH07uHXOUrxga99OZuRaxL2Cjj?= =?us-ascii?Q?tdOnW1AuWjJ+mBXx6lqEOLrKKlYq8NkcN4Nfg9d1OmFSjSpUV65l9iI5cn/l?= =?us-ascii?Q?1OWeEtLprUpwvVrPp6WcBPA9zQlfz62B+0w+FaUPIgVNq8uDGidgV3GrVD9R?= =?us-ascii?Q?XhPfU4SRmOjIvVpKRxo8udk+8sxvWBQjgWFOQADuK3cquhHzo4ZUaXmtzDkT?= =?us-ascii?Q?RggRCOTreJSVX4hRiI90fkzyOWrjcppU2Wb4xlXRX05tN5sPk7vj5h1lxOl4?= =?us-ascii?Q?gaOz510GHIgYCKAfWLo6yuc9MWOw1lO2UIo7V0O80Rc13Ry70L6pDMVsRdAy?= =?us-ascii?Q?J3z24C8eR97/Dun+qKBcnfxaswJMuldBWMek8kWxwuKjHsb+IsFi7cN0TCxg?= =?us-ascii?Q?C86AN0jxc5prMXS7tEe+2Srer4x3KJT/ToB3LHv1FsM1B3DI9BqZmm+brsh5?= =?us-ascii?Q?5rHoRYJcDeZSKSiz7p6BXN3/1wl0FqJdL4xok7yc8od7hYvrsFrLwwE3/9f3?= =?us-ascii?Q?VLhlBdf20ApolXEFzQPgOXcxjX+md0eXtUxHe2LCEAEkqAeo6mKyCVoguMsJ?= =?us-ascii?Q?6TsLmvp+RD36t4jOx8x+6l0wlfSMX0WbMGjtZ4DqW+gk871Kaol8ZDuxbm5v?= =?us-ascii?Q?c6h47C8V9pyJk3IbEiIE69yT59z3cmLvrwv8aY7KUwN/IWcPHzMN2wbVG18I?= =?us-ascii?Q?kIjNfVAfuHhcINGXn7kUn9LeiZqVwXAD9+QSicxAPTJGyfpGDQ3X7VCmJpCM?= =?us-ascii?Q?KgUwP7YYQolneTW1VDv+G7ftmZS24RBSRXw+OgIC?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9723339-231a-491e-54cd-08da802125bb X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2022 07:21:48.1187 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TllUBqL+tWFSQw2IKnvBCeDeC1dvqtbgIRtnnYX2ni2hUuHpC3/e/8VQ6aEqBlYoDkX8eGchAUkmru1OdpP+jQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1214 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Bassam Zaid AlKilani > Sent: Thursday, July 28, 2022 17:12 > To: dev@dpdk.org > Cc: Raslan Darawsheh ; rzidane@nvidia.com; > stable@dpdk.org; Matan Azrad ; Slava Ovsiienko > > Subject: [PATCH] net/mlx5: fix matcher priority for esp item >=20 > ESP is one of IPSec protocols over both IPv4 and IPv6 and is considered a > tunnel layer that cannot be followed by any other layer. Taking that into > consideration, esp is considered as a 4 layer. >=20 > Not defining ESP's priority will make it match with the same priority as = its > prior IP layer, which has a layer 3 priority. This will lead to issues in > matching and will match the packet with the first matching rule even if i= t > doesn't have an esp layer in its pattern, disregarding any following rule= s > that could have an esp item and can be actually a more accurate match sin= ce > it will have a longer matching criterion. >=20 > This is fixed by defining the priority for the ESP item to have a layer 4 > priority, making the match be for the rule with the more accurate and lon= ger > matching criteria. >=20 > Fixes: 18ca4a4ec73a ("net/mlx5: support ESP SPI match and RSS hash") > Cc: rzidane@nvidia.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Bassam ZaidAlKilani Acked-by: Viacheslav Ovsiienko