From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A11E3A0A0E; Wed, 3 Feb 2021 09:04:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2302F240448; Wed, 3 Feb 2021 09:04:21 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by mails.dpdk.org (Postfix) with ESMTP id E22F8240446; Wed, 3 Feb 2021 09:04:19 +0100 (CET) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 03 Feb 2021 00:04:18 -0800 Received: from HQMAIL107.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 03 Feb 2021 00:04:18 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 03 Feb 2021 00:04:18 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 3 Feb 2021 08:04:18 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 3 Feb 2021 08:04:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bbB4sZIyHX/ckvC4mlEM3IPsi816fNvaUaVCrBxtGN2rEZ+wOW+gAlRLeAwDV16SUO2B4cZTSiam2v9vc6M289WeuGsn/muJgsVbw37ECW2T5ZoP/ysF4DideW0G4R3oWjzkyfquZ9yqIB8HnC3NejZXlH+w+FXn1BfTpMP9btHq73tFNav5HFLqEC76Ob4LEVBHepbCao3WEL9ip5pe0NEpl6dvAkVPFGnKKkP26BeaylMnUrOFVKPXrL+1xRBNn68+58KjdYIpSvSspht6kYaIEkSV8KBilYsnXrlehQ4Jgs/hn12oFJp8Z1TBin4RiywPsJnOuK5aG7QFHdesbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i9+Au/fur13V1vvMDpEQ1E+O7cJ6XdmZV3rwrm4vjKI=; b=XtBE/l/XFJFIaqOUGotvwQfyx/GSg/9q6zz6WpTo8Bu5o5IjO/0vN2APa3YJf3XEnvnRfNx8ETc8FneE0zd9+q87ph/xA+5nfX0lG8Tx9R95tYTBO7UqMfPfXoP+5VbnwhJGpwsf2qhEkpWB6oPD3EAz39ke772g3p9CLG9R7c/nRCLsPExIFEUC+LSs8pWcWhsoTni6qJLvWah/FO3WgkZTt4xafEqVmxn4cfBm+m9CPzHwP2al6m+Hucv36ddN3z6PRk73oPz7TjDmELUY6kgbok/ZTMi4fiyw+EtbJ9HK2LT8+iD0XUVSkg6FzAzyxado0Iq0ZKWjfdrRboqR8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM6PR12MB2924.namprd12.prod.outlook.com (2603:10b6:5:183::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.25; Wed, 3 Feb 2021 08:04:17 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::e4a9:f9a1:d873:d07a]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::e4a9:f9a1:d873:d07a%5]) with mapi id 15.20.3805.028; Wed, 3 Feb 2021 08:04:17 +0000 From: Slava Ovsiienko To: "Dey, Souvik" , Raslan Darawsheh , Matan Azrad CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3] common/mlx5: fix storing the synched MAC to internal table Thread-Index: AQHW+Yu7r6DTVZiNeE2wnhVR9ReXp6pGEI/g Date: Wed, 3 Feb 2021 08:04:16 +0000 Message-ID: References: <20210202035352.24512-1-sodey@rbbn.com> <20210202174841.15784-1-sodey@rbbn.com> In-Reply-To: <20210202174841.15784-1-sodey@rbbn.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: rbbn.com; dkim=none (message not signed) header.d=none;rbbn.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 385edf0c-8e3a-4d90-d85f-08d8c81a4dbf x-ms-traffictypediagnostic: DM6PR12MB2924: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-header: ProcessedBy-CMR-outbound x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Fi22FqoMO/miHIWcZ+Va8JSaROTnoJI5na4C9GoT+C3rOqpJbeP2EuSW7yJZs/6emvzqfZGfOO8WEcwqbj/F5KVMIlGmqUJ9NpiSqcH7wSHc0PqcyMAGsGSHb34Y/Sv4yUypOIAc/BtlJcO6cfQfcLOxJIdK7+/crp8s9IHpX3pABL+2CCEqgIr4lNJtYeJpdUN6vdp+elq5ajmIbfOw9xgO7QuW9fUnAq6oZMWgX0D8u5Rbei3T2HENrxasHK9ShnrPLYeEPOfXu4ZW+j30Pfa4N5M5pf0ztcC23X4cc5NvHoyEHlBPYrmA4CF60jm2LO2uMKME2Wjyef44pp/g9rulD5pc6WXNXHqJJvVDTKAwts+I2fYF8qmzvLHWIrYHtFny0aTtmnjMe8aZwSbQO+RliQ9z6ylW7GhX8TSx7d7t9i6h1f9lPHXfCLZwkUIBfeUNvna/zhLvZhWqth5lhABGpJx7ISESawGym49EVvWU4s7CUei/WffeRr7A3Gk41eOXAXntYYh55rjoI9sZTw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(136003)(366004)(346002)(39860400002)(8936002)(478600001)(76116006)(64756008)(66556008)(83380400001)(6636002)(2906002)(4326008)(7696005)(66446008)(53546011)(8676002)(6506007)(33656002)(186003)(86362001)(66476007)(26005)(9686003)(316002)(110136005)(71200400001)(5660300002)(66946007)(52536014)(55016002)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?yVS5uw1SqX2zv1E3l7oCYiqtoP7KD0NBEGVgZBUc1dVseR4GlCHGC22LHMWp?= =?us-ascii?Q?dNa8/PakVg/wyEjlKCYl6fAJyBHWGJ375gsuixyRg4581JNwrjQgLt39RD1w?= =?us-ascii?Q?G3sbHTtNvSdtXiEVsNUj1HR2n0biVDfPcl4xNQ+uTDQqxvba9Seq1mPptGNW?= =?us-ascii?Q?n5vEvEIyWL1pxiqqs14s6TMjZo1IE2ka0t3LWOoO+BkMr1kbm8Zsm22R1v//?= =?us-ascii?Q?2x3eFIS8Kzh+P/A4p03GzyW4wtNmI78W6SCawELbdDS9Ql8brY7Qs9hNGKTd?= =?us-ascii?Q?iQS86JYcVmR0HKnDlTOH14rMS9h2cRGbErOSkl4KL8+eQWvZ/H0Z/75RmPXD?= =?us-ascii?Q?9BhgsMic9jHcjhA2fZh+pgxT6feXlTnXbAgsJL1SpOUHdMCiZI+Rlge6XIPA?= =?us-ascii?Q?jOTZki7owkybIfZQrQ8ib88aU5YkGVGTRIFStmtE/bAiuVOSJeRn9gnj3UE9?= =?us-ascii?Q?Dip4/kIzJrSL8YZt2g4mDX8SMGpycEiL7iLCNln22oQCESl22DVw/jXdXBBg?= =?us-ascii?Q?HS6zGUN6IXn0+X2WnNXnMJVOxtCNjbBgHjilowpcbKieZYa/P6kJFEvuHTwp?= =?us-ascii?Q?QZrMDmB3mH28PuYX+Nnu+nfS4k4zsZLlRougA0Q14IkDFDrptql0u2DiW47g?= =?us-ascii?Q?572yj2d/inFM7hE7CGq/VqT9lg5xtQFiPMizDAOU7Gsl750WS9P4BjzOU3Yf?= =?us-ascii?Q?hNPYGeJhkrcY09/RLmecqovBSOO79Q63AJRSYWmC+sxGn0hGzRtCaw9aHZod?= =?us-ascii?Q?/lwxpLmXtqn447e2caHwKDQCCEZNkFz7qurv36Ek9zMRgd4I6raAuooPS661?= =?us-ascii?Q?N27zLINy+UZT008Pp7e0deE1P8dDECS2nvxKnoI9No5PuOWCWURzgn3LA952?= =?us-ascii?Q?XSUY44Oa6uzAjBTIWd0QOj8pKAH23Gc/Tc3qqdbO1hB1weql0Q555zTEnCYU?= =?us-ascii?Q?vYNp9J+T9d5weSVQU9ejldB99URSmut4OX846M+T1NIUEFpUk+Urkdn1jdOT?= =?us-ascii?Q?rBHoVGPV9tIhWyBK5lm/jd1GlenM07wdTP1qCYsVW2Xl4IXnumeNg8NLajy+?= =?us-ascii?Q?d0fGnlOK?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 385edf0c-8e3a-4d90-d85f-08d8c81a4dbf X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2021 08:04:17.0799 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Fq/dNrhi2NRQqwN7UCWTnTI6yTG5NpMFMz6ci8AaoFqAp9e79NUl8V87Adl6U9L052q0fbVKXIMZ55EhtO2LUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2924 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1612339459; bh=i9+Au/fur13V1vvMDpEQ1E+O7cJ6XdmZV3rwrm4vjKI=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-header:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=kGsL7xnpQh6n0PPj6atHLysQScYTvm/soRDfL9s4JUMVnIn+Qr+3AUlIvaHEq7sTq PwwP08cYBwQ0aNYjalTsUOudUtFltakmfIxn+/jU10mPKdPgdMLKAQI2BuQobIku7W som8pIAxETlkOgMtvBDpBhZ0bNSxodb2HyWP8uJrKFOsc99EiF7yqidaYiGW0VGaTN nDbDNe5d1M4cUaBsS3y19MbsPDdY/X7EGRb9v/ZxlcLEVIN/tpi0+4lyz3C4BhZP0f VCcZTJcSV+khvgSeewWRRb89llh9OhnGpjEorGFn4kGqYiU/Y5TGIEsaaa9UM8RC0l BFkzjxz/mig/g== Subject: Re: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MAC to internal table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, I'm sorry, but quota character in "Fixes" tags is still wrong, causing the = checking script errors. It should be " (0x22 ASCII), not ' (0x27 ASCII). Beside this: Acked-by: Viacheslav Ovsiienko > -----Original Message----- > From: Dey, Souvik > Sent: Tuesday, February 2, 2021 19:49 > To: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad ; Shahaf > Shuler > Cc: dev@dpdk.org; stable@dpdk.org; Souvik Dey > Subject: [PATCH v3] common/mlx5: fix storing the synched MAC to internal > table >=20 > From: Souvik Dey >=20 > As the internal MAC table is divided into Unicast and Multicast address > sections, we should check the type of synched MAC address before storing = it > to the internal table. Currently the check is not done, and the synched M= AC of > 33:33:00:00:00:01 gets stored in the unicast section (mostly index 1) cau= sing > all subsequent mlx5_set_mc_addr_list() to fail with error -EADDRINUSE, as= the > mac_list contains the MAC 33:33:00:00:00:01. This denies adding of any ne= w > multicast address to the internal list and also fails to add the MAC addr= ess to > the device in case of SR-IOV VF. >=20 > Fixes: f22442cb5d42 ('net/mlx5: reduce Netlink commands dependencies') > Fixes: ccdcba53a3f4 ('net/mlx5: use Netlink to add/remove MAC addresses') > Cc: stable@dpdk.org >=20 > Signed-off-by: Souvik Dey > --- > v2: > * net/ -> common/ > * space after mlx5: > * synched -> synched > * section -> sections > * rewording which causes -> causing > * typo: case (to remove) > * added Fixes for LTS ML > --- > v3: > * Changed the "" in Fixes tags to ''. > --- > drivers/common/mlx5/linux/mlx5_nl.c | 20 +++++++++++++++----- > 1 file changed, 15 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/common/mlx5/linux/mlx5_nl.c > b/drivers/common/mlx5/linux/mlx5_nl.c > index 40d8620..ef7a521 100644 > --- a/drivers/common/mlx5/linux/mlx5_nl.c > +++ b/drivers/common/mlx5/linux/mlx5_nl.c > @@ -758,11 +758,21 @@ mlx5_nl_mac_addr_sync(int nlsk_fd, unsigned int > iface_idx, > break; > if (j !=3D n) > continue; > - /* Find the first entry available. */ > - for (j =3D 0; j !=3D n; ++j) { > - if (rte_is_zero_ether_addr(&mac_addrs[j])) { > - mac_addrs[j] =3D macs[i]; > - break; > + if (rte_is_multicast_ether_addr(&macs[i])) { > + /* Find the first entry available. */ > + for (j =3D MLX5_MAX_UC_MAC_ADDRESSES; j !=3D n; ++j) > { > + if (rte_is_zero_ether_addr(&mac_addrs[j])) { > + mac_addrs[j] =3D macs[i]; > + break; > + } > + } > + } else { > + /* Find the first entry available. */ > + for (j =3D 0; j !=3D MLX5_MAX_UC_MAC_ADDRESSES; ++j) > { > + if (rte_is_zero_ether_addr(&mac_addrs[j])) { > + mac_addrs[j] =3D macs[i]; > + break; > + } > } > } > } > -- > 2.9.3.windows.1 >=20 >=20 > Notice: This e-mail together with any attachments may contain information= of > Ribbon Communications Inc. and its Affiliates that is confidential and/or > proprietary for the sole use of the intended recipient. Any review, discl= osure, > reliance or distribution by others or forwarding without express permissi= on is > strictly prohibited. If you are not the intended recipient, please notify= the > sender immediately and then delete all copies, including any attachments.